On Wed, Mar 24, 2021 at 9:22 PM Ben Pfaff wrote:
>
> On Tue, Mar 23, 2021 at 09:22:43PM -0400, Ihar Hrachyshka wrote:
> > When vlan-passthru is true for LS, for untagged localnet ports, tagged
> > VLAN traffic originating from VIFs should be passed through intact since
> > the VLAN header belongs
On Fri, Mar 26, 2021 at 9:16 AM Ben Pfaff wrote:
>
> On Mon, Mar 22, 2021 at 04:29:11PM +0530, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Presently we add 65535 priority lflows in the stages -
> > 'ls_in_acl' and 'ls_out_acl' to drop packets which
> > match on 'ct.inv'.
> >
> > This
On Mon, Mar 22, 2021 at 04:29:11PM +0530, num...@ovn.org wrote:
> From: Numan Siddique
>
> Presently we add 65535 priority lflows in the stages -
> 'ls_in_acl' and 'ls_out_acl' to drop packets which
> match on 'ct.inv'.
>
> This patch provides an option to not use this field in the
> logical
On Thu, Mar 25, 2021 at 3:01 PM Anton Ivanov
wrote:
>
>
>
> On 24/03/2021 15:31, Numan Siddique wrote:
> > On Mon, Mar 1, 2021 at 6:35 PM wrote:
> >>
> >> From: Anton Ivanov
> >>
> >> This adds a set of functions and macros intended to process
> >> hashes in parallel.
> >>
> >> The principles
On Fri, Mar 26, 2021 at 8:36 AM Ben Pfaff wrote:
>
> On Fri, Mar 26, 2021 at 08:18:52AM +0530, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Signed-off-by: Numan Siddique
>
> Acked-by: Ben Pfaff
Thanks. I applied to the main branch.
Numan
>
On Fri, Mar 26, 2021 at 07:44:12AM +0530, Numan Siddique wrote:
> On Thu, Mar 25, 2021 at 3:35 AM Ben Pfaff wrote:
> >
> > I guess this was a cut-and-paste error from ovs-ofctl.
>
> Acked-by: Numan Siddique
Thanks, applied to master.
___
dev mailing
On Fri, Mar 26, 2021 at 07:45:35AM +0530, Numan Siddique wrote:
> On Thu, Mar 25, 2021 at 3:50 AM Ben Pfaff wrote:
> >
> > This is just a typo introduced in a previous fix. The typo shows up
> > at the top of generated manpages.
> >
> > Signed-off-by: Ben Pfaff
> > Fixes: 852316e8dc12
On Fri, Mar 26, 2021 at 08:18:52AM +0530, num...@ovn.org wrote:
> From: Numan Siddique
>
> Signed-off-by: Numan Siddique
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Mar 25, 2021 at 11:40:59PM +, svc.eng.git-m...@nutanix.com wrote:
> diff --git a/northd/lrouter.dl b/northd/lrouter.dl
> index 1a7cb2d23..1d8722282 100644
> --- a/northd/lrouter.dl
> +++ b/northd/lrouter.dl
> @@ -770,6 +770,36 @@ RouterStaticRoute(router, key, dsts) :-
> },
>
From: Numan Siddique
Signed-off-by: Numan Siddique
---
tests/ovn-northd.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 02f6ede847..47f2662e45 100644
--- a/tests/ovn-northd.at
+++ b/tests/ovn-northd.at
@@ -2731,6 +2731,8 @@ check
On Thu, Mar 25, 2021 at 3:50 AM Ben Pfaff wrote:
>
> This is just a typo introduced in a previous fix. The typo shows up
> at the top of generated manpages.
>
> Signed-off-by: Ben Pfaff
> Fixes: 852316e8dc12 ("xml2nroff: Properly support .")
Acked-by: Numan Siddique
Thanks
Numan
> ---
>
On Thu, Mar 25, 2021 at 3:35 AM Ben Pfaff wrote:
>
> I guess this was a cut-and-paste error from ovs-ofctl.
Acked-by: Numan Siddique
Thanks
Numan
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovn-nbctl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
Hello,
I am working on OvS-DPDK and conntrack and seeing weird behavior, maybe I
am doing something wrong.
ovs-vswitchd --version
ovs-vswitchd (Open vSwitch) 2.13.3
DPDK 19.11.5
I have setup using
https://docs.openvswitch.org/en/latest/tutorials/ovs-conntrack/
After initial syn/syn-ack/ack,
On Thu, Mar 25, 2021 at 09:18:19PM +0200, Alexey Roytman wrote:
> From: Alexey Roytman
>
> ovn-nbctl and ovn-sbctl CLI utilities allow destroying the entire
> table or some records from the given table.
> However, either the --all option or the deleted records should be provided.
> This patch
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1106 FILE:
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Use ovs_abort() in place of abort()
#606 FILE: utilities/ovn-dbctl.c:566:
From: Karthik Chandrashekar
Physical switches have the ability to specify "discard" or sometimes
"NULL interface" as a nexthop for routes. This can be used to prevent
routing loops in the network. Add a similar configuration for ovn
where nexthop accepts the string "discard". When the nexthop is
Also rewrite the manpage and convert it to XML for consistency with
ovn-nbctl, and add tests.
Signed-off-by: Ben Pfaff
---
NEWS | 2 +
manpages.mk | 17 -
tests/ovn-sbctl.at| 76 +++--
utilities/automake.mk | 7 +-
utilities/ovn-dbctl.c |
In an upcoming commit, this will allow adding daemon mode to ovn-sbctl
without having a lot of duplicated code.
Signed-off-by: Ben Pfaff
---
utilities/automake.mk |5 +-
utilities/ovn-dbctl.c | 1215
utilities/ovn-dbctl.h | 60 ++
utilities/ovn-nbctl.c
This rearranges the manpage into a more logical order, documents some
options that weren't documented, adds some sections such as
Environment and Exit Status that a manpage should have, puts the
headings at reasonable levels instead of all at the top level, and adds
a little more explanatory text
A daemon mode for ovn-sbctl can make benchmarks much faster. For me,
it made the benchmark provided by Numan drop from several minutes to
about 100 seconds (without ddlog) in one case. I do not know whether
it will make real use of ovn faster, but it's definitely useful if
you want to run tests.
OK. I guess I'll have to try it myself.
On Thu, Mar 25, 2021 at 12:59:00PM +0530, Numan Siddique wrote:
> Hi Ben,
>
> With your memory fixes applied, I still see many test failures due to
> memory leaks
> when configured as:
>
> ./configure --enable-Werror --enable-sparse CFLAGS="-g
From: Alexey Roytman
ovn-nbctl and ovn-sbctl CLI utilities allow destroying the entire
table or some records from the given table.
However, either the --all option or the deleted records should be provided.
This patch adds the test.
Signed-off-by: Alexey Roytman
---
lib/db-ctl-base.c | 5
On Fri, Mar 12, 2021 at 12:59:17PM +0100, Simon Horman wrote:
> --- a/tests/system-offloads-traffic.at
> +++ b/tests/system-offloads-traffic.at
> @@ -70,3 +70,50 @@ AT_CHECK([ovs-appctl upcall/show | grep -E "offloaded
> flows : [[1-9]]"], [0], [i
>
> OVS_TRAFFIC_VSWITCHD_STOP
> AT_CLEANUP
>
On Thu, Mar 25, 2021 at 03:51:11PM -0300, Marcelo Ricardo Leitner wrote:
> On Fri, Mar 12, 2021 at 12:59:16PM +0100, Simon Horman wrote:
> > From: "Yong.Xu"
> >
> > Correct calculation of burst parameter used when configuring TC policer
> > action for ingress port-based policing in the case
On Fri, Mar 12, 2021 at 12:59:16PM +0100, Simon Horman wrote:
> From: "Yong.Xu"
>
> Correct calculation of burst parameter used when configuring TC policer
> action for ingress port-based policing in the case where TC offload is in
> use. This now matches the value calculated for the case where
On Thu, Mar 18, 2021 at 02:47:32PM +0100, Simon Horman wrote:
> On Fri, Mar 12, 2021 at 12:59:15PM +0100, Simon Horman wrote:
> > Hi,
> >
> > this short series corrects the unit of the burst parameter used to
> > configure TC policer actions in the case case where ingress rate limiting
> > is
On 19/03/2021 13:01, Dumitru Ceara wrote:
> On 3/10/21 2:29 PM, gmingchen(ιδΎζ) wrote:
>> From: Gongming Chen
>>
Thanks for the patch. Looks like a lot of thought went into the
algorithm and it has been interesting to review.
Do you know if there are any well-known algorithms to do this? It
Spotted during code inspection.
Signed-off-by: Dumitru Ceara
---
controller/lflow.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/controller/lflow.c b/controller/lflow.c
index a3d84aff4..680b8cca1 100644
--- a/controller/lflow.c
+++ b/controller/lflow.c
@@ -716,15
On Wed, Mar 24, 2021 at 2:32 PM Frode Nordahl
wrote:
>
> On Wed, Mar 24, 2021 at 1:54 PM Numan Siddique wrote:
> > I applied the patches 6 and 7 to the main branch.
> >
> > There are some issues with patch 9. I didn't apply patch 8 as it
> > seems related to patch 9.
> >
> > If I configure like
On 3/23/21 4:55 PM, num...@ovn.org wrote:
> From: Numan Siddique
>
> When a port binding type changes from type 'A' to type 'B', then
> there are many code paths in the existing binding.c which results
> in crashes due to use-after-free or NULL references.
>
> Below crashes are seen when a
On Thu, Mar 25, 2021 at 3:02 PM Michele Baldessari wrote:
>
> Currently if you update the master_ip attribute, pacemaker will restart
> the resource but the ovn master role will still listen to the previous
> old ip address. The reason for this is the following piece of code:
>
>
On Thu, Mar 25, 2021 at 2:42 PM Daniel Alvarez Sanchez
wrote:
>
> On Thu, Mar 25, 2021 at 8:58 AM Dumitru Ceara wrote:
>
> > On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote:
> > > Ports of type 'localport' are present on every hypervisor and
> > > ovn-controller is sending gARPs for them which
Bleep bloop. Greetings Michele Baldessari, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has non-spaces leading whitespace
#52 FILE:
Currently if you update the master_ip attribute, pacemaker will restart
the resource but the ovn master role will still listen to the previous
old ip address. The reason for this is the following piece of code:
conn=`ovn-nbctl get NB_global . connections`
if [ "$conn" == "[]" ]; then
On 24/03/2021 15:31, Numan Siddique wrote:
On Mon, Mar 1, 2021 at 6:35 PM wrote:
From: Anton Ivanov
This adds a set of functions and macros intended to process
hashes in parallel.
The principles of operation are documented in the ovn-parallel-hmap.h
If these one day go into the OVS
On 3/25/2021 11:16 AM, Ivan Malov wrote:
External email: Use caution opening links or attachments
Hello,
You know, now you mention it, will action COUNT always go before any
other actions in OvS ("tunnel set" and "tunnel match" flows)? If this is
the case, then the byte count in the counter
Hello,
You know, now you mention it, will action COUNT always go before any
other actions in OvS ("tunnel set" and "tunnel match" flows)? If this is
the case, then the byte count in the counter of "tunnel set" flow should
be "*before* decapsulation" and the byte count in the counter of
On Thu, Mar 25, 2021 at 8:58 AM Dumitru Ceara wrote:
> On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote:
> > Ports of type 'localport' are present on every hypervisor and
> > ovn-controller is sending gARPs for them which makes upstream
> > switches to see its MAC address flapping.
> >
> > In
Hello,
Note that MLX5 PMD has a bug that the tnl_pop private actions must be
first. In OVS it is not.
Fixing this issue is scheduled for 21.05 (and stable 20.11.2).
Meanwhile, tests were done with a workaround for it.
See https://github.com/elibritstein/dpdk-stable/pull/1
Also, any other
On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote:
> Ports of type 'localport' are present on every hypervisor and
> ovn-controller is sending gARPs for them which makes upstream
> switches to see its MAC address flapping.
>
> In order to avoid this behavior, the current patch is skipping
>
On Mon, Mar 8, 2021 at 7:30 PM Lorenzo Bianconi
wrote:
>
> Changes since v1:
> - fix compilation errors with -Werror and clang compiler
> (just repost patches from 5/8 to 8/8)
Thanks Lorenzo. I applied these patches to the main branch.
Numan
>
> Lorenzo Bianconi (4):
> northd: introduce
On 24/03/2021 11:12, Numan Siddique wrote:
> On Tue, Mar 16, 2021 at 2:32 AM Mark Michelson wrote:
>>
>> LGMT
>>
>> Acked-by: Mark Michelson
>
> Thank you Mark G (and Mark M for the reviews).
>
> I applied this patch to master.
>
> Numan
>
Thank everyone.
>>
>> On 2/16/21 6:55 AM, Mark Gray
Hi Ben,
With your memory fixes applied, I still see many test failures due to
memory leaks
when configured as:
./configure --enable-Werror --enable-sparse CFLAGS="-g -fsanitize=address"
You can find more details about the memory leaks here -
44 matches
Mail list logo
