[ovs-dev] [PATCH v2 ovn] northd: introduce per-lb lb_skip_snat option

2021-04-06 Thread Lorenzo Bianconi
Introduce skip_snat in load balancer option column in order to not force_snat traffic that is hitting a given load balancer applied on a logical router where lb_force_snat has been configured https://bugzilla.redhat.com/show_bug.cgi?id=1927540 Tested-by: Andrew Stoycos Signed-off-by: Lorenzo

Re: [ovs-dev] [PATCH ovn] northd: introduce per-lb lb_skip_snat option

2021-04-06 Thread Lorenzo Bianconi
> Hi Lorenzo, > > In general, this patch seems overly complicated based on the linked bug > report. Hi Mark, thx for the review. > > The bug report wants to make the lb_force_snat_ip behavior to only be > applied to certain load balancers, and not all load balancers on that > router. To me,

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: bypass ct for allow ACLs

2021-04-06 Thread Ihar Hrachyshka
On Fri, Apr 2, 2021 at 7:23 AM Dumitru Ceara wrote: > > On 3/24/21 3:40 PM, Ihar Hrachyshka wrote: > > For allow ACLs, bypass connection tracking by avoiding setting ct > > hints for matching traffic. Avoid sending all traffic to ct when a > > stateful ACL is present. Before the patch, this

Re: [ovs-dev] [PATCH ovn] expr: Combine multiple ipv4 with wildcard mask.(Internet mail)

2021-04-06 Thread Dumitru Ceara
On 4/6/21 12:11 PM, Mark Gray wrote: > I had a conversation with Dumitru and this patch came up in the > conversation. He made an interesting suggestion (Dumitru, please correct > me if I get this wrong) that this could be refactored as an external > tool. This cmdline tool could, for example,

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Flavio Leitner
On Tue, Apr 06, 2021 at 02:53:34PM +0100, Mark Gray wrote: > On 06/04/2021 13:59, Flavio Leitner wrote: > > On Tue, Apr 06, 2021 at 12:30:42PM +0100, Mark Gray wrote: > >> On 05/04/2021 20:56, Flavio Leitner wrote: > >>> On Thu, Apr 01, 2021 at 07:48:19PM +0100, Mark Gray wrote: > On

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Mark Gray
On 06/04/2021 13:59, Flavio Leitner wrote: > On Tue, Apr 06, 2021 at 12:30:42PM +0100, Mark Gray wrote: >> On 05/04/2021 20:56, Flavio Leitner wrote: >>> On Thu, Apr 01, 2021 at 07:48:19PM +0100, Mark Gray wrote: On 01/04/2021 19:29, Ilya Maximets wrote: > On 4/1/21 3:58 PM, Mark Gray

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Flavio Leitner
On Tue, Apr 06, 2021 at 12:30:42PM +0100, Mark Gray wrote: > On 05/04/2021 20:56, Flavio Leitner wrote: > > On Thu, Apr 01, 2021 at 07:48:19PM +0100, Mark Gray wrote: > >> On 01/04/2021 19:29, Ilya Maximets wrote: > >>> On 4/1/21 3:58 PM, Mark Gray wrote: > This series fixes IPv6 support for

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Mark Gray
On 01/04/2021 20:01, Ilya Maximets wrote: > On 4/1/21 8:48 PM, Mark Gray wrote: >> On 01/04/2021 19:29, Ilya Maximets wrote: >>> On 4/1/21 3:58 PM, Mark Gray wrote: This series fixes IPv6 support for Libreswan and introduces IPsec system tests for Libreswan. Mark Gray (5):

Re: [ovs-dev] [PATCH v3 0/5] ipsec: Fix IPv6 support

2021-04-06 Thread Mark Gray
On 05/04/2021 20:56, Flavio Leitner wrote: > On Thu, Apr 01, 2021 at 07:48:19PM +0100, Mark Gray wrote: >> On 01/04/2021 19:29, Ilya Maximets wrote: >>> On 4/1/21 3:58 PM, Mark Gray wrote: This series fixes IPv6 support for Libreswan and introduces IPsec system tests for Libreswan.

Re: [ovs-dev] [PATCH ovn] expr: Combine multiple ipv4 with wildcard mask.(Internet mail)

2021-04-06 Thread Mark Gray
On 01/04/2021 13:28, gmingchen(陈供明) wrote: > Correct some words > > > On 2021/4/1, 8:17 PM, "gmingchen(陈供明)" wrote: > > > > On 2021/3/30, 4:59 PM, "Mark Gray" wrote: > > On 29/03/2021 13:30, gmingchen(陈供明) wrote: > > > > On 2021/3/25, 11:30 PM, "Mark Gray"

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Martin Varghese
On Tue, Apr 06, 2021 at 10:54:32AM +0200, Eelco Chaudron wrote: > > > On 6 Apr 2021, at 10:27, Martin Varghese wrote: > > > On Thu, Apr 01, 2021 at 11:32:06AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 1 Apr 2021, at 11:28, Martin Varghese wrote: > > > > > > > On Thu, Apr 01, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Jan Scheurich via dev
Hi, Thanks for the heads up. The interaction with MPLS push/pop is a use case that was likely not tested during the NSH and generic encap/decap design. It's complex code and a long time ago. I'm willing to help, but I will need some time to go back and have a look. It would definitely help,

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Eelco Chaudron
On 6 Apr 2021, at 10:27, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:32:06AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:28, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr

Re: [ovs-dev] [PATCH ovn] documentation: add sudo to install

2021-04-06 Thread Aidan Shribman
agree, see an alternative fix (v2) in which I run the ovsdb-tool and ovsdb-server under sudo as well On Tue, Apr 6, 2021 at 12:15 AM Ben Pfaff wrote: > On Mon, Apr 05, 2021 at 10:50:07PM +, hunchback wrote: > > - $ mkdir -p /usr/local/etc/ovn > > + $ sudo mkdir -m 777 -p

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Martin Varghese
On Thu, Apr 01, 2021 at 11:32:06AM +0200, Eelco Chaudron wrote: > > > On 1 Apr 2021, at 11:28, Martin Varghese wrote: > > > On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 1 Apr 2021, at 11:09, Martin Varghese wrote: > > > > > > > On Thu, Apr 01, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Eelco Chaudron
On 1 Apr 2021, at 11:32, Eelco Chaudron wrote: On 1 Apr 2021, at 11:28, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: On 1 Apr

[ovs-dev] [PATCH ovn v2] documentation: add sudo to install

2021-04-06 Thread hunchback
add documentation of install sequence sudo to support running install sequence as non-root user Signed-off-by: hunchback --- Documentation/intro/install/general.rst | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Documentation/intro/install/general.rst

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

2021-04-06 Thread Eli Britstein
On 4/6/2021 10:42 AM, Ivan Malov wrote: External email: Use caution opening links or attachments Hi Eli, Thank you for improving the patch series gradually. May I clarify one extra aspect (and I'm sorry if it has been discussed already): will OvS always insert F1 first and then insert F2? I

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

2021-04-06 Thread Ivan Malov
Hi Eli, Thank you for improving the patch series gradually. May I clarify one extra aspect (and I'm sorry if it has been discussed already): will OvS always insert F1 first and then insert F2? I mean, yes, in the model, F2 should process packets coming from F1, but is it *technically*