Re: [ovs-dev] [PATCH ovn] ovn-nbctl: fails to delete and add lr-nat in trx

Bleep bloop. Greetings Aidan Shribman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace #74 FILE: utilities/ovn-nbctl.c:4545:

Re: [ovs-dev] [PATCH ovn v3] documentation: add sudo to install

On 07/04/2021 20:43, Aidan Shribman wrote: > From: hunchback > > add documentation of install sequence sudo to support running install > sequence as non-root user > > Signed-off-by: Aidan Shribman > --- > Documentation/intro/install/general.rst | 14 +++--- > 1 file changed, 7

[ovs-dev] [PATCH ovn] ovn-nbctl: fails to delete and add lr-nat in trx

The delete operation did not update the internal state cuasing the add operation to wrongly believe that the lr-nat entry is still present and thus can't be added. Below is the sequance is failed before and now passes: *** echo "add switch" ovn-nbctl ls-del ls0 2>/dev/null ovn-nbctl ls-add ls0

[ovs-dev] [PATCH ovn v3] documentation: add sudo to install

add documentation of install sequence sudo to support running install sequence as non-root user Signed-off-by: Aidan Shribman --- Documentation/intro/install/general.rst | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Documentation/intro/install/general.rst

Re: [ovs-dev] [PATCH ovn v3] documentation: add sudo to install

Bleep bloop. Greetings Aidan Shribman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author hunchback needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn v2] documentation: add sudo to install

Done. On Wed, Apr 7, 2021, 18:10 Ben Pfaff wrote: > On Tue, Apr 06, 2021 at 08:11:35AM +, hunchback wrote: > > add documentation of install sequence sudo to support running install > > sequence as non-root user > > > > Signed-off-by: hunchback > > Thank you, this looks almost perfect. I

[ovs-dev] [PATCH ovn v3] documentation: add sudo to install

From: hunchback add documentation of install sequence sudo to support running install sequence as non-root user Signed-off-by: Aidan Shribman --- Documentation/intro/install/general.rst | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [ovs-dev] [PATCH] LLDP: add new command to show LLDP neighbor info

On 4/7/21 7:08 PM, Rick Zhong wrote: > Hi Ilya, > > Many thanks for your attention on this and reply. Please see my comments > inline. > > > And I will try the 'git' commands as you mentioned. > > Best regards, > > Rick Zhong > > > At 2021-04-07 20:21:19, "Ilya Maximets" wrote: >>On

Re: [ovs-dev] [PATCH ovn v2] documentation: add sudo to install

On Tue, Apr 06, 2021 at 08:11:35AM +, hunchback wrote: > add documentation of install sequence sudo to support running install > sequence as non-root user > > Signed-off-by: hunchback Thank you, this looks almost perfect. I have only one comment: would you please sign off with your name,

Re: [ovs-dev] [PATCH] LLDP: add new command to show LLDP neighbor info

Hi Ilya, Many thanks for your attention on this and reply. Please see my comments inline. And I will try the 'git' commands as you mentioned. Best regards, Rick Zhong At 2021-04-07 20:21:19, "Ilya Maximets" wrote: >On 3/24/21 4:56 AM, Rick Zhong wrote: >> Dear OVS

Re: [ovs-dev] ovn-northd-ddlog scale issues

On Thu, Apr 01, 2021 at 09:54:10AM -0700, Ben Pfaff wrote: > On Thu, Apr 01, 2021 at 06:33:21PM +0200, Dumitru Ceara wrote: > > On 4/1/21 5:48 PM, Ben Pfaff wrote: > > > On Wed, Mar 24, 2021 at 04:03:07PM +0100, Dumitru Ceara wrote: > > >> Hi Ben, > > >> > > >> We discussed a bit about this during

[ovs-dev] [PATCH ovn v2 27/26] ovn-nbctl: Don't replicate entire database unnecessarily.

ovn-nbctl was retrieving a replica of the entire northbound database regardless of what it was asked to do. This was unnecessary, but it was not written to be smart enough to just retrieve what it needed. This commit fixes the problem. It makes "ovn-nbctl init", for example, run instantly on a

Re: [ovs-dev] [PATCH 3/3] util: munlockall() and retry when locked memory allocation fails

On Wed, Apr 07, 2021 at 01:19:09PM +0200, Ilya Maximets wrote: > On 3/26/21 9:18 PM, Ben Pfaff wrote: > > On Fri, Mar 26, 2021 at 07:52:18PM +0100, Ilya Maximets wrote: > >> On 3/26/21 7:30 PM, Ben Pfaff wrote: > >>> From: James Page > >>> > >>> Normally when OVS runs on a server the effective

Re: [ovs-dev] [PATCH 2/3] util: Add allocation wrappers that don't increment coverage counters.

On Wed, Apr 07, 2021 at 01:12:11PM +0200, Ilya Maximets wrote: > On 3/26/21 7:30 PM, Ben Pfaff wrote: > > The thread-local data allocators can't increment coverage counters > > because this can cause reentrancy. Until now, this code has used > > explicit calls to malloc(). This code replaces

Re: [ovs-dev] [PATCH 1/3] ovs-lldp: Get rid of pointless null pointer check.

On Wed, Apr 07, 2021 at 12:58:21PM +0200, Ilya Maximets wrote: > On 3/26/21 7:30 PM, Ben Pfaff wrote: > > lldpd_alloc_hardware() always returns nonnull. > > > > At the same time, there's no reason that lldpd_alloc_hardware() doesn't > > take a const char *, so change that. > > > > Signed-off-by:

Re: [ovs-dev] [PATCH] LLDP: add new command to show LLDP neighbor info

Hi Ilya and Ben, Actually I was thinking how to make documentation for such kind of user commands change. Sure, I will provide it as you mentioned. Best regards, Rick Zhong At 2021-04-07 23:11:00, "Ilya Maximets" wrote: >On 4/7/21 4:40 PM, Ben Pfaff wrote: >> On Wed, Apr 07, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

Hi Martin, I guess you are aware of the original design document we wrote for generic encap/decap and NSH support: https://docs.google.com/document/d/1oWMYUH8sjZJzWa72o2q9kU0N6pNE-rwZcLH3-kbbDR8/edit# It is no longer 100% aligned with the final implementation in OVS but still a good reference

Re: [ovs-dev] [PATCH] LLDP: add new command to show LLDP neighbor info

On 4/7/21 4:40 PM, Ben Pfaff wrote: > On Wed, Apr 07, 2021 at 02:21:19PM +0200, Ilya Maximets wrote: >> Also, it seems like none of these commands documented anywhere. >> We will need to fix that someday. > > I'd recommend requiring documentation for anything being added, so the > situation

Re: [ovs-dev] [PATCH] LLDP: add new command to show LLDP neighbor info

On Wed, Apr 07, 2021 at 02:21:19PM +0200, Ilya Maximets wrote: > Also, it seems like none of these commands documented anywhere. > We will need to fix that someday. I'd recommend requiring documentation for anything being added, so the situation doesn't get worse. We usually document this kind

Re: [ovs-dev] [PATCH] netdev-offload-tc: use nl_msg_put_flag for OVS_TUNNEL_KEY_ATTR_CSUM

On 7 Apr 2021, at 13:43, Paolo Valerio wrote: when a tunnel port gets added to the bridge setting the checksum option to true: ovs-vsctl add-port br0 geneve0 -- set interface geneve0 type=geneve options:remote_ip= options:key= options:csum=true the flow dump for the outgoing traffic

Re: [ovs-dev] [PATCH] LLDP: add new command to show LLDP neighbor info

On 3/24/21 4:56 AM, Rick Zhong wrote: > Dear OVS reviewers/supervisors: > > > This patch is related to LLDP which provides a new command "ovs-appctl > lldp/neighbor" to show LLDP neighbor info when LLDP is enabled on OVS > interfaces. > > > With this new command, user is enable to get LLDP

Re: [ovs-dev] [PATCH RESEND ovs v3 4/4] dpif: Don't set "burst_size" to "rate" if not specified.

On 4/7/21 1:45 PM, Tonghao Zhang wrote: > On Fri, Apr 2, 2021 at 4:35 AM Ilya Maximets wrote: >> >> On 3/31/21 12:29 AM, Jean Tourrilhes wrote: >>> On Tue, Mar 30, 2021 at 02:27:11PM -0700, Ben Pfaff wrote: On Tue, Mar 30, 2021 at 11:16:48PM +0200, Ilya Maximets wrote: > > OpenFlow

Re: [ovs-dev] [PATCH RESEND ovs v3 4/4] dpif: Don't set "burst_size" to "rate" if not specified.

On Fri, Apr 2, 2021 at 4:35 AM Ilya Maximets wrote: > > On 3/31/21 12:29 AM, Jean Tourrilhes wrote: > > On Tue, Mar 30, 2021 at 02:27:11PM -0700, Ben Pfaff wrote: > >> On Tue, Mar 30, 2021 at 11:16:48PM +0200, Ilya Maximets wrote: > >>> > >>> OpenFlow spec is a bit loose in definition of what

[ovs-dev] [PATCH] netdev-offload-tc: use nl_msg_put_flag for OVS_TUNNEL_KEY_ATTR_CSUM

when a tunnel port gets added to the bridge setting the checksum option to true: ovs-vsctl add-port br0 geneve0 -- set interface geneve0 type=geneve options:remote_ip= options:key= options:csum=true the flow dump for the outgoing traffic will include a "bad key length 1 ..." message:

Re: [ovs-dev] [PATCH RESEND ovs v3 4/4] dpif: Don't set "burst_size" to "rate" if not specified.

On Fri, Apr 2, 2021 at 3:04 AM Jean Tourrilhes wrote: > > On Thu, Apr 01, 2021 at 07:53:25PM +0800, Tonghao Zhang wrote: > > > > Hi Ben, Ilya > > Try to explain this patch again. Now OvS has supported the burst_size, > > as one user case, > > if users don't use the burst_size feature, we should

Re: [ovs-dev] [PATCH 3/3] util: munlockall() and retry when locked memory allocation fails

On 3/26/21 9:18 PM, Ben Pfaff wrote: > On Fri, Mar 26, 2021 at 07:52:18PM +0100, Ilya Maximets wrote: >> On 3/26/21 7:30 PM, Ben Pfaff wrote: >>> From: James Page >>> >>> Normally when OVS runs on a server the effective system limit for >>> locked memory is unlimited as the ovs-vswitchd runs as

Re: [ovs-dev] [PATCH 2/3] util: Add allocation wrappers that don't increment coverage counters.

On 3/26/21 7:30 PM, Ben Pfaff wrote: > The thread-local data allocators can't increment coverage counters > because this can cause reentrancy. Until now, this code has used > explicit calls to malloc(). This code replaces them by calls to the > new functions. This will make it easier in an

Re: [ovs-dev] [PATCH 1/3] ovs-lldp: Get rid of pointless null pointer check.

On 3/26/21 7:30 PM, Ben Pfaff wrote: > lldpd_alloc_hardware() always returns nonnull. > > At the same time, there's no reason that lldpd_alloc_hardware() doesn't > take a const char *, so change that. > > Signed-off-by: Ben Pfaff LGTM, Acked-by: Ilya Maximets

Re: [ovs-dev] [v10 02/15] dpif-netdev: Split HWOL out to own header file.

This is a genuine unexpected sign-off, caused by an error in my .gitconfig. I've fixed this, so all warnings like this in the patchset will be fixed for the next version. Sorry about that. > -Original Message- > From: 0-day Robot > Sent: Wednesday 7 April 2021 11:04 > To: Ferriter,

Re: [ovs-dev] [v10 09/15] dpif-netdev/dpcls: Refactor function names to dpcls.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [v10 07/15] dpif-netdev: Add command to get dpif implementations.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [v10 05/15] dpif-avx512: Add HWOL support to avx512 dpif.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [v10 03/15] dpif-netdev: Add function pointer for netdev input.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [v10 02/15] dpif-netdev: Split HWOL out to own header file.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [v10 01/15] dpif-netdev: Refactor to multiple header files.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #231 FILE: lib/dpif-netdev-private-dfc.h:111:

Re: [ovs-dev] [OVN Patch v17 1/3] ovn-libs: Add support for parallel processing

Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #569 FILE: lib/ovn-parallel-hmap.h:61: #define

[ovs-dev] [v10 15/15] netdev: Optimize netdev_send_prepare_batch

From: Harry van Haaren Optimize for the best case here where all packets will be compatible with 'netdev_flags'. Signed-off-by: Harry van Haaren Co-authored-by: Cian Ferriter Signed-off-by: Cian Ferriter --- NEWS | 2 ++ lib/netdev.c | 31 ++- 2 files

[ovs-dev] [v10 13/15] dpcls-avx512: enabling avx512 vector popcount instruction.

From: Harry van Haaren This commit enables the AVX512-VPOPCNTDQ Vector Popcount instruction. This instruction is not available on every CPU that supports the AVX512-F Foundation ISA, hence it is enabled only when the additional VPOPCNTDQ ISA check is passed. The vector popcount instruction is

[ovs-dev] [v10 14/15] dpif-netdev: Optimize dp output action

From: Harry van Haaren This commit optimizes the output action, by enabling the compiler to optimize the code better through reducing code complexity. The core concept of this optimization is that the array-length checks have already been performed above the copying code, so can be removed.

[ovs-dev] [v10 12/15] dpdk: Cache result of CPU ISA checks.

From: Harry van Haaren As a small optimization, this patch caches the result of a CPU ISA check from DPDK. Particularly in the case of running the DPCLS autovalidator (which repeatedly probes subtables) this reduces the amount of CPU ISA lookups from the DPDK level. By caching them at the

[ovs-dev] [v10 09/15] dpif-netdev/dpcls: Refactor function names to dpcls.

From: Harry van Haaren This commit refactors the function names from netdev_* namespace to the dpcls_* namespace, as they are only used by dpcls code. With the name change, it becomes more obvious that the functions belong to dpcls functionality, and in the dpif-netdev-private-dpcls.h header

[ovs-dev] [v10 10/15] dpif-netdev/dpcls-avx512: enable 16 block processing.

From: Harry van Haaren This commit implements larger subtable searches in avx512. A limitation of the previous implementation was that up to 8 blocks of miniflow data could be matched on (so a subtable with 8 blocks was handled in avx, but 9 blocks or more would fall back to scalar/generic).

[ovs-dev] [v10 11/15] dpif-netdev/dpcls: specialize more subtable signatures.

From: Harry van Haaren This commit adds more subtables to be specialized. The traffic pattern here being matched is VXLAN traffic subtables, which commonly have (5,3), (9,1) and (9,4) subtable fingerprints. Signed-off-by: Harry van Haaren --- v8: Add NEWS entry. Signed-off-by: Cian Ferriter

[ovs-dev] [v10 07/15] dpif-netdev: Add command to get dpif implementations.

From: Harry van Haaren This commit adds a new command to retrieve the list of available DPIF implementations. This can be used by to check what implementations of the DPIF are available in any given OVS binary. Usage: $ ovs-appctl dpif-netdev/dpif-get Signed-off-by: Harry van Haaren

[ovs-dev] [v10 08/15] docs/dpdk/bridge: Add dpif performance section.

This section details how two new commands can be used to list and select the different dpif implementations. It also details how a non default dpif implementation can be tested with the OVS unit test suite. Add NEWS updates for the dpif-netdev.c refactor and the new dpif implementations/commands.

[ovs-dev] [v10 05/15] dpif-avx512: Add HWOL support to avx512 dpif.

From: Harry van Haaren Partial hardware offload is implemented in a very similar way to the scalar dpif. Signed-off-by: Harry van Haaren Signed-off-by: Cian Ferriter --- lib/dpif-netdev-avx512.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [v10 01/15] dpif-netdev: Refactor to multiple header files.

From: Harry van Haaren Split the very large file dpif-netdev.c and the datastructures it contains into multiple header files. Each header file is responsible for the datastructures of that component. This logical split allows better reuse and modularity of the code, and reduces the very large

[ovs-dev] [v10 06/15] dpif-netdev: Add command to switch dpif implementation.

From: Harry van Haaren This commit adds a new command to allow the user to switch the active DPIF implementation at runtime. A probe function is executed before switching the DPIF implementation, to ensure the CPU is capable of running the ISA required. For example, the below code will switch to

[ovs-dev] [v10 04/15] dpif-avx512: Add ISA implementation of dpif.

From: Harry van Haaren This commit adds the AVX512 implementation of DPIF functionality, specifically the dp_netdev_input_outer_avx512 function. This function only handles outer (no re-circulations), and is optimized to use the AVX512 ISA for packet batching and other DPIF work. Sparse is not

[ovs-dev] [v10 00/15] DPIF Framework + Optimizations

v10 Summary: - Added AVX512 POC work for DPIF and MFEX which was added in v9 -- MFEX patches will be sent separately - Rebase additions to NEWS entries - Update copyright notices v9 Summary: - Added AVX512 POC work for DPIF and MFEX in single patch at end -- Note that the AVX512 MFEX is for

[ovs-dev] [v10 03/15] dpif-netdev: Add function pointer for netdev input.

From: Harry van Haaren This commit adds a function pointer to the pmd thread data structure, giving the pmd thread flexibility in its dpif-input function choice. This allows choosing of the implementation based on ISA capabilities of the runtime CPU, leading to optimizations and higher

[ovs-dev] [v10 02/15] dpif-netdev: Split HWOL out to own header file.

From: Harry van Haaren This commit moves the datapath lookup functions required for hardware offload to a seperate file. This allows other DPIF implementations to access the lookup functions, encouraging code reuse. Signed-off-by: Harry van Haaren Signed-off-by: Cian Ferriter ---

[ovs-dev] [OVN Patch v17 1/3] ovn-libs: Add support for parallel processing

From: Anton Ivanov This adds a set of functions and macros intended to process hashes in parallel. The principles of operation are documented in the fasthmap.h If these one day go into the OVS tree, the OVS tree versions would be used in preference. Signed-off-by: Anton Ivanov ---

[ovs-dev] [OVN Patch v17 2/3] ovn-northd: Introduce parallel lflow build

From: Anton Ivanov Datapaths, ports, igmp groups and load balancers can now be iterated over in parallel in order to speed up the lflow generation. This decreases the time needed to generate the logical flows by a factor of 4+ on a 6 core/12 thread CPU without datapath groups - from 0.8-1

[ovs-dev] [OVN Patch v17 3/3] ovn-northd: Add configuration option for parallel lflow build

From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 3 +++ ovn-nb.xml | 13 + 2 files changed, 16 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index fdccde0c6..b68cc81ea 100644 --- a/northd/ovn-northd.c +++

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

On 4/7/2021 12:10 PM, Sriharsha Basavapatna wrote: On Sun, Apr 4, 2021 at 3:25 PM Eli Britstein > wrote: VXLAN decap in OVS-DPDK configuration consists of two flows: F1: in_port(ens1f0),eth(),ipv4(),udp(), actions:tnl_pop(vxlan_sys_4789) F2:

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

On Sun, Apr 4, 2021 at 3:25 PM Eli Britstein wrote: > VXLAN decap in OVS-DPDK configuration consists of two flows: > F1: in_port(ens1f0),eth(),ipv4(),udp(), actions:tnl_pop(vxlan_sys_4789) > F2: tunnel(),in_port(vxlan_sys_4789),eth(),ipv4(), actions:ens1f0_0 > > F1 is a classification flow. It

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

On Tue, Apr 06, 2021 at 09:00:16AM +, Jan Scheurich wrote: > Hi, > > Thanks for the heads up. The interaction with MPLS push/pop is a use case > that was likely not tested during the NSH and generic encap/decap design. > It's complex code and a long time ago. I'm willing to help, but I will

[ovs-dev] [PATCH] ofproto/ofproto-dpif-sflow: Check sflow agent in case of race

sFlow agent may not exist while calling dpif_sflow_received. The sFlow may be deleted in another thread, eg, by user, which will cause crash. Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Chris Mi --- ofproto/ofproto-dpif-sflow.c | 4 ++-- 1 file changed, 2 insertions(+), 2