Re: [ovs-dev] [PATCH ovn 1/5] ovn-controller: Support ssl cert rotation when command line options are used.

On Mon, May 17, 2021 at 6:08 PM Mark Michelson wrote: > > Hi Han, > > My comments below apply equally to the other patches in this series > since they are generally similar. > > I think each patch could use a simple accompanying test case. The test > could ensure that updates to the files are

[ovs-dev] [PATCH ovn] controller: Add support for PTR DNS requests.

From: Vladislav Odintsov The native OVN DNS support doesn't yet support for PTR DNS requests. This patch adds the support for it. If suppose there is a dns record as - "vm1.ovn.org"="10.0.0.4", then a normal DNS request will query for "vm1.ovn.org" and the reply will be the IP address -

Re: [ovs-dev] [PATCH ovn 1/5] ovn-controller: Support ssl cert rotation when command line options are used.

Hi Han, My comments below apply equally to the other patches in this series since they are generally similar. I think each patch could use a simple accompanying test case. The test could ensure that updates to the files are picked up by the OVN component. It could also potentially ensure

Re: [ovs-dev] [PATCH 1/2] stream-ssl.c: Fix stream_ssl_set_key_and_cert.

On Mon, May 17, 2021 at 3:01 PM Ilya Maximets wrote: > > On 5/15/21 12:13 AM, Han Zhou wrote: > > > > > > On Fri, May 14, 2021 at 2:43 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> On 5/13/21 11:33 PM, Han Zhou wrote: > >> > From the description of this interface, one of the

Re: [ovs-dev] [PATCH v9 ovn] ovn-northd: introduce new allow-stateless ACL verb

On Mon, May 17, 2021 at 2:27 PM Ihar Hrachyshka wrote: > > On Fri, May 7, 2021 at 7:11 PM Han Zhou wrote: > > > > > > > > On Fri, May 7, 2021 at 12:54 AM Dumitru Ceara wrote: > > > > > > On 5/7/21 7:35 AM, Han Zhou wrote: > > > > Hi Ihar, > > > > > > > > Thanks for the patch, and it's great to

Re: [ovs-dev] [PATCH 1/2] stream-ssl.c: Fix stream_ssl_set_key_and_cert.

On 5/15/21 12:13 AM, Han Zhou wrote: > > > On Fri, May 14, 2021 at 2:43 AM Ilya Maximets > wrote: >> >> On 5/13/21 11:33 PM, Han Zhou wrote: >> > From the description of this interface, one of the problems it tries to >> > solve is when one of the files is changed

Re: [ovs-dev] [PATCH] raft: Transfer leadership before creating snapshots.

On Mon, May 17, 2021 at 2:02 PM Ilya Maximets wrote: > > On 5/14/21 10:32 PM, Han Zhou wrote: > > > > > > On Fri, May 14, 2021 at 7:05 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> On 5/10/21 3:16 PM, Dumitru Ceara wrote: > >> > On 5/6/21 2:47 PM, Ilya Maximets wrote: > >> > > >>

[ovs-dev] [PATCH ovn 3/3] Honor ACL direction when omitting ct for stateless

While we *should not* circumvent conntrack when a stateful ACL of higher priority is present on the switch, we should do so only when allow-stateless and allow-stateful directions are the same, otherwise we should still skip conntrack for allow-stateless ACLs. Fixes: 3187b9fef1 ("ovn-northd:

[ovs-dev] [PATCH ovn 1/3] Honor allow-related priority when stateless present

For each allow-stateless ACL, a rule was added earlier in the pipeline that circumvented setting REGBIT_CONNTRACK_DEFRAG regardless of whether other, e.g. allow-related ACLs with higher priority were present. Now, when allow-stateless ACLs are present on the switch, for each allow-related, insert

[ovs-dev] [PATCH ovn 2/3] Honor allow priority when stateless present

For each allow-stateless ACL, a rule was added earlier in the pipeline that circumvented setting REGBIT_CONNTRACK_DEFRAG regardless of whether other, e.g. allow ACLs with higher priority were present. Now, when allow-stateless ACLs are present on the switch with other allow-related ACLs, for each

Re: [ovs-dev] [PATCH v9 ovn] ovn-northd: introduce new allow-stateless ACL verb

On Fri, May 7, 2021 at 7:11 PM Han Zhou wrote: > > > > On Fri, May 7, 2021 at 12:54 AM Dumitru Ceara wrote: > > > > On 5/7/21 7:35 AM, Han Zhou wrote: > > > Hi Ihar, > > > > > > Thanks for the patch, and it's great to see the significant performance > > > improvement! > > > Please see my

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fix port group conjunction flow explosion problem.

On Tue, May 11, 2021 at 12:38 PM Mark Michelson wrote: > > On 5/6/21 6:03 PM, Han Zhou wrote: > > > > > > On Thu, May 6, 2021 at 1:18 PM Mark Michelson > > wrote: > > > > > > Thanks, Han! > > > > > > Acked-by: Mark Michelson > > > > >

Re: [ovs-dev] [PATCH] raft: Transfer leadership before creating snapshots.

On 5/14/21 10:32 PM, Han Zhou wrote: > > > On Fri, May 14, 2021 at 7:05 AM Ilya Maximets > wrote: >> >> On 5/10/21 3:16 PM, Dumitru Ceara wrote: >> > On 5/6/21 2:47 PM, Ilya Maximets wrote: >> > >> > [...] >> > >> > Oops, I meant to send this along with the acked-by:

Re: [ovs-dev] [PATCH v2 ovn] controller: fix physical flow update for localport

On Mon, May 17, 2021 at 8:37 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > Properly update logical/openflow flows for localport removing the > interface from the ovs bridge. Openflows in table 65 are not recomputed > removing a localport from an ovs-bridge and the ovs bridge

Re: [ovs-dev] [PATCH ovn v1] Fix Segmentation Fault when LR requests duplicate requested-tnl-key

Thanks Karthik, I applied this to master, branch-21.03, and branch-20.12. On 5/11/21 4:23 PM, svc.eng.git-m...@nutanix.com wrote: From: Karthik Chandrashekar Fixes: b6c349a271363faf277041b230f2244489c7e7a3 Signed-off-by: Karthik Chandrashekar --- northd/ovn-northd.c | 4 ++--

Re: [ovs-dev] [PATCH ovn] controller: bfd: improve debugging logs

On 5/10/21 5:05 PM, Mark Michelson wrote: Thanks Lorenzo, it looks good to me. Acked-by: Mark Michelson I pushed this to master. On 4/24/21 8:46 AM, Lorenzo Bianconi wrote: Add new debug logs in pinctrl_handle_bfd_msg flow path useful for debugging Signed-off-by: Lorenzo Bianconi ---  

Re: [ovs-dev] [PATCH ovn v2] expr: crush the result of a sorted OR expression.

On 5/14/21 3:22 PM, Numan Siddique wrote: On Fri, May 14, 2021 at 3:19 PM Numan Siddique wrote: On Fri, May 7, 2021 at 9:03 AM Mark Michelson wrote: On 5/7/21 8:03 AM, Dumitru Ceara wrote: On 5/6/21 10:49 PM, Mark Michelson wrote: ACLs and logical router policies leave the user open to

Re: [ovs-dev] [PATCH ovn] ovs: Include monitor condition expected seqno fix.

Hi Dumitru, Can you please explain in the commit message why this change is needed? I don't have anything against bumping the OVS submodule commit, but it's hard to review this change without knowing any context. Thanks, Mark On 5/17/21 4:57 AM, Dumitru Ceara wrote: Specifically:

Re: [ovs-dev] [v3 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

[ovs-dev] [PATCH v2 ovn] controller: fix physical flow update for localport

Properly update logical/openflow flows for localport removing the interface from the ovs bridge. Openflows in table 65 are not recomputed removing a localport from an ovs-bridge and the ovs bridge ends-up with a stale configuration adding the interface back. Fix the issue taking care of localport

Re: [ovs-dev] [PATCH v3] conntrack: document all-zero IP SNAT behavior and add a test case

On 4/26/21 2:19 PM, Eelco Chaudron wrote: > Currently, conntrack in the kernel has an undocumented feature referred > to as all-zero IP address NULL SNAT. Basically, when a source port > collision is detected during the commit, the source port will be > translated to an ephemeral port. If there is

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #231 FILE: lib/dpif-netdev-private-dfc.h:111:

Re: [ovs-dev] [PATCH v2] ofp_actions: fix set_mpls_tc formatting

On 5/17/21 1:42 PM, Ilya Maximets wrote: > On 5/17/21 1:28 PM, Adrian Moreno wrote: >> >> >> On 5/14/21 6:50 PM, Ilya Maximets wrote: >>> On 5/14/21 5:14 PM, Adrian Moreno wrote: On 5/14/21 4:34 PM, Ilya Maximets wrote: > On 5/7/21 3:02 PM, Adrian Moreno wrote: >> Apart

Re: [ovs-dev] [PATCH ovn] controller: fix physical flow update for localport

> On Thu, May 13, 2021 at 8:33 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > > Properly update logical/openflow flows for localport removing the > > interface from the ovs bridge. Openflows in table 65 are not recomputed > > removing a localport from an ovs-bridge and the ovs

[ovs-dev] [v3 11/12] dpif-netdev/mfex: add more AVX512 traffic profiles

From: Harry van Haaren This commit adds 3 new traffic profile implementations to the existing avx512 miniflow extract infrastructure. The profiles added are: - Ether()/IP()/TCP() - Ether()/Dot1Q()/IP()/UDP() - Ether()/Dot1Q()/IP()/TCP() The design of the avx512 code here is for scalability to

[ovs-dev] [v3 12/12] dpif/dpcls: limit count subtable search info logs

From: Harry van Haaren This commit avoids many instances of "using subtable X for miniflow (x,y)" in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs when no specialized subtable is found, and the generic "_any" version of the avx512 subtable search implementation was used.

[ovs-dev] [v3 09/12] dpdk: add additional CPU ISA detection strings

From: Harry van Haaren This commit enables OVS to at runtime check for more detailed AVX512 capabilities, specifically Byte and Word (BW) extensions, and Vector Bit Manipulation Instructions (VBMI). These instructions will be used in the CPU ISA optimized implementations of traffic profile

[ovs-dev] [v3 08/12] dpif/stats: add miniflow extract opt hits counter

From: Harry van Haaren This commit adds a new counter to be displayed to the user when requesting datapath packet statistics. It counts the number of packets that are parsed and a miniflow built up from it by the optimized miniflow extract parsers. The ovs-appctl command

[ovs-dev] [v3 06/12] dpif-netdev: Add additional packet count parameter for study function

This commit introduces additonal command line paramter for mfex study function. If user provides additional packet out it is used in study to compare minimum packets which must be processed else a default value is choosen. $ OVS_DIR/utilities/ovs-appctl dpif-netdev/miniflow-parser-set study 500

[ovs-dev] [v3 10/12] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

From: Harry van Haaren This commit adds AVX512 implementations of miniflow extract. By using the 64 bytes available in an AVX512 register, it is possible to convert a packet to a miniflow data-structure in a small quantity instructions. The implementation here probes for Ether()/IP()/UDP()

[ovs-dev] [v3 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

Tests: 6: OVS-DPDK - MFEX Autovalidator 7: OVS-DPDK - MFEX Autovalidator Fuzzy Added a new directory to store the PCAP file used in the tests and a script to generate the fuzzy traffic type pcap to be used in fuzzy unit test. Signed-off-by: Kumar Amber --- tests/automake.mk| 5 +

[ovs-dev] [v3 04/12] docs/dpdk/bridge: add miniflow extract section.

This commit adds a section to the dpdk/bridge.rst netdev documentation, detailing the added miniflow functionality. The newly added commands are documented, and sample output is provided. The use of auto-validator and special study function is also described in detail as well as running fuzzy

[ovs-dev] [v3 03/12] dpif-netdev: Add study function to select the best mfex function

The study function runs all the available implementations of miniflow_extract and makes a choice whose hitmask has maximum hits and sets the mfex to that function. Study can be run at runtime using the following command: $ ovs-appctl dpif-netdev/miniflow-parser-set study Signed-off-by: Kumar

[ovs-dev] [v3 05/12] dpif-netdev: Add configure to enable autovalidator at build time.

This commit adds a new command to allow the user to enable autovalidatior by default at build time thus allowing for runnig unit test by default. $ ./configure --enable-mfex-default-autovalidator Signed-off-by: Kumar Amber Co-authored-by: Harry van Haaren Signed-off-by: Harry van Haaren ---

[ovs-dev] [v3 02/12] dpif-netdev: Add auto validation function for miniflow extract

This patch introduced the auto-validation function which allows users to compare the batch of packets obtained from different miniflow implementations against the linear miniflow extract and return a hitmask. The autovaidator function can be triggered at runtime using the following command: $

[ovs-dev] [v3 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

This patch introduces the mfex function pointers which allows the user to switch between different miniflow extract implementations which are provided by the OVS based on optimized ISA CPU. The user can query for the available minflow extract variants available for that CPU by following commands:

[ovs-dev] [v3 00/12] MFEX Infrastructure + Optimizations

v3 updates: - rebase on to latest DPIF v12 - add additonal AVX512 traffic profiles for tcp and vlan - add new command line for study function to add packet count - add unit tests for fuzzy testing and auto-validation of mfex - add mfex option hit stats to perf-show command v2 updates: - rebase on

[ovs-dev] [v12 14/16] dpcls-avx512: Enable avx512 vector popcount instruction.

From: Harry van Haaren This commit enables the AVX512-VPOPCNTDQ Vector Popcount instruction. This instruction is not available on every CPU that supports the AVX512-F Foundation ISA, hence it is enabled only when the additional VPOPCNTDQ ISA check is passed. The vector popcount instruction is

[ovs-dev] [v12 13/16] dpdk: Cache result of CPU ISA checks.

From: Harry van Haaren As a small optimization, this patch caches the result of a CPU ISA check from DPDK. Particularly in the case of running the DPCLS autovalidator (which repeatedly probes subtables) this reduces the amount of CPU ISA lookups from the DPDK level. By caching them at the

[ovs-dev] [v12 12/16] dpif-netdev/dpcls: Specialize more subtable signatures.

From: Harry van Haaren This commit adds more subtables to be specialized. The traffic pattern here being matched is VXLAN traffic subtables, which commonly have (5,3), (9,1) and (9,4) subtable fingerprints. Signed-off-by: Harry van Haaren --- v8: Add NEWS entry. --- NEWS

[ovs-dev] [v12 15/16] dpif-netdev: Optimize dp output action.

From: Harry van Haaren This commit optimizes the output action, by enabling the compiler to optimize the code better through reducing code complexity. The core concept of this optimization is that the array-length checks have already been performed above the copying code, so can be removed.

[ovs-dev] [v12 09/16] docs/dpdk/bridge: Add dpif performance section.

This section details how two new commands can be used to list and select the different dpif implementations. It also details how a non default dpif implementation can be tested with the OVS unit test suite. Add NEWS updates for the dpif-netdev.c refactor and the new dpif implementations/commands.

[ovs-dev] [v12 16/16] netdev: Optimize netdev_send_prepare_batch.

From: Harry van Haaren Optimize for the best case here where all packets will be compatible with 'netdev_flags'. Signed-off-by: Harry van Haaren Co-authored-by: Cian Ferriter Signed-off-by: Cian Ferriter --- NEWS | 2 ++ lib/netdev.c | 31 ++- 2 files

[ovs-dev] [v12 11/16] dpif-netdev/dpcls-avx512: Enable 16 block processing.

From: Harry van Haaren This commit implements larger subtable searches in avx512. A limitation of the previous implementation was that up to 8 blocks of miniflow data could be matched on (so a subtable with 8 blocks was handled in avx, but 9 blocks or more would fall back to scalar/generic).

[ovs-dev] [v12 07/16] dpif-netdev: Add command to get dpif implementations.

From: Harry van Haaren This commit adds a new command to retrieve the list of available DPIF implementations. This can be used by to check what implementations of the DPIF are available in any given OVS binary. Usage: $ ovs-appctl dpif-netdev/dpif-get Signed-off-by: Harry van Haaren ---

[ovs-dev] [v12 08/16] dpif-netdev: Add a partial HWOL PMD statistic.

It is possible for packets traversing the userspace datapath to match a flow before hitting on EMC by using a mark ID provided by a NIC. Add a PMD statistic for this hit. Signed-off-by: Cian Ferriter --- NEWS | 2 ++ lib/dpif-netdev-avx512.c | 3 +++ lib/dpif-netdev-perf.c

[ovs-dev] [v12 05/16] dpif-avx512: Add HWOL support to avx512 dpif.

From: Harry van Haaren Partial hardware offload is implemented in a very similar way to the scalar dpif. Signed-off-by: Harry van Haaren --- lib/dpif-netdev-avx512.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/lib/dpif-netdev-avx512.c

[ovs-dev] [v12 10/16] dpif-netdev/dpcls: Refactor function names to dpcls.

From: Harry van Haaren This commit refactors the function names from netdev_* namespace to the dpcls_* namespace, as they are only used by dpcls code. With the name change, it becomes more obvious that the functions belong to dpcls functionality, and in the dpif-netdev-private-dpcls.h header

[ovs-dev] [v12 00/16] DPIF Framework + Optimizations

v12 Summary: - Add a partial HWOL PMD statistic. This is added for both the scalar and AVX512 DPIFs. v11 Summary: - Improve the dp_netdev_impl_get_default() function so PMD threads created after running "dpif-set" command will use the DPIF implementation that was set. - Fix small comment

[ovs-dev] [v12 03/16] dpif-netdev: Add function pointer for netdev input.

From: Harry van Haaren This commit adds a function pointer to the pmd thread data structure, giving the pmd thread flexibility in its dpif-input function choice. This allows choosing of the implementation based on ISA capabilities of the runtime CPU, leading to optimizations and higher

[ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

From: Harry van Haaren Split the very large file dpif-netdev.c and the datastructures it contains into multiple header files. Each header file is responsible for the datastructures of that component. This logical split allows better reuse and modularity of the code, and reduces the very large

[ovs-dev] [v12 02/16] dpif-netdev: Split HWOL out to own header file.

From: Harry van Haaren This commit moves the datapath lookup functions required for hardware offload to a seperate file. This allows other DPIF implementations to access the lookup functions, encouraging code reuse. Signed-off-by: Harry van Haaren --- lib/automake.mk| 1 +

[ovs-dev] [v12 04/16] dpif-avx512: Add ISA implementation of dpif.

From: Harry van Haaren This commit adds the AVX512 implementation of DPIF functionality, specifically the dp_netdev_input_outer_avx512 function. This function only handles outer (no re-circulations), and is optimized to use the AVX512 ISA for packet batching and other DPIF work. Sparse is not

[ovs-dev] [v12 06/16] dpif-netdev: Add command to switch dpif implementation.

From: Harry van Haaren This commit adds a new command to allow the user to switch the active DPIF implementation at runtime. A probe function is executed before switching the DPIF implementation, to ensure the CPU is capable of running the ISA required. For example, the below code will switch to

[ovs-dev] [PATCH v2] Fix redundant datapath set ethernet action with NSH Decap

From: Martin Varghese When a decap action is applied on NSH header encapsulatiing a ethernet packet a redundant set mac address action is programmed to the datapath. Fixes: f839892a206a ("OF support and translation of generic encap and decap") Signed-off-by: Martin Varghese Acked-by: Jan

[ovs-dev] [PATCH] netdev-offload-tc: verify the flower rule installed

When OVs installs the flower rule, it only checks for the OK from the kernel. It does not check if the rule requested matches the one actually programmed. This change will add this check and warns the user if this is not the case. Signed-off-by: Eelco Chaudron --- lib/tc.c | 59

Re: [ovs-dev] [PATCH] conntrack: invalid packet should not modify ct state

Zang MingJie writes: > When encounter an invalid packet, all changes made by the packet should > be reverted. Currently an invalid packet can change the seq number while > the connection is in SEQ_RECV state. > > Signed-off-by: Zang MingJie > --- In the future, please submit a test case with

Re: [ovs-dev] [PATCH v2 2/2] add test cases for ingress_policing_kpkts parameters

Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v2 1/2] add port-based ingress policing based packet-per-second rate-limiting

Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v2] ofp_actions: fix set_mpls_tc formatting

On 5/17/21 1:28 PM, Adrian Moreno wrote: > > > On 5/14/21 6:50 PM, Ilya Maximets wrote: >> On 5/14/21 5:14 PM, Adrian Moreno wrote: >>> >>> >>> On 5/14/21 4:34 PM, Ilya Maximets wrote: On 5/7/21 3:02 PM, Adrian Moreno wrote: > Apart from a cut-and-paste typo, the man page claims that

Re: [ovs-dev] [PATCH v2] ofp_actions: fix set_mpls_tc formatting

On 5/14/21 6:50 PM, Ilya Maximets wrote: > On 5/14/21 5:14 PM, Adrian Moreno wrote: >> >> >> On 5/14/21 4:34 PM, Ilya Maximets wrote: >>> On 5/7/21 3:02 PM, Adrian Moreno wrote: Apart from a cut-and-paste typo, the man page claims that mpls_labels can be provided in hexadecimal format

[ovs-dev] [PATCH v2 1/2] add port-based ingress policing based packet-per-second rate-limiting

From: Yong Xu OVS has support for using policing to enforce a rate limit in kilobits per second. This is configured using OVSDB. f.e. $ ovs-vsctl set interface tap0 ingress_policing_rate=1000 $ ovs-vsctl set interface tap0 ingress_policing_burst=100 This patch adds a related feature, allowing

[ovs-dev] [PATCH v2 2/2] add test cases for ingress_policing_kpkts parameters

From: Tianyu Yuan Exercise OVS setting of ingress_policing_kpkts parameters using ovs-vsctl and verify that the correct values are stored on OVSDB. Verify the ingress_policing parameters with tc command. Also check offload and non-offload in tc software datapath based on tc filter type

[ovs-dev] [PATCH v2 0/2] add port-based ingress policing based packet-per-second rate-limiting

Hi, this short test adds support for add port-based ingress policing based packet-per-second rate-limiting. This builds on existing support for byte-per-second rate limiting. Changes since v1 * Correct typo: s/comsume/consume/ Tianyu Yuan (1): add test cases for ingress_policing_kpkts

Re: [ovs-dev] [PATCH v2] ovsdb-cs: Consider all tables when computing expected cond seqno.

On 5/14/21 2:34 PM, Ilya Maximets wrote: > On 5/7/21 9:28 PM, Dumitru Ceara wrote: >> In ovsdb_cs_db_set_condition(), take into account all pending condition >> changes for all tables when computing the db->cond_seqno at which the >> monitor is expected to be updated. >> >> In the following

[ovs-dev] [PATCH branch-2.14] ovsdb-idl: Consider all tables when computing expected cond seqno.

In ovsdb_idl_db_set_condition(), take into account all pending condition changes for all tables when computing the db->cond_seqno at which the monitor is expected to be updated. In the following scenario, with two tables, A and B, the old code performed the following steps: 1. Initial

[ovs-dev] [PATCH ovn] ovs: Include monitor condition expected seqno fix.

Specifically: b5bb044fbe4c ("ovsdb-cs: Consider all tables when computing expected cond seqno.") Signed-off-by: Dumitru Ceara --- ovs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovs b/ovs index ac85cdb38..b5bb044fb 16 --- a/ovs +++ b/ovs @@ -1 +1 @@ -Subproject

Re: [ovs-dev] [PATCH v2] Improve concurrency by adjust flow-limit

Bleep bloop. Greetings Tao YunXiang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #50 FILE: ofproto/ofproto-dpif-upcall.c:970:

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Improve concurrency by adjust flow-limit

At 2021-05-13 01:20:29, "Ben Pfaff" wrote: >On Wed, May 12, 2021 at 10:44:12AM +0800, taoyunupt wrote: >> At 2021-05-12 04:00:30, "Ben Pfaff" wrote: >> >On Tue, May 11, 2021 at 03:52:00PM +0800, Tao YunXiang wrote: >> >> +/* Use duration as a reference, adjust the number of >> >>

[ovs-dev] [PATCH v2] Improve concurrency by adjust flow-limit

OVS uses a set of gentle mechanisms to control the number of flows in datapath. However, it is difficult for the number of datapath flows to reach a high level in a short time. Through some tests with Apache benchmark, I found the point is that the value of flow-limit increases too slowly, but

Re: [ovs-dev] [PATCH ovn] controller: fix physical flow update for localport

On Thu, May 13, 2021 at 8:33 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > Properly update logical/openflow flows for localport removing the > interface from the ovs bridge. Openflows in table 65 are not recomputed > removing a localport from an ovs-bridge and the ovs bridge