On Mon, May 17, 2021 at 7:05 PM Han Zhou wrote:
>
>
>
> On Mon, May 17, 2021 at 6:08 PM Mark Michelson
wrote:
> >
> > Hi Han,
> >
> > My comments below apply equally to the other patches in this series
> > since they are generally similar.
> >
> > I think each patch could use a simple
When SSL configurations are set in Open_vSwitch SSL table,
ovn-controller handles file update properly by re-applying the settings
in the main loop. However, it is also valid to set the options in
command line of ovn-controller without using the SSL table. In this
case, the options are set onetime
Update SSL in the server_loop so that updated pki files can be reapplied.
Signed-off-by: Han Zhou
---
tests/ovn-nbctl.at| 40
utilities/ovn-nbctl.c | 32 +++-
2 files changed, 71 insertions(+), 1 deletion(-)
diff --git
Update SSL in the main loop so that updated pki files can be reapplied.
Signed-off-by: Han Zhou
---
ic/ovn-ic.c | 31 ++-
northd/ovn-northd-ddlog.c | 31 ++-
northd/ovn-northd.c | 31 ++-
On Fri, Apr 30, 2021 at 8:33 AM Mark Gray wrote:
>
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
> space flow table. The upcall sends packets via a Netlink socket.
> Currently, a Netlink socket is created
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, May 19, 2021 4:47 PM
> To: Wang, Liang-min ; Miskell, Timothy
> ; d...@openvswitch.org
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
>
>
> On 5/19/21 4:17 PM, Wang, Liang-min wrote:
> >>
On 5/19/21 4:17 PM, Wang, Liang-min wrote:
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Wednesday, May 19, 2021 8:50 AM
>> To: Wang, Liang-min ; Miskell, Timothy
>> ; d...@openvswitch.org
>> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>>
>>
>>
On Wed, May 19, 2021 at 10:03:57PM +0200, Ilya Maximets wrote:
> Hi.
>
> Taking into account some very unhealthy things that happened recently
> with FreeNode network and resigning of lots of its stuff [1], we
> probably need to discuss if Open vSwitch project wants to change the
> IRC server for
Hi Ihar,
I floated this by the OVN team in #coreovn and got positive responses.
So I think this is a candidate.
On 5/18/21 11:40 AM, Ihar Hrachyshka wrote:
Is it already time to request exceptions for freeze?
I would like the following bug fixes incorporated in 21.06, all
related to the new
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author lin huang needs to sign off.
WARNING: Unexpected sign-offs from developers who are
> On Wed, 2021-05-19 at 17:35 +0200, Lorenzo Bianconi wrote:
> > In the current codebase, check_pkt_len is applied just for traffic
> > leaving the
> > ovn cluster. This series introduces the same capability for traffic
> > entering
> > the network from a gateway router or distributed gateway
On Wed, 2021-05-19 at 17:35 +0200, Lorenzo Bianconi wrote:
> In the current codebase, check_pkt_len is applied just for traffic
> leaving the
> ovn cluster. This series introduces the same capability for traffic
> entering
> the network from a gateway router or distributed gateway router port
> in
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author lin huang needs to sign off.
WARNING: Unexpected sign-offs from developers who are
netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.
Signed-off-by: miter
---
lib/netdev-linux.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 15b25084b..0994044ec 100644
--- a/lib/netdev-linux.c
+++
> Split the very large file dpif-netdev.c and the datastructures
> it contains into multiple header files. Each header file is
> responsible for the datastructures of that component.
>
> This logical split allows better reuse and modularity of the code,
> and reduces the very large file
dpif-netdev.c : Fix indentation.
Add extra space to fix indentation.
Signed-off-by: miter
---
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 816945375..dc77fa2fa 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -7404,7 +7404,7 @@ dp_netdev_input__(struct dp_netdev_pmd_thread
As it is already done for distributed gw router scenario, introduce
check_pkt_len logical flows for gw router use case.
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.c | 31 --
tests/ovn.at| 238
2 files changed, 260
Introduce chec_pkt_len action for ingress traffic entering the cluster
from a distributed gw router port or from a gw router.
Rearrange logical router ingress pipeline in order to properly manage
icmp error packets.
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.c | 154
Introduce build_check_pkt_len_flows_for_lrp routine to configure
check_pkt_len logical flow for a given logical port. This is a
preliminary patch to enable check_pkt_len support for gw router use
case.
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.c | 181
In the current codebase, check_pkt_len is applied just for traffic leaving the
ovn cluster. This series introduces the same capability for traffic entering
the network from a gateway router or distributed gateway router port in order
to send an ICMP error packet if the frame size is greater than
On Mon, May 17, 2021 at 10:01 PM wrote:
>
> From: Vladislav Odintsov
>
> The native OVN DNS support doesn't yet support for PTR DNS requests.
> This patch adds the support for it. If suppose there is a dns record
> as - "vm1.ovn.org"="10.0.0.4", then a normal DNS request will query for
>
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, May 19, 2021 8:50 AM
> To: Wang, Liang-min ; Miskell, Timothy
> ; d...@openvswitch.org
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
>
>
> On 5/19/21 1:53 PM, Wang, Liang-min wrote:
> >>
On Wed, May 19, 2021 at 1:48 PM Stokes, Ian wrote:
> > > I didn't see anymore comments on above, following he patch sync last
> > week and the discussion had there I'm happy to update the commit
> > message, remove the tested tag and push the series to dpdk-latest.
> >
> > Either leaving as is
On 5/18/21 9:48 AM, Adrian Moreno wrote:
> Apart from a cut-and-paste typo, the man page claims that mpls_labels
> can be provided in hexadecimal format but that's currently not the case.
>
> Fix mpls ofp-action formatting, add size checks on ofp-action parsing
> and add some unit tests.
>
>
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author lin huang needs to sign off.
Lines checked: 31, Warnings: 0, Errors: 1
Please
On 2/27/21 10:34 AM, Peng He wrote:
> CT zone could be set from a field that is not included in frozen
> metadata. Consider the example rules which are typically seen in
> OpenStack security group rules:
>
> priority=100,in_port=1,tcp,ct_state=-trk,action=ct(zone=5,table=0)
>
On 5/19/21 1:53 PM, Wang, Liang-min wrote:
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Wednesday, May 19, 2021 3:56 AM
>> To: Wang, Liang-min ; Miskell, Timothy
>> ; d...@openvswitch.org
>> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>>
>> Hi
dpif-netdev.c : Fix indentation.
Add extra space to fix indentation.
Signed-off-by: miter
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 816945375..dc77fa2fa 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -7404,7 +7404,7 @@ dp_netdev_input__(struct
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, May 19, 2021 3:56 AM
> To: Wang, Liang-min ; Miskell, Timothy
> ; d...@openvswitch.org
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
> Hi Liang-min,
>
> When replying inline, please do not
> Hi Ian,
>
> On Wed, May 19, 2021 at 1:23 PM Stokes, Ian wrote:
> >
> > > > On 06/05/2021 16:25, David Marchand wrote:
> > > > > Make this branch point to current main master branch so that we can
> > > > > track API breakage.
> > > > >
> > > >
> > > > s/master//
> > >
> > > I can strip out
Hi Ian,
On Wed, May 19, 2021 at 1:23 PM Stokes, Ian wrote:
>
> > > On 06/05/2021 16:25, David Marchand wrote:
> > > > Make this branch point to current main master branch so that we can
> > > > track API breakage.
> > > >
> > >
> > > s/master//
> >
> > I can strip out master above and keep it as
> > On 06/05/2021 16:25, David Marchand wrote:
> > > Make this branch point to current main master branch so that we can
> > > track API breakage.
> > >
> >
> > s/master//
>
> I can strip out master above and keep it as main on commit.
>
> >
> > > Note: this should not be merged to master,
On 5/17/21 11:22 AM, Dumitru Ceara wrote:
> In ovsdb_idl_db_set_condition(), take into account all pending
> condition changes for all tables when computing the db->cond_seqno at
> which the monitor is expected to be updated.
>
> In the following scenario, with two tables, A and B, the old code
>
On 4/21/21 3:48 PM, Ilya Maximets wrote:
> Implementation of meters supposed to be a classic token bucket with 2
> typical parameters: rate and burst size.
>
> Burst size in this schema is the maximum number of bytes/packets that
> could pass without being rate limited.
>
> Recent changes to
On 5/19/21 5:26 AM, Martin Varghese wrote:
> On Tue, May 18, 2021 at 10:03:39PM +0200, Ilya Maximets wrote:
>> On 5/17/21 3:45 PM, Martin Varghese wrote:
>>> From: Martin Varghese
>>>
>>> When a decap action is applied on NSH header encapsulatiing a
>>> ethernet packet a redundant set mac address
On 5/17/21 5:20 PM, Toms Atteka wrote:
> IPv6 extension headers carry optional internet layer information
> and are placed between the fixed header and the upper-layer
> protocol header.
>
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> packets can be filtered using ipv6_ext
On Tue, May 18, 2021 at 02:22:26PM +0200, Ilya Maximets wrote:
> On 4/27/21 3:23 AM, Chris Mi wrote:
...
> > Hi Ilya,
> >
> > The code according to your suggestion is ready. But during the internal
> > code review, Eli Britstein thought flow_api is netdev based, but the
> > psample/sFlow
New appctl 'dpdk/get-malloc-stats' implemented to get result of
'rte_malloc_dump_stats()' function.
Could be used for debugging.
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
v2:
- Following Eelco Chaudron's comments, abandoned get-socket-stats.
- Acked-by: Eelco Chaudron
Hi Liang-min,
When replying inline, please do not prefix with ">>" as it is handled as
quoted text. There is no need to prefix.
On 5/18/21 8:00 PM, Wang, Liang-min wrote:
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Tuesday, May 18, 2021 12:15 PM
>> To: Miskell, Timothy ;
On 5/18/21 8:49 AM, Dumitru Ceara wrote:
> When setting monitor conditions ovsdb_cs_db_set_condition() returns the
> sequence number when it is expected that all updates that correspond to
> the new condition have been received. This sequence number is used by
> ovn-controller to determine
+ d...@openvswitch.org
On Tue, May 18, 2021 at 12:33 AM Toms Atteka wrote:
>
> IPv6 extension headers carry optional internet layer information
> and are placed between the fixed header and the upper-layer
> protocol header.
>
> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
>
>From 32113ea0fb65a99271359440316abf7d8a14f551 Mon Sep 17 00:00:00 2001
From: miter
Date: Wed, 19 May 2021 12:55:24 +0800
Subject: [PATCH] netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.
Signed-off-by: miter
---
lib/netdev-linux.c | 4 +++-
1 file changed, 3 insertions(+), 1
42 matches
Mail list logo
