fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
doesn't clear skb->tstamp. We encountered a problem with linux
version 5.4.56 and ovs version 2.14.1, and packets failed to
dequeue from qdisc when fq qdisc was attached to ovs port.
Signed-off-by: kaixi.fan
Signed-off-by:
Currently, '__builtin_prefetch' is defined for OVS_PREFETCH macro only
if '__GNUC__' is defined. However, it would make sense to use a
'__has_builtin' preprocessor operator to check if '__builtin_prefetch'
is available and then define the OVS_PREFETCH macro.
Doing so will allow to use prefetching
On 8/16/21 10:09 PM, Ilya Maximets wrote:
> There is still a couple of bug fixes that I want to apply before
> tagging v2.16.0, which are fixes for PACKET_OUT crash in userspace
> datapath:
>
>
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#429 FILE: northd/ovn-northd.c:8819:
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless
(.github/workflows/ovn-kubernetes.yml).
error:
From: Numan Siddique
All the ovn-k8s tests in OVN are now failing since a few weeks.
Bumping the ovn-k8s commit to the latest one in my private
CI run passed all the tests except the control plane test [1].
control plane test is failing since a while and this needs to be
debugged.
ovn-k8s repo
From: Numan Siddique
All the ovn-k8s tests in OVN are now failing since a few weeks.
Bumping the ovn-k8s commit to the latest one in my private
CI run passed all the tests except the control plane test [1].
control plane test is failing since a while and this needs to be
debugged.
ovn-k8s repo
On Mon, Aug 16, 2021 at 10:09:28PM +0200, Ilya Maximets wrote:
> There is still a couple of bug fixes that I want to apply before
> tagging v2.16.0, which are fixes for PACKET_OUT crash in userspace
> datapath:
>
>
Signed-off-by: Vladislav Odintsov
---
tests/ovn-ic.at | 4 +
tests/ovn-nbctl.at| 165 +-
utilities/ovn-nbctl.c | 124 +--
3 files changed, 284 insertions(+), 9 deletions(-)
diff --git a/tests/ovn-ic.at
This patch extends Logical Router's routing functionality.
Now user may create multiple routing tables within a Logical Router
and assign them to Logical Router Ports.
Traffic coming from Logical Router Port with assigned route_table
is checked against global routes if any
Some tests which check logical flows were checking exact match for
output. E.g.:
table=12(lr_in_ip_routing ) ...
This makes harder to add new tables in LR pipeline since in this
case one have to update test, which are not relevant for the change.
Replace all table=NN invocations with table=??
This patch series extends Logical Router's routing functionality.
Now user may create multiple routing tables within a Logical Router
and assign them to Logical Router Ports.
Traffic coming from Logical Router Port with assigned route_table
is checked against global routes if any
On Mon, Aug 16, 2021 at 4:10 PM Ilya Maximets wrote:
>
> There is still a couple of bug fixes that I want to apply before
> tagging v2.16.0, which are fixes for PACKET_OUT crash in userspace
> datapath:
>
>
On Tue, Aug 10, 2021 at 12:16 PM Vladislav Odintsov wrote:
>
> XXREG0 and XXREG1 (128-bit registers), are currently used in
> router pipeline to store NEXT_HOP_IPV6 and SRC_IPV6 respectively.
>
> First time XXREG0 register is written - in stage lr_in_defrag.
> XXREG1 register is written first in
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 559a51ba3..f2497d5ce 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v2.16.1 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 2 +-
debian/changelog | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 1064c4dfc..559a51ba3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-v2.16.0 - xx xxx
+v2.16.0 - 16 Aug 2021
There is still a couple of bug fixes that I want to apply before
tagging v2.16.0, which are fixes for PACKET_OUT crash in userspace
datapath:
https://patchwork.ozlabs.org/project/openvswitch/patch/20210816051007.16373-1-tony.vanderp...@alliedtelesis.co.nz/
and the fix for setting conntrack zone
On 8/11/21 5:43 PM, Paolo Valerio wrote:
> in case nl_msg_nlmsgerr returns true which basically means that the
> nlmsg_type == NLMSG_ERROR, we need to log the error code, besides the
> descriptive representation, stored by nl_msg_nlmsgerr instead of
> "error".
>
> Fixes: 72d32ac0b3a1
On 8/11/21 8:31 PM, Marcelo Ricardo Leitner wrote:
> On Wed, Aug 11, 2021 at 01:39:41PM +0200, Ilya Maximets wrote:
>> On 8/9/21 9:26 AM, Roi Dayan via dev wrote:
>>> From: Vlad Buslov
>>>
>>> The commit that enabled 'no_percpu' flag for compatible actions missed the
>>> tunnel_key release action
On 8/14/21 7:30 AM, Sriharsha Basavapatna via dev wrote:
> On Fri, Aug 13, 2021 at 6:27 PM Gaëtan Rivet wrote:
>
>> On Fri, Aug 13, 2021, at 08:14, Sriharsha Basavapatna via dev wrote:
>>> The 's_tnl' member in flow_patterns and flow_actions should be
>>> to set to DS_EMPTY_INITIALIZER, to be
On 8/13/21 4:39 AM, Sriharsha Basavapatna via dev wrote:
> On Fri, Aug 13, 2021 at 4:07 AM Ilya Maximets wrote:
>>
>> On 8/12/21 8:33 AM, Sriharsha Basavapatna via dev wrote:
>>> In netdev_offload_dpdk_flow_create() when an offload request fails,
>>> dump_flow() is called to log a warning
On 8/12/21 6:17 PM, Aaron Conole wrote:
> we...@ucloud.cn writes:
>
>> From: wenxu
>>
>> The ipf collect original fragment packets and reass a new pkt
>> to do the conntrack logic. After finsh the conntrack things
>> copy the ct meta info to each orignal packet and modify the
>> l4 header in the
Hi,
On Tue, Jul 20, 2021 at 11:41:37AM -0700, Ben Pfaff wrote:
> The OVS review process has greatly slowed over the last few years. This
> is partly because I haven't been able to spend as much time on review,
> since I was once the most productive reviewer. Ilya has been able to
> step up
From: Anton Ivanov
1. Make pool size user defineable.
2. Expose pool destruction.
3. Make pools resizeable at runtime.
Signed-off-by: Anton Ivanov
---
lib/ovn-parallel-hmap.c | 202 ++--
lib/ovn-parallel-hmap.h | 23 -
northd/ovn-northd.c | 58
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#393 FILE: northd/ovn-northd.c:3109:
/* XXX Why
Bleep bloop. Greetings Krzysztof Klimonda, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#103 FILE:
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the
Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
> On 8/16/21 5:17 PM, Stokes, Ian wrote:
> >> On 12/08/2021 16:57, Harry van Haaren wrote:
> >>> This patch fixes a memory leak when the command
> >>> "dpif-netdev/subtable-lookup-prio-set" is run, the pmd_list
> >>> required to iterate the PMD threads was not being freed.
> >>> This issue was
On 8/16/21 5:17 PM, Stokes, Ian wrote:
>> On 12/08/2021 16:57, Harry van Haaren wrote:
>>> This patch fixes a memory leak when the command
>>> "dpif-netdev/subtable-lookup-prio-set" is run, the pmd_list
>>> required to iterate the PMD threads was not being freed.
>>> This issue was identified by a
> On 16/08/2021 09:03, kumar Amber wrote:
> > The commit removes the dead code from the
> > MFEX set command as highlighted by static tool
> > analysis.
> >
> > Fixes: a395b132b7 ("dpif-netdev: Add packet count and core id paramters for
> study")
> > Signed-off-by: kumar Amber
> > ---
> >
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#109 FILE:
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#77 FILE:
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#193 FILE:
A flow may be modified after its initial offload failed. In this case,
according to [1], the modification is handled as a flow add.
For a vport flow "add", the orig_in_port should be provided.
Keep that field in the flow struct, so it can be provided in the flow
modification use case.
[1]
For VLANs, the match of ethernet type should be specified in inner_type
field of the vlan match, and not type field in ethernet match.
Fix it.
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
DPDK 20.11 introduced an ability to specify existance/non-existance of
VLAN tag by [1].
Use this attribute.
[1]: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
Signed-off-by: Eli Britstein
Reviewed-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 16
1
Support IPv6 fragmentation matching.
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 82 ++-
1 file changed, 81 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index ee8e56fe0..d79ad1bea 100644
---
Signed-off-by: Eli Britstein
---
NEWS | 2 ++
lib/netdev-offload-dpdk.c | 5 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/NEWS b/NEWS
index 26920e215..80466c014 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,8 @@ Post-v2.16.0
by default.
Matching on frag types requires range. Add 'last' attribute to patterns.
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 151 --
1 file changed, 81 insertions(+), 70 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
Support IPv4 fragmentation matching.
Signed-off-by: Eli Britstein
---
lib/netdev-offload-dpdk.c | 47 +--
1 file changed, 45 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 769dc48d2..ee8e56fe0 100644
Netdev datapath ignored fragmentation matching so far. [1] introduced
an API for that in dpdk. Use it to apply frag matching.
[1] http://mails.dpdk.org/archives/dev/2020-October/186177.html
Travis:
v1: https://travis-ci.org/github/elibritstein/OVS/builds/752634689
GitHub Actions:
v1:
Hi,
Oops, thanks - it seems I've also goofed up and spammed ML with the same patch
a few times. My bad :(
Thanks,
Krzysztof
On Mon, Aug 16, 2021, at 13:18, Ilya Maximets wrote:
> On 8/16/21 1:01 PM, Krzysztof Klimonda wrote:
> > Hi,
> >
> > I'm trying to send a patch to ovs-dev ML but it's
On 8/13/21 4:52 PM, Suneetha Kalahasthi wrote:
> Modify ci linux build script to use the latest DPDK stable release 20.11.2.
> Modify Documentation to use the latest DPDK stable release 20.11.2.
> Update NEWS file to reflect the latest DPDK stable release 20.11.2.
> FAQ is updated to reflect the
On 8/16/21 1:01 PM, Krzysztof Klimonda wrote:
> Hi,
>
> I'm trying to send a patch to ovs-dev ML but it's not showing up - I get no
> response with error, and I can see it in my mailbox (as git send-email adds
> me to the To: list) and Message-Id is "Message-Id:
>
Hi,
I'm trying to send a patch to ovs-dev ML but it's not showing up - I get no
response with error, and I can see it in my mailbox (as git send-email adds me
to the To: list) and Message-Id is "Message-Id:
<20210816085206.69170-1-kklimo...@syntaxhighlighted.com>". Could someone help
me
On 16/08/2021 09:03, kumar Amber wrote:
> The commit removes the dead code from the
> MFEX set command as highlighted by static tool
> analysis.
>
> Fixes: a395b132b7 ("dpif-netdev: Add packet count and core id paramters for
> study")
> Signed-off-by: kumar Amber
> ---
> lib/dpif-netdev.c | 1
If there are snat entries on the router, and some logical_ip are set to
network instead of an IP address then given SNAT is masquerade. In such
case ct_snat action is used in lr_in_unsnat table to ensure that the
packet is matched against conntrack and destination IP is replaced with
one from
The commit removes the dead code from the
MFEX set command as highlighted by static tool
analysis.
Fixes: a395b132b7 ("dpif-netdev: Add packet count and core id paramters for
study")
Signed-off-by: kumar Amber
---
lib/dpif-netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git
51 matches
Mail list logo
