Re: [ovs-dev] [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support

2021-09-28 Thread Jakub Kicinski
On Tue, 28 Sep 2021 12:47:27 -0700 Toms Atteka wrote: > diff --git a/include/uapi/linux/openvswitch.h > b/include/uapi/linux/openvswitch.h > index a87b44cd5590..dc6eb5f6399f 100644 > --- a/include/uapi/linux/openvswitch.h > +++ b/include/uapi/linux/openvswitch.h > @@ -346,6 +346,13 @@ enum

[ovs-dev] [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support

2021-09-28 Thread Toms Atteka
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and packets can be filtered using ipv6_ext flag. Signed-off-by: Toms Atteka --- include/uapi/linux/openvswitch.h | 12 +++ net/openvswitch/flow.c | 140 +++ net/openvswitch/flow.h | 14

Re: [ovs-dev] [PATCH net-next v5] net: openvswitch: IPv6: Add IPv6 extension header support

2021-09-28 Thread Cpp Code
On Tue, Sep 28, 2021 at 7:51 AM Nicolas Dichtel wrote: > > Le 27/09/2021 à 21:12, Cpp Code a écrit : > > To use this code there is a part of code in the userspace. We want to > > keep compatibility when we only update userspace part code or only > > kernel part code. This means we should have

Re: [ovs-dev] [PATCH ovn] sbctl: add the capability to configure static mac_bindings entries

2021-09-28 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #56 FILE:

[ovs-dev] [PATCH ovn] sbctl: add the capability to configure static mac_bindings entries

2021-09-28 Thread Lorenzo Bianconi
Introduce the two following commands to configure and dump static L2 address bindings: $ovn-sbctl set-mac-binding 192.168.1.100 00:11:22:33:44:55 vif0 $ovn-sbctl list-mac-binding [ 192.168.1.100 00:11:22:33:44:55 S ] https://bugzilla.redhat.com/show_bug.cgi?id=1845111 Signed-off-by: Lorenzo

Re: [ovs-dev] [PATCH] python: replace pyOpenSSL with ssl

2021-09-28 Thread Mark Michelson
Hi Timothy, I can't claim to be a subject matter expert, but the changes make sense on the surface. I can also confirm the OVN testsuite passes with this change. Acked-by: Mark Michelson On 9/10/21 10:34 AM, Timothy Redaelli wrote: Currently, pyOpenSSL is half-deprecated upstream and so

Re: [ovs-dev] [PATCH v3 0/6] MFEX Optimizations IPv6 + Hashing

2021-09-28 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, September 21, 2021 1:45 PM > To: Amber, Kumar ; ovs-dev@openvswitch.org > Cc: ktray...@redhat.com; i.maxim...@ovn.org; Stokes, Ian > ; f...@sysclose.org; echau...@redhat.com; Van Haaren, > Harry > Subject: Re: [PATCH v3 0/6]

[ovs-dev] [PATCH ovn v6 10/12] lib: Add infrastructure for plug providers.

2021-09-28 Thread Frode Nordahl
New lib/plug-provider module contains the infrastructure for registering plug provider classes which may be hosted inside or outside the core OVN repository. New controller/plug module adds internal interface for interacting with the plug providers. Extend build system to allow enabling building

[ovs-dev] [PATCH ovn v6 11/12] ovn-controller: Prepare plug provider infrastructure.

2021-09-28 Thread Frode Nordahl
Add port by interfaces index - To be able to effectively remove ports previously plugged by us we need to look up ports by interface records. Add `enable-dummy-plug` option - To enable testing of the plugging infrastructure without building OVN with an external plugging library we include a dummy

[ovs-dev] [PATCH ovn v6 12/12] controller: Consider plugging of ports on CMS request.

2021-09-28 Thread Frode Nordahl
When OVN is linked with an appropriate plugging implementation, CMS can request OVN to plug individual lports into the local Open vSwitch instance. The port and instance record will be maintained during the lifetime of the lport and it will be removed on release of lport. Signed-off-by: Frode

[ovs-dev] [PATCH ovn v6 00/12] Introduce infrastructure for plug providers

2021-09-28 Thread Frode Nordahl
Introduce infrastructure for plug providers and add feature to ovn-controller to add and remove ports on the integration bridge as directed by CMS through Logical_Switch_Port options. Traditionally it has been the CMSs responsibility to create Virtual Interfaces (VIFs) as part of instance

[ovs-dev] [PATCH ovn v6 09/12] tests: Use built objects for unit test deps

2021-09-28 Thread Frode Nordahl
Currently the tests/automake.mk adds source files from the project as needed and rebuilds these for the unit test programs. Use the already built objects instead. Signed-off-by: Frode Nordahl --- tests/automake.mk | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH ovn v6 08/12] ovn-controller: Move shared functions to ovn-util

2021-09-28 Thread Frode Nordahl
The `get_tunnel_type` (and associated enum) and `get_bridge` functions are used in modules other than the `ovn-controller` module. Since the `ovn-controller` module also has the `main` function this organization makes it hard or impossible to unit test. Signed-off-by: Frode Nordahl ---

[ovs-dev] [PATCH ovn v6 07/12] binding: Make local_binding data structure public

2021-09-28 Thread Frode Nordahl
The binding module maintains a shash of lports bound to the local chassis. Other modules have interest in the same data for lookup, and it would be wasteful to reimplement the same data structure elsewhere. The incremental processing engine already makes sharing of the data between nodes safe

[ovs-dev] [PATCH ovn v6 06/12] binding: Move can_bind helper to lport module

2021-09-28 Thread Frode Nordahl
The `can_bind_on_this_chassis` helper is useful outside of the binding module. Since it is related to lports renaming it to `lport_can_bind_on_this_chassis` and putting it into the lport module appears to be appropriate. Signed-off-by: Frode Nordahl --- controller/binding.c | 17

[ovs-dev] [PATCH ovn v6 05/12] patch: Consume ovsport functions.

2021-09-28 Thread Frode Nordahl
Make use of the common functions for maintaining OVS ports. Signed-off-by: Frode Nordahl --- controller/patch.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/controller/patch.c b/controller/patch.c index a661025da..0d0d53894 100644

[ovs-dev] [PATCH ovn v6 04/12] controller: Move OVS port functions to new module.

2021-09-28 Thread Frode Nordahl
Up until now the controller patch module has been the only consumer of functions to maintain OVS ports and interfaces. With the introduction of infrastructure for plugging providers these functions will also be consumed by the controller binding module. As such we introduce a new module called

[ovs-dev] [PATCH ovn v6 01/12] ovn-sb: Add requested_chassis column to Port_Binding.

2021-09-28 Thread Frode Nordahl
To allow for ovn-controller to efficiently monitor all Port_Binding records destined to it, we add a new requested_chassis column with weakRef to the Chassis table. The ovn-controller can monitor this column and only process records for its chassis UUID before having claimed the port. northd

[ovs-dev] [PATCH ovn v6 03/12] controller: Make use of Port_Binding:requested_chassis

2021-09-28 Thread Frode Nordahl
Improve the efficiency of the requested-chassis feature by using the new Southbound Port_Binding:requested_chassis column instead of each chassis performing string comparison for every Port_Binding record processed. Signed-off-by: Frode Nordahl --- controller/binding.c| 36

[ovs-dev] [PATCH ovn v6 02/12] test: Fix options:requested-chassis with hostname

2021-09-28 Thread Frode Nordahl
This test currently passes, but is broken in two ways. 1) The `fetch_column` helper should be used to retrieve the value of hostname, not `fetch` wich results in a "fetch: command not found" error which is currently not caught by the test. As a consequence the requested-chassis option

Re: [ovs-dev] [PATCH ovn] ovs: Include ovsdb-data optimizations.

2021-09-28 Thread Numan Siddique
On Mon, Sep 27, 2021 at 8:40 AM Dumitru Ceara wrote: > > Recent OVS commits have been optimizing the ovsdb-data module, with > immediate goal of optimizing ovsdb-server operations. However, some of > the ovsdb-data functions are also used on the client side (e.g., > db-ctl-base.c, ovsdb-idl.c).

Re: [ovs-dev] [PATCH net-next v5] net: openvswitch: IPv6: Add IPv6 extension header support

2021-09-28 Thread Nicolas Dichtel
Le 27/09/2021 à 21:12, Cpp Code a écrit : > To use this code there is a part of code in the userspace. We want to > keep compatibility when we only update userspace part code or only > kernel part code. This means we should have same values for constants > and we can only add new ones at the end

Re: [ovs-dev] [PATCH v5] Encap & Decap actions for MPLS packet type.

2021-09-28 Thread Martin Varghese
On Fri, Sep 24, 2021 at 02:30:16PM +0200, Eelco Chaudron wrote: > Hi Martin, > > See my comments below... > > Cheers, > > Eelco > > On 30 Aug 2021, at 14:40, Martin Varghese wrote: > > > From: Martin Varghese > > > > The encap & decap actions are extended to support MPLS packet type. > >

Re: [ovs-dev] [PATCH ovn v5 10/12] lib: Add infrastructure for plug providers.

2021-09-28 Thread 0-day Robot
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: sphinx-build -b html -W -n -d ./Documentation/_build/doctrees ./Documentation

[ovs-dev] [PATCH ovn v5 10/12] lib: Add infrastructure for plug providers.

2021-09-28 Thread Frode Nordahl
New lib/plug-provider module contains the infrastructure for registering plug provider classes which may be hosted inside or outside the core OVN repository. New controller/plug module adds internal interface for interacting with the plug providers. Extend build system to allow enabling building

[ovs-dev] [PATCH ovn v5 00/12] Introduce infrastructure for plug providers

2021-09-28 Thread Frode Nordahl
Introduce infrastructure for plug providers and add feature to ovn-controller to add and remove ports on the integration bridge as directed by CMS through Logical_Switch_Port options. Traditionally it has been the CMSs responsibility to create Virtual Interfaces (VIFs) as part of instance

[ovs-dev] [PATCH ovn v5 12/12] controller: Consider plugging of ports on CMS request.

2021-09-28 Thread Frode Nordahl
When OVN is linked with an appropriate plugging implementation, CMS can request OVN to plug individual lports into the local Open vSwitch instance. The port and instance record will be maintained during the lifetime of the lport and it will be removed on release of lport. Signed-off-by: Frode

[ovs-dev] [PATCH ovn v5 09/12] tests: Use built objects for unit test deps

2021-09-28 Thread Frode Nordahl
Currently the tests/automake.mk adds source files from the project as needed and rebuilds these for the unit test programs. Use the already built objects instead. Signed-off-by: Frode Nordahl --- tests/automake.mk | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH ovn v5 07/12] binding: Make local_binding data structure public

2021-09-28 Thread Frode Nordahl
The binding module maintains a shash of lports bound to the local chassis. Other modules have interest in the same data for lookup, and it would be wasteful to reimplement the same data structure elsewhere. The incremental processing engine already makes sharing of the data between nodes safe

[ovs-dev] [PATCH ovn v5 11/12] ovn-controller: Prepare plug provider infrastructure.

2021-09-28 Thread Frode Nordahl
Add port by interfaces index - To be able to effectively remove ports previously plugged by us we need to look up ports by interface records. Add `enable-dummy-plug` option - To enable testing of the plugging infrastructure without building OVN with an external plugging library we include a dummy

[ovs-dev] [PATCH ovn v5 08/12] ovn-controller: Move shared functions to ovn-util

2021-09-28 Thread Frode Nordahl
The `get_tunnel_type` (and associated enum) and `get_bridge` functions are used in modules other than the `ovn-controller` module. Since the `ovn-controller` module also has the `main` function this organization makes it hard or impossible to unit test. Signed-off-by: Frode Nordahl ---

[ovs-dev] [PATCH ovn v5 05/12] patch: Consume ovsport functions.

2021-09-28 Thread Frode Nordahl
Make use of the common functions for maintaining OVS ports. Signed-off-by: Frode Nordahl --- controller/patch.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/controller/patch.c b/controller/patch.c index a661025da..0d0d53894 100644

[ovs-dev] [PATCH ovn v5 04/12] controller: Move OVS port functions to new module.

2021-09-28 Thread Frode Nordahl
Up until now the controller patch module has been the only consumer of functions to maintain OVS ports and interfaces. With the introduction of infrastructure for plugging providers these functions will also be consumed by the controller binding module. As such we introduce a new module called

[ovs-dev] [PATCH ovn v5 06/12] binding: Move can_bind helper to lport module

2021-09-28 Thread Frode Nordahl
The `can_bind_on_this_chassis` helper is useful outside of the binding module. Since it is related to lports renaming it to `lport_can_bind_on_this_chassis` and putting it into the lport module appears to be appropriate. Signed-off-by: Frode Nordahl --- controller/binding.c | 17

[ovs-dev] [PATCH ovn v5 03/12] controller: Make use of Port_Binding:requested_chassis

2021-09-28 Thread Frode Nordahl
Improve the efficiency of the requested-chassis feature by using the new Southbound Port_Binding:requested_chassis column instead of each chassis performing string comparison for every Port_Binding record processed. Signed-off-by: Frode Nordahl --- controller/binding.c| 36

[ovs-dev] [PATCH ovn v5 01/12] ovn-sb: Add requested_chassis column to Port_Binding.

2021-09-28 Thread Frode Nordahl
To allow for ovn-controller to efficiently monitor all Port_Binding records destined to it, we add a new requested_chassis column with weakRef to the Chassis table. The ovn-controller can monitor this column and only process records for its chassis UUID before having claimed the port. northd

[ovs-dev] [PATCH ovn v5 02/12] test: Fix options:requested-chassis with hostname

2021-09-28 Thread Frode Nordahl
This test currently passes, but is broken in two ways. 1) The `fetch_column` helper should be used to retrieve the value of hostname, not `fetch` wich results in a "fetch: command not found" error which is currently not caught by the test. As a consequence the requested-chassis option

Re: [ovs-dev] Unit Test Failure Report to OVS ML

2021-09-28 Thread Ilya Maximets
On 9/28/21 13:30, Amber, Kumar wrote: > Hi llya, > > The test-case fails with the following build command on the master branch. > > Pass: > ./configure --with-dpdk=static CFLAGS="" > Fails: > ./configure --with-dpdk=static CFLAGS="-msse4.2" > > Testing on ovs-master branch, running test case

Re: [ovs-dev] Unit Test Failure Report to OVS ML

2021-09-28 Thread Amber, Kumar
Hi llya, The test-case fails with the following build command on the master branch. Pass: ./configure --with-dpdk=static CFLAGS="" Fails: ./configure --with-dpdk=static CFLAGS="-msse4.2" Testing on ovs-master branch, running test case like this $ make check TESTSUITEFLAGS="779" Based on the

Re: [ovs-dev] [NOTICE] "0-day robot" CI system outage

2021-09-28 Thread David Marchand
Hi, On Mon, Sep 27, 2021 at 5:18 PM Aaron Conole wrote: > > Greetings all, > > Around September 20th, the hardware running the "0-day Robot" that > provides CI testing for some upstream projects suffered a catastrophic > failure. This required a lot of internal scrambling to get replacement >

Re: [ovs-dev] [PATCH] system-offloads-traffic.at: Add sFlow offload test cases

2021-09-28 Thread Chris Mi via dev
Hi Simon, On 9/24/2021 3:03 PM, Simon Horman wrote: On Thu, Sep 16, 2021 at 11:38:52AM +0300, Chris Mi wrote: Add two sFlow offload test caes: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled ok 4: sflow offloads with sampling=2 - ping between two ports -