Re: [ovs-dev] [PATCH ovn] tests: fix flaky VXLAN check port/datapath key space limits test

2021-11-23 Thread Odintsov Vladislav
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-November/389256.html Regards, Vladislav Odintsov On 23 Nov 2021, at 20:37, Vladislav Odintsov mailto:odiv...@gmail.com>> wrote: OVN requested-tnl-key VXLAN checks affect tunnel_key in datapath_binding record only on datapath

[ovs-dev] [PATCH ovn] northd: I-P: fix BFD dependency.

2021-11-23 Thread Dumitru Ceara
BFD entries are updated and their ->ref field is set to 'true' when static routes are parsed, within build_lflows(), in the 'en_lflow' I-P node. Therefore we cannot clean up BFD entries in 'en_northd' which is an input of 'en_lflow'. To fix this we now move all BFD handling in the 'en_lflow'

Re: [ovs-dev] [PATCH] netlink-socket: Check for null sock in nl_sock_recv__()

2021-11-23 Thread Murilo Opsfelder Araújo
Hi, Flavio. On 11/23/21 15:32, Flavio Leitner wrote: On Mon, Nov 22, 2021 at 03:46:28PM -0300, Murilo Opsfelder Araújo wrote: Hi, Ilya Maximets. On 11/19/21 13:23, Ilya Maximets wrote: On 11/18/21 22:19, David Christensen wrote: On 11/18/21 11:56 AM, Murilo Opsfelder Araújo wrote: On

[ovs-dev] [PATCH ovn] lflow-cache: Automatically trim cache when it becomes inactive.

2021-11-23 Thread Dumitru Ceara
By default perform memory trimming 30 seconds after the lflow cache utilization has dropped. Otherwise, idle ovn-controller processes might wastefully fail to return unused memory to the system. The timeout is configurable through the 'ovn-trim-timeout-ms' external_id. Reported-at:

Re: [ovs-dev] [PATCH] netlink-socket: Check for null sock in nl_sock_recv__()

2021-11-23 Thread Flavio Leitner
On Mon, Nov 22, 2021 at 03:46:28PM -0300, Murilo Opsfelder Araújo wrote: > Hi, Ilya Maximets. > > On 11/19/21 13:23, Ilya Maximets wrote: > > On 11/18/21 22:19, David Christensen wrote: > > > > > > > > > On 11/18/21 11:56 AM, Murilo Opsfelder Araújo wrote: > > > > On 11/16/21 19:31, Ilya

Re: [ovs-dev] [PATCH] TCP Stream: Use TCP keepalive by default

2021-11-23 Thread Flavio Leitner
On Tue, Nov 16, 2021 at 09:54:54PM +0100, Ilya Maximets wrote: > On 10/25/21 16:36, Michael Santana wrote: > > In the case that a client disables jsonrpc probes the client would fail > > to detect if the connection to the server has dropped. To workaround > > such case TCP keepalive is enabled. >

[ovs-dev] [PATCH ovn] tests: fix flaky VXLAN check port/datapath key space limits test

2021-11-23 Thread Vladislav Odintsov
OVN requested-tnl-key VXLAN checks affect tunnel_key in datapath_binding record only on datapath tunnel key assigning. If a dp tnl key was already assigned and VXLAN-enabled chassis is added after that, the value would never be changed. The test didn't check the VXLAN-enabled chassis was created

Re: [ovs-dev] [PATCH ovn 2/2] tests: fix flaky VXLAN check port/datapath key space limits test

2021-11-23 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless

Re: [ovs-dev] [PATCH v2] Backup and remove existing DB when joining cluster

2021-11-23 Thread Flaviof
LGTM! Acked-by: Flavio Fernandes On Fri, Nov 5, 2021 at 2:24 PM Terry Wilson wrote: > ovsdb-tool join-cluster requires a remote addr, so the existing > code that tried to join a cluster without it when there was an > existing $DB_FILE would fail. > > Instead, if we are trying to specifically

[ovs-dev] [PATCH ovn 2/2] tests: fix flaky VXLAN check port/datapath key space limits test

2021-11-23 Thread Vladislav Odintsov
OVN requested-tnl-key VXLAN checks affect tunnel_key in datapath_binding record only on datapath tunnel key assigning. If a dp tnl key was already assigned and VXLAN-enabled chassis is added after that, the value would never be changed. The test didn't check the VXLAN-enabled chassis was created

[ovs-dev] [PATCH ovn 1/2] northd: allow having VXLAN encaps in ovn-ic enabled setup

2021-11-23 Thread Vladislav Odintsov
In ovn-ic enabled setups, which also use VXLAN encapsulation (for instance, for VTEP-switches) interconnected transit switches (datapaths) were not configured after the patch from "Fixes" tag. This was due to the fact that ovn-ic utilises tunnel key for transit switches > OVN_VXLAN_MIN_MULTICAST.

[ovs-dev] [PATCH] packets: fix l4 pseudo csum incremental update

2021-11-23 Thread Jun Xiao
When a packet requests l4 csum offload, the l4 csum field includes a pseudo csum instead of a full csum. The pseudo csum doesn't do the final one's complement, and it must be updated differently than a full csum. Signed-off-by: Jun Xiao --- lib/packets.c | 12 1 file changed, 12

[ovs-dev] [PATCH] packets: fix l4 pseudo csum incremental update

2021-11-23 Thread Jun Xiao
When a packet requests l4 csum offload, the l4 csum field includes a pseudo csum instead of a full csum. The pseudo csum doesn't do the final one's complement, and it must be updated differently than a full csum. Signed-off-by: Jun Xiao --- lib/packets.c | 12 1 file changed, 12

Re: [ovs-dev] [PATCH v2] python: idl: Avoid pre-allocating column defaults

2021-11-23 Thread Flavio Fernandes
LGTM! Acked-by: Flavio Fernandes > -- Forwarded message - > From: Terry Wilson mailto:twil...@redhat.com>> > Date: Fri, Nov 5, 2021 at 10:14 AM > Subject: [ovs-dev] [PATCH v2] python: idl: Avoid pre-allocating column > defaults > To: mailto:d...@openvswitch.org>> > > >

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: Expose per rxq/txq basic statistics.

2021-11-23 Thread Kevin Traynor
On 23/11/2021 15:13, David Marchand wrote: On Thu, Nov 18, 2021 at 4:31 PM Kevin Traynor wrote: @@ -1583,6 +1584,13 @@ netdev_dpdk_get_xstat_name(struct netdev_dpdk *dev, uint64_t id) return dev->rte_xstats_names[id].name; } +/* We filter out everything except per rxq/txq basic

Re: [ovs-dev] [RFC PATCH] netdev-dpdk: Expose per rxq/txq basic statistics.

2021-11-23 Thread David Marchand
On Thu, Nov 18, 2021 at 4:31 PM Kevin Traynor wrote: > > @@ -1583,6 +1584,13 @@ netdev_dpdk_get_xstat_name(struct netdev_dpdk *dev, > > uint64_t id) > > return dev->rte_xstats_names[id].name; > > } > > > > +/* We filter out everything except per rxq/txq basic stats, and dropped, > > + *

[ovs-dev] [PATCH v2] dpif-netdev: Call cpuid for x86 isa availability.

2021-11-23 Thread David Marchand
DPIF AVX512 optimisations currently rely on DPDK availability while they can be used without DPDK. Besides, checking for availability of some isa only has to be done once and won't change while a OVS process runs. Resolve isa availability in constructors by using a simplified query based on cpuid

[ovs-dev] [PATCH ovn] controller: Add IDL memory reports.

2021-11-23 Thread Dumitru Ceara
OVS commit 066741d9c5ca ("ovsdb-idl: Add memory report function.") enhanced the IDL to track memory usage. Use it in ovn-controller for the Southbound DB and local OVS DB IDLs. Signed-off-by: Dumitru Ceara --- controller/ovn-controller.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[ovs-dev] [PATCH v2 3/3] system-dpdk: Test with mlx5 devices.

2021-11-23 Thread David Marchand
The DPDK unit test only runs if vfio or igb_uio kernel module is loaded: on systems with only mlx5, this test is always skipped. Besides, the test tries to grab the first device listed by dpdk-devbind.py, regardless of the PCI device status regarding kmod binding. Remove dependency on this DPDK

[ovs-dev] [PATCH v2 2/3] system-dpdk: Use dummy-pmd port for packet injection.

2021-11-23 Thread David Marchand
net_pcap is not always available in DPDK (like, in a dev environment when you forgot to install the libpcap-devel). On the other hand, OVS already has its own way to inject packets into a bridge. Let's make use of it. This solution is slower than net/pcap DPDK, so lower the number of expected

[ovs-dev] [PATCH v2 1/3] system-dpdk: Refactor common logs matching.

2021-11-23 Thread David Marchand
Move EAL logs and commonly ignored logs to a common macro. Remove obsolete ones (like i40e [1] and timer [2] logs). Extend regex on hugepage logs since a check on hugepages availability is already present on OVS side, and as a consequence, we don't care about the warnings on availability for

Re: [ovs-dev] [PATCH 2/2] system-dpdk: Use dummy-pmd port for packet injection.

2021-11-23 Thread David Marchand
On Tue, Nov 23, 2021 at 2:16 PM David Marchand wrote: > Did you have a chance to look at my patch? > > Now that I tested it with sse4.2 enabled, I can see the "fuzzy" test > fails because of a timeout: the test expects 100k packet in 30s. > I wonder why 100k random data is better than 1k like for

[ovs-dev] [PATCH 2/2] alb.at: Increase time/warp.

2021-11-23 Thread Kevin Traynor
It seems that on slow system with high concurrency and cpu contention time/warp is not accurate enough for the ALB unit tests with the minimum time/warp that was used to hit an amount of events. This results in some intermittent test failures. As those tests are just waiting for a certain amount

[ovs-dev] [PATCH 1/2] alb.at: Check for log from correct line number.

2021-11-23 Thread Kevin Traynor
The next log line number should be updated to ensure that the anticipated log has occurred again after more time has passed. Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.") Signed-off-by: Kevin Traynor --- tests/alb.at | 1 + 1 file changed, 1 insertion(+) diff

Re: [ovs-dev] [PATCH 2/2] system-dpdk: Use dummy-pmd port for packet injection.

2021-11-23 Thread David Marchand
Hello Ilya, On Fri, Nov 19, 2021 at 4:45 PM Ilya Maximets wrote: > > On 11/18/21 10:16, Maxime Coquelin wrote: > > Hi David, > > > > On 9/27/21 15:57, David Marchand wrote: > >> net_pcap is not always available in DPDK (like, in a dev > >> environment when you forgot to install the

Re: [ovs-dev] [PATCH ovn v9 0/6] Add multiple routing tables support to Logical Routers

2021-11-23 Thread Odintsov Vladislav
Thanks Numan! regards, Vladislav Odintsov > On 23 Nov 2021, at 00:35, Numan Siddique wrote: > > On Fri, Nov 19, 2021 at 11:07 AM Vladislav Odintsov > wrote: >> >> v8 -> v9: >> - Fix documentation errors. >> - Fix commit messages. >> >> v7 -> v8: >> - Updated manpages with and commit

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion due to removal of large number of flows.

2021-11-23 Thread Vladislav Odintsov
Thanks for the patch! Tested-by: Vladislav Odintsov Regards, Vladislav Odintsov > On 22 Nov 2021, at 18:23, Ilya Maximets wrote: > > While removing flows, removal itself is deferred, so classifier changes > performed already from the RCU thread. This way every deferred removal > triggers

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-23 Thread Vladislav Odintsov
I’ve re-checked and it really stopped growing after a couple of iterations. Thanks again for the patches. Regards, Vladislav Odintsov > On 23 Nov 2021, at 02:03, Ilya Maximets wrote: > > On 11/22/21 20:54, Vladislav Odintsov wrote: >> Hi Ilya, >> >> I’ve tested both patches, the problem with

[ovs-dev] [PATCH branch-2.13,v3] dpdk: Use DPDK 19.11.10 release

2021-11-23 Thread Suneetha Kalahasthi
Modify ci linux build script to use the latest DPDK stable release 19.11.10. Modify Documentation to use the latest DPDK stable release 19.11.10. Update NEWS file to reflect the latest DPDK stable release 19.11.10. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by:

[ovs-dev] [PATCH branch-2.14,v3] dpdk: Use DPDK 19.11.10 release

2021-11-23 Thread Suneetha Kalahasthi
Modify ci linux build script to use the latest DPDK stable release 19.11.10. Modify Documentation to use the latest DPDK stable release 19.11.10. Update NEWS file to reflect the latest DPDK stable release 19.11.10. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2] northd: Generate ARP responder flows only for reachable VIPs.

2021-11-23 Thread Dumitru Ceara
On 11/23/21 3:07 AM, Numan Siddique wrote: > On Mon, Nov 22, 2021 at 11:03 AM Mark Michelson wrote: >> >> Acked-by: Mark Michelson > Thanks, Mark! > > Thanks Dumitru and Mark. > > I applied this patch to the main branch with the below changes as the > patch needed some > updates in the