Re: [ovs-dev] broadcast and multicast dest MAC address corruption after MPLS decapsulation

2022-01-09 Thread Martin Varghese
HI Rohit, Were you able to test the patch on the latest code ? Were you able to try with the commit "e81ed94214d76005d83fcc24a8f83a896645a739 Fix redundant datapath set ethernet action with NSH Decap" on 2.13. Please let me know if you have any findings Regards, Martin On Sun, Dec 26, 2021 at

[ovs-dev] [PATCH] relay:probe interval of relay server

2022-01-09 Thread Wentao Jia
probe interval of relay server can be configured from "sb_global/nb_global options:relay_probe_interval" minimum and default value is 5s Signed-off-by: Wentao Jia --- ovsdb/relay.c | 74 +++ 1 file changed, 74 insertions(+) diff --git

Re: [ovs-dev] [PATCH net v2 1/1] net: openvswitch: Fix ct_state nat flags for conns arriving from tc

2022-01-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 6 Jan 2022 17:38:04 +0200 you wrote: > Netfilter conntrack maintains NAT flags per connection indicating > whether NAT was configured for the connection. Openvswitch maintains > NAT flags on the per packet flow

[ovs-dev] [PATCH v1 2/2] ofproto-dpif: avoid unneccesary backer revalidation

2022-01-09 Thread lic121
If lldp didn't change, we are not supposed to trigger backer revalidation. Signed-off-by: lic121 --- ofproto/ofproto-dpif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 1cdef18..1bc9ec7 100644 ---

[ovs-dev] [PATCH v1 1/2] ofproto-dpif: trigger revalidation when ipfix changes

2022-01-09 Thread lic121
Currently, ipfix creation/delection don't trigger dpif backer revalidation. This is not expected, as we need the revalidation to commit ipfix into xlate. So that xlate can generate ipfix actions. Signed-off-by: lic121 --- ofproto/ofproto-dpif.c | 5 + 1 file changed, 5 insertions(+) diff

[ovs-dev] [PATCH v1 0/2] fix dpif backer revalidation

2022-01-09 Thread lic121
ovsdb change or netlink notification trigger bridge_reconfigure. In bridge_reconfigure, backer->need_revalidate flag is set if backer revalidation is needed. This series fix two places where need_revalidate flag is not set correctly. lic121 (2): ofproto-dpif: trigger revalidation when ipfix

Re: [ovs-dev] [ovs-dev v7 3/3] ipf: ipf_preprocess_conntrack should also consider ipf_ctx

2022-01-09 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not

Re: [ovs-dev] [ovs-dev v7 2/3] ipf: micro-optimize ipf_ctx_eq

2022-01-09 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not

Re: [ovs-dev] [ovs-dev v7 1/3] ipf: add ipf context

2022-01-09 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. ERROR: Co-author Mike Pattrick needs to sign off.

[ovs-dev] [ovs-dev v7 3/3] ipf: ipf_preprocess_conntrack should also consider ipf_ctx

2022-01-09 Thread Peng He
considering a multi-thread PMD setting, when the frags are reassembled in one PMD, another thread might call *ipf_execute_reass_pkts* and 'steal' the reassembled packets into its ipf ctx, then this reassembled packet will enter into another ipf context and causes errors. This happends when there

[ovs-dev] [ovs-dev v7 2/3] ipf: micro-optimize ipf_ctx_eq

2022-01-09 Thread Peng He
by using ipf_list's key instead of first frags' metadata can reduce quite a lot of cache access as by the time calling ipf_ctx_eq, ipf_list is cache-hot. Signed-off-by: Peng He --- lib/ipf.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/ipf.c

[ovs-dev] [ovs-dev v7 1/3] ipf: add ipf context

2022-01-09 Thread Peng He
From: Peng He ipf_postprocess will emit packets into the datapath pipeline ignoring the conntrack context, this might casuse weird issues when a packet batch has less space to hold all the fragments belonging to single packet. Given the below ruleest and consider sending a 64K ICMP packet which

Re: [ovs-dev] [ovs-dev v6 3/3] ipf: ipf_preprocess_conntrack should also consider ipf_ctx

2022-01-09 Thread 贺鹏
Hi, after I applied this patch, all the failed tests now passed. diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index cba49a99e..a7df7db6f 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -4972,6 +4972,7 @@ packet_execute_prepare(struct ofproto *ofproto_,

[ovs-dev] [PATCH v4] acinclude: Provide better error info when linking fails with DPDK.

2022-01-09 Thread Sunil Pai G
Currently, on failure to link with DPDK, the configure script provides an error message to update the PKG_CONFIG_PATH even though the cause of failure was missing dependencies. Improve the error message to include this scenario. Signed-off-by: Sunil Pai G --- v3-> v4: Address comments. v2-> v3: