Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't log transaction failures on standby instances.

2022-02-10 Thread Numan Siddique
On Thu, Jan 27, 2022 at 10:00 AM Dumitru Ceara wrote: > > We still need to try to ovsdb_idl_loop_commit_and_wait() on instances > that are in standby mode. That's because they need to try to take the > lock. But if they're in standby they won't actually build a transaction > json and will

Re: [ovs-dev] [PATCH ovn] ovs-sandbox: Convert initial databases if needed.

2022-02-10 Thread Numan Siddique
On Fri, Feb 4, 2022 at 2:34 PM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks. Applied to the main branch. Numan > > On 1/26/22 09:17, Dumitru Ceara wrote: > > The --nbdb-source and --sbdb-source options allow users to point the > > sandbox daemons to already existing database

Re: [ovs-dev] [PATCH v3 ovn] controller: reconfigure ovs meters for ovn meters updates

2022-02-10 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #100 FILE: controller/ofctrl.c:1853:

[ovs-dev] [PATCH v3 ovn] controller: reconfigure ovs meters for ovn meters updates

2022-02-10 Thread Lorenzo Bianconi
At the moment ovs meters are reconfigured by ovn just when a new a meter is allocated while updates for an already allocated meter are ignored. This issue can be easily verified with the following reproducer: $ovn-nbctl meter-add meter0 drop 10 pktps $ovn-nbctl --log --meter=meter0 acl-add sw0

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-10 Thread Numan Siddique
On Wed, Feb 2, 2022 at 8:27 PM Mark Michelson wrote: > > It can be desirable for replies to stateful ACLs to be logged. And in > some cases, it can actually be a bit confusing why they aren't logged. > Consider a situation where a port group called "port_group" exists and > logical switch ports

Re: [ovs-dev] [PATCH net 1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure

2022-02-10 Thread Jakub Kicinski
On Thu, 10 Feb 2022 10:53:24 +0200 Paul Blakey wrote: > > The calls seem a little heavy for single byte replacements. > > Can you instead add a helper based on csum_replace4() maybe? > > > > BTW doesn't pedit have the same problem? > > I don't think they are heavier then csum_replace4,

Re: [ovs-dev] [PATCH ovn] Set additional header in DNS message explicitly

2022-02-10 Thread Numan Siddique
On Tue, Feb 8, 2022 at 9:46 AM wrote: > > From: Sven Haardiek > > Some DNS Queries include an optional RR in the additional record section of > DNS, so simply copying the non-zero DNS Header for the additional records, but > not adding any leads to broken DNS packages. > > This patch explicitly

Re: [ovs-dev] [ovs-dev v5] ofproto: add refcount to ofproto to fix ofproto use-after-free

2022-02-10 Thread Gaëtan Rivet
On Sat, Feb 5, 2022, at 06:26, Peng He wrote: > From hepeng: > https://patchwork.ozlabs.org/project/openvswitch/patch/20200717015041.82746-1-hepeng.0...@bytedance.com/#2487473 > > also from guohongzhi : >

Re: [ovs-dev] [ovs-dev v2] tunnel: Remove padding from packet when encapsulating.

2022-02-10 Thread Ilya Maximets
On 2/10/22 02:21, Tonghao Zhang wrote: > On Tue, Jan 25, 2022 at 3:16 PM Harold Huang wrote: >> >> Looks good to me. >> >> Reviewed-by: Harold Huang > Hi Ilya, do you have an opinion? > >> 于2022年1月25日周二 13:25写道: >>> >>> From: Tonghao Zhang >>> >>> The old version of openvswitch doesn't remove

Re: [ovs-dev] Intel AVX-512 CI

2022-02-10 Thread Flavio Leitner
This is great! Congrats to all of you that work to get this up and running. fbl On Tue, Feb 8, 2022 at 5:01 PM Aaron Conole wrote: > Hi Michael, > > "Phelan, Michael" writes: > > > Hi all, > > > > As presented at the OVS conference in December, the AVX-512 CI is coming > online today to test

Re: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy test.

2022-02-10 Thread Ferriter, Cian
> -Original Message- > From: dev On Behalf Of Kumar Amber > Sent: Wednesday 9 February 2022 09:50 > To: ovs-dev@openvswitch.org > Cc: Amber, Kumar ; david.march...@redhat.com > Subject: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy > test. > > Some specific

Re: [ovs-dev] [PATCH net 1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure

2022-02-10 Thread Paul Blakey via dev
On Wed, 9 Feb 2022, Jakub Kicinski wrote: > On Mon, 7 Feb 2022 16:41:01 +0200 Paul Blakey wrote: > > Ipv6 ttl, label and tos fields are modified without first > > pulling/pushing the ipv6 header, which would have updated > > the hw csum (if available). This might cause csum validation > > when