On Mon, Jan 10, 2022 at 5:32 AM Mark Michelson wrote:
>
> On 1/7/22 09:26, Abhiram Sangana wrote:
> > Hi Mark,
> >
> > Thanks for looking into this patch.
> >
> >> On 5 Jan 2022, at 22:01, Mark Michelson wrote:
> >>
> >> Hi,
> >>
> >> I haven't done a full review of this patch, but I have
Hi Cian,
Thanks for the Patch.
I have tested the patch and reviewed as well.
One small minor comment .
> +atomic_store_relaxed(>miniflow_extract_opt,
> +miniflow_funcs[MFEX_IMPL_SCALAR].extract_func);
> VLOG_INFO("Not enough packets matched (%u/%u),
On Mon, Feb 21, 2022 at 10:41 AM Mark Michelson wrote:
>
> Hi Han,
>
> Acked-by: Mark Michelson
>
> I think we should accept this patch as-is, but I think we should make a
> todo item to get rid of test_mode. Having a test_mode makes test runs
> not mean as much since they are not exercising the
Hi Ihar,
I now have read the entire patch series, and I wonder how you would feel
about an alternate approach. Currently, what you've implemented is a
supplement to options:requested-chassis, but what if you went for a
replacement instead?
What if you added a new column (or new "options"
Hi Han,
Acked-by: Mark Michelson
I think we should accept this patch as-is, but I think we should make a
todo item to get rid of test_mode. Having a test_mode makes test runs
not mean as much since they are not exercising the same code that a live
system does.
On 2/11/22 14:05, Han Zhou
On Sun, 20 Feb 2022, Pablo Neira Ayuso wrote:
> Hi Paul,
>
> On Sun, Feb 20, 2022 at 11:32:26AM +0200, Paul Blakey wrote:
> > After cited commit optimizted hw insertion, flow table entries are
> > populated with ifindex information which was intended to only be used
> > for HW offload. This
The same pattern for atomic stores and initialization was used for the
DPIF and MFEX function pointers declared in struct dp_netdev_pmd_thread.
Simplify this pattern for all stores to 'miniflow_extract_opt' and
'netdev_input_func'.
Also replace the first store to 'miniflow_extract_opt' which was
On 21 Feb 2022, at 14:33, Marcelo Leitner wrote:
> On Mon, Feb 21, 2022 at 01:51:37PM +0100, Ilya Maximets wrote:
>> On 2/21/22 13:34, Eelco Chaudron wrote:
>>>
>>>
>>> On 21 Feb 2022, at 12:36, Ilya Maximets wrote:
>>>
On 2/21/22 10:57, Eelco Chaudron wrote:
>
>
> On 17 Feb
The purpose of reconnect_deadline__() function is twofold:
1. Its result is used to tell if the state has to be changed right now
in reconnect_run().
2. Its result also used to determine when the process need to wake up
and call reconnect_run() for a next time, i.e. when the state may
From: Paul Blakey
> Sent: 20 February 2022 13:21
>
> Ipv6 ttl, label and tos fields are modified without first
> pulling/pushing the ipv6 header, which would have updated
> the hw csum (if available). This might cause csum validation
> when sending the packet to the stack, as can be seen in
> the
On Mon, Feb 21, 2022 at 01:51:37PM +0100, Ilya Maximets wrote:
> On 2/21/22 13:34, Eelco Chaudron wrote:
> >
> >
> > On 21 Feb 2022, at 12:36, Ilya Maximets wrote:
> >
> >> On 2/21/22 10:57, Eelco Chaudron wrote:
> >>>
> >>>
> >>> On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
> >>>
> On
On 2/21/22 13:34, Eelco Chaudron wrote:
>
>
> On 21 Feb 2022, at 12:36, Ilya Maximets wrote:
>
>> On 2/21/22 10:57, Eelco Chaudron wrote:
>>>
>>>
>>> On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
>>>
On 1/31/22 11:53, Eelco Chaudron wrote:
> This patch checks for none offloadable
On Mon, Feb 21, 2022 at 01:34:58PM +0100, Eelco Chaudron wrote:
> On 21 Feb 2022, at 12:36, Ilya Maximets wrote:
...
> > And while we're here, I'm not sure why we need to check the +est+new
> > combination in that code either.
>
> Because according to the kernel these two flags are mutually
On 21 Feb 2022, at 13:29, Marcelo Leitner wrote:
> On Mon, Feb 21, 2022 at 12:36:22PM +0100, Ilya Maximets wrote:
>> On 2/21/22 10:57, Eelco Chaudron wrote:
>>>
>>>
>>> On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
>>>
On 1/31/22 11:53, Eelco Chaudron wrote:
> This patch checks for
On 21 Feb 2022, at 12:36, Ilya Maximets wrote:
> On 2/21/22 10:57, Eelco Chaudron wrote:
>>
>>
>> On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
>>
>>> On 1/31/22 11:53, Eelco Chaudron wrote:
This patch checks for none offloadable ct_state match flag combinations.
If they exist tell
On Mon, Feb 21, 2022 at 12:36:22PM +0100, Ilya Maximets wrote:
> On 2/21/22 10:57, Eelco Chaudron wrote:
> >
> >
> > On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
> >
> >> On 1/31/22 11:53, Eelco Chaudron wrote:
> >>> This patch checks for none offloadable ct_state match flag combinations.
> >>>
On 21 Feb 2022, at 12:45, Ilya Maximets wrote:
> On 2/21/22 11:53, Eelco Chaudron wrote:
>>
>>
>> On 17 Feb 2022, at 16:07, Ilya Maximets wrote:
>>
>>> On 2/17/22 13:57, Ilya Maximets wrote:
On 1/31/22 11:34, Eelco Chaudron wrote:
> Verify that the returned ifindex by
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#1108 FILE:
On 2/21/22 11:53, Eelco Chaudron wrote:
>
>
> On 17 Feb 2022, at 16:07, Ilya Maximets wrote:
>
>> On 2/17/22 13:57, Ilya Maximets wrote:
>>> On 1/31/22 11:34, Eelco Chaudron wrote:
Verify that the returned ifindex by netdev_get_ifindex() is valid.
This might not be the case in the
From: Peng He
Currently, when doing NAT, the userspace conntrack will use an extra
conn for the two directions in a flow. However, each conn has actually
the two keys for both orig and rev directions. This patch introduces a
key_node[CT_DIR_MAX] member in the conn which consists of key and a
On 2/21/22 10:57, Eelco Chaudron wrote:
>
>
> On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
>
>> On 1/31/22 11:53, Eelco Chaudron wrote:
>>> This patch checks for none offloadable ct_state match flag combinations.
>>> If they exist tell the user about it once, and ignore the offload.
>>>
>>>
On 17 Feb 2022, at 14:10, Ilya Maximets wrote:
> On 1/31/22 11:54, Eelco Chaudron wrote:
>> Make sure to only update packet and byte counters when valid,
>> or else this could lead to "temporarily/occasionally"
>> out-of-sync flow counters.
>
> There was already the same patch submitted here:
>
On 17 Feb 2022, at 16:07, Ilya Maximets wrote:
> On 2/17/22 13:57, Ilya Maximets wrote:
>> On 1/31/22 11:34, Eelco Chaudron wrote:
>>> Verify that the returned ifindex by netdev_get_ifindex() is valid.
>>> This might not be the case in the ERSPAN port scenario, which can
>>> not be offloaded.
On 2/21/22 11:42, Gaëtan Rivet wrote:
On Mon, Feb 21, 2022, at 08:44, Adrian Moreno wrote:
On 2/18/22 12:18, Gaëtan Rivet wrote:
On Thu, Feb 17, 2022, at 16:40, Adrian Moreno wrote:
On 2/17/22 16:15, Gaëtan Rivet wrote:
On Thu, Feb 17, 2022, at 15:08, wangyunjian wrote:
-Original
On Mon, Feb 21, 2022, at 08:44, Adrian Moreno wrote:
> On 2/18/22 12:18, Gaëtan Rivet wrote:
>> On Thu, Feb 17, 2022, at 16:40, Adrian Moreno wrote:
>>> On 2/17/22 16:15, Gaëtan Rivet wrote:
On Thu, Feb 17, 2022, at 15:08, wangyunjian wrote:
>> -Original Message-
>> From:
On 17 Feb 2022, at 14:00, Ilya Maximets wrote:
> On 1/31/22 11:53, Eelco Chaudron wrote:
>> This patch checks for none offloadable ct_state match flag combinations.
>> If they exist tell the user about it once, and ignore the offload.
>>
>> Signed-off-by: Eelco Chaudron
>> ---
>>
On Sun, 20 Feb 2022, David Laight wrote:
> From: Paul Blakey
> > Sent: 20 February 2022 13:21
> >
> > Ipv6 ttl, label and tos fields are modified without first
> > pulling/pushing the ipv6 header, which would have updated
> > the hw csum (if available). This might cause csum validation
> >
27 matches
Mail list logo
