Thanks for the review Dumitru,
A comment below.
On 2/25/22 13:06, Dumitru Ceara wrote:
On 2/16/22 15:27, Adrian Moreno wrote:
Multi-variable loop iterators avoid potential undefined behavior by
using an internal iterator variable to perform the iteration and only
referencing the containing
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski :
On Sun, 27 Feb 2022 21:22:08 +0800 you wrote:
> Eliminate the following coccicheck warning:
> ./net/openvswitch/flow.c:379:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
>
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#224 FILE:
Hi Dumitru,
This looks good to me. I only have a small nit below.
Acked-by: Mark Michelson
On 2/28/22 16:06, Dumitru Ceara wrote:
Commit 974618c61de8 ("ovn-ic: physical: Support multicast_group flooding
on IC transit switches.") added support for statically forwarding IP
multicast traffic
At the moment ovs meters are reconfigured by ovn just when a
meter is allocated or removed while updates for an already
allocated meter are ignored. This issue can be easily verified
with the following reproducer:
$ovn-nbctl meter-add meter0 drop 10 pktps
$ovn-nbctl --log --meter=meter0 acl-add
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> PMD auto load balance currently only operates when the polling pmd core
> will not change numa after reassignment. Add a unit test for this.
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattrick
> On Fri, Feb 25, 2022 at 12:09 PM Mark Michelson wrote:
> >
> > On 2/25/22 13:44, Han Zhou wrote:
> > > On Fri, Feb 25, 2022 at 9:15 AM Lorenzo Bianconi <
> > > lorenzo.bianc...@redhat.com> wrote:
> > >>
> > >> At the moment ovs meters are reconfigured by ovn just when a
> > >> meter is
On Wed, Mar 2, 2022 at 10:50 AM Adrian Moreno wrote:
>
> Thanks Mike,
>
> On 3/1/22 20:14, Mike Pattrick wrote:
> > Add additional logging for debug and info level with a focus on code
> > related to bond members coming up, go down, and changing.
> >
> > Several existing log messages were
On Wed, Mar 2, 2022 at 11:32 AM Kevin Traynor wrote:
>
> Hi Mike, thanks for reviewing,
>
> On 02/03/2022 15:41, Mike Pattrick wrote:
> > On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
> >>
> >> There are currently some checks for cross-numa polling cases to
> >> ensure that they won't
Hi Mike, thanks for reviewing,
On 02/03/2022 15:41, Mike Pattrick wrote:
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
There are currently some checks for cross-numa polling cases to
ensure that they won't effect the accuracy of the PMD ALB.
If an rxq is pinned to a pmd core by the
Thanks Mike,
On 3/1/22 20:14, Mike Pattrick wrote:
Add additional logging for debug and info level with a focus on code
related to bond members coming up, go down, and changing.
Several existing log messages were modified to handle sub 1kB log
messages with more grace. Instead of reporting 0kB
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> There are currently some checks for cross-numa polling cases to
> ensure that they won't effect the accuracy of the PMD ALB.
>
> If an rxq is pinned to a pmd core by the user it will not be
> reassigned by OVS, so even if it is non-local
On 2/19/22 04:26, Peng He wrote:
From hepeng:
https://patchwork.ozlabs.org/project/openvswitch/patch/20200717015041.82746-1-hepeng.0...@bytedance.com/#2487473
also from guohongzhi :
http://patchwork.ozlabs.org/project/openvswitch/patch/20200306130555.19884-1-guohongz...@huawei.com/
also
> -Original Message-
> From: Ferriter, Cian
> Sent: Wednesday, March 2, 2022 12:18 PM
> To: ovs-dev@openvswitch.org
> Cc: Ferriter, Cian ; Van Haaren, Harry
>
> Subject: [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA.
>
> Only use the "avx512vbmi" compiler target when
On 2 Mar 2022, at 11:50, Roi Dayan wrote:
> On 2022-03-02 12:03 PM, Roi Dayan wrote:
>>
>>
>> On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
>>> Hello:
>>>
>>> This patch was applied to netdev/net-next.git (master)
>>> by David S. Miller :
>>>
>>> On Wed, 23 Feb 2022 16:54:09
Tunnels in LibreSwan and OpenSwan allow for many options to be set on a
per tunnel basis. Pass through any options starting with ipsec_ to the
connection in the configuration file. Administrators are responsible for
picking valid key/value pairs.
Signed-off-by: Andreas Karis
---
> -Original Message-
> From: Ferriter, Cian
> Sent: Wednesday 2 March 2022 12:18
> To: ovs-dev@openvswitch.org
> Cc: Ferriter, Cian ; Van Haaren, Harry
>
> Subject: [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA.
>
> Only use the "avx512vbmi" compiler target when it
Only use the "avx512vbmi" compiler target when it is actually supported
by the compiler.
The order of mfex_impls and the 'dpif_miniflow_extract_impl_idx' enum
have to be changed to keep the start index and size of the impl list
correct in both VBMI and non VBMI cases.
Signed-off-by: Cian
Checking for AVX512VPOPCNTDQ separately will allow the compiler to
generate other AVX512 ISA code where supported. This is relevant for GCC
where AVX512VPOPCNTDQ support is added in GCC 7. In GCC 5 and 6, most
AVX512 code can be generated, just without VPOPCNTDQ support.
Signed-off-by: Cian
Checking for AVX512BW and AVX512DQ separately will allow the compiler to
generate some AVX512 code where it is supported. For example, in GCC 4.9
where there is just support for AVX512F, this patch will allow the
AVX512 DPIF to be built.
This partial support change will be effective when the
There are no instructions from this ISA used. The target is not needed.
Signed-off-by: Cian Ferriter
---
lib/dpif-netdev-extract-avx512.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c
index c1c1fefb6..f36a6eab0 100644
Support for more AVX512 ISA was added in various compiler releases. For
example in GCC, increasing AVX512 ISA support was added in GCC 4.9, 5
and then 7. Depending on the GCC version, none, some or all of the
AVX512 code in OVS can be built. This patchset adds support for the
"some" case, where
---
lib/dpif-netdev-private-extract.c | 8
lib/dpif-netdev-private-extract.h | 10 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/dpif-netdev-private-extract.c
b/lib/dpif-netdev-private-extract.c
index a29bdcfa7..d8e2a55f2 100644
---
Tunnels in LibreSwan and OpenSwan allow for many options to be set on a
per tunnel basis. Pass through any options starting with ipsec_ to the
connection in the configuration file. Administrators are responsible for
picking valid key/value pairs.
Signed-off-by: Andreas Karis
---
A pmd would poll all rxqs with no weight. When a pmd has one rxq
from phy port and several from vhu port, and high loads run for
both rx and tx, then the vhu can get polled more. This will cause
the polling for rx of phy port much less than the vhu port. The
loads for tx/rx
On 2022-03-02 12:03 PM, Roi Dayan wrote:
On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 23 Feb 2022 16:54:09 -0800 you wrote:
This change adds a new OpenFlow field
On 2022-02-25 12:40 PM, patchwork-bot+netdev...@kernel.org wrote:
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller :
On Wed, 23 Feb 2022 16:54:09 -0800 you wrote:
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using
Hi llya,
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, March 1, 2022 1:50 AM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; Phelan, Michael
> Subject: Re: [ovs-dev] [PATCH v1] system-dpdk.at: Add ignore warning for
> context switches in CI.
>
> On
28 matches
Mail list logo
