Re: [ovs-dev] [PATCH RFC v2 0/6] conntrack: Introduce buckets and reduce contention.

2022-03-10 Thread Peng He
Hi, just some thought on the results. the test-conntrack.c now only prepares one batch size of packets for each thread, and repeat running ct on the same batch until the packet number reaches to the parameter of n_pkt, which is, in your case, 16777216 So I guess the optimization results largely

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space

2022-03-10 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 9 Mar 2022 23:20:33 +0100 you wrote: > Few years ago OVS user space made a strange choice in the commit [1] > to define types only valid for the user space inside the copy of a > kernel uAPI header.

Re: [ovs-dev] [PATCH v20 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2022-03-10 Thread Chris Mi via dev
On 2022-03-04 6:59 PM, Eelco Chaudron wrote: We are waiting on Ilya’s feedback on this, which he told us he will look at after the v2.17 release.

Re: [ovs-dev] [PATCH v20 5/8] dpif-offload-netlink: Implement dpif-offload-provider API

2022-03-10 Thread Chris Mi via dev
On 2022-03-04 6:50 PM, Eelco Chaudron wrote: I’m re-adding some of my v18 comments, which I know are depending on Ilya’s feedback, although I still think we should have provider classes, i.e., not based on the datapath class. Some other questions could still be answered regardless of Ilya’s

[ovs-dev] [PATCH] ovsdb: raft: Fix inability to read the database with DNS host names.

2022-03-10 Thread Ilya Maximets
Clustered OVSDB allows to use DNS names as addresses of raft members. However, if DNS resolution fails during the initial database read, this causes a fatal failure and exit of the ovsdb-server process. Also, if DNS name of a joining server is not resolvable for one of the followers, this

[ovs-dev] [PATCH ovn branch-21.12 2/2] Prepare for 21.12.2.

2022-03-10 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b00644b59..4cb40cd7f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v21.12.2 - xx xxx

[ovs-dev] [PATCH ovn branch-21.12 0/2] Release patches for v21.12.1.

2022-03-10 Thread Mark Michelson
Mark Michelson (2): Set release date for 21.12.1. Prepare for 21.12.2. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.31.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.1.

2022-03-10 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0f8e068b1..15fa545d2 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.03.1 - xx xxx

[ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.0.

2022-03-10 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.03.0. Prepare for 22.03.1. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.31.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.0.

2022-03-10 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 9f3ce3cf3..0f8e068b1 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v22.03.0 - XX XXX +OVN v22.03.0 - 11 Mar 2022

[ovs-dev] [PATCH ovn branch-21.12 1/2] Set release date for 21.12.1.

2022-03-10 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 4043ecf20..b00644b59 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v21.12.1 - xx xxx +OVN v21.12.1 - 10 Mar 2022

[ovs-dev] [PATCH ovn v2] ovn-northd: Don't commit to conntrack if the conntrack was skipped.

2022-03-10 Thread numans
From: Numan Siddique Presently, if the inport or outport is a peer port (of router port), then we skip sending the packet to conntrack by not setting the reg0[0]/reg0[1] bits. But the packet still goes through the stages - ls_in_acl_hint, ls_in_acl and ls_in_stateful in the ingress pipeline and

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space

2022-03-10 Thread Aaron Conole
Ilya Maximets writes: > Few years ago OVS user space made a strange choice in the commit [1] > to define types only valid for the user space inside the copy of a > kernel uAPI header. '#ifndef __KERNEL__' and another attribute was > added later. > > This leads to the inevitable clash between

Re: [ovs-dev] [External] Re: [PATCH] dpif-netdev: add an option to assign pmd rxq to all numas

2022-03-10 Thread Kevin Traynor
On 04/03/2022 17:57, Anurag Agarwal wrote: Hello Kevin, I have prepared a patch for "per port cross-numa-polling" and attached herewith. The results are captured in 'cross-numa-results.txt'. We see PMD to RxQ assignment evenly balanced across all PMDs with this patch. Please take

Re: [ovs-dev] [PATCH ovn] ovn-northd: Skip conntrack related stages for router ports in switch pipeline.

2022-03-10 Thread Numan Siddique
On Thu, Mar 10, 2022 at 4:22 AM Dumitru Ceara wrote: > > On 3/10/22 04:04, num...@ovn.org wrote: > > From: Numan Siddique > > > > Hi Numan, > > > Presently, if the inport or outport is a peer port (of router port), > > then we skip sending the packet to conntrack by not setting the > >

Re: [ovs-dev] [External] Re: [PATCH] dpif-netdev: add an option to assign pmd rxq to all numas

2022-03-10 Thread Kevin Traynor
Hi Jan, On 09/03/2022 15:48, Jan Scheurich wrote: Thanks for sharing your experience with it. My fear with the proposal is that someone turns this on and then tells us performance is worse and/or OVS assignments/ALB are broken, because it has an impact on their case. In terms of limiting

Re: [ovs-dev] [PATCH ovn 21.12] controller: reconfigure ovs meters for ovn meters

2022-03-10 Thread Mark Michelson
Thanks Lorenzo for this backport. I did a quick sanity check on the 21.12 branch and it looks good to me. So I Acked and pushed the patch to branch-21.12. On 3/10/22 11:01, Lorenzo Bianconi wrote: At the moment ovs meters are reconfigured by ovn just when a meter is allocated or removed while

Re: [ovs-dev] [PATCH ovn 21.12] controller: reconfigure ovs meters for ovn meters

2022-03-10 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the

[ovs-dev] [PATCH ovn 21.12] controller: reconfigure ovs meters for ovn meters

2022-03-10 Thread Lorenzo Bianconi
At the moment ovs meters are reconfigured by ovn just when a meter is allocated or removed while updates for an already allocated meter are ignored. This issue can be easily verified with the following reproducer: $ovn-nbctl meter-add meter0 drop 10 pktps $ovn-nbctl --log --meter=meter0 acl-add

Re: [ovs-dev] [PATCH] Fix Apache license notice.

2022-03-10 Thread David Marchand
On Thu, Mar 10, 2022 at 1:51 PM Ilya Maximets wrote: > > On 3/10/22 13:12, David Marchand wrote: > > The hacking flake8 plugin generates a lot of noise in GHA logs about an > > issue on the Apache license contained in OVS python files: > >

Re: [ovs-dev] [PATCH] Fix Apache license notice.

2022-03-10 Thread Ilya Maximets
On 3/10/22 13:12, David Marchand wrote: > The hacking flake8 plugin generates a lot of noise in GHA logs about an > issue on the Apache license contained in OVS python files: > https://github.com/openvswitch/ovs/runs/5453426047?#step:11:1519 > > Those prints seem like a bug in the hacking plugin

Re: [ovs-dev] [[PATCH RFC] 13/17] Enable IP checksum offloading by default.

2022-03-10 Thread Flavio Leitner
On Mon, Jan 24, 2022 at 02:21:35PM -0500, Mike Pattrick wrote: > On Tue, Dec 7, 2021 at 11:54 AM Flavio Leitner wrote: > > > > The netdev receiving packets is supposed to provide the flags > > indicating if the IP csum was verified and it is OK or BAD, > > otherwise the stack will check when

Re: [ovs-dev] [[PATCH RFC] 06/17] dp-packet: Use p for packet and b for batch.

2022-03-10 Thread Flavio Leitner
On Mon, Jan 24, 2022 at 01:39:57PM -0500, Mike Pattrick wrote: > On Tue, Dec 7, 2021 at 11:53 AM Flavio Leitner wrote: > > > > Currently 'p' and 'b' and used for packets, so use > > a convention that struct dp_packet is 'p' and > > struct dp_packet_batch is 'b'. > > > > Some comments needed new

Re: [ovs-dev] [PATCH ovn] ovn-northd: Skip conntrack related stages for router ports in switch pipeline.

2022-03-10 Thread Dumitru Ceara
On 3/10/22 04:04, num...@ovn.org wrote: > From: Numan Siddique > Hi Numan, > Presently, if the inport or outport is a peer port (of router port), > then we skip sending the packet to conntrack by not setting the > reg0[0]/reg0[1] bits. But the packet still goes through the > stages -

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: fix uAPI incompatibility with existing user space

2022-03-10 Thread Nicolas Dichtel
Le 09/03/2022 à 23:20, Ilya Maximets a écrit : > Few years ago OVS user space made a strange choice in the commit [1] > to define types only valid for the user space inside the copy of a > kernel uAPI header. '#ifndef __KERNEL__' and another attribute was > added later. > > This leads to the