Re: [ovs-dev] [PATCH ovn v2] northd: Avoid looking up port peers when not needed.

2022-04-21 Thread Mark Michelson
Thanks Dumitru, Acked-by: Mark Michelson I actually already pushed the patch to main as well, because for some reason I thought I had already acked the patch. Hopefully that doesn't cause an issue. On 4/19/22 11:50, Dumitru Ceara wrote: There's no need to always lookup a port's peer in

Re: [ovs-dev] [PATCH ovn v2 0/3] Use newest OVS version to fix Undefined Behavior

2022-04-21 Thread Mark Michelson
Thanks Dumitru and Adrian. I rolled Dumitru's edit into patch 3 and pushed the series to the main branch. On 4/20/22 01:55, Adrian Moreno wrote: A series has been recently introduced in OVS that has two main benefits: - Undefined Behavior in iterator loops is removed. This enforces some

Re: [ovs-dev] [PATCH v2 ovn] Stop sending garps when binding not bound to chassis

2022-04-21 Thread Mark Michelson
I pushed this change to main and branch-22.03. On 4/21/22 01:15, Ales Musil wrote: Thanks, looks good to me. Acked-by: Ales Musil On Thu, Apr 21, 2022 at 1:11 AM Ihar Hrachyshka wrote: When a binding switches to another chassis via requested-chassis option, controller should stop sending

Re: [ovs-dev] [PATCH ovn v3] pinctrl.c: Send GARP only on chassis atached to l3gw

2022-04-21 Thread Mark Michelson
Thanks Ales and Ihar. I added my ack and pushed this to main and branch-22.03. On 4/20/22 18:54, Ihar Hrachyshka wrote: Thank you, this looks great. Signed-off-by: Ihar Hrachyshka On Wed, Apr 20, 2022 at 4:09 AM Ales Musil wrote: The GARP was sent even on chassis that were not serving as

Re: [ovs-dev] OVS installs a broad slow-path match in the presence of user-defined openflow rules

2022-04-21 Thread Reshma Sreekumar
Great, thanks for the update and quick response! On Thu, 21 Apr, 2022, 5:41 pm Aaron Conole, wrote: > Eelco Chaudron writes: > > > Guess this is a known issue, please check out this patch: > > > > >

Re: [ovs-dev] OVS installs a broad slow-path match in the presence of user-defined openflow rules

2022-04-21 Thread Aaron Conole
Eelco Chaudron writes: > Guess this is a known issue, please check out this patch: > > https://patchwork.ozlabs.org/project/openvswitch/patch/20220106180704.2388658-1-acon...@redhat.com/ > > > Aaron any update on the v5 patch? Yes, I'm respinning now and will post by next week > //Eelco > > >

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-21 Thread Numan Siddique
On Thu, Apr 21, 2022 at 5:02 AM Frode Nordahl wrote: > > On Wed, Apr 20, 2022 at 10:10 PM Numan Siddique wrote: > > > > On Tue, Apr 12, 2022 at 11:01 AM Numan Siddique wrote: > > > > > > On Mon, Apr 11, 2022 at 12:37 PM Frode Nordahl > > > wrote: > > > > > > > > tor. 7. apr. 2022, 19:40 skrev

[ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-04-21 Thread Mcnamara, John
This meeting is a follow-up to the previous calls in March and the discussion which has happened since on the DPDK and OVS mailing lists. Three approaches were presented in the previous calls: * "Defer work": Handle DMA completions at OVS PMD thread level * "v3": Handle DMA Tx

Re: [ovs-dev] [PATCH] openvswitch: meter: Remove unnecessary int

2022-04-21 Thread Paolo Abeni
On Mon, 2022-04-18 at 00:50 +, Solomon Tan wrote: > This patch addresses the checkpatch.pl warning that long long is > preferred over long long int. Please don't do that. This kind of changes cause e.g. backporting issue for any later relevant bugfix touching the same area, for no real

Re: [ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-04-21 Thread Mcnamara, John
-Original Appointment- From: Stokes, Ian Sent: Thursday, March 24, 2022 3:37 PM To: Stokes, Ian; Pai G, Sunil; Hu, Jiayu; Ferriter, Cian; Van Haaren, Harry; Ilya Maximets; Maxime Coquelin (maxime.coque...@redhat.com); ovs-dev@openvswitch.org; d...@dpdk.org

Re: [ovs-dev] [PATCH v5] dpcls: Change info-get function to fetch dpcls usage stats.

2022-04-21 Thread Amber, Kumar
Hi Ilya, Please find my replies inline. > -Original Message- > From: Ilya Maximets > Sent: Wednesday, March 30, 2022 10:23 PM > To: Amber, Kumar ; ovs-dev@openvswitch.org; > Stokes, Ian > Cc: i.maxim...@ovn.org; f...@sysclose.org; Eelco Chaudron > ; Ferriter, Cian > Subject: Re:

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-21 Thread Frode Nordahl
On Wed, Apr 20, 2022 at 10:10 PM Numan Siddique wrote: > > On Tue, Apr 12, 2022 at 11:01 AM Numan Siddique wrote: > > > > On Mon, Apr 11, 2022 at 12:37 PM Frode Nordahl > > wrote: > > > > > > tor. 7. apr. 2022, 19:40 skrev Frode Nordahl > > > : > > > > > > > On Thu, Apr 7, 2022 at 6:51 PM

Re: [ovs-dev] OVS installs a broad slow-path match in the presence of user-defined openflow rules

2022-04-21 Thread Eelco Chaudron
Guess this is a known issue, please check out this patch: https://patchwork.ozlabs.org/project/openvswitch/patch/20220106180704.2388658-1-acon...@redhat.com/ Aaron any update on the v5 patch? //Eelco On 20 Apr 2022, at 16:21, Reshma Sreekumar wrote: > Hi All, > > We encountered a dramatic