Re: [ovs-dev] [v5 6/8] netdev-offload-tc: Cleanup police actions with reserved indexes on startup

2022-06-20 Thread Jianbo Liu via dev
On Mon, 2022-06-20 at 12:16 +0200, Eelco Chaudron wrote: > On 27 May 2022, at 11:00, Jianbo Liu wrote: > > > As the police actions with indexes of 0x1000-0x1fff are > > reserved for meter offload, to provide a clean environment for OVS, > > these reserved police actions should be deleted

Re: [ovs-dev] [v5 5/8] netdev-offload-tc: Implement meter offload API for tc

2022-06-20 Thread Jianbo Liu via dev
On Mon, 2022-06-20 at 12:15 +0200, Eelco Chaudron wrote: > On 27 May 2022, at 11:00, Jianbo Liu wrote: > > > For dpif-netlink, meters are mapped by tc to police actions with > > one-to-one relationship. Implement meter offload API to set/get/del > > the police action, and a hmap is used to save

Re: [ovs-dev] [v5 4/8] netdev-linux: Add functions to manipulate tc police action

2022-06-20 Thread Jianbo Liu via dev
On Mon, 2022-06-20 at 12:14 +0200, Eelco Chaudron wrote: > On 27 May 2022, at 11:00, Jianbo Liu wrote: > > > Add helpers to add, delete and get stats of police action with > > the specified index. > > > > Signed-off-by: Jianbo Liu > > --- > >  lib/netdev-linux.c | 142 > >

Re: [ovs-dev] [v5 1/8] netdev-offload: Add meter offload API

2022-06-20 Thread Jianbo Liu via dev
On Mon, 2022-06-20 at 12:12 +0200, Eelco Chaudron wrote: > > On 27 May 2022, at 11:00, Jianbo Liu wrote: > > > Add API to offload meter to HW, and the corresponding functions to > > call > > the meter callbacks from all the registered flow API providers. > > The interfaces are like those related

Re: [ovs-dev] [v5 7/8] netdev-offload-tc: Offloading rules with police actions

2022-06-20 Thread Jianbo Liu via dev
On Mon, 2022-06-20 at 12:17 +0200, Eelco Chaudron wrote: > On 27 May 2022, at 11:00, Jianbo Liu wrote: > > > When offloading rule, tc should be filled with police index, > > instead > > of meter id. As meter is mapped to police action, and the mapping > > is > > inserted into

Re: [ovs-dev] User space connection tracking benchmarks

2022-06-20 Thread Paolo Valerio
Ilya Maximets writes: > On 6/7/22 11:39, Robin Jarry wrote: >> Paolo Valerio, Jun 05, 2022 at 19:37: >>> Just a note that may be useful. >>> After some tests, I noticed that establishing e.g. two TCP connections, >>> and leaving the first one idle after 3whs, once the second connection >>>

[ovs-dev] [PATCH v2] ovs-tcpdump: Default to OVS_RUNDIR if present.

2022-06-20 Thread Mike Pattrick
Now ovs-tcpdump will check for an OVS_RUNDIR environment variable and if present, use it instead of the default RUNDIR. This is useful when used in conjunction with OVS_PAUSE_TEST while running the test suite. Signed-off-by: Mike Pattrick -- V2: Removed unnecessary conditional Signed-off-by:

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Default to OVS_RUNDIR if present.

2022-06-20 Thread Ilya Maximets
On 4/28/22 15:43, Mike Pattrick wrote: > Now ovs-tcpdump will check for an OVS_RUNDIR environment variable and > if present, use it instead of the default RUNDIR. This is useful when > used in conjunction with OVS_PAUSE_TEST while running the test suite. > > Signed-off-by: Mike Pattrick > ---

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: setting RSS hash types in RSS action

2022-06-20 Thread Ilya Maximets
On 3/22/22 03:08, Harold Huang wrote: > Hello, > Is there any opinion from the OVS or DPDK MLX5 driver maintainers? > This is a serious issue we've found when we use MLX5 PMD driver to > offload OVS-DPDK. It looks like DPDK is very inconsistent and drivers do not really put any effort in

Re: [ovs-dev] ovs-monitor-ipsec: LibreSwan update nssdb default path

2022-06-20 Thread Ilya Maximets
On 2/14/22 09:39, Mohammad Heib wrote: > Currently ovs-monitor-ipsec script uses the old NSSDB path (/etc/ipsec.d) > to store the connections keys and certificates and initiate these connections > using ipsec command which in turn uses the NSSDB that located in the new > location (see:

Re: [ovs-dev] [PATCH] ovsdb-idl: Get per-database memory usage statistics.

2022-06-20 Thread Ilya Maximets
On 11/30/21 10:47, Dumitru Ceara wrote: > Clients might be connected to multiple databases (e.g., ovn-controller > is connected to OVN_Southbound and Open_vSwitch databases) and the IDL > memory statistics are more useful if they're not aggregated. > > Signed-off-by: Dumitru Ceara > --- >

Re: [ovs-dev] [PATCH v3] ovsdb-server: Log database transactions for user requested tables.

2022-06-20 Thread Ilya Maximets
On 11/16/21 15:34, Dumitru Ceara wrote: > Add a new command, 'ovsdb-server/tlog-set DB:TABLE on|off', which > allows the user to enable/disable transaction logging for specific > databases and tables. > > By default, logging is disabled. Once enabled, logs are generated > with level INFO and are

Re: [ovs-dev] [PATCH ovn v19] Implement RARP activation strategy for ports

2022-06-20 Thread Numan Siddique
On Fri, Jun 17, 2022 at 8:55 PM Ihar Hrachyshka wrote: > > When options:activation-strategy is set to "rarp" for LSP, when used in > combination with multiple chassis names listed in > options:requested-chassis, additional chassis will install special flows > that would block all ingress and

Re: [ovs-dev] [v5 8/8] dpif-netlink: Offloading meter to tc police action

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > OVS meters are created in advance and openflow rules refer to them by > their unique ID. New tc_police API is used to offload them. By calling > the API, police actions are created and meters are mapped to them. > These actions then can be used in tc

Re: [ovs-dev] [v5 7/8] netdev-offload-tc: Offloading rules with police actions

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > When offloading rule, tc should be filled with police index, instead > of meter id. As meter is mapped to police action, and the mapping is > inserted into meter_id_to_police_idx hmap, this hmap is used to find > the police index. Besides, the reverse

Re: [ovs-dev] [v5 6/8] netdev-offload-tc: Cleanup police actions with reserved indexes on startup

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > As the police actions with indexes of 0x1000-0x1fff are > reserved for meter offload, to provide a clean environment for OVS, > these reserved police actions should be deleted on startup. So dump > all the police actions, delete those actions

Re: [ovs-dev] [v5 5/8] netdev-offload-tc: Implement meter offload API for tc

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > For dpif-netlink, meters are mapped by tc to police actions with > one-to-one relationship. Implement meter offload API to set/get/del > the police action, and a hmap is used to save the mappings. > An id-pool is used to manage all the available

Re: [ovs-dev] [v5 1/8] netdev-offload: Add meter offload API

2022-06-20 Thread Eelco Chaudron
On 20 Jun 2022, at 12:12, Eelco Chaudron wrote: > On 27 May 2022, at 11:00, Jianbo Liu wrote: > >> Add API to offload meter to HW, and the corresponding functions to call >> the meter callbacks from all the registered flow API providers. >> The interfaces are like those related to meter in

Re: [ovs-dev] [v5 4/8] netdev-linux: Add functions to manipulate tc police action

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > Add helpers to add, delete and get stats of police action with > the specified index. > > Signed-off-by: Jianbo Liu > --- > lib/netdev-linux.c | 142 + > lib/netdev-linux.h | 6 ++ > lib/tc.c |

Re: [ovs-dev] [v5 3/8] netdev-linux: Refactor put police action netlink message

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > To reuse the code for manipulating police action, move the common > initialization code to a function, and change PPS parameters as meter > pktps is in unit of packet per second. > > null_police is redundant because either BPS or PPS, not both, can

Re: [ovs-dev] [v5 2/8] tc: Add support parsing tc police action

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > Add function to parse police action from netlink message. > > Signed-off-by: Jianbo Liu These changes look good to me! Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [v5 1/8] netdev-offload: Add meter offload API

2022-06-20 Thread Eelco Chaudron
On 27 May 2022, at 11:00, Jianbo Liu wrote: > Add API to offload meter to HW, and the corresponding functions to call > the meter callbacks from all the registered flow API providers. > The interfaces are like those related to meter in dpif_class, in order > to pass necessary info to HW. > >