On Wed, Jul 20, 2022 at 12:13 PM Numan Siddique wrote:
>
> On Wed, Jul 20, 2022 at 6:18 AM Dumitru Ceara wrote:
> >
> >
> > Hi Han,
> >
> > On 7/7/22 19:02, Dumitru Ceara wrote:
> > > On 7/7/22 18:21, Han Zhou wrote:
> > >> On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara
wrote:
> > >>>
> > >>> On
Hi,
On my enviroment, i have a load-balancer, witch uses udp(icmp) protocol to
check connection status between vip and backend.
In normal cirsumstances, vip send request packet to backends , and backends
send reply to vip, so the result of health check is online status. Then, i set
the
From: Numan Siddique
Compilation is failing with the error:
File "Documentation/conf.py", line 61, in
with open(filename, 'rU') as f:
ValueError: invalid mode: 'rU'
The python 3 documentation [1] says:
There is an additional mode character permitted, 'U',
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Numan Siddique needs to sign off.
Lines checked: 27, Warnings: 0, Errors: 1
From: Numan Siddique
Compilation is failing with the error:
---
File "Documentation/conf.py", line 61, in
with open(filename, 'rU') as f:
ValueError: invalid mode: 'rU'
---
The python 3 documentation [1] says:
There is an additional mode character permitted,
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#311 FILE: ovn-nb.xml:2397:
Hi Ales, I have one finding below.
On 7/20/22 04:48, Ales Musil wrote:
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final conclusion.
---
tests/ovn.at | 109
Hi Ales, I have one minor finding below.
On 7/20/22 04:48, Ales Musil wrote:
Add helper source file for creating index
over MAC binding table.
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final
On Mon, Jul 18, 2022 at 7:44 PM Ihar Hrachyshka wrote:
>
> Hi folks,
>
> looking for some advices on MTU / IP behavior for multi-chassis ports.
>
> 22.06 got the new multichassis port concept introduced where the same
> port may be present on multiple chassis, which can be used as a
> performance
On Tue, Jul 12, 2022 at 11:57 AM Ihar Hrachyshka wrote:
>
> The test sometimes failed because of duplicate periodic bcast ARPs
> captured. Use _UNIQ version of packet check procedure to pass.
>
> Signed-off-by: Ihar Hrachyshka
Thanks. Applied to the main branch.
Numan
> ---
> tests/ovn.at |
On Wed, Jul 20, 2022 at 6:18 AM Dumitru Ceara wrote:
>
>
> Hi Han,
>
> On 7/7/22 19:02, Dumitru Ceara wrote:
> > On 7/7/22 18:21, Han Zhou wrote:
> >> On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara wrote:
> >>>
> >>> On 7/7/22 13:45, Dumitru Ceara wrote:
> On 7/7/22 00:08, Han Zhou wrote:
>
On Tue, Jul 19, 2022 at 10:13 AM Vladislav Odintsov wrote:
>
> Signed-off-by: Vladislav Odintsov
Thanks. Applied to the main branch.
Numan
> ---
> controller/binding.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/controller/binding.c b/controller/binding.c
>
On Wed, Jul 20, 2022 at 12:22 AM Ales Musil wrote:
>
> Hi Dumitru,
>
> this is a great improvement, thank you.
>
> Acked-by: Ales Musil
Thanks. Applied to the main branch.
Numan
>
> On Tue, Jul 19, 2022 at 10:20 PM Dumitru Ceara wrote:
>
> > This has the benefit that we now use names that
On Wed, Jul 20, 2022 at 3:00 AM Ales Musil wrote:
>
> Hi Dumitru,
>
> nice to see it unified, thank you.
>
> Acked-by: Ales Musil
Thanks. I applied this patch to the main branch.
Numan
>
>
> On Tue, Jul 19, 2022 at 10:43 PM Dumitru Ceara wrote:
>
> > Signed-off-by: Dumitru Ceara
> > ---
>
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#55 FILE: lib/netdev-dpdk.c:1207:
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#55 FILE: lib/netdev-dpdk.c:1207:
There is no need to log if the implementation didn't change.
Scalar one is default, any change will be logged. And availability
is not really important to log at INFO level. Moving these logs
to DBG level to avoid littering the log file and confusing users.
We do the same for miniflow_extract
On Wed, Jul 13, 2022 at 4:29 AM Dumitru Ceara wrote:
>
> On 7/13/22 11:08, Dumitru Ceara wrote:
> > On 7/13/22 09:40, Xavier Simonart wrote:
> >> Hi Han, Dumitru
> >>
> >
> > Hi Han, Xavier,
> >
> > Sorry, I had already replied to the previous message and only then
> > noticed this one.
> >
> >>
The MTU vport unit tests do not clean up testpmd after use which causes them to
fail randomly.
This commit amends the MTU vport unit tests to clean up testpmd after running.
Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS-DPDK MTU unit
tests.")
Signed-off-by: Michael Phelan
On 7/20/22 14:18, Ivan Malov wrote:
> DPDK has got support for offloads involving assignment of per-packet
> Rx metadata (flag, mark, tunnel ID and the likes). However, delivery
> of such metadata from the NIC to the PMD might need to be negotiated
> in advance. API [1] addresses that problem.
There is no need to log if the implementation didn't change.
Scalar one is default, any change will be logged. And availability
is not really important to log at INFO level. Moving these logs
to DBG level to avoid littering the log file and confusing users.
We do the same for miniflow_extract
Hi Eli,
Thanks a lot for a prompt review. PSB.
On Wed, 20 Jul 2022, Eli Britstein wrote:
-Original Message-
From: Ivan Malov
Sent: Wednesday, July 20, 2022 3:18 PM
To: d...@openvswitch.org
Cc: Eli Britstein ; Stephen Hemminger
; Ilya Maximets ; Ori
Kam ; Maxime Coquelin
; David
>-Original Message-
>From: Ivan Malov
>Sent: Wednesday, July 20, 2022 3:18 PM
>To: d...@openvswitch.org
>Cc: Eli Britstein ; Stephen Hemminger
>; Ilya Maximets ; Ori
>Kam ; Maxime Coquelin
>; David Marchand
>; Andrew Rybchenko
>
>Subject: [PATCH v3 3/3] netdev-offload-dpdk: use flow
Hi Eli,
Thank you for your review efforts. Please find the new version:
http://patchwork.ozlabs.org/project/openvswitch/patch/20220720121823.2497727-4-ivan.ma...@oktetlabs.ru/
It cares about the detach scenario we've been talking about.
And it cares about port ID logging for transfer flows,
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
---
lib/netdev-dpdk.c | 99 ---
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead.
Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
---
lib/netdev-offload-dpdk.c | 32
1 file changed, 32 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index
This may be required by some PMDs in offload scenarios.
Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
---
lib/netdev-dpdk.c | 44
1 file changed, 44 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index f9535bfb4..45e5d26d2
DPDK has got support for offloads involving assignment of per-packet
Rx metadata (flag, mark, tunnel ID and the likes). However, delivery
of such metadata from the NIC to the PMD might need to be negotiated
in advance. API [1] addresses that problem. Make OvS invoke this API.
Another problem is
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
---
lib/netdev-dpdk.c | 99 ---
Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead.
Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
---
lib/netdev-offload-dpdk.c | 32
1 file changed, 32 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index
DPDK has got support for offloads involving assignment of per-packet
Rx metadata (flag, mark, tunnel ID and the likes). However, delivery
of such metadata from the NIC to the PMD might need to be negotiated
in advance. API [1] addresses that problem. Make OvS invoke this API.
Another problem is
This may be required by some PMDs in offload scenarios.
Signed-off-by: Ivan Malov
Acked-by: Andrew Rybchenko
---
lib/netdev-dpdk.c | 44
1 file changed, 44 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index f9535bfb4..45e5d26d2
Hi Han,
On 7/7/22 19:02, Dumitru Ceara wrote:
> On 7/7/22 18:21, Han Zhou wrote:
>> On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara wrote:
>>>
>>> On 7/7/22 13:45, Dumitru Ceara wrote:
On 7/7/22 00:08, Han Zhou wrote:
> On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote:
>>
>>
Because the transaction is limited, in terms of how
many operations it can do, we should not allow
more than 15 MAC bindings to be removed at once every
10 ms. This has a downside that in theory we could
never finish the removal, however in practice it is
unlikely considering that not all routers
Add helper source file for creating index
over MAC binding table.
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final conclusion.
---
controller/ovn-controller.c | 8 +++-
lib/automake.mk
Add MAC binding aging mechanism, that utilizes
the timestamp column of MAC_Binding table.
When the MAC binding exceeds the threshold it is
removed from SB DB, this is postponed only in case
we receive update ARP with update to MAC address.
The threshold is configurable via option
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final conclusion.
---
tests/ovn.at | 109 +++
1 file changed, 109 insertions(+)
diff --git a/tests/ovn.at
The struct ovn_datapath could not be used outside the northd.c
move it to northd.h that it can be used by other .c files later on.
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final conclusion.
---
Add MAC binding aging mechanism, that
should take care of stale MAC bindings.
The mechanism is configurable per logical
router, with option called
"mac_binding_age_threshold", which is 0 by
default. The zero also indicates that the
aging mechanism is disabled.
The aging is based on timestamp in
The new timestamp column in MAC_Binding is
populated with current time whenever the row is
created or the MAC address is updated.
This can be utilized by MAC binding aging mechanism,
when we can check if enough time has passed since the
creation/update.
Reported-at:
Hi Dumitru,
the code looks good to me, with one small nit see below.
On Tue, Jul 19, 2022 at 10:43 PM Dumitru Ceara wrote:
> RFC 4541 "Considerations for Internet Group Management Protocol (IGMP)
> and Multicast Listener Discovery (MLD) Snooping Switches" [0] states:
>
> For IGMP packets:
>
Hi Dumitru,
nice to see it unified, thank you.
Acked-by: Ales Musil
On Tue, Jul 19, 2022 at 10:43 PM Dumitru Ceara wrote:
> Signed-off-by: Dumitru Ceara
> ---
> V2: Rebase and fix up new calls in test "localnet connectivity with
> multiple requested-chassis"
> ---
> tests/ovn-macros.at |
42 matches
Mail list logo
