Re: [ovs-dev] [PATCH ovn] ovn-ctl: Ensure that log/run directory have correct permission

2022-08-03 Thread Ales Musil
On Wed, Aug 3, 2022 at 11:14 PM Numan Siddique wrote: > On Tue, Aug 2, 2022 at 3:48 AM Ales Musil wrote: > > > > When someone creates or changes permission of the var/log > > directory it stays that way. This can cause issues for logrotate > > as it needs to have correct permission on

Re: [ovs-dev] [PATCH ovn] CI-Actions: define matrix as a list

2022-08-03 Thread Numan Siddique
On Wed, Aug 3, 2022 at 9:55 AM Mohammad Heib wrote: > > Defining the matrix as a list will make it more readable > and easy to extend also users can exclude and add new cases > without using include, exclude just add a new combination > to the list. > > Signed-off-by: Mohammad Heib Thanks.

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Ensure that log/run directory have correct permission

2022-08-03 Thread Numan Siddique
On Tue, Aug 2, 2022 at 3:48 AM Ales Musil wrote: > > When someone creates or changes permission of the var/log > directory it stays that way. This can cause issues for logrotate > as it needs to have correct permission on directory. > > Attempt to fix the permission every time we run

Re: [ovs-dev] [PATCH ovn] system-tests: Make netcat calls more robust

2022-08-03 Thread Numan Siddique
On Wed, Jul 27, 2022 at 3:12 AM Ales Musil wrote: > > The netcat compilation options differ between > distributions, make the nc execution more > robust. Now it does not fail on success message > being printed to stderr. > > Signed-off-by: Ales Musil Thanks. Applied to the main branch. Numan

Re: [ovs-dev] [PATCH v1] ovs-save: Use right OpenFlow version for add-tlv-map

2022-08-03 Thread Mike Pattrick
On Fri, Jul 1, 2022 at 6:53 AM Han Ding wrote: > > > When the bridge protocols is not included Openflow10, printing an error > message "version negotiation failed" when doing "Restoring saved flows". > > Signed-off-by: Han Ding Looks good to me! Acked-by: Mike Pattrick > --- >

Re: [ovs-dev] [PATCH v5 ovn 2/2] controller: throttle port claim attempts

2022-08-03 Thread Numan Siddique
' On Tue, Jul 12, 2022 at 5:58 PM Ihar Hrachyshka wrote: > > When multiple chassis are fighting for the same port (requested-chassis > is not set, e.g. for gateway ports), they may produce an unreasonable > number of chassis field updates in a very short time frame (hundreds of > updates in

Re: [ovs-dev] [PATCH v5 ovn 1/2] Split out code to handle port binding db updates

2022-08-03 Thread Numan Siddique
On Mon, Jul 25, 2022 at 4:27 PM Mark Michelson wrote: > > Acked-by: Mark Michelson The patch looks good to me. But it needs a rebase. Numan > > On 7/12/22 17:57, Ihar Hrachyshka wrote: > > This function will later be used to handle port binding updates for > > postponed (throttled) bindings.

Re: [ovs-dev] [PATCH] dpif-netlink: Fix incorrect bit shift in compat mode.

2022-08-03 Thread Mike Pattrick
On Thu, Jul 28, 2022 at 11:43 AM Ilya Maximets wrote: > > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior in > lib/dpif-netlink.c:1077:40: runtime error: >left shift of 1 by 31 places cannot be represented in type 'int' > > #0 0x73fc31 in dpif_netlink_port_add_compat

Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.

2022-08-03 Thread Ilya Maximets
On 8/3/22 17:19, Mike Pattrick wrote: > On Wed, Aug 3, 2022 at 11:12 AM Ilya Maximets wrote: >> >> On 8/3/22 16:58, Mike Pattrick wrote: >>> On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote: $NC_EOF_OPT should be used to avoid some netcat implementations to wait indefinitely.

Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.

2022-08-03 Thread Mike Pattrick
On Wed, Aug 3, 2022 at 11:12 AM Ilya Maximets wrote: > > On 8/3/22 16:58, Mike Pattrick wrote: > > On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote: > >> > >> $NC_EOF_OPT should be used to avoid some netcat implementations > >> to wait indefinitely. > >> > >> This fixes the check-offloads

Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.

2022-08-03 Thread Ilya Maximets
On 8/3/22 16:58, Mike Pattrick wrote: > On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote: >> >> $NC_EOF_OPT should be used to avoid some netcat implementations >> to wait indefinitely. >> >> This fixes the check-offloads testsuite hanging in Ubuntu 22.04. >> >> Fixes: 5660b89a309d

Re: [ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.

2022-08-03 Thread Mike Pattrick
On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote: > > $NC_EOF_OPT should be used to avoid some netcat implementations > to wait indefinitely. > > This fixes the check-offloads testsuite hanging in Ubuntu 22.04. > > Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action") >

[ovs-dev] [PATCH ovn] northd: Use datapath groups for southbound load balancers.

2022-08-03 Thread Ilya Maximets
Some CMSes, like ovn-kubernetes, tend to create load balancers attached to a big number of logical switches or routers. For each of these load balancers northd creates a record in Load_Balancer table of the Southbound database with all the logical datapaths (switches, routers) listed in the

Re: [ovs-dev] binding.c: update ld->peers when lsp type updated

2022-08-03 Thread 0-day Robot
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/binding.c). error: could not build fake

[ovs-dev] [PATCH ovn v2] binding.c: update ld->peers when lsp type updated

2022-08-03 Thread Mohammad Heib
The local_datapath->peer_ports list contains peers pointers to lsp<-->lrp ports that are supposed to be router end ports, those pointers are added and deleted to the local_datapath->peer_ports when logical switch port of type router are added or deleted from the database. The deletion and

[ovs-dev] binding.c: update ld->peers when lsp type updated

2022-08-03 Thread Mohammad Heib
The local_datapath->peer_ports list contains peers pointers to lsp<-->lrp ports that are supposed to be router end ports, those pointers are added and deleted to the local_datapath->peer_ports when logical switch port of type router are added or deleted from the database. The deletion and

[ovs-dev] [PATCH ovn] CI-Actions: define matrix as a list

2022-08-03 Thread Mohammad Heib
Defining the matrix as a list will make it more readable and easy to extend also users can exclude and add new cases without using include, exclude just add a new combination to the list. Signed-off-by: Mohammad Heib --- .github/workflows/test.yml | 55 ++ 1

Re: [ovs-dev] [PATCH] mac-learning: Fix learned fdb entries are not age out issue.

2022-08-03 Thread lin huang
Hi Vasu & Eelco, Pls review my patch. Thanks a lot. > -Original Message- > From: lin huang > Sent: Friday, July 29, 2022 7:17 PM > To: ovs-dev@openvswitch.org; echau...@redhat.com; i.maxim...@ovn.org; > vdas...@gmail.com > Cc: Lin Huang ; Zhang Yuhuang > > Subject: [PATCH]

Re: [ovs-dev] [PATCH v6 2/2] handlers: Fix handlers mapping

2022-08-03 Thread Aaron Conole
Ilya Maximets writes: > On 7/19/22 08:59, Michael Santana wrote: >> The handler and CPU mapping in upcalls are incorrect, and this is >> specially noticeable systems with cpu isolation enabled. >> >> Say we have a 12 core system where only every even number CPU is enabled >> C0, C2, C4, C6, C8,

[ovs-dev] [PATCH branch-2.17] dpif-netdev: Simplify AVX512 build time checks to enhance readability.

2022-08-03 Thread Sunil Pai G
The preprocessor comparison string to check AVX512 capabilities are lengthy and effecting user readability. Simpify this by aliasing the checks. Suggested-by: Eelco Chaudron Signed-off-by: Sunil Pai G Acked-by: Cian Ferriter --- lib/dpif-netdev-lookup.c | 6 --

Re: [ovs-dev] [PATCH v2] netdev-linux: set correct action for packets that passed policer

2022-08-03 Thread Simon Horman
On Wed, Aug 03, 2022 at 01:33:21PM +0300, Vlad Buslov wrote: ... > Thanks for the review! I've just sent V3 that sets action type based on > target classifier instead of policer BPS/PPS. Likewise, thanks. We'll review v3. ___ dev mailing list

Re: [ovs-dev] [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance readability.

2022-08-03 Thread Pai G, Sunil
> > > > > Sending a friendly ping here to check for any comments/objections > on > >> this patch from maintainers. > >>> > >>> Hi, Sunil. I think, Ian wanted to apply the patch, we discussed > >>> that on a meeting last week. > >> > >> It's probably just a PTO season. :) > >> (Got a

Re: [ovs-dev] [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance readability.

2022-08-03 Thread Ilya Maximets
On 8/3/22 13:50, Pai G, Sunil wrote: > > > Sending a friendly ping here to check for any comments/objections on >> this patch from maintainers. >>> >>> Hi, Sunil. I think, Ian wanted to apply the patch, we discussed that >>> on a meeting last week. >> >> It's probably just a PTO season.

Re: [ovs-dev] [PATCH ovn] tests: Fix flake8 reported warning due to line length.

2022-08-03 Thread Dumitru Ceara
On 8/3/22 13:44, Ilya Maximets wrote: > On 8/3/22 12:39, Dumitru Ceara wrote: >> Starting with flake8>=5.0.1 we got the following report: >> tests/check_acl_log.py:94:80: E501 line too long (80 > 79 characters) >> >> Signed-off-by: Dumitru Ceara >> --- >> tests/check_acl_log.py | 3 ++- >> 1

Re: [ovs-dev] [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance readability.

2022-08-03 Thread Pai G, Sunil
> >> Sending a friendly ping here to check for any comments/objections on > this patch from maintainers. > > > > Hi, Sunil. I think, Ian wanted to apply the patch, we discussed that > > on a meeting last week. > > It's probably just a PTO season. :) > (Got a few OOO replies here) Thanks Ilya

Re: [ovs-dev] [PATCH ovn] tests: Fix flake8 reported warning due to line length.

2022-08-03 Thread Ilya Maximets
On 8/3/22 12:39, Dumitru Ceara wrote: > Starting with flake8>=5.0.1 we got the following report: > tests/check_acl_log.py:94:80: E501 line too long (80 > 79 characters) > > Signed-off-by: Dumitru Ceara > --- > tests/check_acl_log.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

[ovs-dev] [PATCH ovn] northd: Do not relay local IP multicast (224.0.0.X).

2022-08-03 Thread Dumitru Ceara
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2077306 Signed-off-by: Dumitru Ceara --- northd/northd.c | 2 +- northd/ovn-northd.8.xml | 4 ++-- tests/ovn.at| 42 ++--- 3 files changed, 42 insertions(+), 6 deletions(-) diff

[ovs-dev] [PATCH ovn] tests: Fix flake8 reported warning due to line length.

2022-08-03 Thread Dumitru Ceara
Starting with flake8>=5.0.1 we got the following report: tests/check_acl_log.py:94:80: E501 line too long (80 > 79 characters) Signed-off-by: Dumitru Ceara --- tests/check_acl_log.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/check_acl_log.py

Re: [ovs-dev] [PATCH v2] netdev-linux: set correct action for packets that passed policer

2022-08-03 Thread Vlad Buslov via dev
On Tue 02 Aug 2022 at 14:01, Simon Horman wrote: > On Tue, Aug 02, 2022 at 10:38:03AM +0300, Vlad Buslov wrote: >> On Wed 27 Jul 2022 at 11:49, Vlad Buslov wrote: >> > On Wed 27 Jul 2022 at 10:26, Simon Horman >> > wrote: >> >> On Tue, Jul 26, 2022 at 07:52:31AM -0500, Marcelo Ricardo Leitner

[ovs-dev] [PATCH v3] netdev-linux: set correct action for packets that passed policer

2022-08-03 Thread Vlad Buslov via dev
Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 driver at the time validated action type and always assumed 'continue', the breakage wasn't caught until later validation code was added. The change

[ovs-dev] [PATCH v2] netdev-dpdk: fix tx_dropped counters value

2022-08-03 Thread Robin Jarry
Packets that could not be transmitted because the TXQ are full should be taken into account in the global ovs_tx_failure_drops as it was the case before commit 29b94e12d57d ("netdev-dpdk: Refactor the DPDK transmit path."). Also, the global tx_dropped should take all ovs_*_tx_drops counters into