On Wed, Aug 10, 2022 at 3:22 PM Ales Musil wrote:
>
> On Wed, Aug 10, 2022 at 3:20 AM Numan Siddique wrote:
>
> > On Tue, Aug 9, 2022 at 9:06 PM Ales Musil wrote:
> > >
> > > Add MAC binding aging mechanism, that utilizes
> > > the timestamp column of MAC_Binding table.
> > > When the MAC
On Wed, Aug 10, 2022 at 3:20 AM Numan Siddique wrote:
> On Tue, Aug 9, 2022 at 9:06 PM Ales Musil wrote:
> >
> > Add MAC binding aging mechanism, that utilizes
> > the timestamp column of MAC_Binding table.
> > When the MAC binding exceeds the threshold it is
> > removed from SB DB, this is
On Tue, Aug 9, 2022 at 9:06 PM Ales Musil wrote:
>
> Add MAC binding aging mechanism, that utilizes
> the timestamp column of MAC_Binding table.
> When the MAC binding exceeds the threshold it is
> removed from SB DB, this is postponed only in case
> we receive update ARP with update to MAC
On Sat, Aug 6, 2022 at 6:40 AM Frode Nordahl
wrote:
>
> Ilya and Numan,
>
> I preemptively added your names to the commit message because the
> patch contains your work as detailed in the commit message.
>
> I hope this is ok.
I'm fine. I would've been fine even without the credit.
I do not
On Wed, Aug 10, 2022 at 4:25 AM Ihar Hrachyshka wrote:
>
> When multiple chassis are fighting for the same port (requested-chassis
> is not set, e.g. for gateway ports), they may produce an unreasonable
> number of chassis field updates in a very short time frame (hundreds of
> updates in several
On Tue, Aug 9, 2022 at 12:57 PM Han Zhou wrote:
>
>
>
> On Tue, Aug 9, 2022 at 12:53 PM Mark Michelson
wrote:
> >
> > On 8/9/22 15:12, Ilya Maximets wrote:
> > > On 8/9/22 20:59, Mark Michelson wrote:
> > >> On 8/8/22 09:31, Ilya Maximets wrote:
> > >>> On 8/5/22 08:28, Han Zhou wrote:
> >
On Tue, Aug 9, 2022 at 12:53 PM Mark Michelson wrote:
>
> On 8/9/22 15:12, Ilya Maximets wrote:
> > On 8/9/22 20:59, Mark Michelson wrote:
> >> On 8/8/22 09:31, Ilya Maximets wrote:
> >>> On 8/5/22 08:28, Han Zhou wrote:
> On Thu, Jun 30, 2022 at 12:55 PM Mark Michelson
wrote:
> >
>
On 8/9/22 15:12, Ilya Maximets wrote:
On 8/9/22 20:59, Mark Michelson wrote:
On 8/8/22 09:31, Ilya Maximets wrote:
On 8/5/22 08:28, Han Zhou wrote:
On Thu, Jun 30, 2022 at 12:55 PM Mark Michelson wrote:
Hi OVS and OVN devs,
The OVN team has considered the idea of moving inactivity probes
On 8/9/22 20:59, Mark Michelson wrote:
> On 8/8/22 09:31, Ilya Maximets wrote:
>> On 8/5/22 08:28, Han Zhou wrote:
>>> On Thu, Jun 30, 2022 at 12:55 PM Mark Michelson wrote:
Hi OVS and OVN devs,
The OVN team has considered the idea of moving inactivity probes (i.e.
OVSDB
On 8/8/22 09:31, Ilya Maximets wrote:
On 8/5/22 08:28, Han Zhou wrote:
On Thu, Jun 30, 2022 at 12:55 PM Mark Michelson wrote:
Hi OVS and OVN devs,
The OVN team has considered the idea of moving inactivity probes (i.e.
OVSDB echo requests/replies) into a background thread.
OVN logical
When multiple chassis are fighting for the same port (requested-chassis
is not set, e.g. for gateway ports), they may produce an unreasonable
number of chassis field updates in a very short time frame (hundreds of
updates in several seconds). This puts unnecessary load on OVN as well
as any db
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Signed-off-by: Ihar Hrachyshka
Acked-by: Mark Michelson
---
v6: rebased, added Mark's ack
---
controller/binding.c | 246 ++-
1 file changed, 128
On 8/8/22 22:36, Numan Siddique wrote:
On Tue, Aug 9, 2022 at 4:22 AM Mark Michelson wrote:
On 8/4/22 15:55, Numan Siddique wrote:
On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote:
This is a backport of Han Zhou's patch series "Avoid unnecessary
deletion & recreation during restart"
18.04 image is deprecated and will disappear soon. Also some
slowdowns and brownouts are planned to push users away from
this deprecated version:
https://github.com/actions/virtual-environments/issues/6002
Moving to 20.04. Can't move to 22.04 at the moment because of
deprecation warnings
Kernels 5.0, 4.20, 4.18, 4.17, 4.16 are not longterm kernels and
didn't receive updates for a long time. They are failing build
with compilers provided with ubuntu 20.04. Removing them from the
test matrix since we need to move CI from deprecated 18.04 image.
Signed-off-by: Ilya Maximets
---
Branches 2.14 and 2.13 require a bit move work to move to 20.04.
Ilya Maximets (2):
github: Remove kernels that fail to build with newer compilers.
github: Move CI to ubuntu 20.04 base image.
.ci/linux-build.sh | 6 ++
.github/workflows/build-and-test.yml | 13
On 8/9/22 10:48, Dumitru Ceara wrote:
> On 8/8/22 21:48, Ilya Maximets wrote:
>> 18.04 image is deprecated and will disappear soon. Also some
>> slowdowns and brownouts are planned to push users away from
>> this deprecated version:
>>
>>
Again patch looks good I only have one question. Please see bellow.
> This patch implemented meter action, currently, meter only support drop
> method and only support one band. The overall implementation is, when a
> packet comes in, it will first lookup meter according to the meter id,
> then
On Tue, Aug 2, 2022 at 9:05 PM Wentao Jia wrote:
> snat/dnat rules of logical router, no logical flows for established
> connection, all natted packets deliver to kernel conntrack module by
> ct commit, this is low performance and difficult to offload.
> add another logical flows without ct
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#126 FILE: ovn-nb.xml:166:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#326 FILE: ovn-nb.xml:2397:
Add configuration option into NB global table
called "mac_binding_removal_limit" defaulting to 0.
This option allows to limit number of MAC bindings
that can be removed by the aging mechanism in a single
transaction. The 0 means that the mechanism is disabled.
If the limit is reached next removal
The struct ovn_datapath could not be used outside the northd.c
move it to northd.h that it can be used by other .c files later on.
Reported-at: https://bugzilla.redhat.com/2084668
Acked-By: Ihar Hrachyshka
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final conclusion.
v4: Rebase on top of current main.
Address comments from Mark and Ihar.
---
tests/ovn.at | 111
Add MAC binding aging mechanism, that utilizes
the timestamp column of MAC_Binding table.
When the MAC binding exceeds the threshold it is
removed from SB DB, this is postponed only in case
we receive update ARP with update to MAC address.
The threshold is configurable via option
Add MAC binding aging mechanism, that
should take care of stale MAC bindings.
The mechanism is configurable per logical
router, with option called
"mac_binding_age_threshold", which is 0 by
default. The zero also indicates that the
aging mechanism is disabled.
The aging is based on timestamp in
Add helper source file for creating index
over MAC binding table.
Reported-at: https://bugzilla.redhat.com/2084668
Acked-By: Ihar Hrachyshka
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Update according to the final conclusion.
v4: Rebase on top of current main.
The new timestamp column in MAC_Binding is
populated with current time whenever the row is
created or the MAC address is updated.
This can be utilized by MAC binding aging mechanism,
when we can check if enough time has passed since the
creation/update.
Reported-at:
On Tue, Aug 9, 2022 at 5:21 PM Ales Musil wrote:
>
> On Wed, Aug 3, 2022 at 1:21 PM Dumitru Ceara wrote:
>
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2077306
> > Signed-off-by: Dumitru Ceara
> > ---
> > northd/northd.c | 2 +-
> > northd/ovn-northd.8.xml | 4 ++--
>
On Tue, Aug 9, 2022 at 5:49 AM Mark Michelson wrote:
>
> Thanks for the clarification Ales.
>
> Acked-by: Mark Michelson
Thanks. I applied this patch to the main branch.
Numan
>
> On 7/26/22 01:23, Ales Musil wrote:
> > I forgot to add the v2 comment, so for clarification just the commit
On Tue, Aug 9, 2022 at 6:45 PM Ales Musil wrote:
>
> On Mon, Aug 8, 2022 at 5:30 PM Dumitru Ceara wrote:
>
> > These may change over time and, as a matter of fact, have recently changed
> > in OVS master branch with commit fcdf8ae4a350 ("lib: Print nw_frag in flow
> > key.").
> >
> > Instead,
On 8/8/22 21:48, Ilya Maximets wrote:
> 18.04 image is deprecated and will disappear soon. Also some
> slowdowns and brownouts are planned to push users away from
> this deprecated version:
>
> https://github.com/actions/virtual-environments/issues/6002
>
> Moving to 20.04. Can't move to
On Wed, Jul 27, 2022 at 12:09 AM Ihar Hrachyshka wrote:
>
> Acked-By: Ihar Hrachyshka
>
> On Wed, Jul 20, 2022 at 4:56 AM Ales Musil wrote:
> >
> > Because the transaction is limited, in terms of how
> > many operations it can do, we should not allow
> > more than 15 MAC bindings to be removed
On Mon, Aug 8, 2022 at 5:30 PM Dumitru Ceara wrote:
> These may change over time and, as a matter of fact, have recently changed
> in OVS master branch with commit fcdf8ae4a350 ("lib: Print nw_frag in flow
> key.").
>
> Instead, strip the flow key from the output. To achieve that, the calls
>
Ilya Maximets writes:
> On 8/5/22 23:49, Paolo Valerio wrote:
>> Ilya Maximets writes:
>>
>>> On 8/5/22 17:08, Paolo Valerio wrote:
The following test sequence:
conntrack - IPv4 fragmentation incomplete reassembled packet
conntrack - IPv4 fragmentation with fragments
On Wed, Aug 3, 2022 at 4:44 PM Ilya Maximets wrote:
> Some CMSes, like ovn-kubernetes, tend to create load balancers attached
> to a big number of logical switches or routers. For each of these
> load balancers northd creates a record in Load_Balancer table of the
> Southbound database with all
Hi Mohammad,
I have some questions and comments, see inline.
On Wed, Aug 3, 2022 at 4:35 PM Mohammad Heib wrote:
> The local_datapath->peer_ports list contains peers pointers
> to lsp<-->lrp ports that are supposed to be router end ports,
> those pointers are added and deleted to the
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#228 FILE:
On Wed, Aug 3, 2022 at 1:21 PM Dumitru Ceara wrote:
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2077306
> Signed-off-by: Dumitru Ceara
> ---
> northd/northd.c | 2 +-
> northd/ovn-northd.8.xml | 4 ++--
> tests/ovn.at| 42
The handler and CPU mapping in upcalls are incorrect, and this is
specially noticeable systems with cpu isolation enabled.
Say we have a 12 core system where only every even number CPU is enabled
C0, C2, C4, C6, C8, C10
This means we will create an array of size 6 that will be sent to
kernel
Additional threads are required to service upcalls when we have CPU
isolation (in per-cpu dispatch mode). The reason additional threads
are required is because it creates a more fair distribution. With more
threads we decrease the load of each thread as more threads would
decrease the number of
When the packet was traveling through patch port boundary
OvS would check if any of the actions is reversible,
if not it would clone the packet. However, the check
was only at the first level of the second bridge.
That caused some issues when the packet had gone
through more actions, some of them
On Sat, Aug 6, 2022 at 1:49 AM Han Zhou wrote:
>
>
>
> On Thu, Aug 4, 2022 at 7:09 AM Dumitru Ceara wrote:
> >
> > On 7/25/22 23:34, Han Zhou wrote:
> > > Also remove the reset mechanism when DB is reconnected, because at DB
> > > reconnection the data in IDL would not reset.
> > >
> > >
43 matches
Mail list logo
