Re: [ovs-dev] [PATCH v6 4/4] userspace: Enable L4 csum offloading by default.

2022-09-20 Thread Maxime Coquelin
Hi David, On 9/20/22 17:50, David Marchand wrote: I did not finish reviewing the rest, but I have an additional comment on the virtio/vhost features negotiations. On Wed, Jul 13, 2022 at 8:45 PM Mike Pattrick wrote: diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index

[ovs-dev] [PATCH v2 net 2/2] net: openvswitch: allow conntrack in non-initial user namespace

2022-09-20 Thread Michael Weiß
Similar to the previous commit, the Netlink interface of the OVS conntrack module was restricted to global CAP_NET_ADMIN by using GENL_ADMIN_PERM. This is changed to GENL_UNS_ADMIN_PERM to support unprivileged containers in non-initial user namespace. Signed-off-by: Michael Weiß ---

[ovs-dev] [PATCH v2 net 1/2] net: openvswitch: allow metering in non-initial user namespace

2022-09-20 Thread Michael Weiß
The Netlink interface for metering was restricted to global CAP_NET_ADMIN by using GENL_ADMIN_PERM. To allow metring in a non-inital user namespace, e.g., a container, this is changed to GENL_UNS_ADMIN_PERM. Signed-off-by: Michael Weiß --- net/openvswitch/meter.c | 14 +++--- 1 file

[ovs-dev] [PATCH v2 net 0/2] net: openvswitch: metering and conntrack in userns

2022-09-20 Thread Michael Weiß
Currently using openvswitch in a non-initial user namespace, e.g., an unprivileged container, is possible but without metering and conntrack support. This is due to the restriction of the corresponding Netlink interfaces to the global CAP_NET_ADMIN. This simple patches switch from GENL_ADMIN_PERM

Re: [ovs-dev] [PATCH ovn] tests: fix multiple flaky test cases

2022-09-20 Thread Mark Michelson
I merged this to main. Thanks, Xavier. On 8/18/22 09:59, Xavier Simonart wrote: - ovn-controller incremental processing - ovn-ic -- port-bindings deletion upon TS deletion - IP packet buffering - ovn-controller-vtep - hv flows - external logical port - ovn-northd pause and resume - ACLs on Port

Re: [ovs-dev] [PATCH ovn] controller: Restore MAC and vlan for DVR scenario

2022-09-20 Thread Mark Michelson
Thanks Ales, Acked-by: Mark Michelson On 9/16/22 05:23, Ales Musil wrote: When traffic originated from router port the MAC, in DVR setup, the router MAC was replaced by one specified in "ovn-chassis-mac-mappings" option. Along with that the vlan tag of the localnet port was pushed. When the

Re: [ovs-dev] [PATCH ovn branch-22.03] northd: Do not report WARN for empty requested-chassis

2022-09-20 Thread Mark Michelson
Thanks Ales. Acked-by: Mark Michelson On 9/16/22 05:21, Ales Musil wrote: Reported-at: https://bugzilla.redhat.com/2126400 Signed-off-by: Ales Musil --- This patch should be applied only to 22.03 and below, because it was fixed as side effect of RFE on 22.06, 22.09 and main [0]. [0]

Re: [ovs-dev] [PATCH ovn] northd: do not centralize FIP traffic if redirect-type is set to fixed

2022-09-20 Thread Mark Michelson
Hi Lorenzo, I have a couple of comments below. In addition, please add a test for this scenario to the testsuite. On 9/19/22 09:22, Lorenzo Bianconi wrote: Keep FIP traffic distributed and do not centralize it even if the CMS sets redirect-type option to bridged for distributed gateway port.

Re: [ovs-dev] [PATCH v2] utilities: Add revalidator measurement script and needed USDT probes.

2022-09-20 Thread Aaron Conole
Eelco Chaudron writes: > This patch adds a Python script that can be used to analyze the > revalidator runs by providing statistics (including some real time > graphs). > > The USDT events can also be captured to a file and used for > later offline analysis. > > Signed-off-by: Eelco Chaudron >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2022-09-20 Thread David Marchand
On Wed, Sep 14, 2022 at 5:14 PM Mike Pattrick wrote: > > On Tue, Sep 13, 2022 at 5:21 AM David Marchand > wrote: > > > > At some point in OVS history, some virtio features were announced as > > supported (ECN and UFO virtio features). > > > > The userspace TSO code, which has been added later,

Re: [ovs-dev] [PATCH] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2022-09-20 Thread David Marchand
On Mon, Sep 12, 2022 at 4:47 PM Flavio Leitner wrote: > On Mon, Sep 12, 2022 at 5:52 AM David Marchand > wrote: >> On Fri, Sep 9, 2022 at 7:58 PM Flavio Leitner wrote: >> > >> > Thanks for working on this patch! >> > >> > It seems possible to change this patch later when the other TSO series

Re: [ovs-dev] [PATCH v6 4/4] userspace: Enable L4 csum offloading by default.

2022-09-20 Thread David Marchand
I did not finish reviewing the rest, but I have an additional comment on the virtio/vhost features negotiations. On Wed, Jul 13, 2022 at 8:45 PM Mike Pattrick wrote: > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 811c62a87..a69bab829 100644 > --- a/lib/netdev-dpdk.c > +++

Re: [ovs-dev] [PATCH v2] system-dpdk: Improve user configured mempool test.

2022-09-20 Thread Phelan, Michael
> -Original Message- > From: dev On Behalf Of Sunil Pai G > Sent: Wednesday 14 September 2022 09:37 > To: d...@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: [ovs-dev] [PATCH v2] system-dpdk: Improve user configured > mempool test. > > Improve the test by adding and varying the

Re: [ovs-dev] [PATCH ovn 1/6] Rename tunnel ports to include source chassis name

2022-09-20 Thread Ihar Hrachyshka
On Tue, Sep 20, 2022 at 1:27 AM Ales Musil wrote: > Hi, > please see the comment below. > > > On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka > wrote: > >> This is in preparation to support multiple separate controller instances >> with distinct chassis names operating on the same vswitchd

Re: [ovs-dev] [PATCH ovn] lb: Remove unused ovn_northd_lb_vip vip_port_str member.

2022-09-20 Thread Numan Siddique
On Mon, Sep 19, 2022 at 2:06 AM Ales Musil wrote: > > On Fri, Aug 26, 2022 at 2:35 PM Dumitru Ceara wrote: > > > Signed-off-by: Dumitru Ceara > > --- > > lib/lb.c | 5 + > > lib/lb.h | 1 - > > 2 files changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/lib/lb.c b/lib/lb.c > >

[ovs-dev] [v2] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-09-20 Thread Emma Finn
This commit adds support for the AVX512 implementation of the ipv6_set_addrs action as well as an AVX512 implementation of updating the L4 checksums. Signed-off-by: Emma Finn --- v2: - Added check for availbility of s6_addr32 field of struct in6_addr. - Fixed network headers for freebsd

Re: [ovs-dev] [PATCH] ofproto: Release ofport_usage to avoid memory leak.

2022-09-20 Thread Mengxin Liu
We tested ovs from both 2.15 and 2.17 branches. The leak is not that remarkable, about 26KB memory leak detected by memleak-bpfss when creating and deleting 800 ports. Our environment is complex with ovs, ovn, kubernetes and kube-ovn etc. I will try to reproduce it in a minimal setup. On Tue,

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

2022-09-20 Thread Phelan, Michael
> -Original Message- > From: Kevin Traynor > Sent: Tuesday 20 September 2022 13:36 > To: Maxime Coquelin ; Phelan, Michael > ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; Stokes, Ian > Subject: Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release. > > On 20/09/2022 11:47, Kevin

Re: [ovs-dev] [PATCH] ofproto: Release ofport_usage to avoid memory leak.

2022-09-20 Thread Aaron Conole
Mengxin Liu writes: > Sorry for the incomplete information. This patch resolved the problem > in my environment, > but I'm not familiar with the recycling logic and if it will affect > the recycling. Here is the > description of how we found and resolved the leak, hope it helps you > further

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

2022-09-20 Thread Kevin Traynor
On 20/09/2022 11:47, Kevin Traynor wrote: On 20/09/2022 10:38, Maxime Coquelin wrote: On 9/20/22 11:28, Phelan, Michael wrote: -Original Message- From: Maxime Coquelin Sent: Monday 19 September 2022 12:39 To: Phelan, Michael ; d...@openvswitch.org Cc: i.maxim...@ovn.org Subject: Re:

[ovs-dev] [OVSDPDK]A Question about how enic ig-vlan-rewrite parameter to pass down to dpdk driver

2022-09-20 Thread Harley Zhang (mengxzha) via dev
Hi, Team. We are using ovs2.13 and dpdk 19.11 from official github repo to build ovsdpdk container in our deployment. For Enic dpdk driver, the ig-vlan-rewrite is using `pass` as default, and it will not attach the header the packet, keep the vlan through the nic to ovs. For enic it will

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

2022-09-20 Thread Kevin Traynor
On 20/09/2022 10:38, Maxime Coquelin wrote: On 9/20/22 11:28, Phelan, Michael wrote: -Original Message- From: Maxime Coquelin Sent: Monday 19 September 2022 12:39 To: Phelan, Michael ; d...@openvswitch.org Cc: i.maxim...@ovn.org Subject: Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

2022-09-20 Thread Kevin Traynor
On 20/09/2022 10:28, Phelan, Michael wrote: -Original Message- From: Maxime Coquelin Sent: Monday 19 September 2022 12:39 To: Phelan, Michael ; d...@openvswitch.org Cc: i.maxim...@ovn.org Subject: Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release. On 9/16/22 16:23, Michael Phelan

[ovs-dev] [PATCH v2] utilities: Add revalidator measurement script and needed USDT probes.

2022-09-20 Thread Eelco Chaudron
This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. Signed-off-by: Eelco Chaudron --- v2: Added note that script only

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack

2022-09-20 Thread alinserdean
Sorry about the spam! I got an SMTP error through my OVN email and wasn't sure which email got out. -Original Message- From: Ilya Maximets Sent: Tuesday, September 20, 2022 12:24 PM To: alinserd...@gmail.com; d...@openvswitch.org Cc: 'ldejing' ; i.maxim...@ovn.org; 'ldejing' Subject:

Re: [ovs-dev] [PATCH] sparse: Add a guard for netinet/ip6.h header on FreeBSD.

2022-09-20 Thread Finn, Emma
> -Original Message- > From: Ilya Maximets > Sent: Monday 19 September 2022 12:50 > To: ovs-dev@openvswitch.org > Cc: Finn, Emma ; Ilya Maximets > Subject: [PATCH] sparse: Add a guard for netinet/ip6.h header on FreeBSD. > > Same as netinet/in.h, the netinet/ip6.h on FreeBSD requires

Re: [ovs-dev] [PATCH 1/2] net: openvswitch: allow metering in non-initial user namespace

2022-09-20 Thread Paolo Abeni
On Sun, 2022-09-11 at 19:38 +0200, Michael Weiß wrote: > The Netlink interface for metering was restricted to global CAP_NET_ADMIN > by using GENL_ADMIN_PERM. To allow metring in a non-inital user namespace, > e.g., a container, this is changed to GENL_UNS_ADMIN_PERM. > > Signed-off-by: Michael

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

2022-09-20 Thread Maxime Coquelin
On 9/20/22 11:28, Phelan, Michael wrote: -Original Message- From: Maxime Coquelin Sent: Monday 19 September 2022 12:39 To: Phelan, Michael ; d...@openvswitch.org Cc: i.maxim...@ovn.org Subject: Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release. On 9/16/22 16:23, Michael Phelan

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

2022-09-20 Thread Phelan, Michael
> -Original Message- > From: Maxime Coquelin > Sent: Monday 19 September 2022 12:39 > To: Phelan, Michael ; d...@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release. > > > > On 9/16/22 16:23, Michael Phelan wrote: > > Update OVS CLI and

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack

2022-09-20 Thread Ilya Maximets
On 9/20/22 09:12, alinserd...@gmail.com wrote: > Applied on master, thank you! Hi, Alin. Thanks for taking care of these! Though, I suppose, you didn't meant to reply to the same patch multiple times? :) Best regards, Ilya Maximets. > > -Original Message- > From: dev On Behalf Of

[ovs-dev] [PATCH] utilities: Add revalidator measurement script and needed USDT probes.

2022-09-20 Thread Eelco Chaudron
This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. Signed-off-by: Eelco Chaudron --- I'm planning a blog post to explain

Re: [ovs-dev] [PATCH] lib: Add support for sets of UUIDs.

2022-09-20 Thread Ales Musil
On Fri, Sep 16, 2022 at 5:50 PM Dumitru Ceara wrote: > Part of the uuidset implementation is taken from the OVN codebase where > it was added via commit 0e77b3bcbfe2 ("ovn-northd-ddlog: New > implementation of ovn-northd based on ddlog."). > > We now extend that, adding a few helpers and tests.

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack

2022-09-20 Thread alinserdean
Applied on master, thank you! -Original Message- From: dev On Behalf Of ldejing via dev Sent: Friday, September 16, 2022 10:53 AM To: d...@openvswitch.org Cc: ldejing Subject: [ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack From: ldejing This

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack

2022-09-20 Thread alinserdean
I updated the documentation and NEWS and applied on master. Thank you for all the work! Alin. -Original Message- From: dev On Behalf Of ldejing via dev Sent: Friday, September 16, 2022 10:53 AM To: d...@openvswitch.org Cc: ldejing Subject: [ovs-dev] [PATCH v2 1/1] datapath-windows:

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: support meter action initial version

2022-09-20 Thread alinserdean
Fixed the rebase, an include statement and applied on master. Thank you for all the work and testing! Alin. -Original Message- From: dev On Behalf Of ldejing via dev Sent: Thursday, August 18, 2022 2:11 PM To: d...@openvswitch.org Cc: ldejing Subject: [ovs-dev] [PATCH v2 1/1]

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack

2022-09-20 Thread alinserdean
I updated the documentation and NEWS and applied on master. Thank you for all the work! Alin. -Original Message- From: dev On Behalf Of ldejing via dev Sent: Friday, September 16, 2022 10:53 AM To: d...@openvswitch.org Cc: ldejing Subject: [ovs-dev] [PATCH v2 1/1] datapath-windows:

Re: [ovs-dev] [PATCH ovn 6/6] Add connectivity test for 2 controllers on the same host

2022-09-20 Thread Ales Musil
On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka wrote: > Signed-off-by: Ihar Hrachyshka > --- > tests/ovn.at | 124 +++ > 1 file changed, 124 insertions(+) > > diff --git a/tests/ovn.at b/tests/ovn.at > index cd4561069..564a5c149 100644 > ---

Re: [ovs-dev] [PATCH ovn 5/6] Don't touch tunnel ports from a different br-int

2022-09-20 Thread Ales Musil
On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka wrote: > When multiple controllers are running using the same vswitchd, > controllers should delete only those tunnel ports that belong to the > integration bridge that is managed by the controller instance. > > This makes sure multiple controllers

Re: [ovs-dev] [PATCH ovn 4/6] Support passing chassis name via CLI

2022-09-20 Thread Ales Musil
On Tue, Sep 20, 2022 at 2:09 AM Ihar Hrachyshka wrote: > On Mon, Sep 19, 2022 at 8:05 PM Ihar Hrachyshka > wrote: > > > > This patch adds support for the desired system-id (chassis name) to be > > passed via CLI: > > > > $ ovn-controller -n > > > > If passed, CLI overrides any settings stored

Re: [ovs-dev] [PATCH ovn 3/6] Allow to override system-id via file

2022-09-20 Thread Ales Musil
On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka wrote: > Before the patch, system-id could be configured via a global config > option in ovsdb. This patch adds another option - configure system-id > via a file. This is achieved by writing the desired system-id into the > following file location:

Re: [ovs-dev] [PATCH ovn 2/6] Support ovn-...- specific global ovsdb options

2022-09-20 Thread Ales Musil
Hi Ihar, see some comments below. On Tue, Sep 20, 2022 at 2:05 AM Ihar Hrachyshka wrote: > Before the patch, all controller instances were reading configuration > from the same external-ids:ovn-* options. This patch adds support for > distinct config otions for different chassis names stored