From: Thilak Raj Surendra Babu
For SDN workloads that deal with Guest across NUMAs and Multiple Queues being
serviced by different PMD due to the high Capacity of the NIC,Packets
belonging to the same flow can land on different RXQs or an undesirable
RXQ(PMD in a different NUMA than the Guests NU
On Mon, Oct 17, 2022 at 9:19 AM Adrian Moreno wrote:
>
> returning None in a constructor does not make sense and is just error
> prone. Removing what was a lefover from an attempt to handle a common
> error case of trying to parse what is commonly outputted by ovs-ofctl.
> This should be done by
On Mon, Oct 17, 2022 at 9:19 AM Adrian Moreno wrote:
>
> Sometimes we don't want to return the result of a nested key-value
> decoding as a dictionary but as a list of dictionaries. This happens
> when we parse actions where keys can be repeated.
>
> Refactor code that already takes that into acco
On Mon, Oct 17, 2022 at 9:19 AM Adrian Moreno wrote:
>
> Create a small helper script and check that flows tested in odp.at are
> parseable.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://ma
On Mon, Oct 17, 2022 at 9:19 AM Adrian Moreno wrote:
>
> Create a small helper script and check that flows used in ofp-actions.at
> are parseable.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
http
On Mon, Oct 17, 2022 at 9:18 AM Adrian Moreno wrote:
>
> Currently, if a key is not found in the decoder information, we use the
> default decoder which typically returns a string.
>
> This not only means we can go out of sync with the C code without
> noticing but it's also error prone as malform
On 7 Nov 2022, at 12:44, Roi Dayan wrote:
> On 05/09/2022 16:11, Eelco Chaudron wrote:
>> The goal was to run 200 successful tc tests in a row. To do this the
>> following was run:
>>
>> for i in {1..200}; do make check-offloads TESTSUITEFLAGS="50" && break; \
>> echo "ALL_200_OK: $i"; do
On Mon, Oct 17, 2022 at 9:18 AM Adrian Moreno wrote:
>
> We were silently relying on some ofp actions to be decoded by the
> default decoder which would yield decent string values.
>
> In order to be more safe and robust, add an explicit decoder for all
> missing actions.
>
> This patch also rewor
On Mon, Oct 17, 2022 at 9:18 AM Adrian Moreno wrote:
>
> Fix the following erros in odp decoding:
> - Missing push_mpls action
> - Typos in collector_set_id, tp_src/tp_dst and csum
> - Missing two fields in vxlan match
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
__
On Fri, Nov 4, 2022 at 6:02 PM Adrian Moreno wrote:
>
> Currently, things like the number of handler and revalidator threads are
> calculated based on the number of available CPUs. However, this number
> is considered static and only calculated once, hence ignoring events
> such as cpus being hotp
When the input character string is a number greater than UINT_MAX，it
should return an error.
Signed-off-by: liangmc1
---
lib/ofp-parse.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index a90b926ef..6d6a79bcc 100644
--- a/lib/ofp-parse
Hello!
I have been experimenting with conntrack support in OvS, trying to run
the firewall example from the ovs-actions man page:
table=0,priority=1,action=drop
table=0,priority=10,arp,action=normal
table=0,priority=100,ip,ct_state=-trk,action=ct(table=1)
table=1,in
From: Igor Zhukov
Also add python 3.11
Just a some cleanup of the commit:
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
inde
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch failed: m4/ovn.m4:303
error: m4/ovn.m4: patch does not apply
error: Did you hand edit y
From: Igor Zhukov
Also add python 3.11
Just a some cleanup of the commit:
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
inde
From: Igor Zhukov
Also add python 3.11
Just a some cleanup of the commit:
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
inde
On Mon, Nov 07, 2022 at 05:38:04AM -0500, Simon Horman wrote:
> On Sun, Nov 06, 2022 at 08:29:57PM +0100, Ilya Maximets wrote:
> > On 11/5/22 06:19, Justin Pettit wrote:
> > > I assume someone else will pull this in as part of the patch set, so:
> > >
> > > Acked-by: Justin Pettit
> >
> > Thanks
On 05/09/2022 16:11, Eelco Chaudron wrote:
> The goal was to run 200 successful tc tests in a row. To do this the
> following was run:
>
> for i in {1..200}; do make check-offloads TESTSUITEFLAGS="50" && break; \
> echo "ALL_200_OK: $i"; done;
>
is there a typo in the loop example?
Usin
On 05/09/2022 16:11, Eelco Chaudron wrote:
> With some datapaths, read TC, it takes a bit longer to update the
> OpenFlow statistics. Rather than adding an additional delay, try
> to read the counters multiple times until we get the desired value.
>
> Signed-off-by: Eelco Chaudron
> ---
> tes
On 11/7/22 12:31, Dumitru Ceara wrote:
> On 11/2/22 16:57, Lorenzo Bianconi wrote:
>> Rely on the following new actions in order to introduce affinity timeout
>> support to load-balancer sessions:
>> - commit_lb_aff
>> - chk_lb_aff
>>
>> Introduce the following tables in switch and router pipelines
On 11/2/22 16:57, Lorenzo Bianconi wrote:
> Rely on the following new actions in order to introduce affinity timeout
> support to load-balancer sessions:
> - commit_lb_aff
> - chk_lb_aff
>
> Introduce the following tables in switch and router pipelines
> respectively:
> - S_SWITCH_IN_LB_AFF_CHECK
On 05/09/2022 16:10, Eelco Chaudron wrote:
> If a tc flow was installed but has not yet been used, report it as such.
>
> In addition, add a delay to the "IGMP - flood under normal action" test
> case to make it work with many repetitions. This delay is also present
> in other ICMP/IGMP tests.
On Sun, Nov 06, 2022 at 08:29:57PM +0100, Ilya Maximets wrote:
> On 11/5/22 06:19, Justin Pettit wrote:
> > I assume someone else will pull this in as part of the patch set, so:
> >
> > Acked-by: Justin Pettit
>
> Thanks!
>
> >
> > Ilya, let me know if you'd like me to merge it, though.
>
> I
On 05/09/2022 16:10, Eelco Chaudron wrote:
> Make the order of the Netlink attributes for odp_flow_key_from_flow__()
> the same as the kernel will return them.
>
> This will make sure the attributes displayed in the dpctl/dump-flows
> output appear in the same order for all datapath.
>
> Signe
On 05/09/2022 16:09, Eelco Chaudron wrote:
> tc does not include ethernet header length in packet byte count.
> This fix will allow the packets that go trough tc to be 14 bytes less.
>
> This difference in the TC implementation is already described in
> tc-offload.rst.
>
> Signed-off-by: Eelco
On 05/09/2022 16:09, Eelco Chaudron wrote:
> The tc conntrack implementation does not support the timeout option.
> The current implementation is silently ignoring the timeout option
> by adding a general conntrack entry.
>
> This patch will skip the related test by overriding the support macro
On 05/09/2022 16:09, Eelco Chaudron wrote:
> tc does not support conntrack ALGs. Even worse, with tc enabled, they
> should not be used/configured at all. This is because even though TC
> will ignore the rules with ALG configured, i.e., they will flow through
> the kernel module, return traffic
On 05/09/2022 16:08, Eelco Chaudron wrote:
> Flush datapath flows as TC flows take some more time to be flushed out.
> The flush speeds this up.
>
> Signed-off-by: Eelco Chaudron
> ---
> tests/system-offloads-testsuite.at |2 --
> tests/system-traffic.at|6 ++
> 2 file
On 05/09/2022 16:08, Eelco Chaudron wrote:
> This change fixes the "conntrack - floating" test for the TC
> offload case. In this scenario, the connection might move to
> CLOSE_WAIT, which would fail the test as it only accepts
> TIME_WAIT. However, both indicate the connection was
> established
From: Igor Zhukov
Signed-off-by: Igor Zhukov
---
m4/ovn.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/ovn.m4 b/m4/ovn.m4
index bc2ac1aef..6667e5e4d 100644
--- a/m4/ovn.m4
+++ b/m4/ovn.m4
@@ -303,13 +303,13 @@ AC_DEFUN([OVN_CHECK_VALGRIND],
dnl Checks for Python
On 05/09/2022 16:08, Eelco Chaudron wrote:
> This patch adds a delay before dumping the conntrack table because with
> tc it takes a bit longer before it gets synced.
>
> Signed-off-by: Eelco Chaudron
> ---
> tests/system-common-macros.at |3 +
> tests/system-offloads-testsuite.at |
On 05/09/2022 16:08, Eelco Chaudron wrote:
> tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced
> commit was requested. This patch will fix this.
>
> Signed-off-by: Eelco Chaudron
> ---
> lib/netdev-offload-tc.c| 13 +++--
> tests/system-offloads-testsuit
On 05/09/2022 16:07, Eelco Chaudron wrote:
> The revalidator/purge commands in the system test cases sometimes
> get called immediately after a partial test is completed. This
> could cause the revalidator thread to log an error that it can
> not find/delete a flow due to the slower flow install
On 05/09/2022 16:07, Eelco Chaudron wrote:
> TC flower does not allow the push of the implicit null labels (RFC3032).
> Avoid the use of such labels in the MPLS test cases.
>
> Signed-off-by: Eelco Chaudron
> ---
> tests/system-offloads-testsuite.at |2 --
> tests/system-traffic.at
On 05/09/2022 16:07, Eelco Chaudron wrote:
> Include and run the system-traffic.at tests as part of the system offload
> testsuite. Exclude all the tests that will not run without any special
> modifications.
>
> Signed-off-by: Eelco Chaudron
> ---
> tests/system-offloads-testsuite.at | 93
On 05/09/2022 16:07, Eelco Chaudron wrote:
> When the test description is part of the OVS_TEST_SKIP_LIST
> variable, the test is skipped.
>
> Signed-off-by: Eelco Chaudron
> ---
> tests/ofproto-macros.at |5 -
> tests/ovs-macros.at |7 +++
> 2 files changed, 11 insertions(
36 matches
Mail list logo
