[ovs-dev] [PATCH v4] tc: Add support for TCA_STATS_PKT64

Currently tc offload flow packet counters will roll over every ~4 billion packets. This is because the packet counter in struct tc_stats provided by TCA_STATS_BASIC is a 32bit integer. Now we check for the optional TCA_STATS_PKT64 attribute which provides the full 64bit packet counter if the

[ovs-dev] [PATCH net] net: openvswitch: release vport resources on failure

A recent commit introducing upcall packet accounting failed to properly release the vport object when the per-cpu stats struct couldn't be allocated. This can cause dangling pointers to dp objects long after they've been released. Cc: Eelco Chaudron Cc: wangchuanlei Fixes: 1933ea365aa7 ("net:

Re: [ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.3.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.4.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.4.

On 12/20/22 20:36, Aaron Conole wrote: > Ilya Maximets writes: > >> Signed-off-by: Ilya Maximets >> --- > > Acked-by: Aaron Conole Thanks! I applied all the patches now. Will update the website and send announce email soon. Best regards, Ilya Maximets. > >> NEWS | 3 +++ >>

Re: [ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.8.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index fb0a03960..8a34fbf5f 100644 > ---

Re: [ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.3.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 7 ++- > debian/changelog | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 21f56f1ec..4909b7b72 100644 > --- a/NEWS > +++ b/NEWS > @@

Re: [ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.4.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 4909b7b72..ff46fef3a 100644 > ---

Re: [ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.7.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 7 ++- > debian/changelog | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 6510dfc96..fb0a03960 100644 > --- a/NEWS > +++ b/NEWS > @@

Re: [ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.9.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 1752cdebc..8b4c64ae4 100644 > ---

Re: [ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.5.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 7 ++- > debian/changelog | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 9dd57de05..2ea9ac0c2 100644 > --- a/NEWS > +++ b/NEWS > @@

Re: [ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.8.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 7 ++- > debian/changelog | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 817249593..1752cdebc 100644 > --- a/NEWS > +++ b/NEWS > @@

Re: [ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.6.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 2ea9ac0c2..45b974ed2 100644 > ---

Re: [ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.7.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index b64bc0452..ee3855978 100644 > ---

Re: [ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.6.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 7 ++- > debian/changelog | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 331af302b..b64bc0452 100644 > --- a/NEWS > +++ b/NEWS > @@

Re: [ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.10.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 7 ++- > debian/changelog | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index fe5743bb8..a7527f135 100644 > --- a/NEWS > +++ b/NEWS > @@

Re: [ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.11.

Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index a7527f135..7e80b57dc 100644 > ---

[ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.4.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 4909b7b72..ff46fef3a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.0.4 - xx xxx

[ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.3.

Signed-off-by: Ilya Maximets --- NEWS | 7 ++- debian/changelog | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 21f56f1ec..4909b7b72 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,10 @@ -v3.0.3 - xx xxx +v3.0.3 - 20 Dec 2022

[ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.5.

Bug fixes + Security issue in LLDP. Ilya Maximets (2): Set release date for 2.17.5. Prepare for 2.17.6. NEWS | 10 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 17 insertions(+), 3 deletions(-) -- 2.38.1

[ovs-dev] [PATCH branch-3.0 0/2] Release patches for v3.0.3.

Bug fixes + Security issue in LLDP. Ilya Maximets (2): Set release date for 3.0.3. Prepare for 3.0.4. NEWS | 10 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 17 insertions(+), 3 deletions(-) -- 2.38.1

[ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.6.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2ea9ac0c2..45b974ed2 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.17.6 - xx xxx

[ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.7.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b64bc0452..ee3855978 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.16.7 - xx xxx

[ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.5.

Signed-off-by: Ilya Maximets --- NEWS | 7 ++- debian/changelog | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 9dd57de05..2ea9ac0c2 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,10 @@ -v2.17.5 - xx xxx +v2.17.5 - 20 Dec 2022

[ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.6.

Bug fixes + Security issue in LLDP. Ilya Maximets (2): Set release date for 2.16.6. Prepare for 2.16.7. NEWS | 10 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 17 insertions(+), 3 deletions(-) -- 2.38.1

[ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.6.

Signed-off-by: Ilya Maximets --- NEWS | 7 ++- debian/changelog | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 331af302b..b64bc0452 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,10 @@ -v2.16.6 - xx xxx +v2.16.6 - 20 Dec 2022

[ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.8.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index fb0a03960..8a34fbf5f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.15.8 - xx xxx

[ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.7.

Signed-off-by: Ilya Maximets --- NEWS | 7 ++- debian/changelog | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6510dfc96..fb0a03960 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,10 @@ -v2.15.7 - xx xxx +v2.15.7 - 20 Dec 2022

[ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.7.

Bug fixes + Security issue in LLDP. Ilya Maximets (2): Set release date for 2.15.7. Prepare for 2.15.8. NEWS | 10 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 17 insertions(+), 3 deletions(-) -- 2.38.1

[ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.9.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1752cdebc..8b4c64ae4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.14.9 - xx xxx

[ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.8.

Signed-off-by: Ilya Maximets --- NEWS | 7 ++- debian/changelog | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 817249593..1752cdebc 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,10 @@ -v2.14.8 - xx xxx +v2.14.8 - 20 Dec 2022

[ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.8.

Bug fixes + Security issue in LLDP. Ilya Maximets (2): Set release date for 2.14.8. Prepare for 2.14.9. NEWS | 10 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 17 insertions(+), 3 deletions(-) -- 2.38.1

[ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.11.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a7527f135..7e80b57dc 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.13.11 - xx xxx

[ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.10.

Signed-off-by: Ilya Maximets --- NEWS | 7 ++- debian/changelog | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index fe5743bb8..a7527f135 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,10 @@ -v2.13.10 - xx xxx +v2.13.10 - 20 Dec 2022

[ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.10.

Bug fixes + Security issue in LLDP. Ilya Maximets (2): Set release date for 2.13.10. Prepare for 2.13.11. NEWS | 10 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 17 insertions(+), 3 deletions(-) -- 2.38.1

Re: [ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

Ilya Maximets writes: > On 12/20/22 15:36, Aaron Conole wrote: >> The OVS LLDP implementation includes support for AutoAttach standard, which >> the 'upstream' lldpd project does not include. As part of adding this >> support, the message parsing for these TLVs did not include proper length >>

Re: [ovs-dev] [PATCH v2] dpif-netdev: Load based PMD sleeping.

On 19/12/2022 16:18, Ilya Maximets wrote: On 12/16/22 18:50, Kevin Traynor wrote: Sleep for an incremental amount of time if none of the Rx queues assigned to a PMD have at least half a batch of packets (i.e. 16 pkts) on an polling iteration of the PMD. Upon detecting the threshold of >= 16

Re: [ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

On 12/20/22 15:36, Aaron Conole wrote: > The OVS LLDP implementation includes support for AutoAttach standard, which > the 'upstream' lldpd project does not include. As part of adding this > support, the message parsing for these TLVs did not include proper length > checks for the

[ovs-dev] [PATCH v3] stream-ssl: fix setting key and certificate

stream_ssl_set_key_and_cert is supposed to, whenever either the certificate or the private key file changes, re-read both of them. It was re-reading them only when both changed. So, if, for instance, certificate was changed a few seconds only after changing the key, the new key and certificate

[ovs-dev] [syzbot] KASAN: use-after-free Read in ovs_vport_locate

Hello, syzbot found the following issue on: HEAD commit:041fae9c105a Merge tag 'f2fs-for-6.2-rc1' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15c5d02048 kernel config: https://syzkaller.appspot.com/x/.config?x=836aafbf33f4fa6c

Re: [ovs-dev] [PATCH] Revert "rhel: Move conf.db to /var/lib/openvswitch, using symlinks."

On 12/15/22 14:05, Ilya Maximets wrote: > This reverts commit 59e8cb8a053d50f49629be8b6fd614562d066404. > > Commit broke the package install on a clean system and also doesn't > seem to manage access rights for created symlinks correctly. > > Revert it until a proper solution is proposed. > >

Re: [ovs-dev] [ovs-dev v7 1/3] ofproto-dpif-upcall: fix push_dp_ops

On 19 Dec 2022, at 11:52, Peng He wrote: > Eelco Chaudron 于2022年12月16日周五 23:00写道： > >> >> >> On 16 Dec 2022, at 8:56, Peng He wrote: >> >>> From: Peng He >>> To: Eelco Chaudron >>> Cc: Ilya Maximets , ovs-dev@openvswitch.org >>> Subject: Re: [ovs-dev v7 1/3] ofproto-dpif-upcall: fix

Re: [ovs-dev] [PATCH v2 2/7] netdev-afxdp: Allow building with libxdp and newer libbpf.

On 20 Dec 2022, at 14:58, Ilya Maximets wrote: > On 12/20/22 14:01, Eelco Chaudron wrote: >> >> >> On 19 Dec 2022, at 13:20, Ilya Maximets wrote: >> >>> AF_XDP functions was deprecated in libbpf 0.7 and moved to libxdp. >>> Functions bpf_get/set_link_xdp_id() was deprecated in libbpf 0.8 >>>

Re: [ovs-dev] [PATCH ovn 1/2] .ci: ovn-kubernetes: Add a "prepare" stage to allow for custom actions.

On 12/20/22 16:30, Dumitru Ceara wrote: > One example is to allow us to change the ovn-kubernetes code that > decides what e2e tests are run. That's needed on older stable branches > that don't support all the features that newer OVN versions do. > > Currently, on the main branch, there's no

Re: [ovs-dev] [PATCH ovn 2/2] .ci: ovn-kubernetes: Skip session affinity related tests.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #43

Re: [ovs-dev] [syzbot] KASAN: use-after-free Read in ovs_vport_locate

Paolo Abeni writes: > On Tue, 2022-12-20 at 00:22 -0800, syzbot wrote: >> HEAD commit:041fae9c105a Merge tag 'f2fs-for-6.2-rc1' of git://git.ker.. >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=15c5d02048 >> kernel config:

[ovs-dev] [PATCH ovn 2/2] .ci: ovn-kubernetes: Skip session affinity related tests.

The OVN feature used to implement session affinity timeout doesn't exist on this branch. ovn-kubernetes code already moved to implementing the feature by using the newer OVN option so, in order to keep testing as many features as possible in CI, we now disable all session affinity tests (but keep

[ovs-dev] [PATCH ovn 1/2] .ci: ovn-kubernetes: Add a "prepare" stage to allow for custom actions.

One example is to allow us to change the ovn-kubernetes code that decides what e2e tests are run. That's needed on older stable branches that don't support all the features that newer OVN versions do. Currently, on the main branch, there's no custom change required but on older branches

[ovs-dev] [PATCH ovn 0/2] Fix ovn-kubernetes CI jobs on stable branches.

The first patch of the series adds a mechanism to do custom changes to the ovn-kubernetes code to be used in CI. That's needed because ovn-kubernetes might be using OVN features that are not present on all OVN stable branches. It is however desirable to run the most recent version of

Re: [ovs-dev] [PATCH v5] ovs-thread: Detect changes in number of cpus

On 12/19/22 19:29, Adrian Moreno wrote: > Currently, things like the number of handler and revalidator threads are > calculated based on the number of available CPUs. However, this number > is considered static and only calculated once, hence ignoring events > such as cpus being hotplugged,

Re: [ovs-dev] [PATCH v2] ovs-ctl: Allow inclusion of hugepages in coredumps

On 12/19/22 15:28, David Marchand wrote: > On Mon, Dec 19, 2022 at 2:39 PM Mike Pattrick wrote: >> >> Add new option --dump-hugepages option in ovs-ctl to enable the addition >> of hugepages in the core dump filter. >> >> Signed-off-by: Mike Pattrick > > LGTM. > Reviewed-by: David Marchand

Re: [ovs-dev] [PATCH v3] dpif-netdev: Use unmasked key when adding datapath flows.

On 11/28/22 09:53, Eelco Chaudron wrote: > The datapath supports installing wider flows, and OVS relies on > this behavior. For example if ipv4(src=1.1.1.1/192.0.0.0, > dst=1.1.1.2/192.0.0.0) exists, a wider flow (smaller mask) of > ipv4(src=192.1.1.1/128.0.0.0,dst=192.1.1.2/128.0.0.0) is allowed

Re: [ovs-dev] [PATCH] utilities: Add a GDB macro to dump hmap structures.

On 12/7/22 17:26, Eelco Chaudron wrote: > Add a new GDB macro called ovs_dump_hmap, which can be used to dump any > cmap structure. For example > > (gdb) ovs_dump_hmap "&'all_bridges.lto_priv.0'" "struct bridge" "node" > (struct bridge *) 0x55ec43069c70 > (struct bridge *) 0x55ec430428a0 >

Re: [ovs-dev] [PATCH] dpdk: Fix typo in v22.11.1 tarball extract example.

On 12/8/22 09:06, David Marchand wrote: > There was a small typo that slipped in when updating to v22.11.1 tag. > > Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") > Signed-off-by: David Marchand > --- > Documentation/intro/install/dpdk.rst | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH] rhel: avoid creating an empty database file

On 12/19/22 13:23, Ilya Maximets wrote: > On 12/16/22 16:29, Timothy Redaelli wrote: >> In 59e8cb8a053d ("rhel: Move conf.db to /var/lib/openvswitch, using >> symlinks.") >> conf.db is created as empty file in /var/lib/openvswitch, if it doesn't >> exists, but this prevent ovsdb-server to start.

Re: [ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author should not be also be co-author. Lines checked: 80, Warnings: 0, Errors: 1

Re: [ovs-dev] [PATCH v2 2/7] netdev-afxdp: Allow building with libxdp and newer libbpf.

On 12/20/22 14:14, Eelco Chaudron wrote: > > > On 20 Dec 2022, at 14:06, David Marchand wrote: > >> On Tue, Dec 20, 2022 at 2:01 PM Eelco Chaudron wrote: >>> I have problems building this on my fedora35 system with >>> gcc-11.3.1-3.fc35.x86_64: >>> >>> libtool: link: ( cd

[ovs-dev] [PATCH v2] lldp: fix bugs when parsing malformed AutoAttach

The OVS LLDP implementation includes support for AutoAttach standard, which the 'upstream' lldpd project does not include. As part of adding this support, the message parsing for these TLVs did not include proper length checks for the LLDP_TLV_AA_ELEMENT_SUBTYPE and the

Re: [ovs-dev] [PATCH v6] revalidator: add a USDT probe after evaluation when flows are deleted.

On 20 Dec 2022, at 15:21, Eelco Chaudron wrote: > On 16 Nov 2022, at 16:41, Eelco Chaudron wrote: > >> On 21 Oct 2022, at 18:35, Kevin Sprague wrote: >> >>> During normal operations, it is useful to understand when a particular flow >>> gets removed from the system. This can be useful when

Re: [ovs-dev] [ovs-security] [PATCH] lldp: fix bugs when parsing malformed AutoAttach

Ilya Maximets writes: > On 12/19/22 20:27, Aaron Conole wrote: >> From: Qian Chen >> >> The OVS LLDP implementation includes support for AutoAttach standard, which >> the 'upstream' lldpd project does not include. As part of adding this >> support, the message parsing for these TLVs did not

Re: [ovs-dev] [PATCH v2 7/7] rhel: Enable AF_XDP by default in Fedora builds.

On 20 Dec 2022, at 14:39, Ilya Maximets wrote: > On 12/20/22 14:34, Eelco Chaudron wrote: >> >> >> On 19 Dec 2022, at 13:20, Ilya Maximets wrote: >> >>> All supported versions of Fedora do package libxdp and libbpf, so it >>> makes sense to enable AF_XDP support. >>> >>> Control files for

Re: [ovs-dev] [PATCH v6] revalidator: add a USDT probe after evaluation when flows are deleted.

On 16 Nov 2022, at 16:41, Eelco Chaudron wrote: > On 21 Oct 2022, at 18:35, Kevin Sprague wrote: > >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performance >> issues tied to ofproto flow

[ovs-dev] [PATCH v3] utilities: Add revalidator measurement script and needed USDT probes.

This patch adds a Python script that can be used to analyze the revalidator runs by providing statistics (including some real time graphs). The USDT events can also be captured to a file and used for later offline analysis. The following blog explains the Open vSwitch revalidator implementation

Re: [ovs-dev] [PATCH v2 2/7] netdev-afxdp: Allow building with libxdp and newer libbpf.

On 12/20/22 14:01, Eelco Chaudron wrote: > > > On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > >> AF_XDP functions was deprecated in libbpf 0.7 and moved to libxdp. >> Functions bpf_get/set_link_xdp_id() was deprecated in libbpf 0.8 >> and replaced with bpf_xdp_query_id() and

Re: [ovs-dev] [PATCH v2 7/7] rhel: Enable AF_XDP by default in Fedora builds.

On 12/20/22 14:34, Eelco Chaudron wrote: > > > On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > >> All supported versions of Fedora do package libxdp and libbpf, so it >> makes sense to enable AF_XDP support. >> >> Control files for debian packaging are much less flexible, so its hard >> to

Re: [ovs-dev] [PATCH v2 7/7] rhel: Enable AF_XDP by default in Fedora builds.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > All supported versions of Fedora do package libxdp and libbpf, so it > makes sense to enable AF_XDP support. > > Control files for debian packaging are much less flexible, so its hard > to enable AF_XDP builds while not breaking builds for

Re: [ovs-dev] [PATCH v2 6/7] acinclude.m4: Build with AF_XDP support by default if possible.

On 20 Dec 2022, at 14:24, Ilya Maximets wrote: > On 12/20/22 14:19, Eelco Chaudron wrote: >> >> >> On 19 Dec 2022, at 13:20, Ilya Maximets wrote: >> >>> With this change we will try to detect all the netdev-afxdp >>> dependencies and enable AF_XDP support by default if they are >>> present at

Re: [ovs-dev] [PATCH v2 6/7] acinclude.m4: Build with AF_XDP support by default if possible.

On 12/20/22 14:19, Eelco Chaudron wrote: > > > On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > >> With this change we will try to detect all the netdev-afxdp >> dependencies and enable AF_XDP support by default if they are >> present at the build time. >> >> Configuration script behaves in a

Re: [ovs-dev] [PATCH v2 6/7] acinclude.m4: Build with AF_XDP support by default if possible.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > With this change we will try to detect all the netdev-afxdp > dependencies and enable AF_XDP support by default if they are > present at the build time. > > Configuration script behaves in a following way: > > - ./configure --enable-afxdp > >

Re: [ovs-dev] [PATCH v2 2/7] netdev-afxdp: Allow building with libxdp and newer libbpf.

On 20 Dec 2022, at 14:06, David Marchand wrote: > On Tue, Dec 20, 2022 at 2:01 PM Eelco Chaudron wrote: >> I have problems building this on my fedora35 system with >> gcc-11.3.1-3.fc35.x86_64: >> >> libtool: link: ( cd "include/openvswitch/.libs" && rm -f "libcxxtest.la" && >> ln -s

Re: [ovs-dev] [PATCH v2 5/7] Documentation/afxdp: Use packaged libbpf/libxdp for the build.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > Necessary bits was removed from the kernel's libbpf in 6.0 release, > so the instructions on how to build libbpf from kernel sources are > now incorrect. Suggest to use libbpf and libxdp packaged by > distributions instead. > > Signed-off-by:

Re: [ovs-dev] [PATCH v2 2/7] netdev-afxdp: Allow building with libxdp and newer libbpf.

On Tue, Dec 20, 2022 at 2:01 PM Eelco Chaudron wrote: > I have problems building this on my fedora35 system with > gcc-11.3.1-3.fc35.x86_64: > > libtool: link: ( cd "include/openvswitch/.libs" && rm -f "libcxxtest.la" && > ln -s "../libcxxtest.la" "libcxxtest.la" ) > In file included from

Re: [ovs-dev] [PATCH v2 4/7] github: Test AF_XDP build using libbpf instead of kernel sources.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > AF_XDP bits was removed from kernel's libbpf in 6.0. libbpf > and libxdp are now primary way to build AF_XDP applications. > Most of modern distributions are already packaging some version > of libbpf, so it's better to test building with it

Re: [ovs-dev] [PATCH v2 3/7] netdev-afxdp: Hide too large memset from sparse.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > Sparse complains about 64M umem initialization. Hide it from > the checker instead of disabling a warning globally. > > SPARSE_FLAGS are kept in the CI script even though they are > empty at the moment. > > Signed-off-by: Ilya Maximets Looks

Re: [ovs-dev] [PATCH v2 2/7] netdev-afxdp: Allow building with libxdp and newer libbpf.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > AF_XDP functions was deprecated in libbpf 0.7 and moved to libxdp. > Functions bpf_get/set_link_xdp_id() was deprecated in libbpf 0.8 > and replaced with bpf_xdp_query_id() and bpf_xdp_attach/detach(). > > Updating configuration and source code

Re: [ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.2.

On 12/19/22 22:07, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.3.

On 12/19/22 22:07, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.06 2/2] Prepare for 22.06.2.

On 12/19/22 22:07, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.06 1/2] Set release date for 22.06.1.

On 12/19/22 22:07, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.09 2/2] Prepare for 22.09.2.

On 12/19/22 22:07, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.1.

On 12/19/22 22:07, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] dpif: Fix tunnel key set for IPv6 tunnels with SLOW_ACTION.

On 12/7/22 17:17, Eelco Chaudron wrote: > The dpif_execute_helper_cb() function is supposed to add the > OVS_ACTION_ATTR_SET(OVS_KEY_ATTR_TUNNEL()) action to the > list of actions when passing it down to the kernel. > > This function was only checking if the IPv4 destination > address was set,

Re: [ovs-dev] [PATCH v2 1/7] ci: Fix overriding OPTS provided from the yml.

On 19 Dec 2022, at 13:20, Ilya Maximets wrote: > For GCC builds we're overriding --disable-ssl or --enable-shared > options set up in the GHA yml file. > > Fix that by adding to EXTRA_OPTS instead. > > Fixes: 2581b0ad1159 ("travis: Combine kernel builds.") > Signed-off-by: Ilya Maximets

[ovs-dev] [PATCH v2] stream-ssl: fix setting key and certificate

stream_ssl_set_key_and_cert is supposed to, whenever either the certificate or the private key file changes, re-read both of them. It was re-reading them only when both changed. So, if, for instance, certificate was changed a few seconds only after changing the key, the new key and certificate

Re: [ovs-dev] 回复: [PATCH 6/6] ci: add the opts about ALLOW_EXPERIMENTAL_API

On Mon, Dec 19, 2022 at 03:39:50PM +0100, Ilya Maximets wrote: > On 12/17/22 07:15, Nole Zhang wrote: > > > > > >> -邮件原件- > >> 发件人: David Marchand > >> 发送时间: 2022年12月17日 4:02 > >> 收件人: Simon Horman > >> 抄送: d...@openvswitch.org; Eli Britstein ; Chaoyong He > >> ; oss-drivers ; Ilya >

Re: [ovs-dev] [PATCH] [ovs-dev v2] dpctl: Add support to count upcall packets

On 15 Dec 2022, at 2:01, wangchuanlei wrote: > Add support to count upall packets, when kmod of openvswitch upcall to > count the number of packets for upcall succeed and failed, which is a > better way to see how many packets upcalled on every interfaces. > > Signed-off-by: wangchuanlei > ---

Re: [ovs-dev] [syzbot] KASAN: use-after-free Read in ovs_vport_locate

On Tue, 2022-12-20 at 00:22 -0800, syzbot wrote: > HEAD commit:041fae9c105a Merge tag 'f2fs-for-6.2-rc1' of git://git.ker.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15c5d02048 > kernel config:

[ovs-dev] [PATCH ovs] stream-ssl: fix setting key and certificate

stream_ssl_set_key_and_cert is supposed to, whenever either the certificate or the private key file changes, re-read both of them. It was re-reading them only when both changed. So, if, for instance, certificate was changed a few seconds only after changing the key, the new key and certificate