Re: [ovs-dev] [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs

2023-02-10 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 7 Feb 2023 17:52:05 -0500 you wrote: > We've moved some duplicate code into nf_nat_ovs in: > > "net: eliminate the duplicate code in the ct nat functions of ovs and tc" > > This patchset addresses

Re: [ovs-dev] [PATCH v9 4/4] userspace: Enable L4 checksum offloading by default.

2023-02-10 Thread Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote: > From: Flavio Leitner > > The netdev receiving packets is supposed to provide the flags > indicating if the L4 checksum was verified and it is OK or BAD, > otherwise the stack will check when appropriate by software. > > If the packet comes with good

Re: [ovs-dev] [PATCH v9 3/4] userspace: Enable IP checksum offloading by default.

2023-02-10 Thread Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote: > From: Flavio Leitner > > The netdev receiving packets is supposed to provide the flags > indicating if the IP checksum was verified and it is GOOD or BAD, > otherwise the stack will check when appropriate by software. > > If the packet comes with good

Re: [ovs-dev] [PATCH v9 2/4] dpif-netdev: Show netdev offloading flags.

2023-02-10 Thread Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote: > From: Flavio Leitner > > This patch introduces a command to display the current checksum offload > status by port, allowing the user to gain insight into where checksum > offloading is active. Hi, Mike and Flavio. I'm not sure if we need a new comand

Re: [ovs-dev] [PATCH v9 1/4] Documentation: Document netdev offload.

2023-02-10 Thread Ilya Maximets
Hi, Mike and Flavio. On 11/24/22 06:30, Mike Pattrick wrote: > From: Flavio Leitner > > Document the implementation of netdev hardware offloading s/netdev hardware offloading/checksum offloading/ More on that below. > in userspace datapath. > > Signed-off-by: Flavio Leitner >

[ovs-dev] [PATCH ovn] docs: fix the max number of ports per network for vxlan

2023-02-10 Thread Ihar Hrachyshka
Since only 11-bits are available for port tunnel_keys, it's only 2048 ids available, not 4096. The rest of the ID range is reserved to handle multicast. Signed-off-by: Ihar Hrachyshka --- ovn-architecture.7.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH v3] ovsdb-server: Fix handling of DNS name for listener configuration.

2023-02-10 Thread Ilya Maximets
On 2/9/23 08:48, Frode Nordahl wrote: > Commit 08e9e5337383 fixed proper initialization of the dns-resolve > module, and made DNS resolution asynchronous. > > A side effect of that change revealed a long standing logic bug > which broke ovsdb-server listener configuration using DNS names. > >

Re: [ovs-dev] [PATCH v2] sparse: Fix build with DPDK and GCC 12.

2023-02-10 Thread Ilya Maximets
On 2/9/23 13:57, David Marchand wrote: > rte_vect.h pulls some AVX512 instrinsics headers added in GCC 12 [1] > trigger a lot of warnings: > > libtool: compile: env "REAL_CC=ccache gcc" "CHECK=sparse -Wsparse-error > -I ../include/sparse -I ../include -m64 -I /usr/local/include > "

Re: [ovs-dev] [PATCH v2] utilities: add support to set umask in ovs-ctl

2023-02-10 Thread Eelco Chaudron
On 10 Feb 2023, at 17:06, Vladislav Odintsov wrote: > Thanks Eelco, > > requested changes addressed here: > > https://patchwork.ozlabs.org/project/openvswitch/patch/20230210160229.3689298-1-odiv...@gmail.com/ > Thanks for the heads up. I will try to take a loot at it next week. //Eelco >>

Re: [ovs-dev] [PATCH v2] utilities: add support to set umask in ovs-ctl

2023-02-10 Thread Vladislav Odintsov
Thanks Eelco, requested changes addressed here: https://patchwork.ozlabs.org/project/openvswitch/patch/20230210160229.3689298-1-odiv...@gmail.com/ > On 10 Feb 2023, at 11:21, Eelco Chaudron wrote: > > > > On 8 Feb 2023, at 16:22, Vladislav Odintsov wrote: > >> This patch adds new ovs-ctl

[ovs-dev] [PATCH v3 2/2] ipfix: make template and stats interval configurable

2023-02-10 Thread Adrián Moreno
From: Adrian Moreno Add options to the IPFIX table configure the interval to send statistics and template information. Signed-off-by: Adrian Moreno --- - v3: - Removed unit tests which generate errors in Intel CI. Will submit in independent series. - v2: - Fixed a potential race

[ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-10 Thread Adrián Moreno
From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge sampling where there is only one Observation Domain ID per exporter. However, this is does not work for per-flow

[ovs-dev] [PATCH v3] utilities: add support to set umask in ovs-ctl

2023-02-10 Thread Vladislav Odintsov
This patch adds new ovs-ctl options to pass umask configuration to allow OVS daemons set requested socket permissions on group. Previous behaviour (if using with systemd service unit) created sockets with 0750 permissions mask (group has no write permission). Write permission for group is

Re: [ovs-dev] [PATCH v2 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-10 Thread Simon Horman
On Fri, Feb 10, 2023 at 12:30:58PM +0100, Adrian Moreno wrote: > > > On 1/25/23 16:35, Simon Horman wrote: > > On Tue, Jan 24, 2023 at 08:21:28PM +0100, Adrián Moreno wrote: > > > From: Adrian Moreno > > > > > > IPFIX templates have to be sent for each Observation Domain ID. > > > Currently, a

Re: [ovs-dev] [PATCH v3 ovn] Add IPv6 support for lb health-check

2023-02-10 Thread Ales Musil
On Fri, Feb 10, 2023 at 12:18 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health > check support. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094 > Acked-by: Mark Michelson > Signed-off-by: Lorenzo

Re: [ovs-dev] [PATCH v2 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-10 Thread Adrian Moreno
On 1/25/23 16:35, Simon Horman wrote: On Tue, Jan 24, 2023 at 08:21:28PM +0100, Adrián Moreno wrote: From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge

Re: [ovs-dev] [PATCH v2 2/2] route-table: Retrieving the preferred source address from Netlink.

2023-02-10 Thread Eelco Chaudron
On 7 Feb 2023, at 7:48, Nobuhiro MIKI wrote: > We can use the "ip route add ... src ..." command to set the preferred > source address for each entry in the kernel FIB. OVS has a mechanism to > cache the FIB, but the preferred source address is ignored and > calculated with its own logic. This

[ovs-dev] [PATCH v3 ovn] Add IPv6 support for lb health-check

2023-02-10 Thread Lorenzo Bianconi
Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health check support. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094 Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi --- Changes since v2: - cosmetics Changes since v1: - fix potential crash in ovn-northd

Re: [ovs-dev] [PATCH v2 1/2] ovs-router: Introduce src option in ovs/route/add command.

2023-02-10 Thread Eelco Chaudron
On 7 Feb 2023, at 7:48, Nobuhiro MIKI wrote: > When adding a route with ovs/route/add command, the source address > in "ovs_router_entry" structure is always the FIRST address that the > interface has. See "ovs_router_get_netdev_source_address" > function for more information. > > If an

Re: [ovs-dev] [PATCH v2 ovn] Add IPv6 support for lb health-check

2023-02-10 Thread Lorenzo Bianconi
> On Fri, Dec 16, 2022 at 6:06 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health > > check support. > > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094 > > Signed-off-by: Lorenzo Bianconi >

Re: [ovs-dev] [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs

2023-02-10 Thread Florian Westphal
Jakub Kicinski wrote: > On Tue, 7 Feb 2023 17:52:05 -0500 Xin Long wrote: > > We've moved some duplicate code into nf_nat_ovs in: > > > > "net: eliminate the duplicate code in the ct nat functions of ovs and tc" > > > > This patchset addresses more code duplication in the conntrack of ovs >

[ovs-dev] [PATCH ovn] controller: Prevent race in packet buffering

2023-02-10 Thread Ales Musil
There was a race within packet buffering that could result in first packt being dropped. It could happen under following conditions and topology: S1 == R1 == public == R2 == S2 SNAT on R1 and DGP on port connecting R1 with public. 1) The GARP is sent for the GDP SNAT 2) The GARP is delayed on R2

[ovs-dev] [PATCH ovn] ovn-nbctl: Fix documentation typo

2023-02-10 Thread Ales Musil
Reported-at: https://bugzilla.redhat.com/2168009 Signed-off-by: Ales Musil --- utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml index 92e10c012..72d4088f0 100644 --- a/utilities/ovn-nbctl.8.xml +++

[ovs-dev] [PATCH ovn v2] utilities: Add simple container automation

2023-02-10 Thread Ales Musil
Add simple script that allows user to run tests and builds using container. At the same time add example Dockerfile for Fedora 37. Basic usage is: ./utilities/containers/ci.sh This will compile the project with GCC, it expects podman as container platform with default image being

[ovs-dev] [PATCH ovn 1/2] northd: Move en_mac_binding_aging under en_northd_output

2023-02-10 Thread Ales Musil
The en_northd_output does not produce any output and server as "dummy" to avoid run of multiple engines. Move en_mac_binding_aging under this node, because mac_binding_aging does not have any dependency. Signed-off-by: Ales Musil --- northd/en-northd-output.c | 8

[ovs-dev] [PATCH ovn 2/2] controller: Rename flow_output node to controller_output

2023-02-10 Thread Ales Musil
The keep the naming of the "dummy" nodes aligned use controller_output, because we have northd_output in northd. Signed-off-by: Ales Musil --- controller/ovn-controller.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git

[ovs-dev] [PATCH ovn 0/2] Unify the naming of inc engine root node.

2023-02-10 Thread Ales Musil
Both engines in northd and controller has a common root that doesn't do anything. They are there to avoid the need of multiple engines. Use the same naming convention for both and move MAC binding aging under this node in nothd. Ales Musil (2): northd: Move en_mac_binding_aging under

[ovs-dev] [PATCH ovn v2] northd: Make the use of common zone in NAT configurable

2023-02-10 Thread Ales Musil
There are essentially three problems with the current combination of DGP + SNAT + LB: 1) The first packet is being SNATed in common zone due to a problem with pinctrl not preserving ct_mark/ct_label. The commit would create a SNAT entry within the same with DNAT entry. 2) The unSNAT for reply

Re: [ovs-dev] [PATCH v3] net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()

2023-02-10 Thread Simon Horman
On Fri, Feb 10, 2023 at 08:35:50AM +0100, Eelco Chaudron wrote: > > > On 10 Feb 2023, at 3:05, Hangyu Hua wrote: > > > old_meter needs to be free after it is detached regardless of whether > > the new meter is successfully attached. > > > > Fixes: c7c4c44c9a95 ("net: openvswitch: expand the

Re: [ovs-dev] [PATCH ovn] northd: prevents sending packet to conntrack for router ports

2023-02-10 Thread Ales Musil
On Thu, Feb 9, 2023 at 11:19 AM Xavier Simonart wrote: > As commented in northd.c, we should not use ct() for router ports. > When there are no stateful_acl, this patch prevents sending packet to > conntrack > for router ports. > However, this patch does not change the behavior for ACLs such as

Re: [ovs-dev] [PATCH ovn] tests: Fix Flaky system-tests "omit connection tracking ..."

2023-02-10 Thread Ales Musil
On Thu, Feb 9, 2023 at 11:00 AM Xavier Simonart wrote: > While conntrack entries were flushed between the sub-tests, flows from > previous tests might still be present, causing conntrack entries to be > re-created. > > Fixes: a0f82efdd9df ("northd: bypass connection tracking for stateless >

Re: [ovs-dev] [PATCH v3 ovn] northd: do not create flows for reserved multicast IPv6 groups

2023-02-10 Thread Ales Musil
On Thu, Feb 2, 2023 at 11:34 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Avoid creating logical flows for Link-Local reserved multicast addresses if > advertised in a MLD reports since this interferes with Slaac IPv6 address > resolution implemented in OVN. > > Acked-by: Acked-by:

Re: [ovs-dev] [PATCH ovn v1 0/6] drop sampling: Fixes and optimizations

2023-02-10 Thread Ales Musil
On Tue, Jan 24, 2023 at 4:18 PM Adrián Moreno wrote: > While testing, I discovered some problems with drop sampling (first 4 > patches). > > Also, this series introduces an optimization. In order to avoid adding > sample actions on Chassis that do not have a Flow_Sample_Collector_Set >

Re: [ovs-dev] [PATCH v2 ovn] Add IPv6 support for lb health-check

2023-02-10 Thread Ales Musil
On Fri, Dec 16, 2022 at 6:06 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health > check support. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094 > Signed-off-by: Lorenzo Bianconi > Hi Lorenzo, I

Re: [ovs-dev] [PATCH v2] utilities: add support to set umask in ovs-ctl

2023-02-10 Thread Eelco Chaudron
On 8 Feb 2023, at 16:22, Vladislav Odintsov wrote: > This patch adds new ovs-ctl options to pass umask configuration to allow > OVS daemons set requested socket permissions on group. Previous > behaviour (if using with systemd service unit) created sockets with 0750 > permissions mask (group