On 2/22/23 01:14, Ilya Maximets wrote:
On 2/21/23 14:02, Viacheslav Galaktionov via dev wrote:
Cookies are an important part of flow descriptions and must be available
to the end user.
Signed-off-by: Viacheslav Galaktionov
---
v2: print cookies before table ids
ofproto/ofproto.c | 4
Sorry.
The commit message and code are not changed.
Resended when I met a bug of intel-ovs-compilation test fail and add version
descriptions.
From: Simon Horman
Date: 2023-02-21 23:09:05
To: Faicker Mo
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del
On 2/21/23 14:02, Viacheslav Galaktionov via dev wrote:
> Cookies are an important part of flow descriptions and must be available
> to the end user.
>
> Signed-off-by: Viacheslav Galaktionov
> ---
> v2: print cookies before table ids
>
> ofproto/ofproto.c | 4
> 1 file changed, 4
On 2/21/23 16:03, Paolo Valerio wrote:
> Liang Mancang writes:
>
>> when a exp_list contains more than the clean_end's number of nodes,
>> and these nodes will not expire immediately. Then, every times we
>> call conntrack_clean, it use the same next_sweep to get exp_list.
>>
>> Actually, we
On 2/21/23 20:18, Mike Pattrick wrote:
> There was a minor typo in the ovs-actions man page.
>
> Signed-off-by: Mike Pattrick
> ---
> Documentation/ref/ovs-actions.7.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ref/ovs-actions.7.rst
>
There was a minor typo in the ovs-actions man page.
Signed-off-by: Mike Pattrick
---
Documentation/ref/ovs-actions.7.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ref/ovs-actions.7.rst
b/Documentation/ref/ovs-actions.7.rst
index b59b7634f..d13895655
On Tue, Feb 21, 2023 at 10:11:27AM -0500, Mike Pattrick wrote:
> On Tue, Feb 21, 2023 at 5:35 AM Simon Horman
> wrote:
> >
> > On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> > > Currently OVS keeps track of which mirrors that each packet has been
> > > sent to for the purpose
On 2/21/23 01:41, Ivan Malov wrote:
> This may be required by some PMDs in offload scenarios.
>
> Signed-off-by: Ivan Malov
> ---
> lib/netdev-dpdk.c | 40
> 1 file changed, 40 insertions(+)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index
On 2/20/23 16:41, Simon Horman wrote:
> On Fri, Feb 10, 2023 at 05:03:13PM +0100, Adrián Moreno wrote:
>> From: Adrian Moreno
>>
>> IPFIX templates have to be sent for each Observation Domain ID.
>> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
>> This works fine for
Ilya Maximets writes:
> Flow lookup doesn't include masks of the final stage in a resulted
> flow wildcards in case that stage had L4 ports match. Only the result
> of ports trie lookup is added to the mask. It might be sufficient in
> many cases, but it's not correct, because ports trie is
On Tue, Feb 21, 2023 at 5:35 AM Simon Horman wrote:
>
> On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> > Currently OVS keeps track of which mirrors that each packet has been
> > sent to for the purpose of deduplication. However, this doesn't consider
> > that openflow rules can
Liang Mancang writes:
> when a exp_list contains more than the clean_end's number of nodes,
> and these nodes will not expire immediately. Then, every times we
> call conntrack_clean, it use the same next_sweep to get exp_list.
>
> Actually, we should add i every times after we call ct_sweep.
>
On Wed, Feb 01, 2023 at 10:49:22AM +0800, Faicker Mo wrote:
> The device may be deleted and added with ifindex changed.
> The tc rules on the device will be deleted if the device is deleted.
> The func tc_del_filter will fail when flow del. The mapping of
> ufid to tc will not be deleted.
> The
On Wed, Feb 15, 2023 at 09:15:04PM +0100, Ilya Maximets wrote:
> On 2/14/23 14:54, Eelco Chaudron wrote:
> > Run "make check-offloads" as part of the GitHub actions tests.
> >
> > This test was run 25 times using GitHub actions, and the
> > failing rerun test cases where excluded. There are quite
On 2/20/23 22:24, Russell Bryant wrote:
> From: Russell Bryant
>
> I have not been active in OVS development in long enough that I should
> move to emeritus status.
>
> Signed-off-by: Russell Bryant
> ---
Thanks for all the work over the years!
Applied.
Best regards, Ilya Maximets.
>
Cookies are an important part of flow descriptions and must be available
to the end user.
Signed-off-by: Viacheslav Galaktionov
---
v2: print cookies before table ids
ofproto/ofproto.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index
On 2/21/23 16:53, Ilya Maximets wrote:
On 2/21/23 12:22, Viacheslav Galaktionov via dev wrote:
Cookies are an important part of flow descriptions and must be available
to the end user.
Signed-off-by: Viacheslav Galaktionov
---
ofproto/ofproto.c | 4
1 file changed, 4 insertions(+)
On 2/21/23 12:22, Viacheslav Galaktionov via dev wrote:
> Cookies are an important part of flow descriptions and must be available
> to the end user.
>
> Signed-off-by: Viacheslav Galaktionov
> ---
> ofproto/ofproto.c | 4
> 1 file changed, 4 insertions(+)
Hi, Viacheslav. Thanks for the
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#27 FILE:
The tests are looking for specific output from tcpdump
counting number of occurrences and expecting only 1. It
might happen that in the time period there are already two
or more packets and the test simply fails. Change the condition
to be greater or equal to one.
Signed-off-by: Ales Musil
---
The ADD_INT does not work very well with userspace datapath.
To avoid any warnings that might fail the tests
use ADD_VETH instead. Also encourage this in
documentation for ADD_INT, because there should
be good reasoning behind using internal interface.
Signed-off-by: Ales Musil
---
The test with jemalloc and clang is redundant as
we are already testing jemalloc with gcc. Replace
it with system-test-userspace which runs system tests
over userspace OvS datapath.
Signed-off-by: Ales Musil
---
.github/workflows/test.yml | 6 +++---
1 file changed, 3 insertions(+), 3
On Fri, Feb 17, 2023 at 4:56 PM Ilya Maximets wrote:
> On 2/17/23 11:38, Ales Musil wrote:
> > Bump ovs submodule to cd1cf6a2 which is after
> > 0a758703 ("conntrack: Properly unNAT inner header of related traffic.").
> > This patch is needed for "LB - ICMP related traffic" system test to work
>
Newer versions of ping6 print some info to
stderr when specified with -v flag. This info
causes tests to fail. Do not use the verbose
output.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn.at
There is a bug in userspace datapath that causes
failures within the LB affinity test [0].
Skip the test until the bug is fixed.
[0] https://bugzilla.redhat.com/2170828
Signed-off-by: Ales Musil
---
tests/system-kmod-macros.at | 6 ++
tests/system-ovn.at | 2 ++
Bump ovs submodule to b72a7f92 which is after
ed44eefb ("conntrack: Properly unNAT inner header of related traffic.").
This patch is needed for "LB - ICMP related traffic" system test to work
with OvS userspace netdev.
Signed-off-by: Ales Musil
---
ovs | 2 +-
1 file changed, 1 insertion(+), 1
The dpctl/del-flows shouldn't be used on running
ofproto layer, use revalidator/purge instead.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 01112f33e..f56e61923 100644
---
Add support for running system tests with
OvS userspace netdev.
Signed-off-by: Ales Musil
---
.ci/linux-build.sh | 69 ++
1 file changed, 46 insertions(+), 23 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index
In order to allow there are ome fixes done to the
tests itself. The LB affinity needs a fix from OvS
side so it is marked as skip for the time being.
To save some on the CI the last patch replaces
unit tests with Clang and Jemalloc with the
userspace system tests, the Jemalloc still
run with GCC.
On Fri, Feb 17, 2023 at 9:41 PM Dumitru Ceara wrote:
> As mentioned in the structure definition in lb.h, northd should never
> use 'vip_port' instead it should always use 'port_str'. That's because
> it might not always be possible to evaluate the port value in northd,
> e.g., when using LB
Cookies are an important part of flow descriptions and must be available
to the end user.
Signed-off-by: Viacheslav Galaktionov
---
ofproto/ofproto.c | 4
1 file changed, 4 insertions(+)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index e4a1bee76..29020c42e 100644
---
On Fri, Feb 03, 2023 at 12:12:12PM +0100, Eelco Chaudron wrote:
> When the ukey's action set changes, it could caus the flow to use a
nit: s/caus/cause/
> different datapath, for example, when it moves from tc to kernel.
> This will cause the the cached previous datapath statistics to be used.
>
>-Original Message-
>From: Ivan Malov
>Sent: Tuesday, 21 February 2023 2:41
>To: ovs-dev@openvswitch.org
>Cc: Ilya Maximets ; Eli Britstein ; Ori
>Kam ; David Marchand
>Subject: [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy
>mechanism
>
>External email: Use caution
On Tue, Feb 14, 2023 at 02:39:25PM +0100, Eelco Chaudron wrote:
> Depending on the driver implementation, it can take from 0.2 seconds
> up to 2 seconds before offloaded flow statistics are updated. This is
> true for both TC and rte_flow-based offloading. This is causing a
> problem with
On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> Currently OVS keeps track of which mirrors that each packet has been
> sent to for the purpose of deduplication. However, this doesn't consider
> that openflow rules can make significant changes to packets after
> ingress.
>
> For
Liang Mancang writes:
> On Mon, Feb 20, 2023 at 07:38:39PM +0100, Paolo Valerio wrote:
>> Paolo Valerio writes:
>>
>> > Hello Liang,
>> >
>> > Liang Mancang writes:
>> >
>> >> when a exp_list contains more than the clean_end's number of nodes,
>> >> and these nodes will not expire
On Mon, Feb 20, 2023 at 07:38:39PM +0100, Paolo Valerio wrote:
> Paolo Valerio writes:
>
> > Hello Liang,
> >
> > Liang Mancang writes:
> >
> >> when a exp_list contains more than the clean_end's number of nodes,
> >> and these nodes will not expire immediately. Then, every times we
> >> call
On Tue, Feb 21, 2023 at 06:33:32PM +0900, Nobuhiro MIKI wrote:
> On 2023/02/21 2:23, Simon Horman wrote:
> > On Tue, Feb 14, 2023 at 12:39:05PM +0900, Nobuhiro MIKI wrote:
> >> When adding a route with ovs/route/add command, the source address
> >> in "ovs_router_entry" structure is always the
On 2023/02/21 2:23, Simon Horman wrote:
> On Tue, Feb 14, 2023 at 12:39:05PM +0900, Nobuhiro MIKI wrote:
>> When adding a route with ovs/route/add command, the source address
>> in "ovs_router_entry" structure is always the FIRST address that the
>> interface has. See
On Tue, Feb 21, 2023 at 05:41:59PM +0900, Nobuhiro MIKI wrote:
> On 2023/02/21 1:35, Simon Horman wrote:
> > On Tue, Feb 14, 2023 at 12:39:04PM +0900, Nobuhiro MIKI wrote:
> >> This is useful in test cases where multiple IPv4/IPv6 addresses
> >> are assigned together.
> >>
> >> Signed-off-by:
when a exp_list contains more than the clean_end's number of nodes,
and these nodes will not expire immediately. Then, every times we
call conntrack_clean, it use the same next_sweep to get exp_list.
Actually, we should add i every times after we call ct_sweep.
v2: delete unnecessary line.
On 2023/02/21 1:35, Simon Horman wrote:
> On Tue, Feb 14, 2023 at 12:39:04PM +0900, Nobuhiro MIKI wrote:
>> This is useful in test cases where multiple IPv4/IPv6 addresses
>> are assigned together.
>>
>> Signed-off-by: Nobuhiro MIKI
>> ---
>> lib/netdev-dummy.c | 66
42 matches
Mail list logo
