Hi Simon Horman,
Thanks for your review.
On Mon, Mar 6, 2023 at 11:23 PM Simon Horman wrote:
>
> On Sat, Mar 04, 2023 at 11:23:50AM +0800, Wan Junjie wrote:
> > Hi Simon,
> >
> > Thanks for the review.
>
> Hi Wan Junjie,
>
> Thanks for responding.
>
> > On Fri, Mar 3, 2023 at 11:06 PM Simon
On 3/1/23 03:30, Fangrui Song via dev wrote:
> ATOMIC_VAR_INIT has a trivial definition
> `#define ATOMIC_VAR_INIT(value) (value)`,
> is deprecated in C17/C++20, and will be removed in newer standards in
> newer GCC/Clang (e.g. https://reviews.llvm.org/D144196).
>
> Signed-off-by: Fangrui Song
>
Simon Horman writes:
> On Fri, Mar 03, 2023 at 10:16:00AM -0500, Aaron Conole wrote:
>> Open vSwitch generally tries to let the underlying operating system
>> managed the low level details of hardware, for example DMA mapping,
>> bus arbitration, etc. However, when using DPDK, the underlying
>>
On Mon, Mar 6, 2023 at 5:05 PM David Marchand wrote:
> > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> > index fb0dd43f7..e901f857e 100644
> > --- a/lib/netdev-dpdk.c
> > +++ b/lib/netdev-dpdk.c
> > @@ -1008,4 +1008,13 @@ dpdk_watchdog(void *dummy OVS_UNUSED)
> > }
> >
> > +static int
> >
On Thu, Feb 9, 2023 at 5:29 PM Kevin Traynor wrote:
>
> By default OVS configures 2048 descriptors for tx and rx queues
> on DPDK devices. It also allows the user to configure those values.
>
> If the values used are not acceptable to the device than queue setup
> will fail.
>
> The device
On Sat, Mar 04, 2023 at 11:23:50AM +0800, Wan Junjie wrote:
> Hi Simon,
>
> Thanks for the review.
Hi Wan Junjie,
Thanks for responding.
> On Fri, Mar 3, 2023 at 11:06 PM Simon Horman
> wrote:
> > On Wed, Mar 01, 2023 at 04:05:17PM +0800, Wan Junjie wrote:
...
> > > diff --git
On Fri, Mar 03, 2023 at 10:16:00AM -0500, Aaron Conole wrote:
> Open vSwitch generally tries to let the underlying operating system
> managed the low level details of hardware, for example DMA mapping,
> bus arbitration, etc. However, when using DPDK, the underlying
> operating system yields
Hi Dumitru
Thanks for the review and the comments
On Wed, Feb 15, 2023 at 2:15 PM Dumitru Ceara wrote:
> Hi Xavier,
>
> Thanks for this new version and sorry for the time it took to review it!
> I think it mostly looks good; I only have a few minor remarks/questions
> below.
>
> On 1/4/23
Specifying datapath with "dpctl/flush-conntrack" didn't
work as expected and caused error:
ovs-dpctl: field system@ovs-system missing value (Invalid argument)
To prevent that check if we have datapath as first argument
and use it accordingly.
Signed-off-by: Ales Musil
---
v2: Add test case.
---
Signed-off-by: Ales Musil
---
vswitchd/vswitch.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 12708a313..15e4f97b7 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -6301,6 +6301,11 @@ ovs-vsctl add-port br0 p0 -- set
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#28 FILE: lib/dpctl.c:1722:
if
On 3/6/23 13:44, Ales Musil wrote:
> Specifying datapath with "dpctl/flush-conntrack" didn't
> work as expected and caused error:
> ovs-dpctl: field system@ovs-system missing value (Invalid argument)
>
> To prevent that check if we have datapath as first argument
> and use it accordingly.
>
>
On Fri, Mar 3, 2023 at 4:00 PM Roi Dayan wrote:
>
>
> On 01/03/2023 14:01, Ales Musil wrote:
> > On Wed, Mar 1, 2023 at 12:34 PM Roi Dayan wrote:
> >
> >>
> >>
> >> On 01/03/2023 12:53, Roi Dayan via dev wrote:
> >>>
> >>>
> >>> On 16/01/2023 13:45, Ales Musil wrote:
> Currently, the CT
Specifying datapath with "dpctl/flush-conntrack" didn't
work as expected and caused error:
ovs-dpctl: field system@ovs-system missing value (Invalid argument)
To prevent that check if we have datapath as first argument
and use it accordingly.
Signed-off-by: Ales Musil
---
lib/dpctl.c | 17
On 3/3/23 11:20, Olaf Seibert via dev wrote:
> Tangentially related to this: I was trying to detect when the problem with
> the "too many resubmits" occurs, for alerting purposes.
> Some light examination of the source of ovs suggested that the coverage
> counter "drop_action_too_many_resubmit"
Applied on master and backported until 2.9
Thank you!
> On 9 Nov 2022, at 04:32, Wilson Peng wrote:
>
> From: Wilson Peng
>
> In the recent Antrea project testing, some port could not be created
> on Windows.
>
> When doing debug, our team found there is one case happening when multiple
>
As commented in northd.c, we should not use ct() for router ports.
When there are no stateful_acl, this patch prevents sending packet to conntrack
for router ports.
The patch does this by issuing ct_clear in ls_out_pre_lb stage so that hints
are not set in ls_out_acl_hint and ls_out_acl stages.
On 3/6/2023 4:51 PM, Eelco Chaudron wrote:
On 6 Mar 2023, at 9:19, Chris Mi wrote:
On 3/1/2023 9:23 PM, Ilya Maximets wrote:
On 3/1/23 14:21, Ilya Maximets wrote:
On 3/1/23 14:08, Chris Mi wrote:
On 3/1/2023 8:44 PM, Ilya Maximets wrote:
On 2/28/23 14:05, Chris Mi wrote:
On 2/24/2023
On 6 Mar 2023, at 9:19, Chris Mi wrote:
> On 3/1/2023 9:23 PM, Ilya Maximets wrote:
>> On 3/1/23 14:21, Ilya Maximets wrote:
>>> On 3/1/23 14:08, Chris Mi wrote:
On 3/1/2023 8:44 PM, Ilya Maximets wrote:
> On 2/28/23 14:05, Chris Mi wrote:
>> On 2/24/2023 4:16 AM, Ilya Maximets
On 3/1/2023 9:23 PM, Ilya Maximets wrote:
On 3/1/23 14:21, Ilya Maximets wrote:
On 3/1/23 14:08, Chris Mi wrote:
On 3/1/2023 8:44 PM, Ilya Maximets wrote:
On 2/28/23 14:05, Chris Mi wrote:
On 2/24/2023 4:16 AM, Ilya Maximets wrote:
On 2/23/23 12:26, Chris Mi wrote:
Initialize psample
20 matches
Mail list logo
