Re: [ovs-dev] [PATCH v9] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread 0-day Robot
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error =

[ovs-dev] [PATCH v9] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread Wan Junjie via dev
put dump-meters' result in one line so add-meters can handle. save and restore meters when restart ovs. bundle functions are not implemented in this patch. Signed-off-by: Wan Junjie --- v9: fix verbosity mask bits for testcase apologies for mess v8: fix missing code for testcase v7: typo in

Re: [ovs-dev] [PATCH ovn v4 0/2] expr: Optimize OR expressions.

2023-04-10 Thread Han Zhou
On Wed, Apr 5, 2023 at 12:50 PM Ilya Maximets wrote: > > On 4/5/23 21:48, Ilya Maximets wrote: > > This patch set covers removal of expressions which are subsets of other > > wider expressions. This allows to avoid flow explosion in case of > > negative matches. More details are in commit

[ovs-dev] [PATCH ovn v2 3/4] ovn-nbctl: Add tier ACL options.

2023-04-10 Thread Mark Michelson
This modifies the acl-add and acl-del commands so that an ACL tier can be specified when adding or deleting ACLs. For acl-add, if the tier is specified, then the ACL created by the command will have that tier set. For acl-del, if the tier is specified, then the tier will be one of the criteria

[ovs-dev] [PATCH ovn v2 4/4] acls: Add "pass" ACL action.

2023-04-10 Thread Mark Michelson
This allows for evaluating ACLs at the current tier to stop, and to start evaluating ACLs at the next tier. If not using tiers, or if we match on the final ACL tier, then a "pass" verdict results in the default ACL action being applied. Reported-at:

[ovs-dev] [PATCH ovn v2 2/4] northd: Add tiered ACL support.

2023-04-10 Thread Mark Michelson
With this commit, ACLs can now be arranged in hierarchical tiers. A tier number can be assigned to an ACL. When evaluating ACLs, we first will consider ACLs at tier 0. If no matching ACL is found, then we move to tier 1. This continues until a matching ACL is found, or we reach the maximum tier.

Re: [ovs-dev] [PATCH v8] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread 0-day Robot
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error =

[ovs-dev] [PATCH v8] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread Wan Junjie via dev
put dump-meters' result in one line so add-meters can handle. save and restore meters when restart ovs. bundle functions are not implemented in this patch. Signed-off-by: Wan Junjie --- v8: fix missing code for testcase v7: typo in code v6: code style v5: merge oneline to verbosity higher

Re: [ovs-dev] [PATCH v7] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread 0-day Robot
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error =

[ovs-dev] [PATCH v7] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread Wan Junjie via dev
put dump-meters' result in one line so add-meters can handle. save and restore meters when restart ovs. bundle functions are not implemented in this patch. Signed-off-by: Wan Junjie --- v7: typo in code v6: code style v5: merge oneline to verbosity higher bits remove duplicate dump_meters

Re: [ovs-dev] [PATCH v6] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread Simon Horman
On Mon, Apr 10, 2023 at 09:23:46PM +0800, Wan Junjie via dev wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie Hi, unfortunately this one doesn't

Re: [ovs-dev] [PATCH ovn v8 1/2] northd: Update the is_stateless helper for rotuer nat

2023-04-10 Thread Simon Horman
On Thu, Apr 06, 2023 at 07:03:03PM +0200, Ales Musil wrote: > The stateless can be applied only to "snat_and_dnat" nat > type. Update the helper to reflect that. > > Fixes: cc87c4827f47 ("OVN: Use ip4.src and ip4.dst actions for NAT rules") > Signed-off-by: Ales Musil > --- > v8: No change since

Re: [ovs-dev] [PATCH v6] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread 0-day Robot
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error =

[ovs-dev] [PATCH v6] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread Wan Junjie via dev
put dump-meters' result in one line so add-meters can handle. save and restore meters when restart ovs. bundle functions are not implemented in this patch. Signed-off-by: Wan Junjie --- v6: code style v5: merge oneline to verbosity higher bits remove duplicate dump_meters code v4: code