Re: [ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

On 5/20/23 02:34, Ilya Maximets wrote: > On 5/16/23 07:33, Nobuhiro MIKI wrote: >> It supports flowlabel based load balancing by controlling the flowlabel >> of outer IPv6 header, which is already implemented in Linux kernel as >> seg6_flowlabel sysctl [1]. >> >> [1]:

Re: [ovs-dev] [ovs-discuss] connect VM on OVN/OVS and BMS on L2

Hi Numan, Yes, BMS is Bear Metal Server. Another case is SRIOV. I think they are the same case and I am looking for a solution to cover both of them. VTEP is the solution I used to have. Provider VLAN works for L2, but not L3. And it doesn't support multi-tenancy. Now I am looking for the

Re: [ovs-dev] [PATCH v4 2/2] userspace: Add new option srv6_flowlabel in SRv6 tunnel.

On 5/16/23 07:33, Nobuhiro MIKI wrote: > It supports flowlabel based load balancing by controlling the flowlabel > of outer IPv6 header, which is already implemented in Linux kernel as > seg6_flowlabel sysctl [1]. > > [1]: https://docs.kernel.org/networking/seg6-sysctl.html > > Signed-off-by:

[ovs-dev] [PATCH 3/3] netdev-vport: RCU-fy tunnel config.

Tunnel config can be accessed by multiple threads at the same time and it is supposed to be protected by the netdev_vport mutex. However, many functions are getting direct access to it via netdev API without taking the mutex, creating a potential for various race conditions. Fix that by

[ovs-dev] [PATCH 2/3] smap: Make argument of smap_add_ipv6 constant.

The address is not getting modified inside. Signed-off-by: Ilya Maximets --- lib/smap.c | 2 +- lib/smap.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/smap.c b/lib/smap.c index c1633e2a1..47fb34502 100644 --- a/lib/smap.c +++ b/lib/smap.c @@ -100,7 +100,7 @@

[ovs-dev] [PATCH 1/3] netdev-vport: Fix unsafe handling of GRE sequence number.

GRE sequence number is maintained as part of the tunnel config. This triggers tunnel reconfiguration every time set_tunnel_config() is called, because memset over tunnel config will never be equal to the new config constructed from database options. And sequence number incremented non-atomically

[ovs-dev] [PATCH 0/3] netdev-vport: Fix tunnel config thread safety.

Ilya Maximets (3): netdev-vport: Fix unsafe handling of GRE sequence number. smap: Make argument of smap_add_ipv6 constant. netdev-vport: RCU-fy tunnel config. lib/netdev-native-tnl.c| 98 ++- lib/netdev-vport-private.h | 7 +- lib/netdev-vport.c | 191

Re: [ovs-dev] [ovs-discuss] connect VM on OVN/OVS and BMS on L2

On Fri, May 19, 2023 at 12:09 AM Tony Liu wrote: > > Hi Numan, > > Provider VLAN networks is able to connect VM and BMS on L2. > I am going to push this topic further. > > Provider VLAN network is different from regular virtual network. > It seems that I can't create a logical router to connect a

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-v23.06.0.

Thanks for the acks Numan. I pushed the first patch to main, created branch-23.06, and then pushed the second patch to main. We now have branch-23.06 to work with. On 5/19/23 12:01, Numan Siddique wrote: On Thu, May 18, 2023 at 4:58 PM Mark Michelson wrote: Signed-off-by: Mark Michelson

Re: [ovs-dev] [PATCH v4 1/2] netdev-native-tnl: Add ipv6_label param in netdev_tnl_push_ip_header.

On 5/16/23 07:33, Nobuhiro MIKI wrote: > For tunnels such as SRv6, some popular vendor appliances support > IPv6 flowlabel based load balancing. In preparation for OVS to > support it, this patch modifies the encapsulation to allow IPv6 > flowlabel to be configured. > > Signed-off-by: Nobuhiro

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation with patch port and controller.

On 5/15/23 17:22, Paolo Valerio wrote: > If a packet originating from the controller recirculates after going > through a patch port, it gets dropped with the following message: > > ofproto_dpif_upcall(handler8)|INFO|received packet on unassociated > datapath port 4294967295 > > This happens

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

Finally, I’ve managed to find the correct place for this change. I’ve submitted a patch series here: [1] Thanks Dumitru, your help was very valuable! I’d be glad if you can find some time to review this series. :) 1:

[ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

This patch is intended to make next two changes: 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP. Prior to this patch MAC_Binding records were created only when LRP issued ARP request/Neighbor solicitation. If IP to MAC in network attached via vtep lport was changed the old

[ovs-dev] [PATCH ovn 3/5] controller: move put_load for port-binding in function

This is done to simplify and remove duplication of code. New function will be used in next patch. Signed-off-by: Vladislav Odintsov --- controller/physical.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/controller/physical.c

[ovs-dev] [PATCH ovn 2/5] northd: build vtep hairpin lflows only for lswitches with vtep lports

There is no need to build lflows for datapaths, where there are no vtep type lports. For instance, edge-outside logical switch, which has no vtep lports but has many chassis redirect lport, can have many useless lflows. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 5 +

[ovs-dev] [PATCH ovn 4/5] controller: fix typo in comments

Signed-off-by: Vladislav Odintsov --- controller/binding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controller/binding.c b/controller/binding.c index 28218b2e8..c7a2b3f10 100644 --- a/controller/binding.c +++ b/controller/binding.c @@ -2092,7 +2092,7 @@

[ovs-dev] [PATCH ovn 1/5] northd: fix ls_in_hairpin l3dgw flow generation

This patch fixes a situation, where logical flow with incorrect syntax could be generated. If a logical switch has two attached logical router ports and one of them has configured gateway chassis, then incorrect flow can have the match like: `reg0[14] == 1 && (is_chassis_resident("cr-lrp2") || `

[ovs-dev] [PATCH ovn 0/5] VTEP lport ARP handling fixes & GARP support

This patch series brings enhancements to ARP/ND traffic coming from vtep logical switch port. Patch #1 shoud be backported to old branches as it is a bugfix. Patch #2 makes a small optimisation - removed unneeded logical flows, it can be also backported. Patch #3 is a preparation for patch #5,

Re: [ovs-dev] [PATCH v2] ovs-ofctl: skip invalid flows for replace-flows

On 5/6/23 05:20, Wan Junjie via dev wrote: > ovs-save will do replace-flows for ovs restart. For some reason, ovs > could have an invalid action, like invalid meter. Then adding flows > will be stopped at the position of the first invalid flow. This could > happen when ovs restart and vm related

Re: [ovs-dev] [PATCH ovn] tests: Fix "ACL with Port Group including router ports"

Thanks for fixing this Ales, Acked-by: Mark Michelson I went ahead and applied this to main. On 5/19/23 04:22, Ales Musil wrote: The test was failing on Fedora with "grep: warning: stray \ before ," due to autotest stripping the "[" and "]". Use the check directly instead. Fixes:

Re: [ovs-dev] [PATCH ovn v8] controller: Prevent race in packet buffering

Thanks Dumitru and Ales. I pushed this change to main. I attempted to backport this (as well as the previous patches from this series) to branch-23.03 but they did not apply cleanly. If you can provide a series that applies to branch-23.03, then I can get it backported there and attempt to

Re: [ovs-dev] [PATCH ovn v4 2/2] Pass localnet traffic through CT when a LB is configured.

Thanks for the review Ales. I added a bugzilla citation to the commit message and pushed the change to main and all branches back to 22.03. On 5/19/23 03:01, Ales Musil wrote: On Thu, May 18, 2023 at 10:11 PM Mark Michelson > wrote: Current code always

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-v23.06.0.

On Thu, May 18, 2023 at 4:58 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 23.06.0.

On Thu, May 18, 2023 at 4:58 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 4 ++-- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

Acked-by: Justin Pettit Thanks for pulling this together, Russell. (It's been so long since I've done anything code-related, that I'm back to top-posting. :-/ ) --Justin > On May 19, 2023, at 7:52 AM, Russell Bryant wrote: > > The following document discusses emeritus committer status: >

Re: [ovs-dev] [PATCH ovn v2 branch-21.12] ovs: Bump submodule to v2.17.6

On Thu, May 18, 2023 at 3:09 PM Mark Michelson wrote: > > Thanks Ales, > > This looks good to me. > > Acked-by: Mark Michelson Thanks. I applied the patch to branch-21.12. Numan > > On 5/18/23 09:26, Ales Musil wrote: > > Bump submodule to v2.17.6 specifically for: > > 1989caf9ea5e

[ovs-dev] [PATCH] relay: allow setting probe interval

previously it was not possible to set the probe interval for the connection from a relay to the backing ovsdb-server. With this change it is now possible using the `ovsdb-server/set-active-ovsdb-server-probe-interval` command. The command `ovsdb-server/set-active-ovsdb-server-probe-interval` is

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to v3.1.1

On Tue, May 16, 2023 at 10:32 AM Ales Musil wrote: > > To align all relevant branches bump > ovs submodule to v3.1.1. > > Signed-off-by: Ales Musil Thanks for the patch. I applied this patch to the main branch. I updated the commit message and removed "To align all ..." as we are not

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

ACKs from all committers, including those moving to emeritus status, are much appreciated. Our policy requires a majority for this to be approved. Thank you! Russell Bryant -- Russell Bryant On Fri, May 19, 2023 at 10:53 AM Russell Bryant wrote: > The following document discusses emeritus

[ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

The following document discusses emeritus committer status: https://docs.openvswitch.org/en/latest/internals/committer-emeritus-status/ There are several people who I would guess consider themselves emeritus committers but have not formally declared it. Those moved to emeritus status in this

Re: [ovs-dev] [PATCH v3] tests dpdk: Pass `--no-pci` to tests that do not use physical ports.

On 5/12/23 15:41, Frode Nordahl wrote: > At present, the system-dpdk-testsuite makes assumptions about > environment configuration, and will error out if DPDK compatible > interfaces not configured for DPDK are present in the system with > a message like: > > EAL: Probe PCI driver: net_virtio

Re: [ovs-dev] [PATCH v11] utilities/ofctl: add-meters for save and restore

On 5/6/23 13:43, Wan Junjie via dev wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie > > --- > v11: > add OFP_ prefix to macro > add testcases

Re: [ovs-dev] [PATCH v4] backtrace: Extend the backtrace functionality

Ales Musil writes: > Use the backtrace functions that is provided by libc, > this allows us to get backtrace that is independent of > the current memory map of the process. Which in turn can > be used for debugging/tracing purpose. The backtrace > is not 100% accurate due to various

Re: [ovs-dev] [PATCH v9] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On 17 May 2023, at 17:05, Balazs Nemeth wrote: > The only way that stats->{n_packets,n_bytes} would decrease is due to an > overflow, or if there are bugs in how statistics are handled. In the > past, there were multiple issues that caused a jump backward. A > workaround was in place to set

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

On Fri, May 19, 2023 at 11:55 AM Eelco Chaudron wrote: > > > > On 15 May 2023, at 10:04, Frode Nordahl wrote: > > > The tc module combines the use of the `tc_transact` helper > > function for communication with the in-kernel tc infrastructure > > with assertions on the reply data by

Re: [ovs-dev] [PATCH v3] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

On 15 May 2023, at 10:04, Frode Nordahl wrote: > The tc module combines the use of the `tc_transact` helper > function for communication with the in-kernel tc infrastructure > with assertions on the reply data by `ofpbuf_at_assert` on the > received data prior to further processing. > >

[ovs-dev] [PATCH ovn] tests: Fix "ACL with Port Group including router ports"

The test was failing on Fedora with "grep: warning: stray \ before ," due to autotest stripping the "[" and "]". Use the check directly instead. Fixes: 46dacbb755dd ("northd: Break ACLs into two stages.") Signed-off-by: Ales Musil --- tests/ovn.at | 7 --- 1 file changed, 4 insertions(+), 3

[ovs-dev] [PATCH v4] backtrace: Extend the backtrace functionality

Use the backtrace functions that is provided by libc, this allows us to get backtrace that is independent of the current memory map of the process. Which in turn can be used for debugging/tracing purpose. The backtrace is not 100% accurate due to various optimizations, most notably

Re: [ovs-dev] [PATCH ovn v4 2/2] Pass localnet traffic through CT when a LB is configured.

On Thu, May 18, 2023 at 10:11 PM Mark Michelson wrote: > Current code always skips conntrack for traffic that ingresses or > egresses on a localnet port. However, this makes it impossible for > traffic to be load-balanced when it arrives on a localnet port. > > This patch allows for traffic to

Re: [ovs-dev] [PATCH ovn v4 1/2] tests: Use stricter IP match for FORMAT_CT.

On Thu, May 18, 2023 at 10:11 PM Mark Michelson wrote: > The match used in FORMAT_CT matched on "dst=$1". The problem is that > if you passed in an IP address like "10.0.0.1", then this could match on > "10.0.0.1" and "10.0.0.100" for instance. This can allow for unexpected > entries to show up

Re: [ovs-dev] [PATCH v3] backtrace: Extend the backtrace functionality

On Thu, May 18, 2023 at 11:00 PM Ilya Maximets wrote: > On 5/18/23 17:53, Ilya Maximets wrote: > > On 3/23/23 16:09, Ales Musil wrote: > >> +log_received_backtrace(int fd) { > > > > '{' should be on a separate line. > > > >> +struct backtrace bt; > >> + > >> +if