[ovs-dev] [PATCH ovn] Remove lport from related_lports if there is no binding

Currently during port migration, two chassis (source and destination) can try to claim the same logical switch port simultaneously for a short-period of time until the tap is deleted on source hypervisor. ovn-controllers on these 2 hosts constantly receives port-binding updates about other chassis

Re: [ovs-dev] [PATCH ovn v2] northd: Add logical flow to skip GARP with LLA

On Tue, May 30, 2023 at 11:59 AM Ales Musil wrote: > Skip GARP packet with link-local address being advertised > when "always_learn_from_arp_request=false", this should > prevent huge grow of MAC Binding table. To keep the option > consistent overwrite the previous MAC with LLA if it was >

Re: [ovs-dev] [PATCH ovn 09/14] northd: Incremental processing of VIF additions in 'lflow' node.

On Tue, May 30, 2023 at 4:04 AM Ilya Maximets wrote: > > On 5/29/23 20:42, Han Zhou wrote: > > > > > > On Mon, May 29, 2023 at 9:24 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> On 5/13/23 02:03, Han Zhou wrote: > >> > This patch introduces a change handler for 'northd' input

Re: [ovs-dev] [PATCH ovn v7 0/5] Implement MTU Path Discovery for multichassis ports

On Tue, May 30, 2023 at 5:06 PM Ihar Hrachyshka wrote: > > On Tue, May 30, 2023 at 2:28 PM Mark Michelson wrote: > > > > Thanks Ihar and Dumitru. > > > > I applied this series to main and branch-23.06. I encountered conflicts > > when trying to apply this to branch-23.03, specifically with patch

Re: [ovs-dev] [PATCH ovn 6/9] release-policy: Document when versions receive new releases.

On 5/30/23 22:22, Mark Michelson wrote: > On 5/26/23 08:45, Dumitru Ceara wrote: >> On 5/25/23 20:22, Mark Michelson wrote: >>> The OVN team has had no concrete policy regarding when releases are >>> made for a given version. In the past, new releases have been made only >>> when something

Re: [ovs-dev] [PATCH ovn v7 0/5] Implement MTU Path Discovery for multichassis ports

On Tue, May 30, 2023 at 2:28 PM Mark Michelson wrote: > > Thanks Ihar and Dumitru. > > I applied this series to main and branch-23.06. I encountered conflicts > when trying to apply this to branch-23.03, specifically with patch 4. I > suspect a lot of this is due to the fact that the tiered ACL

Re: [ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH ovn] test: Fix expected OpenFlow table numbers.

+1. Thanks Dumitru for cleaning it up! Reviewed-By: Ihar Hrachyshka On Tue, May 30, 2023 at 4:51 PM Dumitru Ceara wrote: > > Commit 549e8ccebca7 ("ovn-controller.c: Fix assertion failure during > address set update.") added a new ovn-controller.at test and commit > 740f23c19577 ("Add new

Re: [ovs-dev] [PATCH ovn v7 0/5] Implement MTU Path Discovery for multichassis ports

On 5/30/23 20:27, Mark Michelson wrote: > Thanks Ihar and Dumitru. > > I applied this series to main and branch-23.06. I encountered conflicts Thanks, Mark! Unfortunately, I had missed the fact that a new test had been added in the meantime and that we had to update the table numbers for that

[ovs-dev] [PATCH ovn] test: Fix expected OpenFlow table numbers.

Commit 549e8ccebca7 ("ovn-controller.c: Fix assertion failure during address set update.") added a new ovn-controller.at test and commit 740f23c19577 ("Add new egress tables to accommodate for too-big packets handling") went in without updating the expected numbers for that test. Fixes:

Re: [ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

On 5/30/23 22:48, Dumitru Ceara wrote: > Whenever an OpenFlow error is returned by OvS, trigger a reconnect of > the OpenFlow (rconn) connection. This will clear any installed OpenFlow > rules/groups. To ensure consistency, trigger a full I-P recompute too. > > An example of scenario that can

[ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

Whenever an OpenFlow error is returned by OvS, trigger a reconnect of the OpenFlow (rconn) connection. This will clear any installed OpenFlow rules/groups. To ensure consistency, trigger a full I-P recompute too. An example of scenario that can result in an OpenFlow error returned by OvS follows

Re: [ovs-dev] [PATCH ovn 6/9] release-policy: Document when versions receive new releases.

On 5/26/23 08:45, Dumitru Ceara wrote: On 5/25/23 20:22, Mark Michelson wrote: The OVN team has had no concrete policy regarding when releases are made for a given version. In the past, new releases have been made only when something critical has been found, meaning that most bug fixes applied

Re: [ovs-dev] [PATCH 1/2] stream-ssl: Disable alerts on unexpected EOF.

On Fri, May 26, 2023 at 06:57:09PM +0200, Ilya Maximets wrote: > On 5/25/23 15:21, Simon Horman wrote: > > On Wed, May 17, 2023 at 06:51:04PM +0200, Ilya Maximets wrote: > >> OpenSSL 3.0 enabled alerts for unexpected EOF by default. It supposed > >> to alert the application whenever the

Re: [ovs-dev] [PATCH 2/2] tests: Check ovsdb-server logs in OVSDB tests.

On Fri, May 26, 2023 at 03:11:01PM +0200, Ilya Maximets wrote: > On 5/25/23 15:20, Simon Horman wrote: > > On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote: > >> Many OVSDB tests are not checking the server log for warnings or > >> errors. Some are not even using the log file. It's

Re: [ovs-dev] [PATCH v2] ovsdb: Condition: Process condition changes incrementally.

On Fri, May 26, 2023 at 07:56:06PM +0200, Ilya Maximets wrote: > My commit hook capitalized 'c' in the 'condition'. I can fix that > before applying. Sounds good. Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

On Fri, May 26, 2023 at 01:38:54PM +0200, Ales Musil wrote: > On Fri, May 26, 2023 at 12:56 PM Simon Horman > wrote: > > > On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote: > > > Sorry for the top post, but I was wondering if there was a way to > > re-trigger > > > the bot testing

Re: [ovs-dev] [PATCH ovn v7 0/5] Implement MTU Path Discovery for multichassis ports

Thanks Ihar and Dumitru. I applied this series to main and branch-23.06. I encountered conflicts when trying to apply this to branch-23.03, specifically with patch 4. I suspect a lot of this is due to the fact that the tiered ACL changes are not present in branch-23.03, so * The table

Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

Hi Dumitru, On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote: > On 5/24/23 09:37, Felix Huettner wrote: > > Hi everyone, > > Hi Felix, > > > > > Ilya mentioned to me that you will want to bring openstack examples to > > ovn-heater. > > > > Yes, we're discussing that. > > > I wanted

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

v2 of patch #5 was submitted: https://patchwork.ozlabs.org/project/ovn/patch/20230530150328.1224972-1-odiv...@gmail.com/ > On 30 May 2023, at 13:12, Vladislav Odintsov wrote: > > > >> On 30 May 2023, at 13:10, Dumitru Ceara wrote: >> >> On 5/30/23 11:59, Vladislav Odintsov wrote: >>> Hi

[ovs-dev] [PATCH ovn v2] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

This patch is intended to make next two changes: 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP. Prior to this patch MAC_Binding records were created only when LRP issued ARP request/Neighbor solicitation. If IP to MAC in network attached via vtep lport was changed the old

Re: [ovs-dev] [PATCH ovn v4] controller: Ignore DNS queries with RRs

On 5/26/23 16:48, Brian Haley wrote: > DNS queries with optional records (RRs), for example, with > cookies for EDNS, are not supported by the OVN resolver. > Trying to reply will result in mangled responses that > clients do not understand - the ANSWER section will > contain an incorrect option.

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Align the timeouts with u/s ovnk

On 5/26/23 13:46, Dumitru Ceara wrote: > On 5/26/23 13:33, Ales Musil wrote: >> We saw a lot of failures recently due to jobs timing out. >> Align the timeouts with upstream ovn-kubernetes. > > Hi Ales, > > Thanks for this! > > Nit: I'd point to the ovn-kubernetes commit (or permalink) where >

Re: [ovs-dev] [PATCH ovn v2] tests: Fixed load balancing system-tests

On 1/18/23 21:09, Mark Michelson wrote: > Thanks, Xavier. > > Acked-by: Mark Michelson > > I pushed this change to main and branch-22.12. The patch did not apply > cleanly to branch-22.09 and anything before. I suspect that those > branches have this problem, too though. If you could post

Re: [ovs-dev] [PATCH ovn] controller: Handle OpenFlow errors.

On 5/25/23 13:40, Ales Musil wrote: > > > On Thu, May 25, 2023 at 10:37 AM Dumitru Ceara > wrote: > > Whenever an OpenFlow error is returned by OvS, trigger a reconnect of > the OpenFlow (rconn) connection.  This will clear any installed OpenFlow >

Re: [ovs-dev] [PATCH ovn 4/5] controller: fix typo in comments

On 5/19/23 20:18, Vladislav Odintsov wrote: > Signed-off-by: Vladislav Odintsov > --- Applied to main and backported down to 22.06, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn 3/5] controller: move put_load for port-binding in function

On 5/19/23 20:18, Vladislav Odintsov wrote: > This is done to simplify and remove duplication of code. > New function will be used in next patch. > > Signed-off-by: Vladislav Odintsov > --- Applied to main branch, thanks! ___ dev mailing list

Re: [ovs-dev] [PATCH ovn 2/5] northd: build vtep hairpin lflows only for lswitches with vtep lports

On 5/19/23 20:18, Vladislav Odintsov wrote: > There is no need to build lflows for datapaths, where there are no vtep type > lports. For instance, edge-outside logical switch, which has no vtep lports > but has many chassis redirect lport, can have many useless lflows. > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn 1/5] northd: fix ls_in_hairpin l3dgw flow generation

On 5/19/23 20:18, Vladislav Odintsov wrote: > This patch fixes a situation, where logical flow with incorrect syntax could > be generated. If a logical switch has two attached logical router ports and > one of them has configured gateway chassis, then incorrect flow can have the > match like: >

[ovs-dev] [PATCH v2] Add editorconfig file

EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in Documentation/internals/contributing/coding-style.rst In order for this file to be taken into account

[ovs-dev] [PATCH] netdev-dpdk: fix warning with gcc 13

GCC now reports uninitialized warnings from function return values. ../lib/netdev-dpdk.c: In function 'netdev_dpdk_mempool_configure': ../lib/netdev-dpdk.c:964:22: warning: 'dmp' may be used uninitialized [-Wmaybe-uninitialized] 964 | dev->dpdk_mp = dmp; |

[ovs-dev] [PATCH] Add editorconfig file

EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in Documentation/internals/contributing/coding-style.rst In order for this file to be taken into account

Re: [ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

Hi Dumitru, I agree with the requested changes, such approach seems much better. I’ve reworked patch and just sent v2. Please, check it out: https://patchwork.ozlabs.org/project/ovn/patch/20230530124157.1223591-1-odiv...@gmail.com/ > On 30 May 2023, at 12:44, Dumitru Ceara wrote: > > On

[ovs-dev] [PATCH ovn v2] northd: match only on supported protocols to handle_svc_check

Depending on the udp service, it can reply with some udp data. In that case ovn-controller will warn with next message: pinctrl(ovn_pinctrl0)|WARN|handle service check: Unsupported protocol - [11] This is not something abnormal, so it needs to be fixed. With this patch ovn-northd changes match

Re: [ovs-dev] [PATCH v5] backtrace: Extend the backtrace functionality

On 5/30/23 09:34, Ales Musil wrote: > > > On Mon, May 29, 2023 at 7:15 PM Ilya Maximets > wrote: > > On 5/25/23 08:33, Ales Musil wrote: > > Use the backtrace functions that is provided by libc, > > this allows us to get backtrace that is independent of >

Re: [ovs-dev] [PATCH v13 4/4] userspace: Enable L4 checksum offloading by default.

On 5/29/23 21:56, Mike Pattrick wrote: > On Wed, May 24, 2023 at 8:56 AM Ilya Maximets wrote: >> >> On 5/17/23 05:11, Mike Pattrick wrote: >>> From: Flavio Leitner >>> >>> The netdev receiving packets is supposed to provide the flags >>> indicating if the L4 checksum was verified and it is OK or

Re: [ovs-dev] [PATCH ovn 09/14] northd: Incremental processing of VIF additions in 'lflow' node.

On 5/29/23 20:42, Han Zhou wrote: > > > On Mon, May 29, 2023 at 9:24 AM Ilya Maximets > wrote: >> >> On 5/13/23 02:03, Han Zhou wrote: >> > This patch introduces a change handler for 'northd' input within the >> > 'lflow' node. It specifically handles cases when VIFs

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

> On 30 May 2023, at 13:10, Dumitru Ceara wrote: > > On 5/30/23 11:59, Vladislav Odintsov wrote: >> Hi Dumitru, >> >> thanks for the review! >> My answers are inline. >> >>> On 30 May 2023, at 12:27, Dumitru Ceara wrote: >>> >>> On 5/19/23 20:18, Vladislav Odintsov wrote: This patch

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

On 5/30/23 11:59, Vladislav Odintsov wrote: > Hi Dumitru, > > thanks for the review! > My answers are inline. > >> On 30 May 2023, at 12:27, Dumitru Ceara wrote: >> >> On 5/19/23 20:18, Vladislav Odintsov wrote: >>> This patch is intended to make next two changes: >>> >>> 1. Support

Re: [ovs-dev] [PATCH ovn v7 2/5] Track interface MTU in if-status-mgr

On 5/23/23 23:55, Ihar Hrachyshka wrote: > This will be used in a later patch to calculate the effective interface > MTU after considering tunneling overhead. > > NOTE: ideally, OVN would support Logical_Port MTU, in which case we > wouldn't have to track OVSDB for interfaces. > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn v7 5/5] Implement MTU Path Discovery for multichassis ports

On 5/23/23 23:55, Ihar Hrachyshka wrote: > When a multichassis port belongs to a switch with a localnet port, > packets originating or directed to the multichassis port are NOT sent > thorugh the localnet port. Instead, tunneling is enforced in-cluster to > guarantee delivery of all packets to all

[ovs-dev] [PATCH ovn v2] northd: Add logical flow to skip GARP with LLA

Skip GARP packet with link-local address being advertised when "always_learn_from_arp_request=false", this should prevent huge grow of MAC Binding table. To keep the option consistent overwrite the previous MAC with LLA if it was already stored in DB. Signed-off-by: Ales Musil --- v2: Remove

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

Hi Dumitru, thanks for the review! My answers are inline. > On 30 May 2023, at 12:27, Dumitru Ceara wrote: > > On 5/19/23 20:18, Vladislav Odintsov wrote: >> This patch is intended to make next two changes: >> >> 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP. >> >> Prior

Re: [ovs-dev] [PATCH ovn] northd: Add logical flow to skip GARP with LLA

On Tue, May 30, 2023 at 11:56 AM Ales Musil wrote: > Skip GARP packet with link-local address being advertised > when "always_learn_from_arp_request=false", this should > prevent huge grow of MAC Binding table. To keep the option > consistent overwrite the previous MAC with LLA if it was >

[ovs-dev] [PATCH ovn] northd: Add logical flow to skip GARP with LLA

Skip GARP packet with link-local address being advertised when "always_learn_from_arp_request=false", this should prevent huge grow of MAC Binding table. To keep the option consistent overwrite the previous MAC with LLA if it was already stored in DB. Signed-off-by: Ales Musil ---

[ovs-dev] [PATCH ovn v2] tests: Fixed "nested containers" test

When a port is removed from a logical switch, the ct-zone is flushed, then the ct-zone-id is removed from external_ids. This is done in two steps (ct-zone-id is removed when the transaction flushing the ct_zone is complete). ovn-nbctl --wait=hv sync does not take this into account, and hence

Re: [ovs-dev] [PATCH ovn] tests: Fixed "nested containers" test

Hi Mark Thanks for the review and sorry for the delay. Yes, you are right, this could have been easily modified as part of a test "clean up" ... I'll go for option 1, so that the test fails in case ovn is modified and a longer sync time is needed. Hence we'll get notified - it might be expected

Re: [ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

On 5/24/23 13:03, Ales Musil wrote: > On Mon, May 22, 2023 at 11:18 PM Vladislav Odintsov > wrote: > >> Depending on the udp service, it can reply with some udp data. >> In that case ovn-controller will warn with next message: >> >> pinctrl(ovn_pinctrl0)|WARN|handle service check: Unsupported

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

On 5/19/23 20:18, Vladislav Odintsov wrote: > This patch is intended to make next two changes: > > 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP. > > Prior to this patch MAC_Binding records were created only when LRP issued > ARP request/Neighbor solicitation. If IP to MAC in

[ovs-dev] [PATCH ovn] tests: fix flaky Multiple OVS interfaces bound to same logical porta

Fixes: 52cb9c3b41c2 ("ovn-controller: Fixed missing flows after interface deletion") Signed-off-by: Xavier Simonart --- tests/ovn.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovn.at b/tests/ovn.at index 6f9fbbfd2..b2ac2e068 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@

Re: [ovs-dev] [PATCH v3 3/7] odp-util: Extract vxlan gbp option encoding to a function

On 5/26/2023 5:10 PM, Eelco Chaudron wrote: External email: Use caution opening links or attachments On 15 May 2023, at 10:23, Roi Dayan wrote: From: Gavin Li Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in following commits. Signed-off-by: Gavin Li Reviewed-by:

Re: [ovs-dev] [PATCH v5] backtrace: Extend the backtrace functionality

On Mon, May 29, 2023 at 7:15 PM Ilya Maximets wrote: > On 5/25/23 08:33, Ales Musil wrote: > > Use the backtrace functions that is provided by libc, > > this allows us to get backtrace that is independent of > > the current memory map of the process. Which in turn can > > be used for

[ovs-dev] [PATCH v6] backtrace: Extend the backtrace functionality

Use the backtrace functions that is provided by libc, this allows us to get backtrace that is independent of the current memory map of the process. Which in turn can be used for debugging/tracing purpose. The backtrace is not 100% accurate due to various optimizations, most notably

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On 26 May 2023, at 22:51, Ilya Maximets wrote: > On 5/26/23 15:09, Eelco Chaudron wrote: >> >> >> On 26 May 2023, at 14:03, Balazs Nemeth wrote: >> >>> The only way that stats->{n_packets,n_bytes} would decrease is due to an >>> overflow, or if there are bugs in how statistics are handled. In