On Tue, Jun 6, 2023 at 7:57 AM Dumitru Ceara wrote:
>
> We don't need to explicitly add port bindings that were already bound
> locally. We implicitly get those because we monitor the datapaths
> they're attached to.
>
> When performing an ovn-heater 500-node density-heavy scale test [0], with
>
On 6/19/23 08:06, Mike Pattrick wrote:
> On Thu, Jun 15, 2023 at 3:30 PM Ilya Maximets wrote:
>>
>> On 6/14/23 21:03, Mike Pattrick wrote:
>>> This patch set is a stripped down subset of the initial 17 patchset
>>> introduced
>>> by Flavio Leitner in 2021.
>>>
>>> The initial omnibus patchset
EditorConfig is a file format and collection of text editor plugins for
maintaining consistent coding styles between different editors and IDEs.
Initialize the file following the coding rules in
Documentation/internals/contributing/coding-style.rst and add exceptions
declared in
The test failure is only on one of the tests and not related to this patch,
so looks like a fluke / flaky test.
Other than that, I accidentally excluded calls to `update-alternatives` required
to run the DPDK test as I mistakenly thought that was not relevant for
the upstream
package source, but
Kevin Traynor, Jun 15, 2023 at 12:53:
> > new_n_rxq = MAX(smap_get_int(args, "n_rxq", NR_QUEUE), 1);
> > +if (dev->requested_rx_steer_flags != 0) {
> > +new_n_rxq += 1;
>
> If rx-steering is set for the port and the flow has previously not been
> able to be offloaded, the
Introduce ls_datapath_group column in the load_balancer table of the SB
db and deprecate datapath_group one. This patch make the table symmetric
with lr_datapath_group column in the load_balancer table of SB db.
Signed-off-by: Lorenzo Bianconi
---
controller/chassis.c| 8
Introduce lr_datapath_group column in the load_balancer table of the SB
db.
Sync load_balancers applied to logical_routers to Load_Balancer table in
the SouthBound database.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2193323
Signed-off-by: Lorenzo Bianconi
---
Changes since RFC v2:
- introduce ls_datapath_group column and deprecate datapath_group one.
Changes since RFC v1:
- get rid of patch 1/2: northd: rename table datapath_group in
ls_datapath_group in load_balancer sb db table
Lorenzo Bianconi (2):
northd: sync lb applied to logical routers in
On Wed, Jun 14, 2023 at 9:45 AM David Marchand
wrote:
>
> At some point in OVS history, some virtio features were announced as
> supported (ECN and UFO virtio features).
>
> The userspace TSO code, which has been added later, does not support
> those features and tries to disable them.
>
> This
Add additional error coverage counters for dpif operation failures.
This could help to quickly identify netlink problems when communicating
with the OVS kernel module.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2070630
Signed-off-by: Eelco Chaudron
---
lib/dpif.c | 39
From: Gavin Li
Add a vxlan gbp offload test case:
vxlan offloads with gbp extention - ping between two ports - offloads
enabled ok
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
tests/system-offloads-traffic.at | 49
1 file
From: Gavin Li
Kernels that do not support vxlan gbp would treat the rule that has vxlan
gbp encap action or vxlan gbp id match differently, either reject it or
just skip the action/match and continue processing the knowing ones.
To solve the issue, probe and disallow inserting rules with vxlan
From: Gavin Li
Most of the data members of struct tc_action{ } are defined as anonymous
struct in place. Instead of passing all members of an anonymous struct,
which is not flexible to new members being added, expose encap as named
struct and pass it entirely.
Signed-off-by: Gavin Li
From: Gavin Li
Add TC offload support for vxlan encap with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
acinclude.m4 | 7
include/linux/tc_act/tc_tunnel_key.h | 17 +++-
From: Gavin Li
Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
lib/odp-util.c | 9 +++--
lib/odp-util.h | 8
2 files changed, 11 insertions(+), 6 deletions(-)
From: Gavin Li
Add TC offload support for filtering vxlan tunnels with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
include/linux/pkt_cls.h | 13 ++
lib/netdev-offload-tc.c | 17
lib/tc.c| 92
From: Gavin Li
Linux kernel netlink module added NLA_F_NESTED flag checking for nested
netlink messages in 5.2. A nested message without the flag set will be
treated as malformated one. The check is optional and is controlled by
message policy. To avoid this, add NLA_F_NESTED explicitly for all
From: Gavin Li
Tc flower tunnel key options were encoded in nl_msg_put_flower_tunnel_opts
and decoded in nl_parse_flower_tunnel_opts. Only geneve was supported.
To avoid adding more arguments to the function to support more vxlan
options in the future, change the function arguments to pass
From: Gavin Li
Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
lib/odp-util.c | 5 +++--
lib/odp-util.h | 5 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff
Hi,
This series adds TC offload support for filtering vxlan tunnels with gbp option.
First 4 patches do some refactoring and the later patches adds the feature.
Thanks,
Roi
changelog
v5:
- Fix byte order issue in probe.
v4:
- probe TC kernel for vxlan gbp support.
- add test.
- style fix in
On 6/19/2023 6:04 PM, Eelco Chaudron wrote:
On 19 Jun 2023, at 7:05, Chris Mi wrote:
Add three sFlow offload test cases:
3: offloads - sflow with sampling=1 - offloads enabled ok
4: offloads - sflow with sampling=2 - offloads enabled ok
5: offloads - ping over vxlan tunnel with
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Add three sFlow offload test cases:
>
> 3: offloads - sflow with sampling=1 - offloads enabled ok
> 4: offloads - sflow with sampling=2 - offloads enabled ok
> 5: offloads - ping over vxlan tunnel with sflow - offloads enabled ok
>
>
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Create a unique group ID to map the sFlow info when offloading sample
> action to TC. When showing the offloaded datapath flows, translate the
> group ID from TC sample action to sFlow info using the mapping.
>
> Signed-off-by: Chris Mi
>
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Iterate each registered offload API. It's not a problem for today
> since we only have one implementation.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> ---
>
You forgot to include my ACK on v27. So here it is again:
Acked-by: Eelco
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> In thread handler 0, add netdev offload recv in normal recv upcalls.
> To avoid starvation, introduce a flag to alternate the order of
> receiving normal upcalls and offload upcalls based on that flag.
>
> Add similar change for recv_wait.
>
>
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Initialize psample socket. Add sample recv API to receive sampled
> packets from psample socket. Add sample recv wait API to add psample
> socket fd to poll list.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
You forgot to include my ACK on
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> When offloading sample action to TC, userspace creates a unique ID
> to map sample action and tunnel info and passes this ID to kernel
> instead of the sample info. Kernel will send this ID and sampled
> packet to userspace. Using the ID, userspace
On 19 Jun 2023, at 7:01, Chris Mi wrote:
>
>>> +if (err) {
>>> +VLOG_ERR_RL(_rl, "No OVS_ACTION_ATTR_USERSPACE attribute");
>>> +}
>>> +return err;
>>> +}
>>> +
>>> +static void
>>> +offload_sample_init(struct offload_sample *sample,
>>> +const struct
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 89 characters long (recommended limit is 79)
#218 FILE:
This patch includes changes made earlier by David in the
ovs branch to cache the dpdk builds.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
v2: Replaced 'sleep 1' with '' after consulting with Dumitru.
v3: No changes
Note that I ran the full
Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
i.e., DPDK ports and mbuf memory.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
v2: No changes.
v3: Add 'dpdk-extra="--log-level=pmd.*:error --no-pci"' to test initialization.
On 16 Jun 2023, at 19:19, Aaron Conole wrote:
> Martin Kennelly writes:
>
>> Hey ovs community,
>>
>> I am a developer working on ovn-kubernetes and I want to programmatically
>> consume long poll information
>> i.e:
>> ovs|00211|timeval(handler25)|WARN|Unreasonably long 52388ms poll
The autopkgtests [0][1] are relevant in an upstream context
because an Open vSwitch contributor may want to have a quick
way of running the upstream system testsuites on recent
Debian/Ubuntu releases in an automated and contained manner.
During the Debian/Ubuntu/upstream package source sync work
On Thu, Jun 15, 2023 at 3:30 PM Ilya Maximets wrote:
>
> On 6/14/23 21:03, Mike Pattrick wrote:
> > This patch set is a stripped down subset of the initial 17 patchset
> > introduced
> > by Flavio Leitner in 2021.
> >
> > The initial omnibus patchset was very complex and included a refactor,
34 matches
Mail list logo
