Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging timestamp refresh mechanism

2023-07-20 Thread Ales Musil
On Thu, Jul 20, 2023 at 10:58 PM Mark Michelson wrote: > Hi Ales, > > I only had time to review patches 1-4 so far. I'll have to save patch 5 > for next week. > Hi Mark, thank you. I'll wait for the v5 review before posting next iteration. Thanks, Ales > > On 7/10/23 07:05, Ales Musil

Re: [ovs-dev] [PATCH ovn 4/5] controller: Add MAC cache I-P node

2023-07-20 Thread Mark Michelson
Hi Ales, I have a couple of comments in-line. On 7/10/23 07:05, Ales Musil wrote: The node currently keeps track of MAC bindings that have aging enabled. The purpose of this node is to have structures that can be used by the thread to update the timestamp when the MAC binding is used. The I-P

Re: [ovs-dev] [PATCH ovn 3/5] northd: Synchronize the MAC binding age threshold

2023-07-20 Thread Mark Michelson
Acked-by: Mark Michelson On 7/10/23 07:05, Ales Musil wrote: Synchrinoize the MAC binding age threashold to SB datapath. This is a preparation for the MAC binding refresh mechanism. Signed-off-by: Ales Musil --- northd/northd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [ovs-dev] [PATCH ovn 2/5] northd, controller: Use the MAC cache table

2023-07-20 Thread Mark Michelson
Hi Ales, Can you please add a test to tests/ovn-controller.at that ensures that flows in table 79 exist when we expect them to and that they are removed when we expect them to be removed? On 7/10/23 07:05, Ales Musil wrote: Populate and use the MAC cache table. The MAC cache has the

Re: [ovs-dev] [PATCH ovn 1/5] actions: Add mac_cache_use action

2023-07-20 Thread Mark Michelson
Acked-by: Mark Michelson On 7/10/23 07:05, Ales Musil wrote: The mac_cache_use is just resubmit to MAC use cache table, which will be later on used by the timestamp refresh mechanism. This is a preparation for the MAC binding refresh mechanism. Signed-off-by: Ales Musil ---

Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging timestamp refresh mechanism

2023-07-20 Thread Mark Michelson
Hi Ales, I only had time to review patches 1-4 so far. I'll have to save patch 5 for next week. On 7/10/23 07:05, Ales Musil wrote: The timestamp refresh mechanism is based on separate table. The new thread will collect flow statistics from this table and based on "idle_age" data we can

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

2023-07-20 Thread Aaron Conole
Ilya Maximets writes: > On 7/20/23 16:55, Aaron Conole wrote: >> Ilya Maximets writes: >> >>> OVS configuration is based on port names and OpenFlow port numbers. >>> Names are stored in the database and translated later to OF ports. >>> On the datapath level, each port has a name and a

Re: [ovs-dev] [PATCH v2] ovs-tcpdump: Bugfix-of-ovs-tcpdump

2023-07-20 Thread Aaron Conole
Hi Simon, Thanks for the contribution! Simon Jones writes: > From: simon > > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > > As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6 address by > default. This is true only on systems where the ipv6 autoconf sysctl is

Re: [ovs-dev] [PATCH] netdev-tc-offload: Fix ip protocols not offloaded in ip rewrite

2023-07-20 Thread Aaron Conole
Faicker Mo via dev writes: > The warning message is > |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X. > > Some ip protocols like ipip, gre and so on do not need the recalculation of > the checksum of themself except for the ip header checksum recalculation > in the ip

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

2023-07-20 Thread Ilya Maximets
On 7/20/23 16:55, Aaron Conole wrote: > Ilya Maximets writes: > >> OVS configuration is based on port names and OpenFlow port numbers. >> Names are stored in the database and translated later to OF ports. >> On the datapath level, each port has a name and a datapath port number. >> Port name in

[ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-20 Thread Mike Pattrick
When the a revalidator thread is updating statistics for an XC_LEARN xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. The revalidator will update stats for rules even if they are in a removed state or marked as invisible. However, ofproto_flow_mod_learn will detect if a flow

[ovs-dev] [PATCH v2 ovn] controller: make garp_max_timeout configurable

2023-07-20 Thread Lorenzo Bianconi
When using VLAN backed networks and OVN routers leveraging the 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field is replaced by the chassis mac address in order to not expose the router mac address from different nodes and confuse the TOR switch. However doing so the TOR

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

2023-07-20 Thread Aaron Conole
Ilya Maximets writes: > OVS configuration is based on port names and OpenFlow port numbers. > Names are stored in the database and translated later to OF ports. > On the datapath level, each port has a name and a datapath port number. > Port name in the database has to match datapath port name,

Re: [ovs-dev] [PATCH ovn] controller: make garp_max_timeout configurable

2023-07-20 Thread Lorenzo Bianconi
> On Mon, Jun 5, 2023 at 5:54 PM Lorenzo Bianconi > wrote: > > > > When using VLAN backed networks and OVN routers leveraging the > > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field > > is > > replaced by the chassis mac address in order to not expose the router mac >

Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Mirror packets that are modified

2023-07-20 Thread Aaron Conole
Mike Pattrick writes: > Currently OVS keeps track of which mirrors that each packet has been > sent to for the purpose of deduplication. However, this doesn't consider > that openflow rules can make significant changes to packets after > ingress. > > For example, OVN can create OpenFlow rules

Re: [ovs-dev] Time for a 22.03.3 point release?

2023-07-20 Thread Ihar Hrachyshka
Yes. We also have a bit of a mess in openstack upstream gates where we committed some stateless security groups test scenarios that rely on a bug fix that is in the non-released version of the branch. (And it turned out that our initial attempt to adjust deployment scripts to pull a git commit

[ovs-dev] [PATCH ovn] northd: Make sure that skip_snat=true is evaluated before force_snat

2023-07-20 Thread Ales Musil
The affinity code was differentiating between force_snat and skip snat. However, if both parameters were set at the same time the force_snat would be preferred, which shouldn't be the case. Make sure the skip_snat is preferred if both parameters are present. Fixes: d3926b433e44 ("northd: rely on

[ovs-dev] Time for a 22.03.3 point release?

2023-07-20 Thread Frode Nordahl
Hello, As far as I understand the OVN release process documentation, this month is a good month for an OVN point release. We are anticipating one for: * The numerous flaky test fixes (thanks alot for doing those!) * 4b10571aa89b ("controller: Ignore DNS queries with RRs") And lots of other

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

2023-07-20 Thread Alin Serdean
Thanks for the quick patch! Tested-by: Alin-Gabriel Serdean Acked-by: Alin-Gabriel Serdean From: Ilya Maximets Sent: Wednesday, July 19, 2023 6:14 PM To: ovs-dev@openvswitch.org Cc: Alin Serdean ; Eelco Chaudron ; Ilya Maximets Subject: [PATCH]

Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Mirror packets that are modified

2023-07-20 Thread Eelco Chaudron
On 19 Jul 2023, at 18:21, Mike Pattrick wrote: > Currently OVS keeps track of which mirrors that each packet has been > sent to for the purpose of deduplication. However, this doesn't consider > that openflow rules can make significant changes to packets after > ingress. > > For example, OVN

Re: [ovs-dev] [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly

2023-07-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Sun, 16 Jul 2023 17:09:16 -0400 you wrote: > With the OVS upcall, the original ct in the skb will be dropped, and when > the skb comes back from userspace it has to create a new ct again through > nf_conntrack_in()