Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-24 Thread Vladislav Odintsov
Hi Dumitru, I just wanted to ask wether you need any help (maybe, testing) in this? I’m ready to check this on my dataset if you were successful to implement a fix. > On 12 Jul 2023, at 12:15, Dumitru Ceara wrote: > > On 7/12/23 00:01, Ilya Maximets wrote: >> On 7/11/23 19:01, Dumitru Ceara

Re: [ovs-dev] [PATCH ovn] fix missing documentation of ovn-ic arguments

2023-07-24 Thread 0-day Robot
Bleep bloop. Greetings Felix Huettner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around

[ovs-dev] [PATCH ovn] northd: support binding remote ports in ovn-northd

2023-07-24 Thread Lorenzo Bianconi
ovn supports creating remote logical ports. An user can set requested-chassis option for a logical switch port to the remote chassis and ovn-northd can bind it to that chassis. This is required for OVN IC in ovn-k8s. Right now ovn-k8s ovnkube-controller after creating a remote logical port, sets

[ovs-dev] [PATCH ovn] fix missing documentation of ovn-ic arguments

2023-07-24 Thread Felix Huettner via dev
the arguments for the interconnect database where missing. Signed-off-by: Felix Huettner --- ic/ovn-ic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 6f31037ec..db7e86bc1 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -106,11 +106,16

Re: [ovs-dev] [PATCH net-next 4/7] net: openvswitch: add misc error drop reasons

2023-07-24 Thread Aaron Conole
Adrian Moreno writes: > Use drop reasons from include/net/dropreason-core.h when a reasonable > candidate exists. > > Signed-off-by: Adrian Moreno > --- > net/openvswitch/actions.c | 17 ++--- > net/openvswitch/conntrack.c | 3 ++- > net/openvswitch/drop.h | 6 ++ > 3

Re: [ovs-dev] [PATCH net-next 7/7] selftests: openvswitch: add explicit drop testcase

2023-07-24 Thread Aaron Conole
Adrian Moreno writes: > Make ovs-dpctl.py support explicit drops as: > "drop" -> implicit empty-action drop > "drop(0)" -> explicit non-error action drop > "drop(42)" -> explicit error action drop > > Signed-off-by: Adrian Moreno > --- > .../selftests/net/openvswitch/openvswitch.sh | 25

Re: [ovs-dev] [PATCH net-next 2/7] net: openvswitch: add explicit drop action

2023-07-24 Thread Aaron Conole
Adrian Moreno writes: > From: Eric Garver > > This adds an explicit drop action. This is used by OVS to drop packets > for which it cannot determine what to do. An explicit action in the > kernel allows passing the reason _why_ the packet is being dropped or > zero to indicate no particular

Re: [ovs-dev] [PATCH net-next 0/7] openvswitch: add drop reasons

2023-07-24 Thread Aaron Conole
Adrian Moreno writes: > There is currently a gap in drop visibility in the openvswitch module. > This series tries to improve this by adding a new drop reason subsystem > for OVS. > > Apart from adding a new drop reasson subsystem and some common drop > reasons, this series takes Eric's

Re: [ovs-dev] [PATCH] netdev-tc-offload: Fix ip protocols not offloaded in ip rewrite

2023-07-24 Thread Faicker Mo via dev
About the second change, A large part of ip protocols do not need the checksum recalculation of themself. There are only 6 protocols in tc csum action except for the ip header. If a protocol need the recalculation of the checksum, may be it should add the special handling in TC, because each has