Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

On 7/28/23 23:13, Mike Pattrick wrote: > On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets > wrote: > > On 7/20/23 17:06, Mike Pattrick wrote: > > When the a revalidator thread is updating statistics for an XC_LEARN > > xcache entry in xlate_push_stats_entry it

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets wrote: > On 7/20/23 17:06, Mike Pattrick wrote: > > When the a revalidator thread is updating statistics for an XC_LEARN > > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. > > The revalidator will update stats for rules even

Re: [ovs-dev] [PATCH ovn] binding: handle ovs ofport update

Hi Mohammad, The actual code change looks good, but I have some other minor comments to address. See inline below. On 7/26/23 12:12, Mohammad Heib wrote: Currently when ovs interface ofport is updated after setting external_ids:iface_id, the ovn-controller will see this change but will not

[ovs-dev] OVN 23.09 proposed delay

Hi everyone, According to the release calendar, OVN 23.09 is supposed to enter soft freeze next week on 4 August, 2023. However, some OVN developers have some code changes that they wish to get in but that they do not think they can get in before the scheduled soft freeze. Given that this is

Re: [ovs-dev] [RFC ovn-heater] OVN scale testing with OpenStack workloads - questionnaire

Hello OVN community, Following up on my previous email: Robin Jarry, Jul 26, 2023 at 21:19: > as discussed yesterday during the community meeting and today on IRC, > I have created a public form that we can use to aggregate the results. > > https://forms.gle/bmZARvrxgfrJvzkn6 > > No account is

Re: [ovs-dev] [PATCH v2 net-next 1/5] selftests: openvswitch: add an initial flow programming case

On 7/28/23 13:59, Aaron Conole wrote: The openvswitch self-tests can test much of the control side of the module (ie: what a vswitchd implementation would process), but the actual packet forwarding cases aren't supported, making the testing of limited value. Add some flow parsing and an

Re: [ovs-dev] [PATCH v2 net-next 3/5] selftests: openvswitch: add a test for ipv4 forwarding

On 7/28/23 13:59, Aaron Conole wrote: This is a simple ipv4 bidirectional connectivity test. Signed-off-by: Aaron Conole Reviewed-by: Adrian Moreno --- .../selftests/net/openvswitch/openvswitch.sh | 40 +++ 1 file changed, 40 insertions(+) diff --git

Re: [ovs-dev] [PATCH v2 net-next 4/5] selftests: openvswitch: add basic ct test case parsing

On 7/28/23 13:59, Aaron Conole wrote: Forwarding via ct() action is an important use case for openvswitch, but generally would require using a full ovs-vswitchd to get working. Add a ct action parser for basic ct test case. Signed-off-by: Aaron Conole Reviewed-by: Adrian Moreno ---

Re: [ovs-dev] [PATCH v2 net-next 5/5] selftests: openvswitch: add ct-nat test case with ipv4

On 7/28/23 13:59, Aaron Conole wrote: Building on the previous work, add a very simplistic NAT case using ipv4. This just tests dnat transformation Signed-off-by: Aaron Conole --- .../selftests/net/openvswitch/openvswitch.sh | 64

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 7/28/23 11:02, Peng He wrote: > > > Ilya Maximets mailto:i.maxim...@ovn.org>> 于2023年7月28日周五 > 00:59写道： > > On 7/27/23 04:31, Peng He wrote: > > > > > > Eelco Chaudron mailto:echau...@redhat.com> > >> 于2023年7月6日周四 >

Re: [ovs-dev] [PATCH v2 net-next 5/5] selftests: openvswitch: add ct-nat test case with ipv4

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v2 net-next 4/5] selftests: openvswitch: add basic ct test case parsing

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v2 net-next 3/5] selftests: openvswitch: add a test for ipv4 forwarding

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v2 net-next 2/5] selftests: openvswitch: support key masks

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v2 net-next 1/5] selftests: openvswitch: add an initial flow programming case

Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless

[ovs-dev] [PATCH v2 net-next 1/5] selftests: openvswitch: add an initial flow programming case

The openvswitch self-tests can test much of the control side of the module (ie: what a vswitchd implementation would process), but the actual packet forwarding cases aren't supported, making the testing of limited value. Add some flow parsing and an initial ARP based test case using arping

[ovs-dev] [PATCH v2 net-next 0/5] selftests: openvswitch: add flow programming cases

The openvswitch selftests currently contain a few cases for managing the datapath, which includes creating datapath instances, adding interfaces, and doing some basic feature / upcall tests. This is useful to validate the control path. Add the ability to program some of the more common flows

[ovs-dev] [PATCH v2 net-next 4/5] selftests: openvswitch: add basic ct test case parsing

Forwarding via ct() action is an important use case for openvswitch, but generally would require using a full ovs-vswitchd to get working. Add a ct action parser for basic ct test case. Signed-off-by: Aaron Conole --- NOTE: 3 lines flag the line-length checkpatch warning, but there didnt

[ovs-dev] [PATCH v2 net-next 5/5] selftests: openvswitch: add ct-nat test case with ipv4

Building on the previous work, add a very simplistic NAT case using ipv4. This just tests dnat transformation Signed-off-by: Aaron Conole --- .../selftests/net/openvswitch/openvswitch.sh | 64 .../selftests/net/openvswitch/ovs-dpctl.py| 75 +++ 2 files

[ovs-dev] [PATCH v2 net-next 3/5] selftests: openvswitch: add a test for ipv4 forwarding

This is a simple ipv4 bidirectional connectivity test. Signed-off-by: Aaron Conole --- .../selftests/net/openvswitch/openvswitch.sh | 40 +++ 1 file changed, 40 insertions(+) diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh

[ovs-dev] [PATCH v2 net-next 2/5] selftests: openvswitch: support key masks

From: Adrian Moreno From: Adrian Moreno The default value for the mask actually depends on the value (e.g: if the value is non-null, the default is full-mask), so change the convert functions to accept the full, possibly masked string and let them figure out how to parse the differnt values.

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

On 7/20/23 17:06, Mike Pattrick wrote: > When the a revalidator thread is updating statistics for an XC_LEARN > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. > The revalidator will update stats for rules even if they are in a > removed state or marked as invisible.

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

Hi Vladislav, After quite some time trying to implement the IDL API change to allow setting a different default monitor condition and mostly struggling with ovn-controller using that properly I kind of gave up and decided to approach this in a different way. We have guidelines about supported

Re: [ovs-dev] [PATCH ovn 2/5] northd, controller: Use the MAC cache table

On Thu, Jul 20, 2023 at 10:58 PM Mark Michelson wrote: > Hi Ales, > > Can you please add a test to tests/ovn-controller.at that ensures that > flows in table 79 exist when we expect them to and that they are removed > when we expect them to be removed? > Hi Mark, I did adjust in v2 the MAC

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Ilya Maximets 于2023年7月28日周五 00:59写道： > On 7/27/23 04:31, Peng He wrote: > > > > > > Eelco Chaudron mailto:echau...@redhat.com>> > 于2023年7月6日周四 15:52写道： > > > > > > > > On 6 Jul 2023, at 4:32, Peng He wrote: > > > > > Eelco Chaudron mailto:echau...@redhat.com>> > 于2023年7月5日周三 22:16写道： > >

Re: [ovs-dev] [PATCH ovn 5/5] controller: Update MAC binding timestamp

On Thu, Jul 27, 2023 at 9:17 PM Mark Michelson wrote: > Hi Ales, I had a look through this patch finally :) > > From a high-level, I appreciate the design. Periodically requesting > flow stats in a background thread makes good sense. > > I have a couple of suggestions to make to the design. >