Re: [ovs-dev] [PATCH v3 net-next 5/5] selftests: openvswitch: add ct-nat test case with ipv4

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v3 net-next 4/5] selftests: openvswitch: add basic ct test case parsing

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v3 net-next 3/5] selftests: openvswitch: add a test for ipv4 forwarding

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v3 net-next 1/5] selftests: openvswitch: add an initial flow programming case

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless

Re: [ovs-dev] [PATCH v3 net-next 2/5] selftests: openvswitch: support key masks

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

[ovs-dev] [PATCH v3 net-next 5/5] selftests: openvswitch: add ct-nat test case with ipv4

2023-08-01 Thread Aaron Conole
Building on the previous work, add a very simplistic NAT case using ipv4. This just tests dnat transformation Signed-off-by: Aaron Conole --- NOTE: A number of lines flag the line-length checkpatch warning, but there didnt seem to be a really good way of breaking the lines smaller.

[ovs-dev] [PATCH v3 net-next 4/5] selftests: openvswitch: add basic ct test case parsing

2023-08-01 Thread Aaron Conole
Forwarding via ct() action is an important use case for openvswitch, but generally would require using a full ovs-vswitchd to get working. Add a ct action parser for basic ct test case. Signed-off-by: Aaron Conole Reviewed-by: Adrian Moreno --- NOTE: A number of lines flag the line-length

[ovs-dev] [PATCH v3 net-next 3/5] selftests: openvswitch: add a test for ipv4 forwarding

2023-08-01 Thread Aaron Conole
This is a simple ipv4 bidirectional connectivity test. Signed-off-by: Aaron Conole Reviewed-by: Adrian Moreno --- NOTE: 4 lines flag the line-length checkpatch warning, but there didn't seem to be a good way of breaking the lines smaller. .../selftests/net/openvswitch/openvswitch.sh |

[ovs-dev] [PATCH v3 net-next 2/5] selftests: openvswitch: support key masks

2023-08-01 Thread Aaron Conole
From: Adrian Moreno The default value for the mask actually depends on the value (e.g: if the value is non-null, the default is full-mask), so change the convert functions to accept the full, possibly masked string and let them figure out how to parse the different values. Also, implement

[ovs-dev] [PATCH v3 net-next 1/5] selftests: openvswitch: add an initial flow programming case

2023-08-01 Thread Aaron Conole
The openvswitch self-tests can test much of the control side of the module (ie: what a vswitchd implementation would process), but the actual packet forwarding cases aren't supported, making the testing of limited value. Add some flow parsing and an initial ARP based test case using arping

[ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases

2023-08-01 Thread Aaron Conole
The openvswitch selftests currently contain a few cases for managing the datapath, which includes creating datapath instances, adding interfaces, and doing some basic feature / upcall tests. This is useful to validate the control path. Add the ability to program some of the more common flows

Re: [ovs-dev] [PATCH ovn v2] binding: handle ovs ofport update

2023-08-01 Thread Mark Michelson
Thanks for the changes, Mohammad. Acked-by: Mark Michelson On 7/31/23 13:18, Mohammad Heib wrote: Currently when ovs interface ofport is updated after setting external_ids:iface_id, the ovn-controller will see this change but will not do much if it handles this change incrementally. This

[ovs-dev] [RFC net-next v2 4/7] net: openvswitch: add meter drop reason

2023-08-01 Thread Adrian Moreno
By using an independent drop reason it makes it easy to ditinguish between QoS-triggered or flow-triggered drop. Signed-off-by: Adrian Moreno --- net/openvswitch/actions.c | 2 +- net/openvswitch/drop.h| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [RFC net-next v2 0/7] openvswitch: add drop reasons

2023-08-01 Thread Adrian Moreno
There is currently a gap in drop visibility in the openvswitch module. This series tries to improve this by adding a new drop reason subsystem for OVS. Apart from adding a new drop reasson subsystem and some common drop reasons, this series takes Eric's preliminary work [1] on adding an explicit

[ovs-dev] [RFC net-next v2 7/7] selftests: openvswitch: add explicit drop testcase

2023-08-01 Thread Adrian Moreno
Make ovs-dpctl.py support explicit drops as: "drop" -> implicit empty-action drop "drop(0)" -> explicit non-error action drop "drop(42)" -> explicit error action drop Signed-off-by: Adrian Moreno --- .../selftests/net/openvswitch/openvswitch.sh | 25 +++

[ovs-dev] [RFC net-next v2 6/7] selftests: openvswitch: add drop reason testcase

2023-08-01 Thread Adrian Moreno
Test if the correct drop reason is reported when OVS drops a packet due to an explicit flow. Signed-off-by: Adrian Moreno --- .../selftests/net/openvswitch/openvswitch.sh | 67 ++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [RFC net-next v2 5/7] net: openvswitch: add misc error drop reasons

2023-08-01 Thread Adrian Moreno
Use drop reasons from include/net/dropreason-core.h when a reasonable candidate exists. Signed-off-by: Adrian Moreno --- net/openvswitch/actions.c | 17 ++--- net/openvswitch/conntrack.c | 3 ++- net/openvswitch/drop.h | 6 ++ 3 files changed, 18 insertions(+), 8

[ovs-dev] [RFC net-next v2 1/7] net: openvswitch: add datapath flow drop reason

2023-08-01 Thread Adrian Moreno
Create a new drop reason subsystem for openvswitch and add the first drop reason to represent flow drops. A flow drop happens when a flow has an empty action-set or there is no action that consumes the packet (output, userspace, recirc, etc). Implementation-wise, most of these skb-consuming

[ovs-dev] [RFC net-next v2 3/7] net: openvswitch: add explicit drop action

2023-08-01 Thread Adrian Moreno
From: Eric Garver From: Eric Garver This adds an explicit drop action. This is used by OVS to drop packets for which it cannot determine what to do. An explicit action in the kernel allows passing the reason _why_ the packet is being dropped or zero to indicate no particular error happened

[ovs-dev] [RFC net-next v2 2/7] net: openvswitch: add action error drop reason

2023-08-01 Thread Adrian Moreno
Add a drop reason for packets that are dropped because an action returns a non-zero error code. Signed-off-by: Adrian Moreno --- net/openvswitch/actions.c | 2 +- net/openvswitch/drop.h| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/actions.c

Re: [ovs-dev] [PATCH v7 3/4] netdev-dpdk: Add support for egress packet-per-second policing.

2023-08-01 Thread miter
Hi Aaron, Thanks for reviewing my code. I will update a new patch later. On 8/1/2023 4:10 AM, Aaron Conole wrote: mit...@outlook.com writes: From: Lin Huang OvS has supported packet-per-second policer which can be set at ingress and egress side in kernel datapath. But the userspace

Re: [ovs-dev] [PATCH v7 4/4] netdev-dpdk: Add support for ingress packet-per-second policing.

2023-08-01 Thread miter
Hi Aaron, Thanks for reviewing my code. I will update a new patch later. On 8/1/2023 4:11 AM, Aaron Conole wrote: mit...@outlook.com writes: From: Lin Huang OvS has supported packet-per-second policer which can be set at ingress and egress side in kernel datapath. But the userspace

[ovs-dev] [PATCH ovn v3] Expose distributed gateway port information in NB DB

2023-08-01 Thread lmartins
From: Lucas Alvares Gomes In order for the CMS to know which Chassis a distributed gateway port is bond to, this patch updates the ovn-northd daemon to populate the Logical_Router_Port table with that information. To avoid changing the database schema, ovn-northd is setting a new key called

Re: [ovs-dev] [PATCH ovn] ovn-controller: Detect and use L4_SYM dp-hash if available.

2023-08-01 Thread Han Zhou
On Tue, Jul 18, 2023 at 6:16 AM Dumitru Ceara wrote: > > On 7/18/23 12:14, Han Zhou wrote: > > On Mon, Jul 17, 2023 at 9:51 PM Dumitru Ceara wrote: > >> > >> On 7/14/23 08:41, Ales Musil wrote: > >>> On Thu, Jul 13, 2023 at 4:39 PM Dumitru Ceara wrote: > >>> > Regular dp-hash is not a

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-08-01 Thread Vladislav Odintsov
Hi Dumitru! I’ve performed test on the host, where ovn-controller (22.09.x) without your patch and without any local datapaths consumed 3+GiB of ram after start and the process start took 100% CPU during ~40 seconds after start. With your patch ovn-controller starts during ~5 seconds with max

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

2023-08-01 Thread Ilya Maximets
On 7/31/23 21:31, Aaron Conole wrote: > Ilya Maximets writes: > >> On 7/20/23 21:18, Aaron Conole wrote: >>> Ilya Maximets writes: >>> On 7/20/23 16:55, Aaron Conole wrote: > Ilya Maximets writes: > >> OVS configuration is based on port names and OpenFlow port numbers. >>

[ovs-dev] [Qestion] How can I get traffic statistics of an OVN QoS item?

2023-08-01 Thread yang_y_yi
Hi, folks After I added QoS, I can see it by ovn-nbctl list qos """ _uuid               : 690ecdf9-c6ae-41ef-a4ae-0a7a7c7c33ce action              : {} bandwidth           : {rate=100} direction           : to-lport external_ids        : {} match               : "outport ==

Re: [ovs-dev] backporting 8c341b9d704cdf002126699527308203319954f0 to 22.03 ?

2023-08-01 Thread Dumitru Ceara
On 8/1/23 10:53, Nikhil Kshirsagar wrote: > Hello Han, Dmitri, > > my name is Nikhil and I saw your contact details on the upstream ovn git repo. > Hi Nikhil, Nice to meet you! I'm cc-ing the ovs-dev mailing list where the OVN development work currently happens. > I am writing to you for

Re: [ovs-dev] [PATCH ovn 2/2] ovn-ic: support learning routes in same AZ

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings maximkorezkij, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author maximkorezkij needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn 1/2] ovn-ic fix multiple routers in an az

2023-08-01 Thread 0-day Robot
Bleep bloop. Greetings maximkorezkij, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author maximkorezkij needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] [PATCH ovn 2/2] ovn-ic: support learning routes in same AZ

2023-08-01 Thread maximkorezkij via dev
when connecting multiple logical routers to a transit switch per az then previously the routers in the same az would not learn each others routes while the routers in the others az would learn all of them. As this is confusing and would require each user to have additional logical that configures

[ovs-dev] [PATCH ovn 1/2] ovn-ic fix multiple routers in an az

2023-08-01 Thread Maxim Korezkij via dev
previously if multiple routers in the same az are connected to the same transit switch then ovn-ic would only propagate the routes of one of these routers to the ic-sb. This commit fixes this behaviour and allows multiple routers in a single az to use route advertisements. Signed-off-by: Maxim