Re: [ovs-dev] [PATCH v3] ovs-tcpdump: Bugfix-of-ovs-tcpdump

OK. At last, I think this patch is done, nothing need I do. Is that? Simon Jones Ilya Maximets 于2023年8月3日周四 22:46写道： > On 7/28/23 03:41, Simon Jones wrote: > > From: Simon Jones > > > > ovs-tcpdump: clear auto-assigned ipv6 address of mirror port > > I think, that supposed to be a

[ovs-dev] [PATCH ovn] northd: Fall back to 'northd' engine recompute for certain VIF scenarios.

From: Numan Siddique When a logical switch has only router ports and if a new VIF port is added, both northd engine and lflow engine handle this change incrementally, but it misses out on adding a few logical flows where we have checks like : if (od->n_router_ports != od->nbs->n_ports) {

[ovs-dev] [PATCH v14 4/4] treewide: Add `ovs_assert` to check for null pointers

This patch adds an assortment of `ovs_assert` statements to check for null pointers. We use assertions since it should be impossible for any of these pointers to be NULL. Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman --- lib/dp-packet.c| 1 + lib/odp-execute.c |

[ovs-dev] [PATCH v14 3/4] lib, ovsdb, vtep: Add various null pointer checks

This commit adds various null pointer checks to some files in the `lib`, `ovsdb`, and `vtep` directories to fix several Coverity defects. These changes are grouped together as they perform similar checks, returning early, skipping some action, or logging a warning if a null pointer is encountered.

[ovs-dev] [PATCH v14 1/4] lib: Add non-null assertions to some return values of `dp_packet_data`

This commit adds some `ovs_assert()` checks to some return values of `dp_packet_data()` to ensure that they are not NULL and to prevent null-pointer dereferences, which might lead to unwanted crashes. We use assertions since it should be impossible for these calls to `dp_packet_data()` to return

[ovs-dev] [PATCH v14 0/4] treewide: Fix multiple Coverity defects

This cleanup patchset addresses several high and medium-impact Coverity defects. Unit tests have been successfully executed via `make check` and they successfully passed. The list of revisions so far: v2: Fix some apply-robot checkpatch errors and warnings. v3: Fix some apply-robot checkpatch

[ovs-dev] [PATCH v14 2/4] lib, ovs-vsctl: Add zero-initializations

This commit adds zero-initializations by changing `SFL_ALLOC` from `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`, initializing a `pollfd` struct variable with zeroes, and changing some calls to `xmalloc` to `xzalloc`. This is to prevent potential data leaks or undefined behavior from

[ovs-dev] [PATCH v13 4/4] treewide: Add `ovs_assert` to check for null pointers

This patch adds an assortment of `ovs_assert` statements to check for null pointers. We use assertions since it should be impossible for any of these pointers to be NULL. Signed-off-by: James Raphael Tiovalen Reviewed-by: Simon Horman --- lib/dp-packet.c| 1 + lib/odp-execute.c |

[ovs-dev] [PATCH v13 3/4] lib, ovsdb, vtep: Add various null pointer checks

This commit adds various null pointer checks to some files in the `lib` and the `ovsdb` directories to fix several Coverity defects. These changes are grouped together as they perform similar checks, returning early or skipping some action if a null pointer is encountered. Signed-off-by: James

[ovs-dev] [PATCH v13 2/4] lib, ovs-vsctl: Add zero-initializations

This commit adds zero-initializations by changing `SFL_ALLOC` from `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`, initializing a `pollfd` struct variable with zeroes, and changing some calls to `xmalloc` to `xzalloc`. This is to prevent potential data leaks or undefined behavior from

[ovs-dev] [PATCH v13 1/4] lib: Add non-null assertions to some return values of `dp_packet_data`

This commit adds some `ovs_assert()` checks to some return values of `dp_packet_data()` to ensure that they are not NULL and to prevent null-pointer dereferences, which might lead to unwanted crashes. We use assertions since it should be impossible for these calls to `dp_packet_data()` to return

[ovs-dev] [PATCH v13 0/4] treewide: Fix multiple Coverity defects

This cleanup patchset addresses several high and medium-impact Coverity defects. Unit tests have been successfully executed via `make check` and they successfully passed. The list of revisions so far: v2: Fix some apply-robot checkpatch errors and warnings. v3: Fix some apply-robot checkpatch

Re: [ovs-dev] [PATCH v12 8/8] treewide: Add `ovs_assert` to check for null pointers

On Wed, Jul 12, 2023 at 6:49 AM Ilya Maximets wrote: > > These are not optional for a json parser and ovsdb_parser_finish() > checks and fails if they do not exist. I don't think we should > check them here. If we can't trust the parser code, we'll need to > add this kind of checks in many

Re: [ovs-dev] [PATCH v12 8/8] treewide: Add `ovs_assert` to check for null pointers

On Tue, Jul 11, 2023 at 7:40 PM Eelco Chaudron wrote: > > I think we should not assert, but do proper error handling here with a > dpctl_error() > Sure, will do that in the next patch version. > > Same as above. > Got it. > > I think if we do a pop from an empty set, we should just return

Re: [ovs-dev] [PATCH v12 7/8] lib, ovsdb: Add various null pointer checks

On Tue, Jul 11, 2023 at 6:33 PM Eelco Chaudron wrote: > > Maybe just define it here (and remove it above).. > > char *name = node->name; > Sure. > > Line feed. > Sure. > > Looks a bit odd in the middle of the definitions. Maybe move it down? > > struct ovsdb_error *error; > struct

Re: [ovs-dev] [PATCH v12 2/8] lib, ovs-vsctl: Add zero-initializations

On Tue, Jul 11, 2023 at 6:03 PM Eelco Chaudron wrote: > > Add a new line here. > Sure. > > Assert should not be needed as xzalloc will do this. > Agreed, will remove this in the next patch version. Best regards, James Raphael Tiovalen ___ dev

Re: [ovs-dev] [PATCH v12 1/8] lib: Add non-null assertions to some return values of `dp_packet_data`

On Tue, Jul 11, 2023 at 5:50 PM Eelco Chaudron wrote: > > This patch looks good, however, it needs a re-work due to changes to tunnel > checksum handling. > > //Eelco > Apologies for the late reply. I have been busy with other work. I will fix the merge conflict in the next patch version. Best

Re: [ovs-dev] [PATCH v3] ovs-tcpdump: Bugfix-of-ovs-tcpdump

On 7/28/23 03:41, Simon Jones wrote: > From: Simon Jones > > ovs-tcpdump: clear auto-assigned ipv6 address of mirror port I think, that supposed to be a Subject line. > > ovs-tcpdump will add mipxxx NIC, and on some systems this NIC has IPv6 > address by default. For vxlan topology, mipxxx,

Re: [ovs-dev] [PATCH] ovsdb-tool: Fix json leak while showing clustered log.

On 8/2/23 22:43, Dumitru Ceara wrote: > On 8/2/23 18:46, Ilya Maximets wrote: >> The json read from file is never freed in ovsdb-tool show-log >> for a clustered database: >> >> ERROR: LeakSanitizer: detected memory leaks >> >> Direct leak of 10774760 byte(s) in 269369 object(s) allocated from:

Re: [ovs-dev] [PATCH] ovsdb-server: Fix excessive memory usage on DB open.

On 8/2/23 22:41, Dumitru Ceara wrote: > On 8/2/23 15:45, Ilya Maximets wrote: >> During initial read of a database file all the file transactions are >> added to the transaction history. The history run with the history >> size checks is only executed after the whole file is processed. >> If, for

Re: [ovs-dev] [PATCH 4/4] tests: Add ovsdb execution cases for set size constraints.

On 8/2/23 22:19, Dumitru Ceara wrote: > On 7/25/23 11:32, Ilya Maximets wrote: >> Adding an extra check to one of the ovsdb execution cases that will >> verify that ovsdb-server is able to read back transactions previously >> written to a database file. And also adding new execution tests >> that

Re: [ovs-dev] backporting 8c341b9d704cdf002126699527308203319954f0 to 22.03 ?

Hi Dumitru, thanks for writing back. Yes, I needed to first switch the ovn branch and then get the ovs version for that one. I tried backporting it to 22.09 first, and when I cherry picked 8c341b9d704cdf002126699527308203319954f0 and then 27a92cc272 followed by a42c808f30 with manual conflict

Re: [ovs-dev] [PATCH v2 ovn 0/2] sync lb applied to logical routers in sb db lb table

On 8/3/23 09:46, Ales Musil wrote: > > > On Fri, Jul 14, 2023 at 5:25 PM Lorenzo Bianconi > wrote: > > Changes since v1: > - rebase on top of ovn main branch > - cosmetics > Changes since RFC v2: > - introduce ls_datapath_group column and

[ovs-dev] [PATCH] ci: Fix OPTS not being passed to OSX builds.

Before GHA, OPTS were always passed as an argument for a *-build.sh script. But that changed. Linux builds are using the OPTS variable from the environment, but OSX script does not, so the options are currently ignored. That wasn't a big issue until now, because SSL was not available or the

Re: [ovs-dev] [PATCH v3 2/4] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On Thu, Aug 03, 2023 at 01:43:40PM +0200, Ilya Maximets wrote: > On 7/28/23 02:04, Eric Garver wrote: > > Kernel support is being added for this action. As such, we need to probe > > the datapath for support. > > > > Signed-off-by: Eric Garver > > Hi, Eric. Thanks for the update. > > IIRC,

Re: [ovs-dev] [PATCH ovn v5] Expose distributed gateway port information in NB DB

On Thu, Aug 3, 2023 at 3:15 PM wrote: > From: Lucas Alvares Gomes > > In order for the CMS to know which Chassis a distributed gateway port > is bond to, this patch updates the ovn-northd daemon to populate the > Logical_Router_Port table with that information. > > To avoid changing the

Re: [ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases

Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Tue, 1 Aug 2023 17:22:21 -0400 you wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic

Re: [ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases

On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control

[ovs-dev] [PATCH ovn v5] Expose distributed gateway port information in NB DB

From: Lucas Alvares Gomes In order for the CMS to know which Chassis a distributed gateway port is bond to, this patch updates the ovn-northd daemon to populate the Logical_Router_Port table with that information. To avoid changing the database schema, ovn-northd is setting a new key called

Re: [ovs-dev] [PATCH ovn v4] Expose distributed gateway port information in NB DB

Hi, Thanks Ales! My bad on the tests there, will push a new version fixing it! On Thu, Aug 3, 2023 at 1:55 PM Ales Musil wrote: > > > > On Thu, Aug 3, 2023 at 2:29 PM wrote: >> >> From: Lucas Alvares Gomes >> >> In order for the CMS to know which Chassis a distributed gateway port >> is bond

Re: [ovs-dev] [PATCH ovn v4] Expose distributed gateway port information in NB DB

On Thu, Aug 3, 2023 at 2:29 PM wrote: > From: Lucas Alvares Gomes > > In order for the CMS to know which Chassis a distributed gateway port > is bond to, this patch updates the ovn-northd daemon to populate the > Logical_Router_Port table with that information. > > To avoid changing the

[ovs-dev] [PATCH ovn v4] Expose distributed gateway port information in NB DB

From: Lucas Alvares Gomes In order for the CMS to know which Chassis a distributed gateway port is bond to, this patch updates the ovn-northd daemon to populate the Logical_Router_Port table with that information. To avoid changing the database schema, ovn-northd is setting a new key called

Re: [ovs-dev] [PATCH ovn v3] Expose distributed gateway port information in NB DB

Hi Ales, Thank you for the insightful review! On Thu, Aug 3, 2023 at 11:25 AM Ales Musil wrote: > > > > On Tue, Aug 1, 2023 at 4:11 PM wrote: >> >> From: Lucas Alvares Gomes >> >> In order for the CMS to know which Chassis a distributed gateway port >> is bond to, this patch updates the

Re: [ovs-dev] [PATCH v3 2/4] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 7/28/23 02:04, Eric Garver wrote: > Kernel support is being added for this action. As such, we need to probe > the datapath for support. > > Signed-off-by: Eric Garver Hi, Eric. Thanks for the update. IIRC, there was a discussion that this feature has to be mutually exclusive with the TC

Re: [ovs-dev] [PATCH ovn 0/4] Multiple simple fixes to unit tests

On Thu, Aug 3, 2023 at 8:59 AM Xavier Simonart wrote: > Xavier Simonart (4): > tests: fixed "Logical flows with Chassis_Template_Var reference" > tests: fixed multiple ovn-ic unit tests > tests: fixed "CT flush load balancer backends" > tests: fixed "check fip and lb flows" > >

Re: [ovs-dev] [PATCH ovn v3] Expose distributed gateway port information in NB DB

On Tue, Aug 1, 2023 at 4:11 PM wrote: > From: Lucas Alvares Gomes > > In order for the CMS to know which Chassis a distributed gateway port > is bond to, this patch updates the ovn-northd daemon to populate the > Logical_Router_Port table with that information. > > To avoid changing the

Re: [ovs-dev] [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases

On Tue, Aug 01, 2023 at 05:22:21PM -0400, Aaron Conole wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the

Re: [ovs-dev] [PATCH ovn v2] binding: handle ovs ofport update

On Mon, Jul 31, 2023 at 7:18 PM Mohammad Heib wrote: > Currently when ovs interface ofport is updated > after setting external_ids:iface_id, the ovn-controller > will see this change but will not do much if it handles > this change incrementally. > > This behavior leads to a mismatch between the

Re: [ovs-dev] [PATCH ovn] QoS: Properly set qos when ovs db is read only

On Wed, Jul 26, 2023 at 3:44 PM Xavier Simonart wrote: > QoS was not configured in OVS db when db was read only: the configuration > was just ignored and not done later when OVS db became writable. > It was sometimes set later, if/when a recompute happened. > This is now fixed: when OVS db is

Re: [ovs-dev] OVN Request to update OVS submodule

Sure Ales. Thanks for the update Regards, Abhiram R N On Thu, Aug 3, 2023 at 1:14 PM Ales Musil wrote: > > > On Thu, Aug 3, 2023 at 9:37 AM Abhiram R N wrote: > >> Hi Team, >> >> Recently a fix has gone into OVS with the commit ID as below >> commit feed7f6775056b3dd55249596a7e587bc9c5fd4a >>

Re: [ovs-dev] [PATCH v2 ovn 0/2] sync lb applied to logical routers in sb db lb table

On Fri, Jul 14, 2023 at 5:25 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Changes since v1: > - rebase on top of ovn main branch > - cosmetics > Changes since RFC v2: > - introduce ls_datapath_group column and deprecate datapath_group one. > Changes since RFC v1: > - get rid of

Re: [ovs-dev] OVN Request to update OVS submodule

On Thu, Aug 3, 2023 at 9:37 AM Abhiram R N wrote: > Hi Team, > > Recently a fix has gone into OVS with the commit ID as below > commit feed7f6775056b3dd55249596a7e587bc9c5fd4a > Author: Mike Pattrick > Date: Wed Jul 19 12:21:09 2023 -0400 > > >

[ovs-dev] OVN Request to update OVS submodule

Hi Team, Recently a fix has gone into OVS with the commit ID as below commit feed7f6775056b3dd55249596a7e587bc9c5fd4a Author: Mike Pattrick Date: Wed Jul 19 12:21:09 2023 -0400 https://github.com/openvswitch/ovs/commit/feed7f6775056b3dd55249596a7e587bc9c5fd4a This we had reported while

[ovs-dev] [PATCH ovn 0/4] Multiple simple fixes to unit tests

Xavier Simonart (4): tests: fixed "Logical flows with Chassis_Template_Var reference" tests: fixed multiple ovn-ic unit tests tests: fixed "CT flush load balancer backends" tests: fixed "check fip and lb flows" tests/ovn-ic.at | 10 +++--- tests/ovn-northd.at | 2 +-

[ovs-dev] [PATCH ovn 3/4] tests: fixed "CT flush load balancer backends"

Signed-off-by: Xavier Simonart --- tests/ovn.at | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index a00731191..94f04d011 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -35967,7 +35967,10 @@ AT_CHECK([grep -q "Flushing CT for 5-tuple:

[ovs-dev] [PATCH ovn 1/4] tests: fixed "Logical flows with Chassis_Template_Var reference"

Signed-off-by: Xavier Simonart --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index 3de1444f8..a00731191 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -35368,7 +35368,7 @@ AT_CHECK_UNQUOTED([ovs-ofctl dump-flows br-int | grep

[ovs-dev] [PATCH ovn 2/4] tests: fixed multiple ovn-ic unit tests

- ovn-ic -- gateway sync - ovn-ic -- route sync - ovn-ic -- route sync -- route tables - ovn-ic -- route sync -- IPv6 route tables Signed-off-by: Xavier Simonart --- tests/ovn-ic.at | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at

[ovs-dev] [PATCH ovn 4/4] tests: fixed "check fip and lb flows"

Signed-off-by: Xavier Simonart --- tests/ovn-northd.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 3e06f14c9..e6fdb9d57 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -9658,7 +9658,7 @@ check ovn-nbctl lsp-add