On Mon, Aug 7, 2023 at 4:45 PM Dumitru Ceara wrote:
>
> On 8/4/23 21:24, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > When adding the arp req lflows in the 'ls_in_l2_lkup' stage for the
> > load balancer VIPs associated to a logical router we iterate through
> > the lb_ips sset of the r
On 7/31/23 06:55, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow and make the ukeys and m
Use drop reasons from include/net/dropreason-core.h when a reasonable
candidate exists.
Signed-off-by: Adrian Moreno
---
net/openvswitch/actions.c | 17 ++---
net/openvswitch/conntrack.c | 3 ++-
net/openvswitch/drop.h | 6 ++
3 files changed, 18 insertions(+), 8 deletio
Make ovs-dpctl.py support explicit drops as:
"drop" -> implicit empty-action drop
"drop(0)" -> explicit non-error action drop
"drop(42)" -> explicit error action drop
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/openvswitch.sh | 25 +++
.../selftests/net/openvs
Test if the correct drop reason is reported when OVS drops a packet due
to an explicit flow.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/openvswitch.sh | 67 ++-
1 file changed, 66 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/openvswi
From: Eric Garver
From: Eric Garver
This adds an explicit drop action. This is used by OVS to drop packets
for which it cannot determine what to do. An explicit action in the
kernel allows passing the reason _why_ the packet is being dropped or
zero to indicate no particular error happened (i.e
By using an independent drop reason it makes it easy to ditinguish
between QoS-triggered or flow-triggered drop.
Signed-off-by: Adrian Moreno
---
net/openvswitch/actions.c | 2 +-
net/openvswitch/drop.h| 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/openvswitch/actio
There is currently a gap in drop visibility in the openvswitch module.
This series tries to improve this by adding a new drop reason subsystem
for OVS.
Apart from adding a new drop reasson subsystem and some common drop
reasons, this series takes Eric's preliminary work [1] on adding an
explicit d
Create a new drop reason subsystem for openvswitch and add the first
drop reason to represent flow drops.
A flow drop happens when a flow has an empty action-set or there is no
action that consumes the packet (output, userspace, recirc, etc).
Implementation-wise, most of these skb-consuming actio
Add a drop reason for packets that are dropped because an action
returns a non-zero error code.
Signed-off-by: Adrian Moreno
---
net/openvswitch/actions.c | 2 +-
net/openvswitch/drop.h| 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/openvswitch/actions.c b/net/openvs
On 8/7/23 15:50, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> 13.2 was released in April and 13.1 images no longer able
>> to update packages:
>> pkg: repository FreeBSD contains packages for wrong OS version
>>
>> Fix that by updating to FreeBSD 13.2.
>>
>> Reported-by: David Marchand
>>
Ilya Maximets writes:
> 13.2 was released in April and 13.1 images no longer able
> to update packages:
> pkg: repository FreeBSD contains packages for wrong OS version
>
> Fix that by updating to FreeBSD 13.2.
>
> Reported-by: David Marchand
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aa
On Mon, Aug 07, 2023 at 03:00:41PM +0200, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 06:24:41PM +0100, Colin Watson wrote:
> > This fixes a number of "table wider than line length minus indentation"
> > warnings from tbl. The table cells are too narrow for centered text to
> > look good, so lef
On Sat, Aug 05, 2023 at 12:14:37AM +0800, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath doesn't
> support for ingress and egress packet-per-second policing no
On Mon, Aug 7, 2023 at 2:28 PM Ilya Maximets wrote:
>
> 13.2 was released in April and 13.1 images no longer able
> to update packages:
> pkg: repository FreeBSD contains packages for wrong OS version
>
> Fix that by updating to FreeBSD 13.2.
>
> Reported-by: David Marchand
> Signed-off-by: Ily
On Fri, Aug 04, 2023 at 01:58:49PM -0400, Mike Pattrick wrote:
> Diagnosing connectivity issues involving a bond can be complicated by a
> lack of logging in LACP. It is difficult to determine the health of
> sending and receving LACP packets. This is further complicated by the
> tendency of some s
On Fri, Aug 04, 2023 at 06:24:41PM +0100, Colin Watson wrote:
> This fixes a number of "table wider than line length minus indentation"
> warnings from tbl. The table cells are too narrow for centered text to
> look good, so left-align the contents of the text blocks.
>
> Reported-by: Lucas Nussb
On Fri, Aug 04, 2023 at 03:58:45PM -0400, Eric Garver wrote:
> Kernel support is being added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
Acked-by: Simon Horman
___
dev mailing list
d...@openvs
On Fri, Aug 04, 2023 at 03:58:44PM -0400, Eric Garver wrote:
> This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
> action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
> to make -Werror happy we must add a case to all existing switches.
>
> Signed-off-by: Eric
On Fri, Aug 04, 2023 at 03:58:46PM -0400, Eric Garver wrote:
nit: I would slightly prefer if there was a patch description here.
Or, alternatively, perhaps this patch could be squashed into
the following one.
> Signed-off-by: Eric Garver
> ---
> tests/system-common-macros.at | 4
On Fri, Aug 04, 2023 at 04:58:34PM -0400, Chandan Somani wrote:
> If a subject is missing, then a command like
> utilities/checkpatch.py -S file.patch will write in the new subject
> to file.patch itself.
>
> Signed-off-by: Chandan Somani
Hi Chandan,
I'm unclear on the motivation for this chang
13.2 was released in April and 13.1 images no longer able
to update packages:
pkg: repository FreeBSD contains packages for wrong OS version
Fix that by updating to FreeBSD 13.2.
Reported-by: David Marchand
Signed-off-by: Ilya Maximets
---
.cirrus.yml | 2 +-
1 file changed, 1 insertion(+),
On Fri, Aug 04, 2023 at 04:58:33PM -0400, Chandan Somani wrote:
> Subject spellcheck on git-based patches is now included in commands like
> utilities/checkpatch.py -S -2. Additionally, a block of code that is
> used to call ovs_checkpatch_parse() has been deleted since
> ovs_checkpatch_file() call
On Sat, Aug 05, 2023 at 01:12:15PM +0200, Francois wrote:
> Add an additional coverage counter for the case where no controller is
> available to receive a OFPT_PACKET_IN/NXT_PACKET_IN2 message and so the
> message is not sent at all.
>
> This should help investigate issues where controller action
On Mon, Aug 07, 2023 at 11:13:09AM +0800, Peng He wrote:
> Hi, Ilya,
>
> are there any more comments beside the Fixes tag?
FWIIW, the tag aside, this looks good to me.
Acked-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.open
On 8/7/23 13:57, Ilya Maximets wrote:
> On 8/5/23 14:07, Simon Horman wrote:
>> Kevin Traynor was recently elected by the Open vSwitch committers.
>> This formalises his status as an Open vSwitch committer.
>>
>> Welcome Kevin!
>
> Welcome!
>
Congrats, Kevin, well deserved!
On 8/5/23 14:07, Simon Horman wrote:
> Kevin Traynor was recently elected by the Open vSwitch committers.
> This formalises his status as an Open vSwitch committer.
>
> Welcome Kevin!
Welcome!
>
> Signed-off-by: Simon Horman
Applied. Thanks!
Best regards, Ilya Maximets.
On 8/4/23 21:24, num...@ovn.org wrote:
> From: Numan Siddique
>
> When adding the arp req lflows in the 'ls_in_l2_lkup' stage for the
> load balancer VIPs associated to a logical router we iterate through
> the lb_ips sset of the router datapath. For each ip of this sset we
> check if this is re
28 matches
Mail list logo
