[ovs-dev] [PATCH v4] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-08-17 Thread Mike Pattrick
When the a revalidator thread is updating statistics for an XC_LEARN xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. The revalidator will update stats for rules even if they are in a removed state or marked as invisible. However, ofproto_flow_mod_learn will detect if a flow

[ovs-dev] OVN 23.09 soft freeze is tomorrow

2023-08-17 Thread Mark Michelson
Hi everyone, As I announced a few weeks ago, the soft freeze date for OVN 23.09 is tomorrow, 18 August, 2023. This is the final date that patches for new features may be submitted for inclusion in OVN 23.09. The OVN team will spend the next two weeks attempting to get those patches merged.

Re: [ovs-dev] [PATCH ovn 0/5] Add port group incremental processing in northd.

2023-08-17 Thread Mark Michelson
Hi Dumitru, I had a look through the series, and it looks good to me. Acked-by: Mark Michelson On 8/10/23 08:44, Dumitru Ceara wrote: This series cleans up, factors out and then adds incremental processing support to the code that processes port group updates in ovn-northd. Some performance

Re: [ovs-dev] [PATCH ovn v3] northd: Fix incorrect warning logs when handling port binding changes.

2023-08-17 Thread Numan Siddique
On Thu, Aug 17, 2023 at 9:42 PM Han Zhou wrote: > > On Thu, Aug 17, 2023 at 12:05 AM wrote: > > > > From: Numan Siddique > > > > When changes to port bindings corresponding to router ports are > > handled by northd engine node, incorrect warning logs (like below) > > are logged. > > > > >

[ovs-dev] [PATCH v2] bond: Always revalidate unbalanced bonds when active member changes

2023-08-17 Thread Mike Pattrick
Currently a bond will not always revalidate when an active member changes. This can result in counter-intuitive behaviors like the fact that using ovs-appctl bond/set-active-member will cause the bond to revalidate but changing other_config:bond-primary will not trigger a revalidate in the bond.

Re: [ovs-dev] [PATCH] bond: Always revalidate unbalanced bonds when active member changes

2023-08-17 Thread Mike Pattrick
On Wed, Aug 16, 2023 at 4:18 PM Ilya Maximets wrote: > > On 8/9/23 19:00, Mike Pattrick wrote: > > Currently a bond will not always revalidate when an active member > > changes. This can result in counter-intuitive behaviors like the fact > > that using ovs-appctl bond/set-active-member will

Re: [ovs-dev] [PATCH ovn] northd.c: Incremental processing for first/last switch port change.

2023-08-17 Thread Han Zhou
On Thu, Aug 17, 2023 at 2:13 AM Ales Musil wrote: > > > > On Wed, Aug 16, 2023 at 2:56 AM Han Zhou wrote: >> >> Commit 1eb09838 fixed an incremental processing problem by falling back >> to recompute. The problem was handling VIF changes for a LS that >> has router ports when: >> - adding the

Re: [ovs-dev] [PATCH ovn v3] northd: Fix incorrect warning logs when handling port binding changes.

2023-08-17 Thread Han Zhou
On Thu, Aug 17, 2023 at 12:05 AM wrote: > > From: Numan Siddique > > When changes to port bindings corresponding to router ports are > handled by northd engine node, incorrect warning logs (like below) > are logged. > > > northd|WARN|A port-binding for lrp0 is created but the LSP is not

Re: [ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.0.

2023-08-17 Thread Ilya Maximets
On 8/17/23 17:16, Eelco Chaudron wrote: > > > On 17 Aug 2023, at 15:25, Ilya Maximets wrote: > >> According to our release process, it's time to release v3.2.0! >> >> Ilya Maximets (2): >> Set release date for 3.2.0. >> Prepare for 3.2.1. > > > Ack on the series! > > Acked-by: Eelco

Re: [ovs-dev] [PATCH ovn] northd: Add a separate I-P node for handling meters.

2023-08-17 Thread Dumitru Ceara
On 8/17/23 12:43, Ales Musil wrote: > On Wed, Aug 16, 2023 at 10:42 PM Dumitru Ceara wrote: > >> This is beneficial in a few ways: >> - first, it reduces the number of different types of data the northd >> I-P node has to process. >> - it turns out the northd I-P node (whose recompute is

[ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-17 Thread Dumitru Ceara
This is beneficial in a few ways: - first, it reduces the number of different types of data the northd I-P node has to process. - it turns out the northd I-P node (whose recompute is rather costly) doesn't really depend on meters or ACLs. - prepares the ground for a pure I-P implementation for

[ovs-dev] [PATCH ovn v2 1/2] northd: Refactor meter code to avoid duplication.

2023-08-17 Thread Dumitru Ceara
Use the band_cmp() function instead of duplicating code. Also simplify some of the band related code. Suggested-by: Ales Musil Signed-off-by: Dumitru Ceara --- northd/northd.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/northd/northd.c

[ovs-dev] [PATCH ovn v2 0/2] northd: Meter incremental processing.

2023-08-17 Thread Dumitru Ceara
Changes in V2: - Refactored a bit the meter code and added that as first patch. Dumitru Ceara (2): northd: Refactor meter code to avoid duplication. northd: Add a separate I-P node for handling meters. lib/stopwatch-names.h| 1 + northd/automake.mk | 2 +

Re: [ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.0.

2023-08-17 Thread Eelco Chaudron
On 17 Aug 2023, at 15:25, Ilya Maximets wrote: > According to our release process, it's time to release v3.2.0! > > Ilya Maximets (2): > Set release date for 3.2.0. > Prepare for 3.2.1. Ack on the series! Acked-by: Eelco Chaudron ___ dev

Re: [ovs-dev] [PATCH branch-3.2 1/2] Set release date for 3.2.0.

2023-08-17 Thread Ilya Maximets
On 8/17/23 15:36, 0-day Robot wrote: > Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > error: Failed to merge in the changes. >

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Assume well-known tables are in the SB schema.

2023-08-17 Thread Vladislav Odintsov
Thanks Dumitru for the efforts! > On 15 Aug 2023, at 13:39, Dumitru Ceara wrote: > > On 8/14/23 00:24, Han Zhou wrote: >> On Fri, Aug 11, 2023 at 5:25 AM Dumitru Ceara wrote: >>> >>> It's safe to assume that tables that existed in the previous LTS branch >>> first release (currently 22.03.0)

Re: [ovs-dev] [PATCH branch-3.2 1/2] Set release date for 3.2.0.

2023-08-17 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH branch-3.2 2/2] Prepare for 3.2.1.

2023-08-17 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.0.

2023-08-17 Thread Simon Horman
On Thu, Aug 17, 2023 at 03:25:03PM +0200, Ilya Maximets wrote: > According to our release process, it's time to release v3.2.0! > > Ilya Maximets (2): > Set release date for 3.2.0. > Prepare for 3.2.1. > > NEWS | 5 - > configure.ac | 2 +- > debian/changelog | 8

[ovs-dev] [PATCH branch-3.2 2/2] Prepare for 3.2.1.

2023-08-17 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a3a5c2e4a..790cab495 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.2.1 - xx xxx

[ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.0.

2023-08-17 Thread Ilya Maximets
According to our release process, it's time to release v3.2.0! Ilya Maximets (2): Set release date for 3.2.0. Prepare for 3.2.1. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.40.1

[ovs-dev] [PATCH branch-3.2 1/2] Set release date for 3.2.0.

2023-08-17 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 1438f9f8d..a3a5c2e4a 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v3.2.0 - xx xxx +v3.2.0 - 17 Aug 2023

Re: [ovs-dev] [PATCH ovn 3/3] m4: Update ax_func_posix_memalign to the latest version.

2023-08-17 Thread Dumitru Ceara
On 8/17/23 12:03, Ilya Maximets wrote: > On 8/17/23 09:31, Dumitru Ceara wrote: >> On 8/17/23 00:26, Ilya Maximets wrote: >>> This fixes the obsolescence warning for AC_TRY_RUN with autoconf 2.70+: >>> >>> $ ./boot.sh >>> configure.ac:141: warning: The macro `AC_TRY_RUN' is obsolete. >>>

Re: [ovs-dev] [PATCH ovn 0/3] m4: Fix autoconf 2.70+ warnings.

2023-08-17 Thread Dumitru Ceara
On 8/17/23 11:31, Ales Musil wrote: > On Thu, Aug 17, 2023 at 12:26 AM Ilya Maximets wrote: > >> autoconf 2.70+ complais about these obsolete macros. >> Replacements are available in our baseline 2.63, so >> use them instead. >> >> It also complains about AC_PROG_CC_C99, but I'm not >> sure if

Re: [ovs-dev] [PATCH ovn] northd: Add a separate I-P node for handling meters.

2023-08-17 Thread Ales Musil
On Wed, Aug 16, 2023 at 10:42 PM Dumitru Ceara wrote: > This is beneficial in a few ways: > - first, it reduces the number of different types of data the northd > I-P node has to process. > - it turns out the northd I-P node (whose recompute is rather costly) > doesn't really depend on

Re: [ovs-dev] [PATCH ovn 3/3] m4: Update ax_func_posix_memalign to the latest version.

2023-08-17 Thread Ilya Maximets
On 8/17/23 09:31, Dumitru Ceara wrote: > On 8/17/23 00:26, Ilya Maximets wrote: >> This fixes the obsolescence warning for AC_TRY_RUN with autoconf 2.70+: >> >> $ ./boot.sh >> configure.ac:141: warning: The macro `AC_TRY_RUN' is obsolete. >> configure.ac:141: You should run autoupdate. >>

Re: [ovs-dev] [PATCH ovn 0/3] m4: Fix autoconf 2.70+ warnings.

2023-08-17 Thread Ales Musil
On Thu, Aug 17, 2023 at 12:26 AM Ilya Maximets wrote: > autoconf 2.70+ complais about these obsolete macros. > Replacements are available in our baseline 2.63, so > use them instead. > > It also complains about AC_PROG_CC_C99, but I'm not > sure if we want to or how to correctly replace it. >

Re: [ovs-dev] [PATCH ovn] northd.c: Incremental processing for first/last switch port change.

2023-08-17 Thread Ales Musil
On Wed, Aug 16, 2023 at 2:56 AM Han Zhou wrote: > Commit 1eb09838 fixed an incremental processing problem by falling back > to recompute. The problem was handling VIF changes for a LS that > has router ports when: > - adding the first switch port to the LS, or > - deleting the last switch port

Re: [ovs-dev] [PATCH v2 ovn] controller: make garp_max_timeout configurable

2023-08-17 Thread Ales Musil
On Thu, Jul 20, 2023 at 5:02 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > When using VLAN backed networks and OVN routers leveraging the > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field > is > replaced by the chassis mac address in order to not expose

Re: [ovs-dev] [PATCH ovn 3/3] m4: Update ax_func_posix_memalign to the latest version.

2023-08-17 Thread Dumitru Ceara
On 8/17/23 00:26, Ilya Maximets wrote: > This fixes the obsolescence warning for AC_TRY_RUN with autoconf 2.70+: > > $ ./boot.sh > configure.ac:141: warning: The macro `AC_TRY_RUN' is obsolete. > configure.ac:141: You should run autoupdate. > ./lib/autoconf/general.m4:2997: AC_TRY_RUN is

[ovs-dev] [PATCH ovn v3] northd: Fix incorrect warning logs when handling port binding changes.

2023-08-17 Thread numans
From: Numan Siddique When changes to port bindings corresponding to router ports are handled by northd engine node, incorrect warning logs (like below) are logged. northd|WARN|A port-binding for lrp0 is created but the LSP is not found. Fix these warnings. Fixes: 3b120ccf7f7c

Re: [ovs-dev] [PATCH ovn v2] northd: Fix incorrect warning logs when handling port binding changes.

2023-08-17 Thread Numan Siddique
On Thu, Aug 17, 2023 at 11:47 AM Han Zhou wrote: > > On Wed, Aug 16, 2023 at 1:27 AM wrote: > > > > From: Numan Siddique > > > > When changes to port bindings corresponding to router ports are > > handled by northd engine node, incorrect warning logs (like below) > > are logged. > > > > >

Re: [ovs-dev] [PATCH v2] doc: Fix description of max_len for controller action.

2023-08-17 Thread Simon Horman
On Wed, Aug 16, 2023 at 05:30:59PM -0700, Antonin Bas wrote: > From: Antonin Bas > > From: Antonin Bas > > Since Open vSwitch 2.7, the max_len option has no effect, and the full > packet is always sent to controllers. This was confirmed with both the > kernel and netdev datapaths. > >

Re: [ovs-dev] [PATCH ovn v2] northd: Fix incorrect warning logs when handling port binding changes.

2023-08-17 Thread Han Zhou
On Wed, Aug 16, 2023 at 1:27 AM wrote: > > From: Numan Siddique > > When changes to port bindings corresponding to router ports are > handled by northd engine node, incorrect warning logs (like below) > are logged. > > > northd|WARN|A port-binding for lrp0 is created but the LSP is not