Re: [ovs-dev] [PATCH ovn v5 09/14] northd: Use objdep mgr for lport to lflow references.

2023-08-29 Thread Numan Siddique
On Tue, 22 Aug, 2023, 6:11 am Han Zhou, wrote: > On Fri, Aug 18, 2023 at 4:35 AM Numan Siddique wrote: > > > > On Fri, Aug 18, 2023 at 2:33 PM Numan Siddique wrote: > > > > > > On Fri, Aug 18, 2023 at 11:38 AM Han Zhou wrote: > > > > > > > > On Wed, Aug 9, 2023 at 9:38 AM wrote: > > > > > >

[ovs-dev] [PATCH ovn] Use correct nw_ttl=255 to match against legit NAs

2023-08-29 Thread Ihar Hrachyshka
RFC 4861 (Neighbor Discovery for IP version 6) requires that Hop Limit is set to 255, but the flows we generated for 135 and 136 erroneously used 225. Fixes: 8cab00bdb581 ("ovn-controller: Add OF rules for port security.") Signed-off-by: Ihar Hrachyshka --- controller/lflow.c | 6 +++---

Re: [ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-08-29 Thread Ilya Maximets
On 8/23/23 14:53, Paolo Valerio wrote: > From: hepeng > > The patch avoids the extra allocation for nat_conn. > Currently, when doing NAT, the userspace conntrack will use an extra > conn for the two directions in a flow. However, each conn has actually > the two keys for both orig and rev

Re: [ovs-dev] [PATCH v2] ofproto-dpif-mirror: Add support for pre-selection filter

2023-08-29 Thread Mike Pattrick
On Fri, Aug 25, 2023 at 10:28 AM Adrian Moreno wrote: > > > > On 7/18/23 21:38, Mike Pattrick wrote: > > Currently a bridge mirror will collect all packets and tools like > > ovs-tcpdump can apply additional filters after they have already been > > duplicated by vswitchd. This can result in

Re: [ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.3.

2023-08-29 Thread Ilya Maximets
On 8/29/23 17:30, Mark Michelson wrote: > > Mark Michelson (2): > Set release date for 22.03.3. > Prepare for 22.03.4. > > NEWS | 7 ++- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 14 insertions(+), 3 deletions(-) > I didn't test the

Re: [ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.2.

2023-08-29 Thread Ilya Maximets
On 8/29/23 17:30, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index d5170786b..1758bf633 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,5 +1,6 @@ >

Re: [ovs-dev] [PATCH ovn branch-22.12 1/2] Set release date for 22.12.1.

2023-08-29 Thread Ilya Maximets
On 8/29/23 17:30, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 01baa2be6..4efa1d1fe 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,5 +1,6 @@ >

Re: [ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.1.

2023-08-29 Thread Ilya Maximets
On 8/29/23 17:30, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 47d259150..1c75eeeae 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,5 +1,6 @@ >

Re: [ovs-dev] [PATCH ovn branch-23.06 0/2] Release patches for v23.06.1.

2023-08-29 Thread Ilya Maximets
On 8/29/23 17:30, Mark Michelson wrote: > > Mark Michelson (2): > Set release date for 23.06.1. > Prepare for 23.06.2. > > NEWS | 7 ++- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 14 insertions(+), 3 deletions(-) > I didn't test the

[ovs-dev] [PATCH v3 7/7] system-dpdk: Run traffic tests.

2023-08-29 Thread David Marchand
Integrate system-traffic.at tests as part of check-dpdk. Some tests that can't work with the userspace datapath are skipped by overriding some OVS_CHECK_* macros. ADD_VETH is implemented with a tap interface in the kernel, directly polled by OVS with the net/tap DPDK driver. ADD_VETH_IGNORE_LOGS

[ovs-dev] [PATCH v3 6/7] system-dpdk: Refactor OVS daemons helpers.

2023-08-29 Thread David Marchand
Align system-dpdk existing helpers to other common OVS helpers so they can accept some optional arguments. Introduce a OVS_DPDK_STOP_VSWITCHD wrapper around OVS_VSWITCHD_STOP to catch dpdk related logs in a centralised fashion. Signed-off-by: David Marchand Acked-by: Eelco Chaudron ---

[ovs-dev] [PATCH v3 5/7] tests: Define a macro to skip tc/tcpdump relying tests.

2023-08-29 Thread David Marchand
Some unit tests expect that a OVS port has an associated netdevice on which they can hook tc or tcpdump. This will not be possible when testing the userspace datapath with DPDK. Introduce two helpers (which will be overriden in system-dpdk tests) and use them in the existing tests. Signed-off-by:

[ovs-dev] [PATCH v3 4/7] ci: Run DPDK tests in GitHub Actions.

2023-08-29 Thread David Marchand
Let's enhance our coverage in the CI and run DPDK system tests. A few DPDK drivers are enabled in DPDK compilation. Put DPDK build in $PATH for dpdk-testpmd to be available. sudo drops PATH= updates and -E alone does not seem to preserve this variable. Pass PATH=$PATH when running the tests, as

[ovs-dev] [PATCH v3 3/7] system-dpdk: Don't require hugetlbfs.

2023-08-29 Thread David Marchand
dpdk-testpmd does not need hugetlbfs backing as we don't require multiprocess support in OVS unit tests. Plus, there is no need for explicitly reserving more memory than what testpmd would actually need at runtime. Switch to --in-memory, use dynamic allocations and remove the then unneeded check

[ovs-dev] [PATCH v3 2/7] system-dpdk: Introduce helpers for testpmd.

2023-08-29 Thread David Marchand
Rather than copy/paste everywhere, introduce helpers to control testpmd runs. Rely on --stats-period (which outputs port stats every n seconds) so that testpmd keeps running without expecting any user input. Signed-off-by: David Marchand Acked-by: Aaron Conole Acked-by: Eelco Chaudron ---

[ovs-dev] [PATCH v3 1/7] netdev-dpdk: Disable net/tap Tx L4 checksum offloads.

2023-08-29 Thread David Marchand
As reported by Ales when doing some OVN integration tests with OVS 3.2, net/tap has broken L4 checksum offloads. Fixes are pending on DPDK side. Until they get in a LTS release used by OVS, disable those Tx offloads. Acked-by: Eelco Chaudron Signed-off-by: David Marchand --- Changes since v1:

Re: [ovs-dev] [PATCH ovn] northd, controller: Add CoPP for SVC monitor

2023-08-29 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Committer Mark Michelson needs to sign off. Lines checked: 131, Warnings: 0, Errors:

[ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.3.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 55b73b5f8..9dc5ae9ce 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,9 @@ -OVN v22.03.3 - xx xxx +OVN v22.03.3 - 29 Aug 2023

[ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.4.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 9dc5ae9ce..1dfded4ba 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.03.4 - xx xxx

[ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.3.

2023-08-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.03.3. Prepare for 22.03.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.40.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.09 2/2] Prepare for 22.09.3.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1758bf633..bbe636cd9 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.09.3 - xx xxx

[ovs-dev] [PATCH ovn branch-22.09 0/2] Release patches for v22.09.2.

2023-08-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.09.2. Prepare for 22.09.3. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.40.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.2.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index d5170786b..1758bf633 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v22.09.2 - xx xxx +OVN v22.09.2 - 29 Aug 2023

[ovs-dev] [PATCH ovn branch-22.12 1/2] Set release date for 22.12.1.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 01baa2be6..4efa1d1fe 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v22.12.1 - xx xxx +OVN v22.12.1 - 29 Aug 2023

[ovs-dev] [PATCH ovn branch-22.12 2/2] Prepare for 22.12.2.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 4efa1d1fe..a8fdfd387 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.12.2 - xx xxx

[ovs-dev] [PATCH ovn branch-22.12 0/2] Release patches for v22.12.1.

2023-08-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.12.1. Prepare for 22.12.2. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.40.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-23.03 0/2] Release patches for v23.03.1.

2023-08-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 23.03.1. Prepare for 23.03.2. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.40.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.2.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1c75eeeae..6c680afbb 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.03.2 - xx xxx

[ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.1.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 47d259150..1c75eeeae 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v23.03.1 - xx xxx +OVN v23.03.1 - 29 Aug 2023

[ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.2.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index ef000ef7b..0056bb175 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.06.2 - xx xxx

[ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.1.

2023-08-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index d17c5d508..ef000ef7b 100644 --- a/NEWS +++ b/NEWS @@ -1,9 +1,11 @@ -OVN v23.06.1 - xx xxx +OVN v23.06.1 - 29 Aug 2023

[ovs-dev] [PATCH ovn branch-23.06 0/2] Release patches for v23.06.1.

2023-08-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 23.06.1. Prepare for 23.06.2. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.40.1 ___ dev mailing list

Re: [ovs-dev] [PATCH ovn] northd, controller: Add CoPP for SVC monitor

2023-08-29 Thread Mark Michelson
Thanks Ales, Acked-by: Mark Michelson I pushed the change to main and all branches back to 22.03. On 8/29/23 11:24, Mark Michelson wrote: From: Ales Musil The SVC monitor was exposed without any limitation. Add CoPP for the SVC monitor flow, which adds a way for CMSs to limit the traffic

[ovs-dev] [PATCH ovn] northd, controller: Add CoPP for SVC monitor

2023-08-29 Thread Mark Michelson
From: Ales Musil The SVC monitor was exposed without any limitation. Add CoPP for the SVC monitor flow, which adds a way for CMSs to limit the traffic that this flow accepts. Signed-off-by: Ales Musil --- lib/copp.c | 1 + lib/copp.h | 1 + northd/northd.c | 8

Re: [ovs-dev] [PATCH ovn branch-23.03] northd: Fix recompute of referenced chassis in HA chassis groups.

2023-08-29 Thread Mark Michelson
Thank you Ilya, I applied this patch to 23.03 and all branches back to 22.03. On 8/25/23 14:03, Ilya Maximets wrote: Current implementation of 'ref_chassis' recompute is horribly slow. For each port binding it finds LR group, then it adds a chassis of the current port binding to each HA

Re: [ovs-dev] [PATCH ovn 2/2] ovn-ic: support learning routes in same AZ

2023-08-29 Thread Felix Huettner via dev
Thank you for the feedback, the route learning feature needs to be explicitly enabled [1]. This is currently a global setting, so if we want to limit this to individual routers i would rather make this a general ovn-ic feature than to include this here. Thanks Felix [1]

Re: [ovs-dev] [PATCH] netdev-dpdk: Disable net/tap Tx L4 checksum offloads.

2023-08-29 Thread David Marchand
On Fri, Aug 25, 2023 at 3:46 PM Ilya Maximets wrote: > > On 8/24/23 17:19, David Marchand wrote: > > As reported by Ales when doing some OVN integration tests with OVS 3.2, > > net/tap has broken L4 checksum offloads. > > > > Fixes are pending on DPDK side. > > Until they get in a LTS release

Re: [ovs-dev] [PATCH ovn] tests: offload scapy transformations to a separate daemon

2023-08-29 Thread Ilya Maximets
On 8/25/23 18:50, Ihar Hrachyshka wrote: > The daemon life cycle spans over the whole test case life time, which > significantly speeds up test cases that rely on fmt_pkt for packet byte > representations. > > The speed-up comes from the fact that we no longer start a python > environment with

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-29 Thread Mark Michelson
On 8/29/23 04:49, Dumitru Ceara wrote: On 8/21/23 19:33, Mark Michelson wrote: Hi Dumitru, I have one finding in the test code, but other than that it looks good. Hi Mark, Thanks for the review! On 8/17/23 11:25, Dumitru Ceara wrote: This is beneficial in a few ways: - first, it reduces

Re: [ovs-dev] [PATCH v3 ovn] controller: make garp_max_timeout configurable

2023-08-29 Thread Ales Musil
On Thu, Aug 24, 2023 at 6:36 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > When using VLAN backed networks and OVN routers leveraging the > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field > is > replaced by the chassis mac address in order to not expose

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-29 Thread Dumitru Ceara
On 8/21/23 19:33, Mark Michelson wrote: > Hi Dumitru, > > I have one finding in the test code, but other than that it looks good. > Hi Mark, Thanks for the review! > On 8/17/23 11:25, Dumitru Ceara wrote: >> This is beneficial in a few ways: >> - first, it reduces the number of different

[ovs-dev] [PATCH ovn v2 2/2] ofctrl: Prevent conjunction duplication

2023-08-29 Thread Ales Musil
During ofctrl_add_or_append_flow we are able to combine two flows with same match but different conjunctions. However, the function didn't check if the conjunctions already exist in the installed flow, which could result in conjunction duplication and the flow would grow infinitely e.g.

[ovs-dev] [PATCH ovn v2 1/2] ofctrl: Do not try to program long flows

2023-08-29 Thread Ales Musil
If the flow size is bigger than UINT16_MAX it doesn't fit into openflow message. Programming of such flow will fail which results in disconnect of ofctrl. After reconnect we program everything from scratch, in case the long flow still remains the cycle continues. This causes the node to be almost

Re: [ovs-dev] [PATCH ovn 1/2] ofctrl: Do not try to program long flows

2023-08-29 Thread Ales Musil
On Tue, Aug 29, 2023 at 10:42 AM Ales Musil wrote: > If the flow size is bigger than UINT16_MAX it doesn't > fit into openflow message. Programming of such flow will > fail which results in disconnect of ofctrl. After reconnect > we program everything from scratch, in case the long flow still >

[ovs-dev] [PATCH ovn 2/2] ofctrl: Prevent conjunction duplication

2023-08-29 Thread Ales Musil
During ofctrl_add_or_append_flow we are able to combine two flows with same match but different conjunctions. However, the function didn't check if the conjunctions already exist in the installed flow, which could result in conjunction duplication and the flow would grow infinitely e.g.

[ovs-dev] [PATCH ovn 1/2] ofctrl: Do not try to program long flows

2023-08-29 Thread Ales Musil
If the flow size is bigger than UINT16_MAX it doesn't fit into openflow message. Programming of such flow will fail which results in disconnect of ofctrl. After reconnect we program everything from scratch, in case the long flow still remains the cycle continues. This causes the node to be almost

Re: [ovs-dev] [PATCH v3 2/2] netdev-tc-offload: Add IPIP/GRE protocols to offload in ip rewrite

2023-08-29 Thread Faicker Mo via dev
>This looks strange to me. Was it intentional?No. So sorry for this typo.BTW, >v4 patches are sent. Any suggestions about the commit message of 2/2? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev