Re: [ovs-dev] [ovs-build] |fail| pw1829630 [ovs-dev, v5, 6/6] system-dpdk: Run traffic tests.

2023-09-05 Thread Ilya Maximets
On 9/5/23 16:48, David Marchand wrote: > On Mon, Sep 4, 2023 at 10:04 PM wrote: >>> 2023-09-04T19:18:23.154Z|00024|dpif_netdev_impl|INFO|Default DPIF >>> implementation is dpif_scalar. >>> 2023-09-04T19:18:23.166Z|00025|ofproto_dpif|INFO|netdev@ovs-netdev: >>> Datapath supports recirculation

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Fix recirculation with patch port and controller.

2023-09-05 Thread Paolo Valerio
If a packet originating from the controller recirculates after going through a patch port, it gets dropped with the following message: ofproto_dpif_upcall(handler8)|INFO|received packet on unassociated datapath port 4294967295 This happens because there's no xport_uuid in the recirculation

Re: [ovs-dev] [ovs-build] |fail| pw1829630 [ovs-dev, v5, 6/6] system-dpdk: Run traffic tests.

2023-09-05 Thread David Marchand
On Mon, Sep 4, 2023 at 10:04 PM wrote: > > Test-Label: intel-ovs-compilation > Test-Status: fail > http://patchwork.ozlabs.org/api/patches/1829630/ > > AVX-512_compilation: failed > DPLCS Test: fail > DPIF Test: fail > MFEX Test: fail > Actions Test: fail > Errors in DPCLS test: > make check-dpdk

Re: [ovs-dev] [ovs-build] |fail| pw1829630 [ovs-dev, v5, 6/6] system-dpdk: Run traffic tests.

2023-09-05 Thread David Marchand
On Tue, Sep 5, 2023 at 4:48 PM David Marchand wrote: > > On Mon, Sep 4, 2023 at 10:04 PM wrote: > > > 2023-09-04T19:18:23.154Z|00024|dpif_netdev_impl|INFO|Default DPIF > > > implementation is dpif_scalar. > > > 2023-09-04T19:18:23.166Z|00025|ofproto_dpif|INFO|netdev@ovs-netdev: > > > Datapath

Re: [ovs-dev] [ovs-build] |fail| pw1829630 [ovs-dev, v5, 6/6] system-dpdk: Run traffic tests.

2023-09-05 Thread David Marchand
On Mon, Sep 4, 2023 at 10:04 PM wrote: > > 2023-09-04T19:18:23.154Z|00024|dpif_netdev_impl|INFO|Default DPIF > > implementation is dpif_scalar. > > 2023-09-04T19:18:23.166Z|00025|ofproto_dpif|INFO|netdev@ovs-netdev: > > Datapath supports recirculation > >

[ovs-dev] [OVSCONF] CFP deadline extension

2023-09-05 Thread Michael Santana
Happy September! Given that we had previously moved the conference back a month we have also decided to also move the CFP Deadline. Here are the new dates CFP submissions: October 20th Notification back to speakers: November 3rd Conference: December 6-7 (still the same) Please feel free to

[ovs-dev] [PATCH ovn] northd: check if parent_name is set for tag_request 0

2023-09-05 Thread Lorenzo Bianconi
Check if parent_name is properly set in build_gateway_get_l2_hdr_size routine if tag_request is set 0, since parent_name is mandatory for dynamically allocated VLANID. Reported-at: https://issues.redhat.com/browse/FDP-38 Fixes: b68753a573cd ("northd: dynamically compute l2 hdr len for

[ovs-dev] [PATCH] checkpatch: Add checks for the subject line.

2023-09-05 Thread Eelco Chaudron
This patch adds WARNINGs for the subject line length and the format, i.e., the sentence should start with a capital and end with a dot. Signed-off-by: Eelco Chaudron --- utilities/checkpatch.py | 30 ++ 1 file changed, 30 insertions(+) diff --git

[ovs-dev] [PATCH] tests: Add some tests for byteq module

2023-09-05 Thread James Raphael Tiovalen
This commit adds a non-exhaustive list of tests for some of the functions declared in `lib/byteq`. These unit tests have been executed via `make check` and they successfully passed. Signed-off-by: James Raphael Tiovalen --- tests/automake.mk | 1 + tests/library.at | 5 ++

Re: [ovs-dev] [PATCH ovn] ci, tests: Remove parallelization permutation

2023-09-05 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #47 FILE:

[ovs-dev] [PATCH ovn] ci, tests: Remove parallelization permutation

2023-09-05 Thread Ales Musil
Single test needs to run 4 times to check all the permutations, this is taking a lot of CI time and job space. Remove the parallel permutation and leave parallelization enabled for all tests, as this use case is more complex. This allows us to greatly reduce the number of test cases (by half) and

Re: [ovs-dev] [PATCH ovn] Use correct nw_ttl=255 to match against legit NAs

2023-09-05 Thread Ales Musil
On Wed, Aug 30, 2023 at 3:23 AM Ihar Hrachyshka wrote: > RFC 4861 (Neighbor Discovery for IP version 6) requires that Hop Limit > is set to 255, but the flows we generated for 135 and 136 erroneously > used 225. > > Fixes: 8cab00bdb581 ("ovn-controller: Add OF rules for port security.") >

[ovs-dev] [PATCH v5 0/2] Add more protocols to offload in ip rewrite

2023-09-05 Thread Faicker Mo via dev
v5: - fix typo. v4: - more accurate commit message for 2/2. v3: - add test case for 1/2. - more verbose commit message. v2: - seperated into two commits. - add the specific protocols to offload in ip rewrite. Faicker Mo (2): netdev-tc-offload: Add csum offload of IGMP/UDPLITE/SCTP

[ovs-dev] [PATCH v5 1/2] netdev-tc-offload: Add csum offload of IGMP/UDPLITE/SCTP in ip rewrite

2023-09-05 Thread Faicker Mo via dev
When the IP header is rewritten like NAT or ttl/tos changed, the csum of IP header need recalculation. The UDPLITE checksum needs recalculation if src or dst changed in IP header. The tc-csum action is for this. Signed-off-by: Faicker Mo --- lib/tc.c | 7 ++-

[ovs-dev] [PATCH v5 2/2] netdev-tc-offload: Add IPIP/GRE protocols to offload in ip rewrite

2023-09-05 Thread Faicker Mo via dev
The warning message is |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X. IPIP and GRE only need the checksum recalculation of the IP header if the IP header is rewritten. Eliminate the warning for IPIP and GRE protocols. Fixes: d6118e628988 ("netdev-tc-offloads: Verify

Re: [ovs-dev] [PATCH v2] utilities: Add kernel_delay.py script to debug a busy Linux kernel.

2023-09-05 Thread 0-day Robot
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 106 characters long (recommended limit is 79) #1511 FILE:

[ovs-dev] [PATCH v2] utilities: Add kernel_delay.py script to debug a busy Linux kernel.

2023-09-05 Thread Eelco Chaudron
This patch adds an utility that can be used to determine if an issue is related to a lack of Linux kernel resources. This tool is also featured in a Red Hat developers blog article: https://developers.redhat.com/articles/2023/07/24/troubleshooting-open-vswitch-kernel-blame Signed-off-by:

Re: [ovs-dev] [PATCH] utilities: Add kernel_delay.py script to debug a busy Linux kernel.

2023-09-05 Thread Eelco Chaudron
On 28 Aug 2023, at 16:15, Aaron Conole wrote: > Eelco Chaudron writes: > >> This patch adds an utility that can be used to determine if >> an issue is related to a lack of Linux kernel resources. >> >> This tool is also featured in a Red Hat developers blog article: >> >> >>