On Wed, Aug 30, 2023 at 8:21 AM Felix Huettner via dev <
ovs-dev@openvswitch.org> wrote:
> when connecting multiple logical routers to a transit switch per az then
> previously the routers in the same az would not learn each others
> routes while the routers in the others az would learn all of the
On Wed, Aug 30, 2023 at 8:20 AM Felix Huettner via dev <
ovs-dev@openvswitch.org> wrote:
> previously if multiple routers in the same az are connected to the same
> transit switch then ovn-ic would only propagate the routes of one of
> these routers to the ic-sb.
> This commit fixes this behaviour
On Mon, Sep 11, 2023 at 9:01 AM wrote:
>
> From: Numan Siddique
>
> 'lb_data' engine node now also handles logical switch changes.
> Its data maintains ls to lb related information. i.e if a
> logical switch sw0 has lb1, lb2 and lb3 associated then
> it stores this info in its data. And when a n
On Mon, Sep 11, 2023 at 5:58 PM Han Zhou wrote:
>
> On Mon, Sep 11, 2023 at 2:15 PM Numan Siddique wrote:
> >
> > On Mon, Sep 11, 2023 at 2:18 PM Han Zhou wrote:
> > >
> > > On Mon, Sep 11, 2023 at 9:48 AM Numan Siddique wrote:
> > > >
> > > > On Fri, Sep 1, 2023 at 12:52 AM Han Zhou wrote:
>
On Mon, Sep 11, 2023 at 2:15 PM Numan Siddique wrote:
>
> On Mon, Sep 11, 2023 at 2:18 PM Han Zhou wrote:
> >
> > On Mon, Sep 11, 2023 at 9:48 AM Numan Siddique wrote:
> > >
> > > On Fri, Sep 1, 2023 at 12:52 AM Han Zhou wrote:
> > > >
> > > > On Thu, Aug 31, 2023 at 7:14 PM Han Zhou wrote:
>
On Mon, Sep 11, 2023 at 2:18 PM Han Zhou wrote:
>
> On Mon, Sep 11, 2023 at 9:48 AM Numan Siddique wrote:
> >
> > On Fri, Sep 1, 2023 at 12:52 AM Han Zhou wrote:
> > >
> > > On Thu, Aug 31, 2023 at 7:14 PM Han Zhou wrote:
> > > >
> > > >
> > > >
> > > > On Fri, Aug 18, 2023 at 1:58 AM wrote:
>
On Mon, Sep 11, 2023 at 9:48 AM Numan Siddique wrote:
>
> On Fri, Sep 1, 2023 at 12:52 AM Han Zhou wrote:
> >
> > On Thu, Aug 31, 2023 at 7:14 PM Han Zhou wrote:
> > >
> > >
> > >
> > > On Fri, Aug 18, 2023 at 1:58 AM wrote:
> > > >
> > > > From: Numan Siddique
> > > >
> > > > 'lb_data' engine
On Fri, Sep 1, 2023 at 2:41 AM Han Zhou wrote:
>
> On Fri, Aug 18, 2023 at 1:58 AM wrote:
> >
> > From: Numan Siddique
> >
> > A new engine node 'sync_to_sb_pb' is added within 'sync_to_sb'
> > node to sync NAT column of Port bindings table. This separation
> > is required in order to add load
On Fri, Sep 1, 2023 at 12:52 AM Han Zhou wrote:
>
> On Thu, Aug 31, 2023 at 7:14 PM Han Zhou wrote:
> >
> >
> >
> > On Fri, Aug 18, 2023 at 1:58 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > 'lb_data' engine node now also handles logical switch changes.
> > > Its data maintains ls to l
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#323 FILE: northd/northd.c:5587
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#509 FILE: northd/northd.c:5432:
* For every tracked '
From: Numan Siddique
When a logical router gets updated due to load balancer or load balancer
groups changes, it is now incrementally handled first in 'lb_data'
engine node similar to how logical switch changes are handled. The
tracking data of 'lb_data' is updated similarly so that northd engin
From: Numan Siddique
A new engine node 'sync_to_sb_pb' is added within 'sync_to_sb'
node to sync NAT column of Port bindings table. This separation
is required in order to add load balancer group I-P handling
in 'northd' engine node (which is handled in the next commit).
'sync_to_sb_pb' engine
From: Numan Siddique
For a given load balancer group 'A', northd engine data maintains
a bitmap of datapaths associated to this lb group. So when lb group 'A'
gets associated to a logical switch 's1', the bitmap index of 's1' is set
in its bitmap.
In order to handle the load balancer group chan
From: Numan Siddique
'lb_data' engine node now also handles logical switch changes.
Its data maintains ls to lb related information. i.e if a
logical switch sw0 has lb1, lb2 and lb3 associated then
it stores this info in its data. And when a new load balancer
lb4 is associated to it, it stores t
From: Numan Siddique
This patch series adds the support to handle load balancer and
load balancer group changes incrementally in the "northd" engine
node. Changes to logical switches and router's load
balancer and load balancer group columns are also handled incrementally
provided other columns d
On Sat, Sep 09, 2023 at 01:41:05AM +0200, Ilya Maximets wrote:
> On 9/1/23 21:42, Eric Garver wrote:
> > Kernel support is being added for this action. As such, we need to probe
> > the datapath for support.
> >
> > Signed-off-by: Eric Garver
> > ---
> > include/linux/openvswitch.h | 2 +-
> >
On 9/7/23 15:59, Ales Musil wrote:
> On Fri, Sep 1, 2023 at 12:56 PM Dumitru Ceara wrote:
>
>> Commit 506f7d4bcfbc ("northd: rely on new actions for ecmp-symmetric
>> routing") relied on commit_ecmp_nh() to learn the mapping between a
>> traffic session's 5-tuple and the MAC of the next-hop to be
On 9/7/23 20:52, Han Zhou wrote:
> On Thu, Sep 7, 2023 at 7:48 AM Ales Musil wrote:
>>
>> Single test needs to run 4 times to check all
>> the permutations, this is taking a lot of CI time
>> and job space.
>>
>> Remove the parallel permutation and leave parallelization
>> enabled for all tests, a
This patch adds WARNINGs for the subject line length and the format,
i.e., the sentence should start with a capital and end with a dot.
Signed-off-by: Eelco Chaudron
---
v2: - Add test cases
- Made it work on files and git patches
- Changed it from 50 chars on the summary, to 70 chars on
On Thu, Aug 31, 2023 at 2:47 PM Mark Michelson wrote:
>
> I had a look at patches 1-8. I have no additional notes beyond what Han
> and Ales have already mentioned.
>
> For patches 1-8:
>
> Acked-by: Mark Michelson
Thanks Mark, Han and Ales for the reviews.
I applied the first 4 patches of this
Hi Dumitru,
if eventually this patch got merged, please remove next lines from its commit
message:
"Disablement for ovs-vswitchd -> ovn-controller OF inacivity probing will
be done in the next patch."
Unfortunately I was unsuccessful in removing these probing direction (default
60s).
Maybe you
On 9/11/23 14:54, Dumitru Ceara wrote:
> On 6/14/23 20:02, Vladislav Odintsov wrote:
>> Hi Mark,
>>
>> thanks for taking time to look on this!
>>
>> Your point with a hung OVS is really an interesting case.
>>
>> From one hand it’s a possible situation, and from another I guess it’s much
>> higher
On 6/14/23 20:02, Vladislav Odintsov wrote:
> Hi Mark,
>
> thanks for taking time to look on this!
>
> Your point with a hung OVS is really an interesting case.
>
> From one hand it’s a possible situation, and from another I guess it’s much
> higher probability for OVS to be busy by some other
On 9/6/23 16:39, Mark Michelson wrote:
> Thanks Ales,
>
Hi Ales, Mark,
> Acked-by: Mark Michelson
>
> Thankfully the extra overhead is in the much less frequently-hit case.
>
We still do a O(N^2) processing, I wonder if it's a lot of
work/complexity to add the map to all 'struct desired_flow
On 8/21/23 17:41, Eelco Chaudron wrote:
This patch adds an utility that can be used to determine if
an issue is related to a lack of Linux kernel resources.
This tool is also featured in a Red Hat developers blog article:
https://developers.redhat.com/articles/2023/07/24/troubleshooting-o
On 9/6/23 16:39, Mark Michelson wrote:
> Thanks Ales,
>
> Acked-by: Mark Michelson
>
Hi Ales, Mark,
> I think this change should be applied as-is. I also wanted to contribute
> some thoughts.
>
I shared some thoughts too, below.
> As you mentioned in the commit message, this is not a self-h
Hey Kevin,
Kevin Traynor, Sep 07, 2023 at 15:37:
> This came up in conversation with other maintainers as I mentioned I was
> reviewing and the question raised was - Why add this ? if you want these
> values exposed, wouldn't it be better to to add to ovsdb ?
That's a good point. I had consider
On 9 Sep 2023, at 1:11, Ilya Maximets wrote:
> On 9/5/23 14:40, Eelco Chaudron wrote:
>> This patch adds WARNINGs for the subject line length and the format,
>> i.e., the sentence should start with a capital and end with a dot.
>>
>> Signed-off-by: Eelco Chaudron
>> ---
>> utilities/checkpatc
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 106 characters long (recommended limit is 79)
#1511 FILE: utilities/usdt-scr
On 11 Sep 2023, at 11:36, David Marchand wrote:
> On Fri, Sep 8, 2023 at 4:28 PM Eelco Chaudron wrote:
>> On 6 Sep 2023, at 8:20, David Marchand wrote:
>>
>>> Integrate system-traffic.at tests as part of check-dpdk.
>>>
>>> Some tests that can't work with the userspace datapath are skipped by
>
This patch adds an utility that can be used to determine if
an issue is related to a lack of Linux kernel resources.
This tool is also featured in a Red Hat developers blog article:
https://developers.redhat.com/articles/2023/07/24/troubleshooting-open-vswitch-kernel-blame
Signed-off-by: Eelc
On Fri, Sep 8, 2023 at 4:28 PM Eelco Chaudron wrote:
> On 6 Sep 2023, at 8:20, David Marchand wrote:
>
> > Integrate system-traffic.at tests as part of check-dpdk.
> >
> > Some tests that can't work with the userspace datapath are skipped by
> > overriding some OVS_CHECK_* macros.
> >
> > ADD_VETH
On 9 Sep 2023, at 10:48, James Raphael Tiovalen wrote:
> C++ does not allow implicit conversion from void pointer to a specific
> pointer type. This change removes the cast from uint32_t* to void* in
> `hash_words_32aligned` and adds an explicit typecast from uint32_t* to
> uint64_t* in `hash_w
34 matches
Mail list logo
