Re: [ovs-dev] [PATCH] python: idl: Fix last-id update from a monitor reply.

On 9/12/23 20:10, Han Zhou wrote: > Thanks Ilya! > > On Fri, Sep 8, 2023 at 7:18 PM Ilya Maximets > wrote: >> >> While sending a reply to the monitor_cond_since request, server >> includes the last transaction ID.  And it sends new IDs with each >> subsequent update. 

Re: [ovs-dev] [PATCH] dpdk: expose cpu usage stats on telemetry socket

On 9/12/23 15:47, Eelco Chaudron wrote: > > > On 12 Sep 2023, at 15:19, Robin Jarry wrote: > >> Eelco Chaudron, Sep 12, 2023 at 09:17: >>> I feel like if we do need another way of getting (real time) >>> statistics out of OVS, we should use the same communication channel as >>> the other

Re: [ovs-dev] [PATCH] vswitchd, ofproto-dpif: Add support for CT limit

On 9/11/23 08:36, Ales Musil wrote: > > > On Sat, Sep 9, 2023 at 12:33 AM Ilya Maximets > wrote: > > On 8/10/23 14:48, Ales Musil wrote: > > Add support for setting CT zone limit via ovs-vswitchd > > database CT_Zone entry. The limit is propagated > >

[ovs-dev] [PATCH ovn 06/15] tests: fixed multiple tests not properly waiting for packets to be received

- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS - dns lookup : 1 HV, 2 LS, 2 LSPs/LS - dhcpv6 : 1 HV, 2 LS, 5 LSPs - IPv6 ND Router Solicitation responder - 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port - send gratuitous arp for NAT rules on distributed router - send gratuitous ARP for

[ovs-dev] [PATCH ovn 11/15] tests: fixed "send gratuitous ARP for NAT rules on HA distributed router"

Fixes: 0c89c0fddb4f ("tests: fixed another flake in "send gratuitous ARP for NAT rules on HA distributed router"") Signed-off-by: Xavier Simonart --- tests/ovn.at | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 8ebf55580..d4e0016e5

[ovs-dev] [PATCH ovn 08/15] tests: fixed "L2 Drop and Allow ACL w/ Stateful ACL"

The test was setting ACL rules, then sending packets, then changing ACLs rules, then sending packets. Then it checked whether those packets were properly received/dropped at the end. It should check whether those packets are properly recived/dropped before updating ACLs rules for the second test

[ovs-dev] [PATCH ovn 13/15] tests: fixed "LSP incremental processing"

We might get less recomputes than expected: e.g. Port_Binding->chassis and Port_Binding->up might be received by northd within the same idl transaction. Signed-off-by: Xavier Simonart --- tests/ovn-northd.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH ovn 03/15] tests: fixed "options:requested-chassis for logical port"

The test was checking if a lport was properly released, but in some race condition the logging message is slighly different. Signed-off-by: Xavier Simonart --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index

[ovs-dev] [PATCH ovn 14/15] tests: fixed "ipsec -- basic configuration"

Signed-off-by: Xavier Simonart --- tests/ovn-ipsec.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn-ipsec.at b/tests/ovn-ipsec.at index 10ef97878..f8df8d60e 100644 --- a/tests/ovn-ipsec.at +++ b/tests/ovn-ipsec.at @@ -48,11 +48,11 @@ ovn-nbctl set nb_global .

[ovs-dev] [PATCH ovn 10/15] tests: move trim_zeros() to ovn-macros

trim_zeros was redefined multiple times in ovn.at, and was undefined for one test. Signed-off-by: Xavier Simonart --- tests/ovn-macros.at | 4 tests/ovn.at| 53 - 2 files changed, 4 insertions(+), 53 deletions(-) diff --git

[ovs-dev] [PATCH ovn 02/15] tests: fixed "Logical router policy packet marking"

The test was sometimes failing if an arp packet was received after installing priority=0 flow, and before installing the flow matching arp. Signed-off-by: Xavier Simonart --- tests/ovn.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index

[ovs-dev] [PATCH ovn 01/15] tests: fixed multiple ovn-ic tests

Multiple ovn-ic tests change routes in az1 and check whether the routes are properly updated in az2. Some of those tests add some ovn-nbctl --wait=sb sync in az2. However, if ovn-ic processes are slow for whatever reasons, such tests might have failed. Signed-off-by: Xavier Simonart ---

[ovs-dev] [PATCH ovn 12/15] tests: fixed "SCTP Load balancer health checks"a

There is no guarantee that ovn-northd and not its 'backup' gets the lock. Hence we need to check both logs. Signed-off-by: Xavier Simonart --- tests/ovn.at | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index d4e0016e5..02c763593 100644 ---

[ovs-dev] [PATCH ovn 05/15] tests: wait for all flows to be installed before sending packets

Remote output flows are setup when binding of remote port is received. Hence those flows can be setup after ports have been reported up. - 3 HVs, 1 VIFs/HV, 1 software GW, 1 LS - 3 HVs, 3 LS, 3 lports/LS, 1 LR - 2 HVs, 2 LRs connected via LS, gateway router Signed-off-by: Xavier Simonart ---

[ovs-dev] [PATCH ovn 09/15] tests: skip test "MAC binding aging" if scapy not available.

Signed-off-by: Xavier Simonart --- tests/ovn.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovn.at b/tests/ovn.at index 863f7c71d..31e41c012 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -34484,6 +34484,7 @@ AT_CLEANUP OVN_FOR_EACH_NORTHD([ AT_SETUP([MAC binding aging])

[ovs-dev] [PATCH ovn 07/15] tests: fixed multiple tests missing ovn-nbctl "wait"

- dhcpv4 : 1 HV, 2 LS - Remote port binding - MLD snoop/querier/relay - basic connectivity with multiple requested-chassis Signed-off-by: Xavier Simonart --- tests/ovn-northd.at | 2 +- tests/ovn.at| 15 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH ovn 15/15] tests: do not start northd-backup for northd tests querying northd

At test startup, there is no guarantee that northd gets the lock instead of northd-backup. Some northd tests query northd using "as northd ovn-appctl -t ovn-northd ..". Hence those query might go to the inactive northd, and tests were randomly failing. Signed-off-by: Xavier Simonart ---

[ovs-dev] [PATCH ovn 00/15] Fixed another set of flaky Unit Tests

Xavier Simonart (15): tests: fixed multiple ovn-ic tests tests: fixed "Logical router policy packet marking" tests: fixed "options:requested-chassis for logical port" tests: tests fixed "Encaps tunnel cleanup ..." and "ovn-controller exit" tests: wait for all flows to be installed

[ovs-dev] [PATCH ovn 04/15] tests: tests fixed "Encaps tunnel cleanup ..." and "ovn-controller exit"

Both tests were randomly failing as not properly checking that ovn-controller really exited. Fixes: 4caf8da7e81b ("tests: fixed "Encaps tunnel cleanup does not interfere with multiple controller on the same host"") Signed-off-by: Xavier Simonart --- tests/ovn.at | 7 ++- 1 file changed,

[ovs-dev] [PATCH ovn 2/3] binding: handle pb->chassis and pb->up from if-status module

Before this patch, if-status module handled pb->chassis and pb->up for vif ports, but not for non-VIF ports. This caused a few potential issues: - It was difficult to check that a no-vif port has been previously claimed as there was no state in if-status. Hence it was difficult to always release

[ovs-dev] [PATCH ovn 3/3] Fix flows not removed in ha migration

Signed-off-by: Xavier Simonart --- controller/binding.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/controller/binding.c b/controller/binding.c index fff631e7f..d7dd84a1b 100644 --- a/controller/binding.c +++ b/controller/binding.c @@ -1853,7 +1853,9 @@

[ovs-dev] [PATCH ovn 1/3] binding: slight refactor if no local binding in consider_iface_release

Signed-off-by: Xavier Simonart --- controller/binding.c | 74 +--- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/controller/binding.c b/controller/binding.c index fd08aaafa..dbd2d52b7 100644 --- a/controller/binding.c +++

[ovs-dev] [PATCH ovn] Fix missing flows in ls_in_dhcp_options table

When ha-chassis-group is updated, causing a new hv to become master, port move to a different chassis, and flows get created in table ls_in_dhcp_options. If pb->chassis is reported empty by sb (because set to [] by the hv being the previous owner of the port) those flows were deleted. However,

[ovs-dev] [PATCH ovn] controller: have I+P assigning ct_zones for l3gateway ports

When l3gateway ports get added, ct_zones were assigned during (ct_zones) recomputes, but not by I+P. Before this patch, test "Migration of CT zone from UUID to name" was randomly failing, as ct_zone was not assigned by I+P but a ct_zone recompute happened most of the time (and hence test

[ovs-dev] [PATCH ovn] controller: throttle port claim attempts from if-status

A recent commit (4dc4bc7f) throttled the port claim attemps from the binding module when multiple chassis were fighting for the same port. However, the if-status module was also sometimes fighting for the same ports. Fix this by having the if-status module postponing claims in a similar way as

[ovs-dev] [PATCH ovn] northd: Remove hosting-chassis only if it's specified

To avoid any warning spam in the northd.log remove the "hosting-chassis" status only if it was previously specified. Fixes: 19164b030404 ("Expose distributed gateway port information in NB DB") Reported-at: https://issues.redhat.com/browse/FDP-54 Signed-off-by: Ales Musil --- northd/northd.c |

[ovs-dev] 答复: [PATCH] netdev-dpdk: fix tso bug

Hi，david In dpdk 22.11 rte_mbuf_core.h file, there are notes as follows: /** * TCP segmentation offload. To enable this offload feature for a * packet to be transmitted on hardware supporting TSO: * - set the RTE_MBUF_F_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies *