Hi, all,
I know this, it's NOT bug.
The design of this command is right.
The option carried is use for read, the flow FILE is used for write.
User need to ensure the version of option and flow FILE matches, like, If
your flow FILE is written by openflow13, then you should use -O OpenFlow13.
These were recently updated to pass the checks, so should be
added to the list in order to avoid regressions in the future.
While at it, fixing the indentation.
Signed-off-by: Ilya Maximets
---
build-aux/automake.mk | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff
A few general style issues like extra spacing and line length,
semicolons at the end of the line and unused variable 'raw_types'.
And a few invalid escape sequences, which are not actual escape
sequences, but cause actual syntax warnings starting python 3.12
and will eventually become syntax
A few general style issues like extra spacing and lines being too long,
unused variable 'error_types', passing more arguments than a format
string has. And a few invalid escape sequences, which are not actual
escape sequences, but cause actual syntax warnings starting python 3.12
and will
A few general style issues like extra spacing and block comment format.
And a few invalid escape sequences, which are not actual escape
sequences, but cause actual syntax warnings starting python 3.12 and
will eventually become syntax errors [1]:
extract-ofp-fields:323: SyntaxWarning: invalid
A few general style issues like extra spacing and lines being too long.
Also, unused variables 'error_types' and 'comments'. And a few invalid
escape sequences, which are not actual escape sequences, but cause
actual syntax warnings starting python 3.12 and will eventually become
syntax errors
The main goal of this patch set is to enable builds without warnings
on systems with Python 3.12. Python 3.12 turned having invalid escape
sequences into a SyntaxWarning. In the future it will become an
actual syntax error:
Otherwise it's hard to keep track of all the scripts we have.
Signed-off-by: Ilya Maximets
---
build-aux/automake.mk| 10 +-
datapath-windows/include/automake.mk | 2 --
include/automake.mk | 1 -
include/openflow/automake.mk | 3 ---
Hi Ilya,
thanks for sharing your thoughts, always appreciated! ☺️ Please find comments
below.
On 28.10.23 00:05, Ilya Maximets wrote:
> On 10/27/23 23:51, Ilya Maximets wrote:
>> On 10/26/23 13:44, Jakob Meng wrote:
>>> On 25.10.23 11:37, jm...@redhat.com wrote:
From: Jakob Meng
There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offload
should not be attempted if OVS_TUNNEL_KEY_ATTR_TP_SRC is requested
by OVS. Current code just ignores the attribute in the tunnel(set())
action leading to a flow mismatch and potential incorrect datapath
behavior:
On 30.10.23 14:07, Ilya Maximets wrote:
> On 10/30/23 10:54, Jakob Meng wrote:
>> On 27.10.23 17:25, Kevin Traynor wrote:
>>> On 27/10/2023 14:38, Ilya Maximets wrote:
On 10/26/23 11:29, Jakob Meng wrote:
> On 25.10.23 19:10, Ilya Maximets wrote:
>> ...
>> Maybe something along
On 10/30/23 10:54, Jakob Meng wrote:
> On 27.10.23 17:25, Kevin Traynor wrote:
>> On 27/10/2023 14:38, Ilya Maximets wrote:
>>> On 10/26/23 11:29, Jakob Meng wrote:
On 25.10.23 19:10, Ilya Maximets wrote:
> ...
> Maybe something along these lines:
>
> - ovs-appctl:
>
On 30 Oct 2023, at 11:50, Jakob Meng wrote:
> On 27.10.23 15:52, Eelco Chaudron wrote:
>> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> This patch introduces support for different output formats to the
>>> Python code, as did the previous commit for ovs-xxx
On 10/30/23 10:52, Eelco Chaudron wrote:
>
>
> On 27 Oct 2023, at 23:51, Ilya Maximets wrote:
>
>> On 10/26/23 13:44, Jakob Meng wrote:
>>> On 25.10.23 11:37, jm...@redhat.com wrote:
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if
OVS
On Mon, Oct 30, 2023 at 09:54:58AM +0100, Jakob Meng wrote:
> Hi Aaron,
>
> first and foremost: I am fully committed to make our OVS community more
> inclusive. Replacing terminology that promotes racial and cultural bias is
> one of many (!) steps in achieving that. For the objective there is
On 10/30/23 11:03, Hemanth Aramadaka wrote:
> Hi Ilya,
>
> The changes are not required for flow_hash_5tuple() function. I have added
> debug statements, and we are not hitting this function as part of this code
> flow.
It doesn't matter if you hit this particular function in your scenario
or
On Mon, Oct 30, 2023 at 02:58:36AM -0400, Mike Pattrick wrote:
> Currently when userspace-tso is enabled, netdev-linux interfaces will
> indicate support for all offload flags regardless of interface
> configuration. This patch checks for which offload features are enabled
> during netdev
On Mon, Oct 30, 2023 at 02:00:04PM +0900, Nobuhiro MIKI wrote:
> A conjunctive flow consists of two or more multiple flows with
> conjunction actions. When input to the ofproto/trace command
> matches a conjunctive flow, it outputs flows of all dimensions.
>
> Signed-off-by: Nobuhiro MIKI
On 30.10.23 11:19, Eelco Chaudron wrote:
> On 30 Oct 2023, at 11:07, Jakob Meng wrote:
>
>> On 27.10.23 16:27, Eelco Chaudron wrote:
>>> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
From: Jakob Meng
Add global option to output JSON from ovs-appctl cmds.
This patch is
On 27.10.23 15:52, Eelco Chaudron wrote:
> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> This patch introduces support for different output formats to the
>> Python code, as did the previous commit for ovs-xxx tools like
>> 'ovs-appctl --format json dpif/show'.
>> In
On 10/27/23 18:05, Numan Siddique wrote:
> On Fri, Jul 14, 2023 at 2:12 AM Ales Musil wrote:
>>
>> On Thu, Jul 13, 2023 at 12:52 PM Dumitru Ceara wrote:
>>
>>> If we want to catch new failures faster we have a better chance if CI
>>> doesn't auto-retry (once).
>>>
>>> There are some tests that
On 10/27/23 17:57, Numan Siddique wrote:
> On Thu, Oct 26, 2023 at 7:37 AM Dumitru Ceara wrote:
>>
>> OVS actually supports way more. Detect the real number of groups and
>> meters instead. To avoid preallocating huge bitmaps for the IDs,
>> switch to id-pool instead (as suggested by Ilya).
>>
On Tue, Oct 24, 2023 at 05:04:05PM +, Ihar Hrachyshka wrote:
> With --hexified, it will produce a bare hexified payload with no spaces
> or offset indicators inserted, which is useful in tests to produce
> frames to pass to e.g. `receive`.
>
> With --bad-csum, it will produce a frame that has
On 30 Oct 2023, at 11:07, Jakob Meng wrote:
> On 27.10.23 16:27, Eelco Chaudron wrote:
>> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> Add global option to output JSON from ovs-appctl cmds.
>>>
>>> This patch is an update of [0] with the following major
On Mon, Oct 23, 2023 at 07:22:08PM -0700, Kaixi Fan wrote:
> Hi Simon Horman,
>
> Thanks. If it's ready, I will repost again.
Thanks, much appreciated.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Ilya,
The changes are not required for flow_hash_5tuple() function. I have added
debug statements, and we are not hitting this function as part of this code
flow.
Thanks,
Hemanth.
-Original Message-
From: Ilya Maximets
Sent: Monday, June 26, 2023 7:59 PM
To: Hemanth Aramadaka ;
, Oct 30, 2023 at 10:50:
From: Jakob Meng
For better usability, the function pairs get_config() and
set_config() for netdevs should be symmetric: Options which are
accepted by set_config() should be returned by get_config() and the
latter should output valid options for set_config() only.
On 27.10.23 16:27, Eelco Chaudron wrote:
> On 25 Oct 2023, at 11:37, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> Add global option to output JSON from ovs-appctl cmds.
>>
>> This patch is an update of [0] with the following major changes:
>> * The JSON-RPC API change is now backward
On 27.10.23 17:25, Kevin Traynor wrote:
> On 27/10/2023 14:38, Ilya Maximets wrote:
>> On 10/26/23 11:29, Jakob Meng wrote:
>>> On 25.10.23 19:10, Ilya Maximets wrote:
...
Maybe something along these lines:
- ovs-appctl:
* Output of 'dpctl/show' command no longer
On 27 Oct 2023, at 23:51, Ilya Maximets wrote:
> On 10/26/23 13:44, Jakob Meng wrote:
>> On 25.10.23 11:37, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> For monitoring systems such as Prometheus it would be beneficial if
>>> OVS and OVS-DPDK would expose statistics in a
From: Jakob Meng
For better usability, the function pairs get_config() and
set_config() for netdevs should be symmetric: Options which are
accepted by set_config() should be returned by get_config() and the
latter should output valid options for set_config() only.
This patch moves key-value
From: Jakob Meng
For better usability, the function pairs get_config() and
set_config() for netdevs should be symmetric: Options which are
accepted by set_config() should be returned by get_config() and the
latter should output valid options for set_config() only. This patch
also moves key-value
From: Jakob Meng
This patch series incorporates Ilya's and Kevin's change requests for v6:
* added NEWS suggestion to netdev-dpdk patch
* netdev-dpdk patch with NEWS entry has been put at the end of the series
* get_config shuffle in dpdk_class, dpdk_vhost_class and
dpdk_vhost_client_class has
From: Jakob Meng
For better usability, the function pairs get_config() and
set_config() for netdevs should be symmetric: Options which are
accepted by set_config() should be returned by get_config() and the
latter should output valid options for set_config() only. This patch
also moves key-value
Before this patch, if-status module handled pb->chassis and pb->up
for vif ports, but not for non-VIF ports.
This caused a few potential issues:
- It was difficult to check that a no-vif port has been previously claimed
as there was no state in if-status. Hence it was difficult to always release
Xavier Simonart (3):
binding: slight refactor if no local binding in consider_iface_release
binding: handle pb->chassis and pb->up from if-status module
Fix flows not removed in ha migration
controller/binding.c| 221 ++--
controller/binding.h
Signed-off-by: Xavier Simonart
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index bd48db621..cc316f390 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -1841,7 +1841,9 @@
Signed-off-by: Xavier Simonart
---
controller/binding.c | 74 +---
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/controller/binding.c b/controller/binding.c
index 8020d052f..9a09b2074 100644
--- a/controller/binding.c
+++
On 28.10.23 00:08, Ilya Maximets wrote:
> On 10/26/23 14:10, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> The unixctl implementation in Python has been split into three parts in
>> the past. During this process the UnixctlClient was duplicated, in
>> python/ovs/unixctl/client.py and
From: Jakob Meng
The unixctl implementation in Python has been split into three parts in
the past. During this process the UnixctlClient was duplicated, in
python/ovs/unixctl/client.py and python/ovs/unixctl/server.py. This
patch removes the duplicate from the latter.
Fixes: 53cf9963ccc6
From: Jakob Meng
Only change from v1 is that the "Fixes" tag in the commit message is
not abbreviated anymore.
Jakob Meng (1):
python: Remove duplicate UnixctlClient implementation.
python/ovs/unixctl/server.py | 44
1 file changed, 44 deletions(-)
--
Hi Aaron,
first and foremost: I am fully committed to make our OVS community more
inclusive. Replacing terminology that promotes racial and cultural bias is one
of many (!) steps in achieving that. For the objective there is a broad
consensus, on the practical implementation not so much, it
When a tunnel_key for a datapath was changed, the local_datapaths hmap was not
properly updated
as the old/initial entry was not removed.
- If the datapath was not deleted at the same time, a new entry (for the same
dp) was created
in the local_datapaths as the previous entry was not found
When l3gateway ports get added, ct_zones were assigned during
(ct_zones) recomputes, but not by I+P.
Before this patch, test "Migration of CT zone from UUID to name"
was randomly failing, as ct_zone was not assigned by I+P but
a ct_zone recompute happened most of the time (and hence test
From: Flavio Leitner
This provides a software implementation in the case
the egress netdev doesn't support segmentation in hardware.
The challenge here is to guarantee packet ordering in the
original batch that may be full of TSO packets. Each TSO
packet can go up to ~64kB, so with segment size
Currently when userspace-tso is enabled, netdev-linux interfaces will
indicate support for all offload flags regardless of interface
configuration. This patch checks for which offload features are enabled
during netdev construction.
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 156
From: Flavio Leitner
Currently OVS will calculate the segment size based on the
MTU of the egress port. That usually happens to be correct
when the ports share the same MTU, but that is not always true.
Therefore, if the segment size is provided, then use that and
make sure the over sized
47 matches
Mail list logo
