Re: [ovs-dev] [PATCH] reconnect: set defaults from environment variables

2023-11-07 Thread 0-day Robot
Bleep bloop. Greetings Felix Huettner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary

[ovs-dev] [PATCH] reconnect: set defaults from environment variables

2023-11-07 Thread Felix Huettner via dev
this exposes the old constants regarding min backoff, max backoff and probe interval using environment variables. In case previously users wanted to tune the probe interval for all connections this required setting this setting in multiple locations. E.g. to configure the probe interval from a

Re: [ovs-dev] [PATCH ovn] northd: Support CIDR-based MAC binding aging threshold.

2023-11-07 Thread Dumitru Ceara
On 11/8/23 05:39, Han Zhou wrote: > On Tue, Nov 7, 2023 at 6:12 PM Han Zhou wrote: >> >> >> >> On Tue, Nov 7, 2023 at 8:06 AM Dumitru Ceara wrote: >>> >>> On 11/6/23 08:19, Han Zhou wrote: On Sun, Nov 5, 2023 at 10:59 PM Ales Musil wrote: > > > > On Sat, Nov 4, 2023 at 5:45 

Re: [ovs-dev] [PATCH ovn v2] northd: Support CIDR-based MAC binding aging threshold.

2023-11-07 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #446 FILE: northd/northd.c:1172: * XXX: This approach

Re: [ovs-dev] [PATCH ovn] northd: Support CIDR-based MAC binding aging threshold.

2023-11-07 Thread Han Zhou
On Tue, Nov 7, 2023 at 6:12 PM Han Zhou wrote: > > > > On Tue, Nov 7, 2023 at 8:06 AM Dumitru Ceara wrote: > > > > On 11/6/23 08:19, Han Zhou wrote: > > > On Sun, Nov 5, 2023 at 10:59 PM Ales Musil wrote: > > >> > > >> > > >> > > >> On Sat, Nov 4, 2023 at 5:45 AM Han Zhou wrote: > > >>> > >

[ovs-dev] [PATCH ovn v2] northd: Support CIDR-based MAC binding aging threshold.

2023-11-07 Thread Han Zhou
Enhance MAC_Binding aging to allow CIDR-based threshold configurations. This enables distinct threshold settings for different IP ranges, applying the longest prefix matching for overlapping ranges. A common use case involves setting a default threshold for all IPs, while disabling aging for a

Re: [ovs-dev] [PATCH ovn] northd: Support CIDR-based MAC binding aging threshold.

2023-11-07 Thread Han Zhou
On Tue, Nov 7, 2023 at 8:06 AM Dumitru Ceara wrote: > > On 11/6/23 08:19, Han Zhou wrote: > > On Sun, Nov 5, 2023 at 10:59 PM Ales Musil wrote: > >> > >> > >> > >> On Sat, Nov 4, 2023 at 5:45 AM Han Zhou wrote: > >>> > >>> > >>> > >>> On Fri, Nov 3, 2023 at 1:08 AM Ales Musil wrote: > >

Re: [ovs-dev] [PATCH ovn] fake-multinode-ci: Use python version '3.11' instead of '3.x'.

2023-11-07 Thread Mark Michelson
On 11/6/23 23:47, Dumitru Ceara wrote: On 11/2/23 16:30, num...@ovn.org wrote: From: Numan Siddique With the 'ubuntu-latest' image in github CI, OVS compilation is failing with the below error: --- python/ovs/tests/test_dns_resolve.py:272:54: E231 missing whitespace after ':' make[1]: ***

Re: [ovs-dev] [PATCH ovn] northd: Support CIDR-based MAC binding aging threshold.

2023-11-07 Thread Dumitru Ceara
On 11/6/23 08:19, Han Zhou wrote: > On Sun, Nov 5, 2023 at 10:59 PM Ales Musil wrote: >> >> >> >> On Sat, Nov 4, 2023 at 5:45 AM Han Zhou wrote: >>> >>> >>> >>> On Fri, Nov 3, 2023 at 1:08 AM Ales Musil wrote: On Tue, Oct 24, 2023 at 9:36 PM Han Zhou wrote: > >

[ovs-dev] [PATCH ovn 2/2] pinctrl: reset success and failures n_count regardless of svc state

2023-11-07 Thread Evgenii Kovalev
This patch adds reset n_count regardless of svc state and does only if n_count >= configured_count. The behavior hc with windows server as backend in load balancers show some issue with counters, e.g.: ovn-controller --> win_srv | SYN ovn-controller <-- win_srv | SYN_ACK <- increase n_success

[ovs-dev] [PATCH ovn 1/2] pinctrl: send RST instead of RST_ACK bit for lb hc

2023-11-07 Thread Evgenii Kovalev
Currently an ovn-controller send RST_ACK after receive SYN_ACK in load balancer health check, but for a windows as load balancer backend this behavior unexcpected and windows send SYN_ACK like a tcp retransmission after every RST_ACK, finaly after few reties windows send RST bit to ovn-controller.

[ovs-dev] [PATCH ovn v2 2/2] controller: avoid extra flows if localnet_learn_fdb is disabled

2023-11-07 Thread Xavier Simonart
Those extra flows are added when 1st localnet_learn_fdb is enabled. They are however not removed if/when last localnet_learn_fdb got disabled. Signed-off-by: Xavier Simonart --- controller/binding.c| 12 controller/binding.h| 3 +++ controller/lflow.c | 28

[ovs-dev] [PATCH ovn v2 1/2] controller: FDB entries for localnet should not overwrite entries for vifs

2023-11-07 Thread Xavier Simonart
When localnet_learn_fdb is set, some localnet entries were overwriting entries from vifs; as a result, packets were not delivered to vifs anymore. This could have happened in the following config: - Two hv (hv1 and hv2) - vif1, vif2 and ln on ls - vif1 on hv1 and vif2 on hv2 When vif1 (mac1) sends

[ovs-dev] [PATCH ovn v2 0/2] FDB entries for localnet should not overwrite entries for vifs

2023-11-07 Thread Xavier Simonart
*** BLURB HERE *** Xavier Simonart (2): controller: FDB entries for localnet should not overwrite entries for vifs controller: avoid extra flows if localnet_learn_fdb is disabled controller/binding.c | 12 ++ controller/binding.h | 3 + controller/lflow.c |