Re: [ovs-dev] [PATCH] Documentation: Add section on inclusive language.

2023-12-14 Thread Aaron Conole
Simon Horman writes: > As a community we should strive to be inclusive. > As such it seems appropriate to adopt an word list, > to help guide the use of inclusive language. > > This patch proposes use of the Inclusive Naming Word List v1.0. > > Link: https://inclusivenaming.org/word-lists/ >

Re: [ovs-dev] [PATCH ovn v2 07/18] northd: Generate logical router's LB and NAT flows using lr_lbnat_data.

2023-12-14 Thread Numan Siddique
On Thu, Dec 14, 2023 at 12:32 PM Han Zhou wrote: > > On Tue, Nov 14, 2023 at 10:42 PM Han Zhou wrote: > > > > > > > > On Thu, Oct 26, 2023 at 11:16 AM wrote: > > > > > > From: Numan Siddique > > > > > > Previous commits added new engine nodes to store logical router's lb > > > and NAT data.

Re: [ovs-dev] [RFC] bridge: Re-create bridges when Flow API is enabled.

2023-12-14 Thread Adrian Moreno
On 12/13/23 11:47, Adrian Moreno wrote: On 9/15/23 17:25, Eelco Chaudron wrote: On 9 Sep 2023, at 1:40, Ilya Maximets wrote: Currently OVS requires restart of ovs-vswitchd after enabling hardware offload.  This is necessary to make sure all the correct features are probed and all the

Re: [ovs-dev] [branch-21.12 v2 ovn] controller: make garp_max_timeout configurable

2023-12-14 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [branch-21.12 v2 ovn] controller: make garp_max_timeout configurable

2023-12-14 Thread Lorenzo Bianconi
When using VLAN backed networks and OVN routers leveraging the 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field is replaced by the chassis mac address in order to not expose the router mac address from different nodes and confuse the TOR switch. However doing so the TOR

Re: [ovs-dev] [PATCH ovn v2 07/18] northd: Generate logical router's LB and NAT flows using lr_lbnat_data.

2023-12-14 Thread Han Zhou
On Tue, Nov 14, 2023 at 10:42 PM Han Zhou wrote: > > > > On Thu, Oct 26, 2023 at 11:16 AM wrote: > > > > From: Numan Siddique > > > > Previous commits added new engine nodes to store logical router's lb > > and NAT data. Make use of the data stored by these engine nodes > > to generate logical

Re: [ovs-dev] [PATCH v9 1/2] userspace: Support vxlan and geneve tso.

2023-12-14 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH v9 2/2] userspace: Enable tunnel tests with tso.

2023-12-14 Thread Mike Pattrick
This patch enables most of the tunnel tests in the testsuite, and adds a large TCP transfer to a vxlan and geneve test to verify TSO functionality. Some additional changes were required to accommodate these changes with netdev-linux interfaces. The test for vlan over vxlan is purposely not enabled

[ovs-dev] [PATCH v9 1/2] userspace: Support vxlan and geneve tso.

2023-12-14 Thread Mike Pattrick
From: Dexia Li For userspace datapath, this patch provides vxlan and geneve tunnel tso. Only support userspace vxlan or geneve tunnel, meanwhile support tunnel outter and inner csum offload. If netdev do not support offload features, there is a software fallback.If netdev do not support vxlan

[ovs-dev] [PATCH ovn v2] controller: Avoid double controller action for ICMP errors

2023-12-14 Thread Ales Musil
The fields that are not directly supported by OvS were encoded via additional controller action that changed the required value. This was most notably needed for ICMP need frag messages. Encode the field value loads as note action instead. This allows us to find the note and act accordingly in

[ovs-dev] [PATCH] Documentation: Add section on inclusive language.

2023-12-14 Thread Simon Horman
As a community we should strive to be inclusive. As such it seems appropriate to adopt an word list, to help guide the use of inclusive language. This patch proposes use of the Inclusive Naming Word List v1.0. Link: https://inclusivenaming.org/word-lists/ Signed-off-by: Simon Horman ---

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-12-14 Thread Aaron Conole
Eelco Chaudron writes: > On 15 Nov 2023, at 3:33, Aaron Conole wrote: > >> Eelco Chaudron writes: >> >>> On 14 Nov 2023, at 8:49, Roi Dayan wrote: >>> On 13/11/2023 19:08, Aaron Conole wrote: > Roi Dayan writes: > >> codespell dictionary contains a list of widely used words

Re: [ovs-dev] [PATCH 00/22] ovsdb-server: Configuration via config-file.

2023-12-14 Thread Ilya Maximets
On 12/14/23 08:12, Frode Nordahl wrote: > On Thu, Dec 14, 2023 at 2:04 AM Ilya Maximets wrote: >> >> The original problem was summarized on the OVS+OVN Conf'22 last year: >> https://www.openvswitch.org/support/ovscon2022/#t19 >> Slides: >>

Re: [ovs-dev] [PATCH v5 1/1] dpif-netdev: Add per pmd sleep config.

2023-12-14 Thread Ilya Maximets
On 12/14/23 12:15, Kevin Traynor wrote: > On 11/10/2023 20:08, Ilya Maximets wrote: >> On 9/29/23 14:50, Kevin Traynor wrote: >>> Extend 'pmd-sleep-max' so that individual PMD thread cores may have >>> a specified max sleep request value. >>> >>> Existing behaviour is maintained. >>> >>> Any PMD

Re: [ovs-dev] [PATCH 08/22] ovsdb: Track jsonrpc options per remote.

2023-12-14 Thread Frode Nordahl
On Thu, Dec 14, 2023 at 11:41 AM Ilya Maximets wrote: > > On 12/14/23 08:15, Frode Nordahl wrote: > > On Thu, Dec 14, 2023 at 2:05 AM Ilya Maximets wrote: > >> > >> Store KSON-RPC options for each remote separately, so it will be > > > > s/KSON/JSON > > > >> possible to have different

Re: [ovs-dev] [PATCH v5 1/1] dpif-netdev: Add per pmd sleep config.

2023-12-14 Thread Kevin Traynor
On 11/10/2023 20:08, Ilya Maximets wrote: On 9/29/23 14:50, Kevin Traynor wrote: Extend 'pmd-sleep-max' so that individual PMD thread cores may have a specified max sleep request value. Existing behaviour is maintained. Any PMD thread core without a value will use the global value if set or

[ovs-dev] [PATCH v6 1/1] dpif-netdev: Add per pmd sleep config.

2023-12-14 Thread Kevin Traynor
Extend 'pmd-sleep-max' so that individual PMD thread cores may have a specified max sleep request value. Existing behaviour is maintained. Any PMD thread core without a value will use the global value if set or default no sleep. To set PMD thread cores 8 and 9 to never request a load based

[ovs-dev] [PATCH v6 0/1] Per pmd load based sleeping

2023-12-14 Thread Kevin Traynor
These patches allow specific sleep settings for PMD threads. It is backwards compatabile with previously only allowing a global value. v6: - Reworked for Ilya v5 review - Added NEWS - Reworked list parsing to handle invalid key:value value correctly - Added UTs for invalid values - Other minor

Re: [ovs-dev] [PATCH 08/22] ovsdb: Track jsonrpc options per remote.

2023-12-14 Thread Ilya Maximets
On 12/14/23 08:15, Frode Nordahl wrote: > On Thu, Dec 14, 2023 at 2:05 AM Ilya Maximets wrote: >> >> Store KSON-RPC options for each remote separately, so it will be > > s/KSON/JSON > >> possible to have different configurations per remote in the future. >> >> These are also stored to and

Re: [ovs-dev] [PATCH ovn 0/3] Keep track of SNAT status for ICMP need frag

2023-12-14 Thread Ales Musil
On Wed, Dec 6, 2023 at 11:19 AM Ales Musil wrote: > The ICMP need frag could be generated after routing > stage when the unSNAT already happened. Add flows > that will ensure that we are keeping track of the CT > state and do appropriate CT nat action later on. > > Because the ICMP traffic is

Re: [ovs-dev] [PATCH v3 2/2] checkpatch.py: Load codespell dictionary.

2023-12-14 Thread Eelco Chaudron
On 15 Nov 2023, at 3:33, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 14 Nov 2023, at 8:49, Roi Dayan wrote: >> >>> On 13/11/2023 19:08, Aaron Conole wrote: Roi Dayan writes: > codespell dictionary contains a list of widely used words > which enchant alone could fail

[ovs-dev] [PATCH ovn] test: multinode: add IPv6 test for geneve pmtu test

2023-12-14 Thread Lorenzo Bianconi
Introduce IPv6 tests for pmtu discovery in multinode test Signed-off-by: Lorenzo Bianconi --- tests/multinode.at | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/multinode.at b/tests/multinode.at index a051ea8c2..0f098000c 100644 ---