[ovs-dev] [PATCH ovn] Revert "ovn: add geneve PMTUD support"

2023-12-15 Thread numans
From: Numan Siddique This reverts commit 450e41e783bfa69e4f9d6c80f6bcb01147d5cfe1. If a packet has to be tunnelled to another node and if the physical interface used for tunnelling has lower MTU than the packet or if there is a route exception with a lower MTU, then the geneve kernel module

Re: [ovs-dev] [PATCH] dpdk: Update to use v23.11.

2023-12-15 Thread Ilya Maximets
On 12/13/23 14:06, David Marchand wrote: > This commit adds support for DPDK v23.11. > It updates the CI script and documentation and includes the following > changes coming from the dpdk-latest branch: > > - sparse: Add some compiler intrinsics for DPDK build. >

Re: [ovs-dev] [PATCH v6 0/1] Per pmd load based sleeping

2023-12-15 Thread Ilya Maximets
On 12/14/23 12:15, Kevin Traynor wrote: > These patches allow specific sleep settings for PMD threads. It is > backwards compatabile with previously only allowing a global value. > > v6: > - Reworked for Ilya v5 review > - Added NEWS > - Reworked list parsing to handle invalid key:value value

Re: [ovs-dev] [PATCH v2 2/2] netdev-dummy: Add support and test for tso.

2023-12-15 Thread Ilya Maximets
On 12/11/23 16:39, Mike Pattrick wrote: > Test that netdev-dummy is able to send and recieve segment offloaded > packets. > > Signed-off-by: Mike Pattrick > > --- > v2: Fix clang build error: mutex needed to access netdev_dummy members > > Signed-off-by: Mike Pattrick > --- >

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-15 Thread Ilya Maximets
On 12/11/23 16:39, Mike Pattrick wrote: > Currently dp_netdev_upcall() resolves checksums on all packets, but this > isn't strictly needed. The checksums will be resolved before > transmission. However, we do have to resolve the checksums before > sending a packet to the controller as offload

Re: [ovs-dev] [PATCH v4] reconnect: Set defaults from environment variables.

2023-12-15 Thread Ilya Maximets
On 12/4/23 12:23, Felix Huettner via dev wrote: > This exposes the old constants regarding min backoff, max backoff and > probe interval using environment variables. In case previously users > wanted to tune the probe interval for all connections this required > setting this setting in multiple

Re: [ovs-dev] [PATCH 2/2] ovsdb: Abort schema conversion before election timer expires.

2023-12-15 Thread Ilya Maximets
On 12/13/23 23:19, Frode Nordahl wrote: > Since the topic of clustered database schema conversion issues was > first brought up [0], there has been several performance > improvements which has greatly improved the situation. > > However, we cannot get away from the fact that the process remains >

Re: [ovs-dev] [PATCH v7 2/3] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2023-12-15 Thread Eric Garver
On Fri, Dec 15, 2023 at 06:02:21PM +0100, Adrian Moreno wrote: > > > On 9/28/23 13:50, Eelco Chaudron wrote: > > > > > > On 25 Sep 2023, at 20:04, Eric Garver wrote: > > > > > Kernel support has been added for this action. As such, we need to probe > > > the datapath for support. > > > > > >

[ovs-dev] [PATCH v10 2/2] userspace: Enable tunnel tests with tso.

2023-12-15 Thread Mike Pattrick
This patch enables most of the tunnel tests in the testsuite, and adds a large TCP transfer to a vxlan and geneve test to verify TSO functionality. Some additional changes were required to accommodate these changes with netdev-linux interfaces. The test for vlan over vxlan is purposely not enabled

[ovs-dev] [PATCH v10 1/2] userspace: Support vxlan and geneve tso.

2023-12-15 Thread Mike Pattrick
From: Dexia Li For userspace datapath, this patch provides vxlan and geneve tunnel tso. Only support userspace vxlan or geneve tunnel, meanwhile support tunnel outter and inner csum offload. If netdev do not support offload features, there is a software fallback.If netdev do not support vxlan

Re: [ovs-dev] [PATCH 1/2] ovsdb: Fix use after free on schema conversion error.

2023-12-15 Thread Ilya Maximets
On 12/13/23 23:19, Frode Nordahl wrote: > In the event a schema conversion aborts, the cleanup code in > ovsdb_convert() prior to this patch will remove the in-memory > copy of the new database prior to aborting any on-going > transactions in that database, consequently leading to a use after >

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-15 Thread Mike Pattrick
On Fri, Dec 15, 2023 at 8:01 AM Eelco Chaudron wrote: > > > > On 11 Dec 2023, at 16:39, Mike Pattrick wrote: > > > Currently dp_netdev_upcall() resolves checksums on all packets, but this > > isn't strictly needed. The checksums will be resolved before > > transmission. However, we do have to

Re: [ovs-dev] [branch-21.12 v2 ovn] controller: make garp_max_timeout configurable

2023-12-15 Thread Lorenzo Bianconi
> On 12/14/23 18:42, Lorenzo Bianconi wrote: > > When using VLAN backed networks and OVN routers leveraging the > > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field > > is > > replaced by the chassis mac address in order to not expose the router mac > > address from

Re: [ovs-dev] [PATCH v7 2/3] dpif: Probe support for OVS_ACTION_ATTR_DROP.

2023-12-15 Thread Adrian Moreno
On 9/28/23 13:50, Eelco Chaudron wrote: On 25 Sep 2023, at 20:04, Eric Garver wrote: Kernel support has been added for this action. As such, we need to probe the datapath for support. Signed-off-by: Eric Garver This patch looks fine to me, and I’ll ack it. However, we should not apply

[ovs-dev] [PATCH ovn] test: add dedicated test for garp-max-timeout

2023-12-15 Thread Lorenzo Bianconi
Introduce a dedicated test for garp-max-timeout knob Signed-off-by: Lorenzo Bianconi --- tests/ovn.at | 82 1 file changed, 82 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 918f97a9e..25b101a7a 100644 --- a/tests/ovn.at +++

Re: [ovs-dev] [RFC] bridge: Re-create bridges when Flow API is enabled.

2023-12-15 Thread Adrian Moreno
On 12/15/23 11:03, Eelco Chaudron wrote: On 14 Dec 2023, at 19:15, Adrian Moreno wrote: On 12/13/23 11:47, Adrian Moreno wrote: On 9/15/23 17:25, Eelco Chaudron wrote: On 9 Sep 2023, at 1:40, Ilya Maximets wrote: Currently OVS requires restart of ovs-vswitchd after enabling

Re: [ovs-dev] [PATCH v3 09/11] ci: Fix dpdk build cache key generation.

2023-12-15 Thread David Marchand
On Tue, Dec 5, 2023 at 4:00 PM Eelco Chaudron wrote: > > When new drivers are introduced, the cache key is not accurately computed. > > Before the commit 1a1b3106d90e ("ci: Separate DPDK from OVS build."), the > DPDK build process was integrated in .ci/linux-{setup,build}.sh scripts, > where

Re: [ovs-dev] [PATCH 00/22] ovsdb-server: Configuration via config-file.

2023-12-15 Thread Dumitru Ceara
On 12/14/23 13:40, Ilya Maximets wrote: > On 12/14/23 08:12, Frode Nordahl wrote: >> On Thu, Dec 14, 2023 at 2:04 AM Ilya Maximets wrote: >>> >>> The original problem was summarized on the OVS+OVN Conf'22 last year: >>> https://www.openvswitch.org/support/ovscon2022/#t19 >>> Slides: >>>

Re: [ovs-dev] [PATCH v3 10/11] ci: Allow make check-dpdk to run the MFEX tests.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:41PM +0100, Eelco Chaudron wrote: > The testcase change will make sure the 'MFEX Configuration' test > will run without the need for scapy and it's auto generated tests. > In addition we exclude the traffic related MFEX tests from running > on GitHub actions due to

Re: [ovs-dev] [PATCH v3 09/11] ci: Fix dpdk build cache key generation.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:27PM +0100, Eelco Chaudron wrote: > When new drivers are introduced, the cache key is not accurately computed. > > Before the commit 1a1b3106d90e ("ci: Separate DPDK from OVS build."), the > DPDK build process was integrated in .ci/linux-{setup,build}.sh scripts, >

Re: [ovs-dev] [PATCH v3 09/11] ci: Fix dpdk build cache key generation.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:27PM +0100, Eelco Chaudron wrote: > When new drivers are introduced, the cache key is not accurately computed. > > Before the commit 1a1b3106d90e ("ci: Separate DPDK from OVS build."), the > DPDK build process was integrated in .ci/linux-{setup,build}.sh scripts, >

Re: [ovs-dev] [PATCH v3 08/11] ci: Add make check-system-tso to GitHub actions ci.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:19PM +0100, Eelco Chaudron wrote: > This patch adds 'make check-system-tso' to the GitHub actions ci. > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 07/11] ci: Add make check-system-userspace to GitHub actions ci.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:09PM +0100, Eelco Chaudron wrote: > This patch adds 'make check-system-userspace' to the GitHub actions ci. > The tests are not split into two seperate test runs as they complete in > around 10 minutes. > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman

Re: [ovs-dev] [PATCH v3 06/11] ci: Add make check-offloads to GitHub actions ci.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:01PM +0100, Eelco Chaudron wrote: > This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip > tests that won't execute successfully through GitHub actions. > We could not use the -k !keyword option, as it can not be > combined with a range of tests. > >

Re: [ovs-dev] [PATCH v3 11/11] ci: Add make check-afxdp to GitHub actions ci.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 04:00:49PM +0100, Eelco Chaudron wrote: > This patch adds 'make check-afxdp' to the GitHub actions ci. > The tests are not split into two seperate test runs as they > complete in around 10 minutes. > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman

Re: [ovs-dev] [PATCH v3 05/11] ci: Add make check-kernel to GitHub actions ci.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 03:59:54PM +0100, Eelco Chaudron wrote: > This patch adds 'make check-kernel' to the GitHub actions ci. > However, to do this, some additional changes were needed. First, > some of the missing test and package dependencies had to be added. > Finally, we added an option to

Re: [ovs-dev] [PATCH v3 04/11] ci: Exclude tests that show random failures through GitHub actions.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 03:59:46PM +0100, Eelco Chaudron wrote: > I ran 80 series of full tests, and the following tests showed failures: > > 802.1ad - vlan_limit >+2023-11-20T10:32:11.245Z|1|dpif_netdev(revalidator5)|ERR|internal > error parsing flow key

Re: [ovs-dev] [PATCH v3 03/11] ci: Update the GitHub Ubuntu runner image to Ubuntu 22.04.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 03:59:38PM +0100, Eelco Chaudron wrote: > Updating this image is a requirement for the kernel system-traffic > tests to pass on Ubuntu. In addition, 20.04 might be replaced, > as soon as 24.04 comes out. Or we need to do this when it becomes > EOL in April 2025. > >

Re: [ovs-dev] [PATCH v3 01/11] ci: Add JOBS variable to replace all the '-j4' instances.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 03:59:23PM +0100, Eelco Chaudron wrote: > Add a JOBS variable, which defaults to '-j4' but can be overwritten > with the same environment variable. This can be useful if you use > this linux-build.sh script outside of GitHub actions on a machine > with many cores. > >

Re: [ovs-dev] [PATCH v3 02/11] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-12-15 Thread Simon Horman
On Tue, Dec 05, 2023 at 03:59:31PM +0100, Eelco Chaudron wrote: > This patch adds 'make check-ovsdb-cluster' tests to GitHub action ci. > In addition, this patch also makes sure this test and 'make check' do > not run as root. > > Signed-off-by: Eelco Chaudron > --- > .ci/linux-build.sh

Re: [ovs-dev] [branch-21.12 v2 ovn] controller: make garp_max_timeout configurable

2023-12-15 Thread Dumitru Ceara
On 12/14/23 18:42, Lorenzo Bianconi wrote: > When using VLAN backed networks and OVN routers leveraging the > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field is > replaced by the chassis mac address in order to not expose the router mac > address from different nodes and

Re: [ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-15 Thread Eelco Chaudron
On 11 Dec 2023, at 16:39, Mike Pattrick wrote: > Currently dp_netdev_upcall() resolves checksums on all packets, but this > isn't strictly needed. The checksums will be resolved before > transmission. However, we do have to resolve the checksums before > sending a packet to the controller as

Re: [ovs-dev] [PATCH v5 0/3] Extend the CT flush with mark and labels fields

2023-12-15 Thread Ilya Maximets
On 12/6/23 08:53, Ales Musil wrote: > The CT flush is not capable of partial flush based > on the touples and zone combinations. Extend it > so it also accepts mark and labels. As part of this > series unify parsing of arguments in dpctl and ovs-ofctl > for the ct flush command. > > Ales Musil

Re: [ovs-dev] [RFC] bridge: Re-create bridges when Flow API is enabled.

2023-12-15 Thread Eelco Chaudron
On 14 Dec 2023, at 19:15, Adrian Moreno wrote: > On 12/13/23 11:47, Adrian Moreno wrote: >> >> >> On 9/15/23 17:25, Eelco Chaudron wrote: >>> >>> >>> On 9 Sep 2023, at 1:40, Ilya Maximets wrote: >>> Currently OVS requires restart of ovs-vswitchd after enabling hardware offload.  This

Re: [ovs-dev] [PATCH v3] ci: Add clang-analyze to GitHub actions.

2023-12-15 Thread Ilya Maximets
On 12/7/23 10:32, Eelco Chaudron wrote: > This patch detects new static analyze issues, and report them. > It does this by reporting on the delta for this branch, compared > to the base branch. > > For example the error might look like this: > > error level: +0 -0 no changes > warning level: