Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-14 Thread Mike Pattrick
On Wed, Feb 14, 2024 at 12:09 PM David Marchand wrote: > > Hello Mike, > > On Mon, Feb 12, 2024 at 8:50 PM Mike Pattrick wrote: > > > > Previously if an OVS configuration nested multiple layers of UDP tunnels > > like VXLAN or GENEVE on top of each other through netdev-linux > > interfaces, the

Re: [ovs-dev] [PATCH ovn] northd: Initialize hmap size in lflow_mgr.

2024-02-14 Thread Numan Siddique
On Wed, Feb 14, 2024 at 1:26 PM Xavier Simonart wrote: > > When (re)starting ovn-northd with an existing big nbdb, > the first iteration of northd was very slow as trying to > push all flows in a single bucket. > > Fixes: a623606052ea ("northd: Refactor lflow management into a separate >

[ovs-dev] [PATCH ovn] northd: Initialize hmap size in lflow_mgr.

2024-02-14 Thread Xavier Simonart
When (re)starting ovn-northd with an existing big nbdb, the first iteration of northd was very slow as trying to push all flows in a single bucket. Fixes: a623606052ea ("northd: Refactor lflow management into a separate module.") Signed-off-by: Xavier Simonart --- northd/lflow-mgr.c | 3 +++

Re: [ovs-dev] [PATCH ovn v1 0/4] northd memory and CPU increase fix due to lflow-mgr.

2024-02-14 Thread Numan Siddique
On Wed, Feb 14, 2024 at 9:51 AM Dumitru Ceara wrote: > > On 2/9/24 00:28, Numan Siddique wrote: > > On Thu, Feb 8, 2024, 4:49 PM wrote: > > > >> From: Numan Siddique > >> > >> This patch series fixes the memory and CPU usage increase seen > >> in ovn-northd after the lflow I-P patches were

Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-14 Thread David Marchand
Hello Mike, On Mon, Feb 12, 2024 at 8:50 PM Mike Pattrick wrote: > > Previously if an OVS configuration nested multiple layers of UDP tunnels > like VXLAN or GENEVE on top of each other through netdev-linux > interfaces, the vnet header would be incorrectly set to the outermost > UDP tunnel

Re: [ovs-dev] [PATCH ovn v1 0/4] northd memory and CPU increase fix due to lflow-mgr.

2024-02-14 Thread Dumitru Ceara
On 2/9/24 00:28, Numan Siddique wrote: > On Thu, Feb 8, 2024, 4:49 PM wrote: > >> From: Numan Siddique >> >> This patch series fixes the memory and CPU usage increase seen >> in ovn-northd after the lflow I-P patches were merged. >> >> The first 2 patches in the series addresses duplicate flows

Re: [ovs-dev] [PATCH ovn v1 4/4] northd: lflow-mgr: Allocate DP reference counters on a second use.

2024-02-14 Thread Dumitru Ceara
On 2/13/24 08:19, Han Zhou wrote: > On Thu, Feb 8, 2024 at 1:50 PM wrote: >> >> From: Ilya Maximets >> >> Currently, whenever a new logical flow is created, northd allocates >> a reference counter for every datapath in the datapath group for that >> logical flow. Those reference counters are

Re: [ovs-dev] [PATCH ovn v1 3/4] northd: Fix lflow ref node's reference counting.

2024-02-14 Thread Dumitru Ceara
On 2/13/24 08:14, Han Zhou wrote: > On Thu, Feb 8, 2024 at 1:50 PM wrote: >> >> From: Numan Siddique >> >> When the lflows in an lflow_ref are unlinked by calling >> lflow_ref_unlink_lflows(lflow_ref), the dp_ref counter >> for each lflow in the lflow_ref is decremented (by calling >>

Re: [ovs-dev] [PATCH ovn v1 2/4] northd: Don't add ARP request responder flows for NAT multiple times.

2024-02-14 Thread Dumitru Ceara
On 2/13/24 08:04, Han Zhou wrote: > On Thu, Feb 8, 2024 at 1:49 PM wrote: >> >> From: Numan Siddique >> >> If an SNAT external_ip belongs to the router IP, then there >> is no need to generate ARP request responder flows in >> build_lswitch_rport_arp_req_flows_for_lbnats() as these flows >> for

Re: [ovs-dev] [PATCH ovn v1 1/4] northd: Don't add lr_out_delivery default drop flow for each lrp.

2024-02-14 Thread Dumitru Ceara
On 2/13/24 07:44, Han Zhou wrote: > On Thu, Feb 8, 2024 at 1:49 PM wrote: >> >> From: Numan Siddique >> >> The default drop flow in lr_out_delivery stage is generated >> for every router port of a logical router. This results in the >> lflow_table_add_lflow() to be called multiple times for the

Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-14 Thread Mike Pattrick
Note, this failed github CI with the following error message: ../../tests/testsuite: line 4034: ./atconfig: No such file or directory This appears to be a false negative. -M On Mon, Feb 12, 2024 at 2:50 PM Mike Pattrick wrote: > > Previously if an OVS configuration nested multiple layers of

[ovs-dev] [PATCH] conntrack: Fix flush not flushing all elements.

2024-02-14 Thread Xavier Simonart
When a ct element was cleaned, the cmap could be shrinked, potentially causing some elements to be skipped in the flush iteration. Signed-off-by: Xavier Simonart --- lib/conntrack.c | 14 - lib/conntrack.h | 1 + tests/system-traffic.at | 45