Re: [ovs-dev] [Patch ovn 2/2] northd.c: Fix direct access to SNAT network on DR.

2024-03-05 Thread Ales Musil
On Wed, Mar 6, 2024 at 8:07 AM Ales Musil wrote: > > > On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok > wrote: > >> This change fixes bug that breaks ability of machines from external >> networks to communicate with machines in SNATed networks (specifically >> when using a Distributed router).

Re: [ovs-dev] [Patch ovn 2/2] northd.c: Fix direct access to SNAT network on DR.

2024-03-05 Thread Ales Musil
On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok wrote: > This change fixes bug that breaks ability of machines from external > networks to communicate with machines in SNATed networks (specifically > when using a Distributed router). > > Currently when a machine (S1) on an external network tries

Re: [ovs-dev] [Patch ovn 1/2] actions.c/h: Enable specifying zone for ct_commit.

2024-03-05 Thread Ales Musil
On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok wrote: > Action `ct_commit` currently does not allow specifying zone into > which connection is committed. For example, in LR datapath, the `ct_commit` > will always use the DNAT zone. > > This change adds option to use `ct_commit(snat)` or

Re: [ovs-dev] [PATCH ovn 2/2] tests: Use sync command in ovn-ic tests.

2024-03-05 Thread Ales Musil
On Tue, Feb 27, 2024 at 11:42 AM Mohammad Heib wrote: > Use the sync commands in the ovn-ic unit tests > and remove lines that wait for IC-SB to sync with IC-NB. > > Signed-off-by: Mohammad Heib > --- > tests/ovn-ic.at | 178 > 1 file changed,

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Stop dropping bind_vport requests immediately after handling.

2024-03-05 Thread Ales Musil
On Mon, Feb 26, 2024 at 2:55 PM Mohammad Heib wrote: > ovn-controller immediately removes the vport_bindings requests that were > generated by VIFs after handling them locally, this approach is intended > to avoid binding the vport to one VIF only and allocate the vport > between the different

Re: [ovs-dev] [PATCH ovn] Update copyright year to 2024.

2024-03-05 Thread Ales Musil
On Thu, Feb 29, 2024 at 5:43 PM Igor Zhukov wrote: > I noticed the copyright year at the bottom of > https://docs.ovn.org/en/latest/contents.html > > Signed-off-by: Igor Zhukov > --- > Documentation/conf.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH ovn] acl-log: Properly log the "pass" verdict.

2024-03-05 Thread Ales Musil
On Fri, Mar 1, 2024 at 9:05 PM Mark Michelson wrote: > The "pass" verdict was not explicitly defined in the list of verdicts > for ACL logging. This resulted in logs saying "Syntax error at `pass' > unknown verdict." > > This change adds the "pass" verdict explicitly so that it shows up as a >

[ovs-dev] [PATCH v2] bfd: Improve state change log message.

2024-03-05 Thread Timothy Redaelli
A log message like this one: 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD state change: down->up "Neighbor Signaled Session Down"->"Neighbor Signaled Session Down". can be hard to read since '->' usually represents a status change, but in this case the diagnostic code

Re: [ovs-dev] [PATCH] tests: Fix "SSL db: implementation" test with openssl > 3.2.0.

2024-03-05 Thread 0-day Robot
Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. Subject: tests: Fix "SSL db:

Re: [ovs-dev] [PATCH v6 1/2] util: Support checking for kernel versions.

2024-03-05 Thread Mike Pattrick
On Mon, Mar 4, 2024 at 3:22 AM Felix Huettner via dev wrote: > > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner > --- Acked-by: Mike Pattrick ___ dev

[ovs-dev] [PATCH] tests: Fix "SSL db: implementation" test with openssl > 3.2.0.

2024-03-05 Thread Timothy Redaelli
In OpenSSL 3.2.0 (81b741f) all the "alert" error messages was updated to replace "sslv3" with "ssl/tls". This commit updates the "SSL db: implementation" test to support both the pre-openssl 3.2.0 error message: "sslv3 alert certificate unknown" and the post-openssl 3.2.0 error message: "ssl/tls

Re: [ovs-dev] [PATCH] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-05 Thread Ilya Maximets
On 3/5/24 18:13, Kevin Traynor wrote: > On 05/03/2024 15:22, Ilya Maximets wrote: >> It's hard to debug situations where driver rejects packets for some >> reason. Dumping out the mbuf should help with debugging. >> >> Sample output looks like this: >> >> |netdev_dpdk(pmd-c03/id:8)|DBG|ovs-p1:

Re: [ovs-dev] [PATCH] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-05 Thread Kevin Traynor
On 05/03/2024 15:22, Ilya Maximets wrote: > It's hard to debug situations where driver rejects packets for some > reason. Dumping out the mbuf should help with debugging. > > Sample output looks like this: > > |netdev_dpdk(pmd-c03/id:8)|DBG|ovs-p1: Invalid packet: > dump mbuf at

Re: [ovs-dev] [PATCH v2 0/5] DEI: Address some instances of master and slave

2024-03-05 Thread Kevin Traynor
On 01/03/2024 14:50, Simon Horman wrote: > Recently OVS adopted a policy of using the inclusive naming word list v1 > [1, 2]. > > This patch-set addresses some uses of the terms master and slave > by using alternate terms. > > These changes are not intended to have any runtime effect. > > [1]

[ovs-dev] [PATCH v10 2/2] rhel: Enable USDT scripts by default in Fedora builds.

2024-03-05 Thread Aaron Conole
All supported versions of Fedora do package libbpf, so it makes sense to enable USDT support. Acked-by: Simon Horman Acked-by: Eelco Chaudron Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 8 1 file changed, 8 insertions(+) diff --git

[ovs-dev] [PATCH v10 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-05 Thread Aaron Conole
From: Kevin Sprague During normal operations, it is useful to understand when a particular flow gets removed from the system. This can be useful when debugging performance issues tied to ofproto flow changes, trying to determine deployed traffic patterns, or while debugging dynamic systems where

[ovs-dev] [PATCH v10 0/2] debugging: Add a revalidator probe, and monitor script

2024-03-05 Thread Aaron Conole
Resurrecting a feature from 2022, introduce a probe that indicates why a particular flow may be selected for eviction during revalidation and includes the flow information. The second patch tells fedora builds to include the USDT probe support on Fedora systems. Aaron Conole (1): rhel: Enable

[ovs-dev] [PATCH] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-05 Thread Ilya Maximets
It's hard to debug situations where driver rejects packets for some reason. Dumping out the mbuf should help with debugging. Sample output looks like this: |netdev_dpdk(pmd-c03/id:8)|DBG|ovs-p1: Invalid packet: dump mbuf at 0x1180bce140, iova=0x2cb7ce400, buf_len=2176 pkt_len=64,

Re: [ovs-dev] [PATCH ovn] northd: Don't skip the unSNAT stage for traffic towards VIPs.

2024-03-05 Thread Numan Siddique
On Mon, Feb 26, 2024 at 7:59 AM Dumitru Ceara wrote: > > Otherwise, in case there's also a SNAT rule that uses the VIP as > external IP, we break sessions initiated from behind the VIP. > > This partially reverts 832893bdbb42 ("ovn-northd: Skip unsnat flows for > load balancer vips in router

[ovs-dev] [PATCH] conntrack: Do clean instead of forece expire.

2024-03-05 Thread Cheng Li
Force expire a connection and then create new connection of the same tuple(cmap hash). This makes ct->conns cmap operation expensive( within ct->ct_lock). This patch cover the scenario by doing the clean immediately instead of setting expire. Also this patch fix ct_clean debug log.