On Fri, Apr 22, 2022 at 1:41 AM Eelco Chaudron wrote:
>
>
>
> On 15 Apr 2022, at 13:25, wenx05124...@163.com wrote:
>
> > From: wenxu
> >
> > The netdev-offload in tc mode can't work with flow-restore-wait.
> > When the vswitchd restart with flow-restore-wait, the tc qdisc
> > will be delete in
Thanks Tao for fixing this. I think the title can be more generic because
this problem and fix applies to all tunnel types rather than just VXLAN.
On Tue, Mar 12, 2024 at 7:04 AM Tao Liu wrote:
>
> Reproduce:
> ovs-vsctl add-port br-int p0 \
> -- set interface p0 type=vxlan
Bleep bloop. Greetings LIU Yulong, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary should
A potential race condition happened with the following 3 threads:
* PMD thread replaced the old_ukey and transitioned the state to
UKEY_DELETED.
* RCU thread is freeing the old_ukey mutex.
* While the revalidator thread is trying to lock the old_ukey mutex.
Then vswitchd process aborts at the
In v4.0, LibreSwan changed a default paths that had been hardcoded in
ovs-monitor-ipsec, breaking some uses of this script. This patch adds
support for both old and newer versions by auto detecting the location
of these paths from LibreSwan shell script environment variables.
Reported-at:
On Fri, Feb 16, 2024 at 10:54 PM Naveen Yerramneni
wrote:
>
> Signed-off-by: Naveen Yerramneni
Thanks. Applied to main.
Numan
> ---
> ovn-nb.xml | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/ovn-nb.xml b/ovn-nb.xml
> index e0b983ed6..b652046a7 100644
> --- a/ovn-nb.xml
>
Tunnel types are not flags, but 4-bit fields, so checking them with
a simple binary 'and' is incorrect and may produce false-positive
matches.
While the current implementation is unlikely to cause any issues today,
since both RTE_MBUF_F_TX_TUNNEL_VXLAN and RTE_MBUF_F_TX_TUNNEL_GENEVE
only have 1
RTE_MBUF_F_TX_TCP_CKSUM is not a flag, but a 2-bit field, so checking
it with a simple binary 'and' is incorrect. For example, this check
will succeed for a packet with UDP checksum requested as well.
Fix the check to avoid wrongly initializing tso_segz and potentially
accessing UDP header via
Stuff discovered while working on:
https://github.com/openvswitch/ovs-issues/issues/321
Ilya Maximets (3):
netdev-dpdk: Clear inner packet marks if no inner offloads requested.
netdev-dpdk: Fix TCP check during Tx offload preparation.
netdev-dpdk: Fix tunnel type check during Tx offload
In some cases only outer offloads may be requested for a tunneled
packet. In this case there is no need to mark the type of an
inner packet. Clean these flags up to avoid potential confusion
of DPDK drivers.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Ilya
Couple places in the documentation reference "--wait" and "--no-wait"
options for "ovn-sbctl" but it doesn't support these options [0].
Trying, for example, "ovn-sbctl --no-wait init" exits with:
ovn-sbctl: --no-wait not supported
[0]
On 3/12/24 14:36, Mike Pattrick wrote:
> On Mon, Mar 11, 2024 at 2:31 PM Ilya Maximets wrote:
>>
>> Some drivers (primarily, Intel ones) do not expect any marking flags
>> being set if no offloads are requested. If these flags are present,
>> driver will fail Tx preparation or behave abnormally.
Recent kernels introduced a mechanism that allows to evict colliding
entries in a closing state whereas they were previously considered as
parts of a non-recoverable clash.
This new behavior makes "conntrack - SNAT with port range with
exhaustion test" fail, as it relies on the previous
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#206 FILE: Documentation/ref/ovs-flowviz.8.rst:126:
On Tue, Mar 12, 2024 at 9:17 PM Martin Kalcok
wrote:
> Following up on the comments from v1.
>
> @amusil You were right that the struct in actions.h was not necessary
> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
> function and for that I think the struct is
Regarding the failed unstable test in the CI, I suspect that this is not
related to the code change, I've had couple successful CI runs in my branch
[0].
Martin.
[0] https://github.com/mkalcok/ovn/actions/runs/8256539983
On Tue, Mar 12, 2024 at 8:45 PM Martin Kalcok
wrote:
> This change fixes
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 4 +-
Documentation/conf.py | 2 +
Documentation/ref/index.rst | 1 +
In order to support dark style in html outputs, allow the config file to
express the background color and set it in a top style object.
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/ovs/flowviz/html_format.py | 4 +++-
python/ovs/flowviz/odp/html.py | 30
Graph view leverages the tree format (specially the tree-based
filtering) and uses graphviz library to build a visual graph of the
datapath in graphviz format.
Conntrack zones are shown in random colors to help visualize connection
tracking interdependencies.
An html flag builds an HTML page
Using the existing FlowTree and HTMLFormatter, create an HTML tree
visualization that also supports collapsing and expanding entire flow
trees and subtrees.
Examples:
$ ovs-appcl dpctl/dump-flows | ovs-flowviz --highlight drop datapath
html > /tmp/flows.html
$ ovs-appcl dpctl/dump-flows |
This view is interesting for debugging the logical pipeline. It arranges
the flows in "logical" groups (not to be confused with OVN's
Logical_Flows). A logical group of flows is a set of flows that:
- Have the same table number and priority
- Match on the same fields (regardless of the value they
Datapath flows can be arranged into a "tree"-like structure based on
recirculation ids, e.g:
recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
\-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1
\-> recirc(42),ct_state(1/0),eth(...),ipv4(...) actions=userspace(...)
This patch
Add a HTML Formatter and use it to print OpenFlow flows in an HTML list
with table links.
Examples
$ ovs-flowviz -i offlows.txt --highlight "drop" openflow html >
/tmp/flows.html
$ ovs-flowviz -i offlows.txt --filter "n_packets > 0" openflow html >
/tmp/flows.html
Acked-by: Eelco Chaudron
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting implementations. It supports
styles to be described by any class, highlighting and config-file based
When anaylizing OVN issues, it might be useful to see what OpenFlow
flows were generated from each logical flow. In order to make it simpler
to visualize this, add a cookie format that simply sorts the flows first
by cookie, then by table.
Example:
$ export OVN_NB_DB=...
$ export OVN_SB_DB=...
$
process.py contains a useful base class that processes files
odp.py and ofp.py: contain datapath and openflow subcommand definitions
as well as the first formatting option: json.
Also, this patch adds basic filtering support.
Examples:
$ ovs-ofctl dump-flows br-int | ovs-flowviz openflow json
$
The goal of this utility is to read both datapath and Openflow flows
(using the flow library already available) and print them in different
formats and styles to make it easier to understand them and troubleshoot
issues.
The formats are quite opinionated and so are the colors chosen so I'm
eager
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
Examples:
$ ovs-flowviz -i /tmp/dpflows --style=dark datapath console
$ ovs-flowviz -i /tmp/ofpflows --style=light openflow console
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
Add a new python package (just the scheleton for now) to hold a flow
visualization tool based on the flow parsing library.
flowviz dependencies are installed via "extras_require", so a user must
run:
$ pip install .[flowviz]
or
$ pip install ovs[flowviz]
Acked-by: Eelco Chaudron
Signed-off-by:
On 3/8/24 15:24, Ilya Maximets wrote:
On 3/7/24 22:29, Ilya Maximets wrote:
On 3/7/24 21:59, Adrian Moreno wrote:
On 3/7/24 17:54, Ilya Maximets wrote:
On 3/7/24 16:18, Adrian Moreno wrote:
** Background ** Currently, OVS supports several packet
sampling mechanisms (sFlow, per-bridge
30 matches
Mail list logo
