Re: [ovs-dev] [PATCH v13 4/6] dpif: Probe support for OVS_ACTION_ATTR_DROP.

On 3/22/24 14:54, Eric Garver wrote: > Kernel support has been added for this action. As such, we need to probe > the datapath for support. > > Acked-by: Eelco Chaudron > Signed-off-by: Eric Garver > --- > include/linux/openvswitch.h | 2 +- > lib/dpif.c | 6 ++- >

Re: [ovs-dev] [PATCH v13 1/6] dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.

On 3/22/24 14:54, Eric Garver wrote: > This is prep for adding a different OVS_ACTION_ATTR_ enum value. This > action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However, > to make -Werror happy we must add a case to all existing switches. > > Acked-by: Eelco Chaudron > Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

Thanks Han, Acked-by: Mark Michelson On 3/28/24 02:58, Han Zhou wrote: The ovn-ofctrl-wait-before-clear setting is designed to minimize downtime during the initial start-up of the ovn-controller. For this purpose, the ovn-controller should wait only once upon entering the S_WAIT_BEFORE_CLEAR

Re: [ovs-dev] Hardware Offload Scaling

On 28 Mar 2024, at 16:31, Shahaji Bhosle via dev wrote: > Hi, > I am looking for tuning params for scaling OVS-DPDK/TC to million flows. It > seems like flow dump(revalidator) is not able to collect the stats after > about 150K flows per second, thus it is trying to delete the flows. > Any

Re: [ovs-dev] [PATCH] conntrack: Do not use icmp reverse helper for icmpv6.

Ilya Maximets writes: > On 3/12/24 11:02, Paolo Valerio wrote: >> In the flush tuple code path, while populating the conn_key, >> reverse_icmp_type() gets called for both icmp and icmpv6 cases, >> while, depending on the proto, its respective helper should be >> called, instead. > > Thanks for

[ovs-dev] [PATCH v2] conntrack: Do not use icmp reverse helper for icmpv6.

In the flush tuple code path, while populating the conn_key, reverse_icmp_type() gets called for both icmp and icmpv6 cases, while, depending on the proto, its respective helper should be called, instead. The above leads to an abort: [...] __GI_abort () at abort.c:79 reverse_icmp_type (type=128

[ovs-dev] [PATCH v2] conntrack: Fix SNAT with exhaustion system test.

Recent kernels introduced a mechanism that allows to evict colliding entries in a closing state whereas they were previously considered as parts of a non-recoverable clash. This new behavior makes "conntrack - SNAT with port range with exhaustion test" fail, as it relies on the previous

Re: [ovs-dev] Request for Source File Location: 'ovs-vswitchd.conf.db' MAN Page

Hello David, Thank you for your reply. Regards, Farhan On Thu, Mar 28, 2024 at 3:17 PM David Marchand wrote: > Hello, > > On Thu, Mar 28, 2024 at 11:13 AM Farhan Tariq > wrote: > > > > I'm adding a new feature to OvS and need to update the > 'ovs-vswitchd.conf.db' MAN page. However, I'm

Re: [ovs-dev] [PATCH] conntrack: Fix SNAT with exhaustion system test.

Ilya Maximets writes: > On 3/13/24 12:08, Paolo Valerio wrote: >> Recent kernels introduced a mechanism that allows to evict colliding >> entries in a closing state whereas they were previously considered as >> parts of a non-recoverable clash. >> This new behavior makes "conntrack - SNAT with

[ovs-dev] Hardware Offload Scaling

Hi, I am looking for tuning params for scaling OVS-DPDK/TC to million flows. It seems like flow dump(revalidator) is not able to collect the stats after about 150K flows per second, thus it is trying to delete the flows. Any guidance where million flows are offloaded to hardware would be great.

Re: [ovs-dev] [PATCH v2] Documentation: Update references to kernel datapath in OVS tree.

On 3/22/24 16:56, Simon Horman wrote: > The Kernel datapath is no longer present in the primary development > branch of the OVS tree. Update documentation to more clearly reflect > this. > > Documentation relating to the kernel datapath in the OVS tree can > be removed once 2.17 is EOL. > >

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

On 3/28/24 15:19, Frode Nordahl wrote: > On Thu, Mar 28, 2024 at 3:03 PM Dumitru Ceara wrote: >> >> On 3/18/24 22:21, Mark Michelson wrote: >>> Thanks Frode, looks good to me. >>> >>> Acked-by: Mark Michelson >>> >>> On 3/18/24 07:43, Frode Nordahl wrote: The current code puts the contents

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

On Thu, Mar 28, 2024 at 3:03 PM Dumitru Ceara wrote: > > On 3/18/24 22:21, Mark Michelson wrote: > > Thanks Frode, looks good to me. > > > > Acked-by: Mark Michelson > > > > On 3/18/24 07:43, Frode Nordahl wrote: > >> The current code puts the contents of the ``ipb6_ra_pd_list`` > >> option

Re: [ovs-dev] [PATCH ovn] ovn-ic: Avoid igmp/mld traffic flooding.

On 3/15/24 16:23, Lorenzo Bianconi wrote: > Avoid recirculating IGMP/MLD packets more than one time from stage > ls_out_pre_lb in the egress pipeline to ovn table 37 in order to avoid > packet looping for ovn-ic deployment. > > Acked-by: Mohammad Heib > Signed-off-by: Lorenzo Bianconi > --- >

Re: [ovs-dev] [PATCH ovn] northd: Fix population of ipv6_ra_prefixes from IPv6 PD.

On 3/18/24 22:21, Mark Michelson wrote: > Thanks Frode, looks good to me. > > Acked-by: Mark Michelson > > On 3/18/24 07:43, Frode Nordahl wrote: >> The current code puts the contents of the ``ipb6_ra_pd_list`` >> option verbatim into the ``ipv6_ra_prefixes`` option. >> >> This does not work,

Re: [ovs-dev] [PATCH ovn v3 0/8] Various treewide fixes.

On 3/22/24 19:33, Mark Michelson wrote: > I had a look through all the patches. For the entire series: > > Acked-by: Mark Michelson > Thanks, applied to main. Regards, Dumitru ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn] controller: Use multicast for IPv6 Prefix Delegation.

On 3/18/24 22:08, Mark Michelson wrote: > Thanks Frode, looks good to me. > > Acked-by: Mark Michelson > > On 3/18/24 07:42, Frode Nordahl wrote: >> The OVN Controller currently uses unicast messages when >> communicating with the DHCPv6 server. >> >> This is at odds with RFC 3315 paragraph 1

Re: [ovs-dev] [PATCH ovn] ovn-ic: Avoid igmp/mld traffic flooding.

On 3/15/24 16:23, Lorenzo Bianconi wrote: > Avoid recirculating IGMP/MLD packets more than one time from stage > ls_out_pre_lb in the egress pipeline to ovn table 37 in order to avoid > packet looping for ovn-ic deployment. > > Acked-by: Mohammad Heib > Signed-off-by: Lorenzo Bianconi > ---

Re: [ovs-dev] [PATCH ovn v2 2/2] tests: Use sync command in ovn-ic tests.

On 3/12/24 11:56, Mohammad Heib wrote: > Use the sync commands in the ovn-ic unit tests > and remove lines that wait for IC-SB to sync with IC-NB. > > Signed-off-by: Mohammad Heib > --- Thanks, Mohammad! Applied to main and 24.03. Regards, Dumitru

Re: [ovs-dev] [PATCH ovn v2 1/2] tests: Move ovn interconnection tests to ovn-ic.at.

On 3/12/24 11:56, Mohammad Heib wrote: > Move ovn-ic tests that exist in ovn.at to ovn-ic.at. > > Signed-off-by: Mohammad Heib > --- Thanks, Mohammad! Applied to main and 24.03. Regards, Dumitru ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn 2/2] IC: Tansit switch don't flood mcast traffic to router ports if matches igmp group.

On 3/15/24 11:56, Mohammad Heib wrote: > Crrently ovn transit switch forward mcast traffic that match an igmp > group to all ports participating in this group and to all router ports > that are connected to this TS switch and have mcast_flood enabled. > > The above behavior can lead to packet

Re: [ovs-dev] [PATCH ovn 1/2] northd: Don't skip transit switch LSP when creating mcast groups.

On 3/15/24 11:56, Mohammad Heib wrote: > Currently when we enable IGMP on OVN-IC cluster with two or more AZs > and one vm from AZ1 send IGMP report, northd will create the following > multicast_group on each AZ: > > AZ1: > 1. multicast_group that forward the mcast traffic from LS1 to the VM. >

Re: [ovs-dev] [PATCH ovn] northd: Fix NAT configuration with --add-route option for gw-router.

On 3/15/24 20:45, Mark Michelson wrote: > Thanks for this Lorenzo, looks good to me. > > Acked-by: Mark Michelson > Thanks, Lorenzo and Mark! Applied to main and 24.03. If we need it backported to older branches please post an explicit patch. There were some conflicts when cherry picking to

Re: [ovs-dev] [PATCH ovn] controller: Fix an issue wrt cleanup of stale patch port.

References: <20240328122842.36708-1-priyankar.j...@nutanix.com> Bleep bloop. Greetings Priyankar Jain, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is

[ovs-dev] [PATCH ovn] controller: Fix an issue wrt cleanup of stale patch port.

Issue: Upon updating the network_name option of localnet port from one physical bridge to another, ovn-controller fails to cleanup the peer localnet patch port from the old bridge and ends up creating a duplicate peer localnet patch port which fails in the following ovsdb transaction: ```

Re: [ovs-dev] [PATCH] appveyor: Prepare for rename of primary development branch.

On 3/22/24 16:11, Simon Horman wrote: > Recently OVS adopted a policy of using the inclusive naming word list v1 > [1, 2]. And in keeping with this policy it is intended to rename the > primary development branch from master to main [3]. > > In order to help facilitate this change allow Appveyor

Re: [ovs-dev] [PATCH ovn] northd: Fix pmtud for non routed traffic.

On 3/15/24 20:34, Mark Michelson wrote: > Hi Lorenzo, > > Thanks for the fix. > > Acked-by: Mark Michelson > Hi Lorenzo, Mark, I'm afraid there's a bug in this patch, please see below. > When this is merged, the following should also be folded in: > > --- > diff --git

Re: [ovs-dev] OVN technical community meeting - March 19th

On 3/20/24 16:39, Dumitru Ceara wrote: > On 3/19/24 10:44, Dumitru Ceara wrote: >> Hi all, >> >> The next OVN technical community meeting is scheduled to happen today, >> at 4PM UTC. >> >> Feel free to add topics you might want to discuss today to the agenda >> doc below. I added the ones saw

Re: [ovs-dev] Request for Source File Location: 'ovs-vswitchd.conf.db' MAN Page

Hello, On Thu, Mar 28, 2024 at 11:13 AM Farhan Tariq wrote: > > I'm adding a new feature to OvS and need to update the 'ovs-vswitchd.conf.db' > MAN page. However, I'm unable to locate the source file for this MAN page to > add the necessary information about the new feature. > > Could you

[ovs-dev] Request for Source File Location: 'ovs-vswitchd.conf.db' MAN Page

Hello, I'm adding a new feature to OvS and need to update the 'ovs-vswitchd.conf.db' MAN page. However, I'm unable to locate the source file for this MAN page to add the necessary information about the new feature. Could you please provide the exact file path or location for the

[ovs-dev] [syzbot] [openvswitch?] KASAN: slab-use-after-free Read in ovs_ct_exit

Hello, syzbot found the following issue on: HEAD commit:fe46a7dd189e Merge tag 'sound-6.9-rc1' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=117d023a18 kernel config: https://syzkaller.appspot.com/x/.config?x=4d90a36f0cab495a

Re: [ovs-dev] [PATCH ovn v3 6/8] utilities/docker: Fix up container build.

On 3/27/24 07:40, Ales Musil wrote: > On Tue, Mar 26, 2024 at 7:09 PM Mark Michelson wrote: > >> On 3/25/24 05:09, Ales Musil wrote: >>> >>> >>> On Mon, Mar 25, 2024 at 9:47 AM Dumitru Ceara >> > wrote: >>> >>> On 3/22/24 19:34, Mark Michelson wrote: >>> > On

[ovs-dev] [PATCH v2] netdev-dpdk: Fallback to non tunnel offloading API.

The outer checksum offloading API in DPDK is ambiguous and was added by Intel folks with the assumption that any outer offloading always goes with an inner offloading request. With net/i40e and net/ice drivers, requesting outer ip checksum with a tunnel context but no inner offloading request

Re: [ovs-dev] [PATCH ovn v2 1/2] Merge QoS logical pipelines.

On Tue, Mar 26, 2024 at 5:32 PM Jacob Tanenbaum wrote: > currently there are 2 QoS pipelines for ingress (ls_in_qos_mark, > ls_in_qos_meter) and egress (ls_out_qos_mark, ls_out_qos_meter). This is > not necessary as there are no actions across the two pipelines that > depend on each other. The

Re: [ovs-dev] [PATCH ovn v2 2/2] missed during test simplification.

On Tue, Mar 26, 2024 at 5:32 PM Jacob Tanenbaum wrote: Hi Jacob, thank you for the v2. As 0-day suggests the commit subject should stat with capital letter. the testing was changed to remove the hardcoded table numbers from > flows. Two referances to table=28 where missed, this patch corrects

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 101 characters long (recommended limit is 79) #829 FILE:

Re: [ovs-dev] [PATCH] netdev-dpdk: Fallback to non tunnel offloading API.

On Thu, Mar 28, 2024 at 5:40 AM junwan...@cestc.cn wrote: > > I validated this modification on my x710 network card, but I found that > the outer UDP checksum of the transmitted packets is incorrect, leading > to communication abnormalities. I think it's necessary to disable the outer > UDP

[ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

The br-int connection is hardcoded to use unix socket, which requires for the socket to be visible for ovn-controller. This is achievable in container by mounting the socket, but in turn the container requires additional privileges. Add option to ovn-controller that allows to specify remote

Re: [ovs-dev] [PATCH ovn v2 3/3] pinctrl: Fixed 100% cpu on ovs connection loss.

On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: > This issue is happening for instance when running test > "ovn-controller - Chassis other_config". > > Signed-off-by: Xavier Simonart > > --- > v2: Amend subject summary. > Rebase on origin/main. > --- > controller/pinctrl.c | 15

Re: [ovs-dev] [PATCH] netdev-dpdk: Fallback to non tunnel offloading API.

On Wed, Mar 27, 2024 at 5:51 PM David Marchand wrote: > /* If packet is vxlan or geneve tunnel packet, calculate outer > * l2 len and outer l3 len. Inner l2/l3/l4 len are calculated > * before. */ > -const uint64_t tunnel_type = mbuf->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK; > -

Re: [ovs-dev] [PATCH ovn v2 2/3] pinctrl: Fix missing MAC_Bindings.

On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: > Pinctrl is responsible of creating MAC_Bindings on peer router datapaths. > However, when sb was read-only, this did not happen. > This caused the test "neighbor update on same HV" to fail in a flaky way. > > Signed-off-by: Xavier

Re: [ovs-dev] [PATCH ovn v2 1/3] tests: Add macros to pause controller updates.

On Tue, Mar 26, 2024 at 12:55 PM Xavier Simonart wrote: > Such macros can then be used for instance to create condition where > sb is seen as read-only by ovn-controller. > > Signed-off-by: Xavier Simonart > --- > Hi Xavier, thank you for the v2, there is one small nit that can be addressed

Re: [ovs-dev] [PATCH ovn] automake: Make system tests dependent of ovn-macro.

On Tue, Mar 26, 2024 at 12:56 PM Xavier Simonart wrote: > So system testsuite will be recompiled when ovn-macro is changed. > > Signed-off-by: Xavier Simonart > --- > tests/automake.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/automake.mk b/tests/automake.mk > index

Re: [ovs-dev] [PATCH ovn] tests: Add macro for checking flows after recompute.

On Tue, Mar 26, 2024 at 12:57 PM Xavier Simonart wrote: > The macro CHECK_FLOWS_AFTER_RECOMPUTE dumps the Openflows, then > recomputes, then dumps again the Openflows, and finally compares > both sets of flows. The test fails if flows are different. > As of now, the macro cannot be used in all

[ovs-dev] [PATCH ovn] northd, controller: Use paused controller action for packet buffering.

The current packet injection loses ct_state in the process. When the ct_state is lost we might commit to DNAT zone and perform zero SNAT after the packet injection. This causes the first session to be wrong as the reply packets are not unDNATted. Instead of re-injecting the packet back into the

Re: [ovs-dev] [PATCH ovn] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

On Wed, Mar 20, 2024 at 4:07 PM Han Zhou wrote: > > > > On Mon, Mar 18, 2024 at 11:27 AM Mark Michelson wrote: > > > > Hi Han, > > > > I have a comment below > > > > On 3/5/24 01:27, Han Zhou wrote: > > > The ovn-ofctrl-wait-before-clear setting is designed to minimize > > > downtime during the

[ovs-dev] [PATCH ovn v2] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

The ovn-ofctrl-wait-before-clear setting is designed to minimize downtime during the initial start-up of the ovn-controller. For this purpose, the ovn-controller should wait only once upon entering the S_WAIT_BEFORE_CLEAR state for the first time. Subsequent reconnections to the OVS, such as those