Re: [ovs-dev] [PATCH ovn v3] northd: Add support for disabling vxlan mode.

2024-04-29 Thread Ihar Hrachyshka
On Sat, Apr 27, 2024 at 2:14 AM Vladislav Odintsov wrote: > Hi Dumitru, Ihar, > > Thanks for the review. PSB. > > regards, > Vladislav Odintsov > > On 26 Apr 2024, at 23:13, Ihar Hrachyshka wrote: > >  > Hi Vladislav, > > This looks good to me. I think documentation should be adjusted to not >

Re: [ovs-dev] [PATCH ovn v2] controller: Track individual address set constants.

2024-04-29 Thread Han Zhou
On Fri, Apr 12, 2024 at 8:20 AM Ales Musil wrote: > > Instead of tracking address set per struct expr_constant_set track it > per individual struct expr_constant. This allows more fine grained > control for I-P processing of address sets in controller. It helps with > scenarios like matching on

[ovs-dev] [PATCH v8 2/2] ofproto-dpif-mirror: Add support for pre-selection filter.

2024-04-29 Thread Mike Pattrick
Currently a bridge mirror will collect all packets and tools like ovs-tcpdump can apply additional filters after they have already been duplicated by vswitchd. This can result in inefficient collection. This patch adds support to apply pre-selection to bridge mirrors, which can limit which

[ovs-dev] [PATCH v8 1/2] ofproto-dpif-mirror: Reduce number of function parameters.

2024-04-29 Thread Mike Pattrick
Previously the mirror_set() and mirror_get() functions took a large number of parameters, which was inefficient and difficult to read and extend. This patch moves most of the parameters into a struct. Signed-off-by: Mike Pattrick Acked-by: Simon Horman Acked-by: Eelco Chaudron Signed-off-by:

[ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-04-29 Thread Eelco Chaudron
While offloading header modifications to TC, OVS is using {TCA_PEDIT} + {TCA_CSUM} combination as that it the only way to represent header rewrite. However, {TCA_CSUM} is unable to calculate L4 checksums for IP fragments. Since TC already applies fragmentation bit masking, this patch simply

Re: [ovs-dev] [PATCH] GitHub: Add Coverity scan as a daily GitHub action.

2024-04-29 Thread Ilya Maximets
On 4/16/24 09:44, Eelco Chaudron wrote: > This patch adds a daily Coverity run for the OVS main branch > to the GitHub actions. The result of the runs can be found here: > > https://scan.coverity.com/projects/openvswitch > > Before applying, we need to add the following two actions secrets >

Re: [ovs-dev] [PATCH] tc: Fix -Wgnu-variable-sized-type-not-at-end warning with Clang 18.

2024-04-29 Thread Ilya Maximets
On 4/26/24 19:44, Ilya Maximets wrote: > Clang 18.1.3-2.fc41 throws a warning: > > lib/tc.c:3060:25: error: field 'sel' with variable sized type > 'struct tc_pedit_sel' not at the end of a struct or class is a > GNU extension

Re: [ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-29 Thread Ilya Maximets
On 4/26/24 18:35, Ilya Maximets wrote: > Cirrus CI is broken on FreeBSD 13.3 due to clang version update. > It now complains about snprintf truncation the same way GCC does: > > tests/test-util.c:1129:16: error: 'snprintf' will always be truncated; > specified size is 5, but format

Re: [ovs-dev] [PATCH] ofproto-dpif-rid: Fix duplicate entries.

2024-04-29 Thread Eelco Chaudron
On 27 Apr 2024, at 11:00, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > In scenarios with multiple PMDs, there may be > simultaneous requests for recirc_id from multiple > PMD threads.In recirc_alloc_id_ctx, we first check > if there is a duplicate entry in the metadata_map > for the