On Tue, Apr 23, 2024 at 1:54 PM Xavier Simonart wrote:
> Comparing I+P flows versus flows after recompute highlighted a few
> issues.
>
> Xavier Simonart (5):
> controller: Fix iface-id-ver handling.
> controller: Nonvif related lports handling.
> controller: Fix deletion of container
Issue:
In case of a Logical_Router without mac_binding_age_threshold set or a
Logical_Router with an incorrectly formatted mac_binding_threshold
option, entries were not being purged from the Mac Binding table in
SouthBound.
This was because in the function `en_mac_binding_aging_run` in case of
On 5/15/24 12:12, Eelco Chaudron wrote:
>
>
> On 14 May 2024, at 15:48, Emma Finn wrote:
>
>> The AVX implementation for calcualting checksums was not
>> handling carry-over addition correctly in some cases.
>> This patch adds an additional shuffle to add 16-bit padding
>> to the final part of
On 5/14/24 09:50, Chandler Wu wrote:
> Hi, IIya, thanks for the attention.
>
> If I create a zone for the first time, the new tp_cfg will be copied
> to the zone, see `ct_zone_alloc`. Then update_timeout_policy will check
> that the new copied tp equals to tp_cfg, so
On 5/14/24 00:42, Ilya Maximets wrote:
> On 5/14/24 00:11, William Tu wrote:
>> Add route-table support for ipv4 dst via ipv6. One use case is BGP
>> unnumbered, a mechanism that establishes peering sessions without the
>> need to explicitly configure IPv4 addresses on the interfaces involved
>>
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 72.
Subject: netdev-linux: Fix
Open vSwitch is originally intended to switch at layer 2, only dealing with
Ethernet frames. With the introduction of l3 tunnels support, it crossed
into the realm of needing to care a bit about some routing details when
making forwarding decisions. If an oversized packet would need to be
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 78.
Subject: netdev-native-tnl: Fix
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 80.
Subject: netdev-offload: Fix
Clang's static analyzer will complain about an uninitialized value
because we weren't setting a value for ufid_generated in all code paths.
Now we initialize this on declaration.
Signed-off-by: Mike Pattrick
---
lib/dpctl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Clang's static analyzer will complain about a null pointer dereference
because dumps can be set to null and then there is a loop where it could
have been written to.
Instead, return early from the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
Clang's static analyzer will complain about an uninitialized value
because in some error conditions we wouldn't set all values that are
used later.
Now we initialize more values that are needed later even in error
conditions.
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 7 ++-
1
Clang's static analyzer will complain about an uninitialized value
because we weren't setting a value for dns_failure in all code paths.
Now we initialize this on declaration.
Signed-off-by: Mike Pattrick
---
lib/socket-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Clang's static analyzer has identified several instances of uninitialized
variable usage and null pointer dereferencing that while not likely, is
possible. These mostly included making sure that a variable is properly set
or error code properly returned in every error condition.
Signed-off-by:
Clang's static analyzer will complain about an uninitialized value
because we weren't properly checking the error code from a function that
would have initialized the value.
Instead, add a check for that return code.
Signed-off-by: Mike Pattrick
---
lib/netdev-native-tnl.c | 4 +++-
1 file
On 4/24/24 9:53 PM, Adrian Moreno wrote:
This is the userspace counterpart of the work being done in the kernel
[1]. Sending it as RFC to get some early feedback on the overall
solution.
** Problem description **
Currently, OVS supports several observability features, such as
per-bridge
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
Recheck-request: github-robot
On Thu, May 16, 2024 at 9:58 AM Mike Pattrick wrote:
>
> This patch attempts to fix a large number of ubsan error messages that
> take the following form:
>
> lib/netlink-notifier.c:237:13: runtime error: call to function
> route_table_change through pointer to
On Thu, May 16, 2024 at 12:01 PM Ales Musil wrote:
>
> On Thu, May 16, 2024 at 5:57 PM Numan Siddique wrote:
>
> > On Tue, May 14, 2024 at 4:41 AM Ales Musil wrote:
> > >
> > > The series is pretty small however it is required for the
> > > bump to Ubuntu 24.04 and Fedora 40. Both have newer
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
On Thu, May 16, 2024 at 5:57 PM Numan Siddique wrote:
> On Tue, May 14, 2024 at 4:41 AM Ales Musil wrote:
> >
> > The series is pretty small however it is required for the
> > bump to Ubuntu 24.04 and Fedora 40. Both have newer GCC and
> > Clang which brought up some issues that needed to be
On Tue, May 14, 2024 at 9:46 AM Ales Musil wrote:
>
> On Tue, May 14, 2024 at 3:19 PM Ilya Maximets wrote:
>
> > On 5/14/24 10:38, Ales Musil wrote:
> > > There were two things missing for the Fedora builds, 32-bit
> > > version of glibc to allows the -m32 compilation on Fedora
> > > and
On Tue, May 14, 2024 at 4:41 AM Ales Musil wrote:
>
> The series is pretty small however it is required for the
> bump to Ubuntu 24.04 and Fedora 40. Both have newer GCC and
> Clang which brought up some issues that needed to be fixed.
>
> The series also includes fix for weekly runs to use
On Mon, May 6, 2024 at 6:37 AM Ales Musil wrote:
>
> Avoid use after free in scenario when controller received LB deletion
> after the DB was reconnected. The reconnect led to idl clearing up
> the "old" structs, one of them being the LB. However, during recompute
> the struct was referenced when
From: Jakob Meng
The 'dpif/show' command now supports machine-readable JSON output in
addition to the plain-text output for humans. An example would be:
ovs-appctl --format json dpif/show
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
NEWS
From: Jakob Meng
With the '--pretty' option, appctl.py will now print JSON output in a
more readable fashion, i.e. with additional line breaks, spaces and
sorted dictionary keys. The pretty-printed output from appctl.py is not
strictly the same as with ovs-appctl because of both use different
From: Jakob Meng
The 'list-commands' command now supports machine-readable JSON output
in addition to the plain-text output for humans.
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
NEWS | 1 +
lib/unixctl.c | 44
From: Jakob Meng
With the '--pretty' option, ovs-appctl will now print JSON output in a
more readable fashion, i.e. with additional line breaks, spaces and
sorted dictionary keys.
Signed-off-by: Jakob Meng
---
Documentation/ref/ovs-appctl.8.rst | 7 ++
NEWS
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if
OVS would expose statistics in a machine-readable format.
This patch introduces support for different output formats to
ovs-appctl. It gains a global option '-f,--format' which changes it to
print a JSON
From: Jakob Meng
v12 has one tiny change compared to v11 [0]:
diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c
Signed-off-by: Jakob Meng
index 2ade64336..3b76740ea 100644
--- a/utilities/ovs-appctl.c
+++ b/utilities/ovs-appctl.c
@@ -88,6 +88,7 @@ main(int argc, char *argv[])
From: Jakob Meng
This patch introduces support for different output formats to Python
Unixctl* classes and appctl.py, similar to what the previous commit did
for ovs-appctl.
In particular, tests/appctl.py gains a global option '-f,--format'
which allows users to request JSON instead of
When conntrack is reassembling packet fragments, the same reassembly
context can be shared across multiple threads handling different packets
simultaneously. Once a full packet is assembled, it is added to a packet
batch for processing, in the case where there are multiple different pmd
threads
When conntrack is reassembling packet fragments, the same reassembly
context can be shared across multiple threads handling different packets
simultaneously. Once a full packet is assembled, it is added to a packet
batch for processing, this is most likely the batch that added it in the
first
On Thu, May 16, 2024 at 8:35 AM Simon Horman wrote:
>
> Hi Mike,
>
> On Wed, May 15, 2024 at 12:24:33PM -0400, Mike Pattrick wrote:
> > When conntrack is reassembling packet fragments, the same reassembly
> > context can be shared across multiple threads handling different packets
> >
This patch attempts to fix a large number of ubsan error messages that
take the following form:
lib/netlink-notifier.c:237:13: runtime error: call to function
route_table_change through pointer to incorrect function type
'void (*)(const void *, void *)'
In Clang 17 the undefined
Eelco Chaudron writes:
> The flow_reval_monitor.py script incorrectly reported the reasons for
> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
> This patch rectifies the order using a dictionary to avoid similar
> problems in the future.
>
> In addition this patch also
> On Thu, May 2, 2024 at 8:22 AM Lorenzo Bianconi
> wrote:
> >
> > Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd
> > connections and northd static_route/policy_route changes.
> >
> > Reported-at: https://issues.redhat.com/browse/FDP-600
> > Signed-off-by: Lorenzo Bianconi
On 5/14/24 15:15, Eelco Chaudron wrote:
> The flow_reval_monitor.py script incorrectly reported the reasons for
> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
> This patch rectifies the order using a dictionary to avoid similar
> problems in the future.
>
> In addition
Hi Mike,
On Wed, May 15, 2024 at 12:24:33PM -0400, Mike Pattrick wrote:
> When conntrack is reassembling packet fragments, the same reassembly
> context can be shared across multiple threads handling different packets
> simultaneously. Once a full packet is assembled, it is added to a packet
>
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if
OVS would expose statistics in a machine-readable format.
This patch introduces support for different output formats to
ovs-appctl. It gains a global option '-f,--format' which changes it to
print a JSON
From: Jakob Meng
The 'list-commands' command now supports machine-readable JSON output
in addition to the plain-text output for humans.
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
NEWS | 1 +
lib/unixctl.c | 44
From: Jakob Meng
The 'dpif/show' command now supports machine-readable JSON output in
addition to the plain-text output for humans. An example would be:
ovs-appctl --format json dpif/show
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
NEWS
From: Jakob Meng
With the '--pretty' option, appctl.py will now print JSON output in a
more readable fashion, i.e. with additional line breaks, spaces and
sorted dictionary keys. The pretty-printed output from appctl.py is not
strictly the same as with ovs-appctl because of both use different
From: Jakob Meng
This patch introduces support for different output formats to Python
Unixctl* classes and appctl.py, similar to what the previous commit did
for ovs-appctl.
In particular, tests/appctl.py gains a global option '-f,--format'
which allows users to request JSON instead of
From: Jakob Meng
With the '--pretty' option, ovs-appctl will now print JSON output in a
more readable fashion, i.e. with additional line breaks, spaces and
sorted dictionary keys.
Signed-off-by: Jakob Meng
---
Documentation/ref/ovs-appctl.8.rst | 7 ++
NEWS
From: Jakob Meng
v11 has one tiny change compared to v10 [0]:
* Added a missing newline at the end of utilities/ovs-appctl.c.
[0]
https://patchwork.ozlabs.org/project/openvswitch/list/?series=407002=both=*
Jakob Meng (6):
Add global option for JSON output to ovs-appctl.
python: Add
Issue:
In case of a Logical_Router without mac_binding_age_threshold set or a
Logical_Router with an incorrectly formatted mac_binding_threshold option,
entries were not being purged from the Mac Binding table in SouthBound.
This was because in the function `en_mac_binding_aging_run` in case of
On Wed, May 15, 2024 at 2:11 PM Kevin Traynor wrote:
> > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> > index 1dad2ef833..31dd6f1d5a 100644
> > --- a/lib/netdev-dpdk.c
> > +++ b/lib/netdev-dpdk.c
> > @@ -2584,6 +2584,9 @@ static bool
> > netdev_dpdk_prep_hwol_packet(struct netdev_dpdk
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
On 13.04.24 00:55, Ilya Maximets wrote:
> On 4/12/24 09:26, jm...@redhat.com wrote:
>> From: Jakob Meng
>>
>> The 'dpif/show' command now supports machine-readable JSON output in
>> addition to the plain-text output for humans. An example would be:
>>
>> ovs-appctl --format json dpif/show
>>
>>
On Wed, May 15, 2024 at 2:09 PM Kevin Traynor wrote:
>
> On 19/04/2024 15:06, David Marchand wrote:
> > In a typical setup like:
> > guest A <-virtio-> OVS A <-vxlan-> OVS B <-virtio-> guest B
> >
> > TSO packets from guest A are segmented against the OVS A physical port
> > mtu adjusted by the
From: Jakob Meng
The 'dpif/show' command now supports machine-readable JSON output in
addition to the plain-text output for humans. An example would be:
ovs-appctl --format json dpif/show
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
NEWS
From: Jakob Meng
With the '--pretty' option, appctl.py will now print JSON output in a
more readable fashion, i.e. with additional line breaks, spaces and
sorted dictionary keys. The pretty-printed output from appctl.py is not
strictly the same as with ovs-appctl because of both use different
From: Jakob Meng
This patch introduces support for different output formats to Python
Unixctl* classes and appctl.py, similar to what the previous commit did
for ovs-appctl.
In particular, tests/appctl.py gains a global option '-f,--format'
which allows users to request JSON instead of
From: Jakob Meng
v10 addresses all of Ilya's comments for v9 [0], most importantly:
* Output formatting has been moved from unixctl_client_transact() in unixctl.c
to ovs-appctl.c; same for Python code.
* unixctl_command_reply_error() will never wrap plain-text in JSON.
*
From: Jakob Meng
The 'list-commands' command now supports machine-readable JSON output
in addition to the plain-text output for humans.
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
NEWS | 1 +
lib/unixctl.c | 44
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if
OVS would expose statistics in a machine-readable format.
This patch introduces support for different output formats to
ovs-appctl. It gains a global option '-f,--format' which changes it to
print a JSON
From: Jakob Meng
With the '--pretty' option, ovs-appctl will now print JSON output in a
more readable fashion, i.e. with additional line breaks, spaces and
sorted dictionary keys.
Signed-off-by: Jakob Meng
---
Documentation/ref/ovs-appctl.8.rst | 7 ++
NEWS
On Thu, May 2, 2024 at 8:22 AM Lorenzo Bianconi
wrote:
>
> Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd
> connections and northd static_route/policy_route changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by: Lorenzo Bianconi
Hi Lorenzo,
Hi Ales,
Have addressed the comment on the new patch.
Thanks,
Indrajitt
On 16 May 2024, at 11:18 AM, Ales Musil wrote:
CAUTION: External Email
On Thu, May 16, 2024 at 7:24 AM Indrajitt Valsaraj
mailto:indrajitt.valsa...@nutanix.com>> wrote:
Issue:
In case of a Logical_Router without
Issue:
In case of a Logical_Router without mac_binding_age_threshold set or a
Logical_Router with an incorrectly formatted mac_binding_threshold
option, entries were not being purged from the Mac Binding table in
SouthBound.
This was because in the function `en_mac_binding_aging_run` in case of
64 matches
Mail list logo
