Sure Ales.
Thanks for the update
Regards,
Abhiram R N
On Thu, Aug 3, 2023 at 1:14 PM Ales Musil wrote:
>
>
> On Thu, Aug 3, 2023 at 9:37 AM Abhiram R N wrote:
>
>> Hi Team,
>>
>> Recently a fix has gone into OVS with the commit ID as below
>> commit feed
& Regards,
Abhiram R N
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
-mirror sw0-port1 mirror1
Detach a source from Mirror
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
Acked-By: Ihar Hrachyshka
---
NEWS
sync
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
Acked-By: Ihar Hrachyshka
---
northd/en-northd.c | 4 ++
northd/inc-proc-northd.c | 4 ++
northd/northd.c | 133 +++
northd/northd.h
In order to support Remote Port Mirroring
added the required schemas in NB and related xml.
Also, ovn-nbctl.c changes are added.
Futher added test cases to test nbctl commands.
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
Acked-By: Ihar Hrachyshka
' and
'from-lport' since we are observing issue for the 'both' case.
It will pursued with OVS team separately and tracked via a BZ and
after getting that fixed we can enchance the filter to support
'both' as well.
Abhiram R N (3):
OVN Remote Port Mirroring: Add new Schemas in NB
OVN Remote Port
-mirror sw0-port1 mirror1
Detach a source from Mirror
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v17-->v18: Addressed comments of Mark from
-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v17-->v18: Addressed comments of Mark from v17
Modifications related to comments are in
northd.c, ovn-northd.at
Other files changed to just fix rebase conflicts
northd/en-northd.c | 4 ++
northd/inc-proc-northd.c | 4 ++
nor
In order to support Remote Port Mirroring
added the required schemas in NB and SB.
Also, ovn-nbctl.c and ovn-sbctl.c changes are added.
Futher added test cases to test nbctl commands.
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v17-->
. The lsp-attach-mirror
triggers the sequence to create Mirror in OVS DB on compute node.
Note: This is targeted to mirror to destinations anywhere outside the
cluster where the analyser resides and it need not be an OVN node.
Abhiram R N (3):
OVN Remote Port Mirroring: Add new Schemas in NB and SB
Hi Mark,
On Tue, Nov 29, 2022 at 10:00 PM Mark Michelson wrote:
> On 11/29/22 08:27, Abhiram R N wrote:
> > Hi Mark,
> >
> > Thanks for your review.
> > Please see replies inline below.
> >
> > On Tue, Nov 29, 2022 at 3:23 AM Mark Michelson
Hi Mark,
Thanks for your review.
Agreed. I will remove the 'allow_engine_recompute' related changes in the
next patch set.
Thanks & Regards,
Abhiram R N
On Tue, Nov 29, 2022 at 3:24 AM Mark Michelson wrote:
> On 11/27/22 15:14, Abhiram R N wrote:
> > Mirror creation just creat
Hi Mark,
Thanks for your review.
Please see replies inline below.
On Tue, Nov 29, 2022 at 3:23 AM Mark Michelson wrote:
> On 11/27/22 15:14, Abhiram R N wrote:
> > Changes which syncs the NB port mirrors with SB port mirrors.
> > Also test added to check the NB and SB sync
>
not all that familiar with the ins and outs of port
> mirroring (i.e. what the requirements are), so I'm focusing mostly on
> the mechanics in this review. With all that said, I have comments down
> below.
>
> On 11/27/22 15:14, Abhiram R N wrote:
> > In order to support Remote Por
-mirror sw0-port1 mirror1
Detach a source from Mirror
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v16-->v17: Fixed mem leak issue in mirror.c wh
Changes which syncs the NB port mirrors with SB port mirrors.
Also test added to check the NB and SB sync
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v16-->v17: No changes
northd/en-northd.c | 4 +
northd/inc-proc-northd.c |
In order to support Remote Port Mirroring
added the required schemas in NB and SB.
Also, nbctl.c and sbctl.c changes are added.
Futher added test case to test nbctl commands.
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v16-->v17: No chan
-mirror sw0-port1 mirror1
Detach a source from Mirror
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
NEWS| 1 +
controller
Changes which syncs the NB port mirrors with SB port mirrors.
Also test added to check the NB and SB sync
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
northd/en-northd.c | 4 +
northd/inc-proc-northd.c | 4 +
northd/northd.c
In order to support Remote Port Mirroring
added the required schemas in NB and SB.
Also, nbctl.c and sbctl.c changes are added.
Futher added test case to test nbctl commands.
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
ovn-nb.ovsschema
Hi Numan,
Thanks for your review.
On Fri, Nov 25, 2022 at 8:47 AM Numan Siddique wrote:
> On Thu, Nov 24, 2022 at 9:14 AM Abhiram R N wrote:
> >
> > Mirror creation just creates the mirror. The lsp-attach-mirror
> > triggers the sequence to create Mirror in OVS DB on
mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v14 --> v15: Addressed comments of Ihar from v14 in function
ovn_port_mirror_handle_lport (mirror.c)
i.e. to have both mirror_delete AND mirror_cre
mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v13 --> v14: Addressed comments of Ihar from v13.
Merged all the cases of bulk test cases(in ovn.at)
to a single bulk updates test.
Expanded b
vsctl add-br br-phys -- set bridge br-phys
other-config:hwaddr=\"00:00:00:02:02:00\"
ovn_attach n2 br-phys 192.168.1.12
OVN_POPULATE_ARP
Thanks & Regards,
Abhiram R N
On Wed, Nov 16, 2022 at 4:39 AM Ihar Hrachyshka wrote:
> On 11/15/22 5:42 PM, Ihar Hrachyshka wrote:
>
mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
v12 --> V13: Made each of bulk test cases(in ovn.at) as separate
test to make it pass consistently.
V11 --> V12: Minor fix in ovn.at to solve intermittent failure
mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V11 --> V12: Minor fix in ovn.at to solve intermittent failures
V10 --> V11: Addressed review comments from V10 by Ihar
i) Expanded bulk updates test cases in
mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V10 --> V11: Addressed review comments from V10 by Ihar
i) Expanded bulk updates test cases in ovn.at
Overall below cases are covered
a) Attac
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V9 --> V10: Reverted typecasting in mirror.c as its needed.
V8 --> V9: Updated NEWS file which I
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V8 --> V9: Updated NEWS file which I missed earlier.
Reverted the typcasting in ovn-nbctl.c as
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V7 --> V8: Addressed review comments from V7 by Ihar
i) Added new test case for Mirror bulk upda
Hi Ihar,
Thanks for your review.
Please see below for replies inline.
On Mon, Oct 3, 2022 at 11:28 PM Ihar Hrachyshka wrote:
> NEWS file should be updated. See more comments inline below.
>
Sure. Will update the NEWS file in the next patch.
>
> On Wed, Sep 28, 2022 at 9:08 AM
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V6 --> V7: Addressed review comments from V6 by Numan
i) Did suggested changes in mirror.c and
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V5 --> V6: Fixed a memleak issue in mirror.c (missed free)
V4 --> V5: Addressed review comments
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V4 --> V5: Addressed review comments on V4 by Ihar
i) Expanded test cases in ovn.at and
below.
Kindly take a look and let me know your comments.
On Thu, Aug 25, 2022 at 5:21 AM Ihar Hrachyshka wrote:
> Hi,
>
> I've reviewed everything except mirror.[ch] files. See below.
>
> On Mon, Aug 22, 2022 at 4:41 PM Abhiram R N wrote:
> >
> > Added changes in o
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V3 --> V4: Addressed review comments from V3
i) Fixed Issues 1,2 and 3
ii) Did ot
Hi ILya,
On Tue, Jul 19, 2022 at 9:49 PM Ilya Maximets wrote:
> On 6/22/22 20:36, Abhiram R N wrote:
> > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller.
> > While Mirror creation just creates the mirror, the lsp-attach-mirror
> > triggers the sequ
n't changed anything there now but already hw-offload
we know we should be working there.
Thanks & Regards,
Abhiram R N
On Mon, Jul 4, 2022 at 10:22 PM Eelco Chaudron wrote:
> Hi Abhiram,
>
> It’s been there since your patch was committed to the repo.
> I did a quick verification again,
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V2 --> V3 : Addressed review comments (as below)
i) Avoided big 'if' and added chassis ch
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
V1 --> V2 : Addressed Review comments
i) Created new ENGINE node in OVN control
On Mon, May 09, 2022 at 03:34:47PM +0530, Abhiram R N wrote:
Hi Ihar,
> On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote:
> > Hi Abhiram,
> >
> > thanks for sending the patch.
>
> Thanks for spening time to review it.
>
> >
>
-sb.dlopts, ovn_northd.dl]
> 2) Update NEWS file with the new feature.
Sure. Will update it.
> 3) I think ovn-nbctl man page needs an update. Perhaps also
> ovn-architecture man page.
Sure. Will update it.
>
> Thanks for working on it,
> Ihar
Thanks again for taking time to give
ovn-nbctl lsp-detach-mirror sw0-port1 mirror1
Mirror deletion
ovn-nbctl mirror-del mirror1
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
controller/binding.c| 275
controller/binding.h| 4
-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
controller/binding.c| 276
controller/binding.h| 4 +
controller/ovn-controller.c | 16 +-
northd/en-northd.c | 4 +
northd/inc-proc-northd.c| 4 +
northd/northd.c | 118
end to end. That needs to be done in
future patches as incremental change.
This patch prepares for the next step.
Co-authored-by: Veda Barrenkala
Signed-off-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
ovn-nb.ovsschema | 30 +++-
ovn-nb.xml| 53 ++
tests/ovn-nbctl.at
end to end. That needs to be done in
future commits as incremental changes.
Co-authored-by: Veda Barrenkala
Signed-off-by: Abhiram R N
---
ovn-nb.ovsschema | 27 ++-
ovn-nb.xml| 53 ++
tests/ovn-nbctl.at| 78 +
utilities/ovn-nbctl.c | 397
-by: Abhiram R N
---
lib/netdev-vport.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 64331f74b..3b3927865 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -1245,7 +1245,8 @@ netdev_vport_tunnel_register(void
-by: Abhiram R N
---
lib/netdev-vport.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 64331f74b..871f7db05 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -1245,7 +1245,8 @@ netdev_vport_tunnel_register(void
Hi Ilya,
Thanks for your response.
I understand the problem you have mentioned.
Also for the rate limiting atleast we have solution as you have pointed
out which can be helpful.
Thanks & Regards,
Abhiram R N
On Wed, Feb 02, 2022 at 05:42:29PM +0100, Ilya Maximets wrote:
> On 1/24/2
that there is no spamming.
Signed-off-by: Abhiram R N
---
lib/netlink-socket.c | 10 --
tests/ofproto-dpif.at | 2 +-
tests/ovs-vswitchd.at | 5 +++--
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 93c1fa561..435a5945f 100644
--- a/lib/netlink
50 matches
Mail list logo
